From d464af7857107d034c276ec0d40e25aab74d9bd0 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Thu, 23 Jan 2020 07:55:52 -0300 Subject: [PATCH 01/96] [xunit tests][mono] Remove disabled Microsoft.VisualBasic.Core.Tests tests from rsp file. --- .../tests/ErrObjectTests.cs | 1 + .../tests/InteractionTests.cs | 7 +++++-- src/mono/netcore/CoreFX.issues.rsp | 13 ------------- 3 files changed, 6 insertions(+), 15 deletions(-) diff --git a/src/libraries/Microsoft.VisualBasic.Core/tests/ErrObjectTests.cs b/src/libraries/Microsoft.VisualBasic.Core/tests/ErrObjectTests.cs index 0f863c5ab02c1..36c2c0c82ad64 100644 --- a/src/libraries/Microsoft.VisualBasic.Core/tests/ErrObjectTests.cs +++ b/src/libraries/Microsoft.VisualBasic.Core/tests/ErrObjectTests.cs @@ -11,6 +11,7 @@ namespace Microsoft.VisualBasic.Tests public class ErrObjectTests { [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/14854", TargetFrameworkMonikers.Mono)] public void Clear() { ProjectData.ClearProjectError(); diff --git a/src/libraries/Microsoft.VisualBasic.Core/tests/InteractionTests.cs b/src/libraries/Microsoft.VisualBasic.Core/tests/InteractionTests.cs index b94b9d51f180d..4e5de9a44222a 100644 --- a/src/libraries/Microsoft.VisualBasic.Core/tests/InteractionTests.cs +++ b/src/libraries/Microsoft.VisualBasic.Core/tests/InteractionTests.cs @@ -138,6 +138,7 @@ public static IEnumerable IIf_TestData() } [Fact] + [ActiveIssue("https://github.com/dotnet/corefx/issues/40842#issuecomment-528858413", TargetFrameworkMonikers.Mono)] public void DeleteSetting() { if (!PlatformDetection.IsInAppContainer) @@ -207,6 +208,7 @@ private static (string, string)[] GetEnvironmentVariables() } [Fact] + [ActiveIssue("https://github.com/dotnet/corefx/issues/40842#issuecomment-528858413", TargetFrameworkMonikers.Mono)] public void GetAllSettings() { if (!PlatformDetection.IsInAppContainer) @@ -221,6 +223,7 @@ public void GetAllSettings() } [Fact] + [ActiveIssue("https://github.com/dotnet/corefx/issues/40842#issuecomment-528858413", TargetFrameworkMonikers.Mono)] public void GetSetting() { if (!PlatformDetection.IsInAppContainer) @@ -301,14 +304,14 @@ public void Partition_Overflow(long Number, long Start, long Stop, long Interval { Assert.Throws(() => Interaction.Partition(Number, Start, Stop, Interval)); } - + [Fact] + [ActiveIssue("https://github.com/dotnet/corefx/issues/40842#issuecomment-528858413", TargetFrameworkMonikers.Mono)] public void SaveSetting() { if (!PlatformDetection.IsInAppContainer) { Assert.Throws(() => Interaction.SaveSetting(AppName: "", Section: "", Key: "", Setting: "")); - } else { diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 7d4cf244d47a6..40b95acc292ef 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -5,19 +5,6 @@ -notrait category=failing -notrait category=IgnoreForCI -#################################################################### -## Microsoft.VisualBasic.Core.Tests -#################################################################### - -# https://github.com/mono/mono/issues/14854 --nomethod Microsoft.VisualBasic.Tests.ErrObjectTests.Clear - -# Windows-only tests, incorrect platform guards (https://github.com/dotnet/corefx/pull/40365) --nomethod Microsoft.VisualBasic.Tests.InteractionTests.SaveSetting --nomethod Microsoft.VisualBasic.Tests.InteractionTests.DeleteSetting --nomethod Microsoft.VisualBasic.Tests.InteractionTests.GetAllSettings --nomethod Microsoft.VisualBasic.Tests.InteractionTests.GetSetting - #################################################################### ## System.Collections.Specialized.Tests #################################################################### From de634c567ef1e9144ca6529b57f32503d987b830 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Thu, 23 Jan 2020 08:43:38 -0300 Subject: [PATCH 02/96] [xunit tests][mono] Remove System.Collections.Specialized.Tests.Ctor_NegativeCapacity_ThrowsArgumentOutOfRangeException from rsp file --- .../NameValueCollection/NameValueCollection.CtorTests.cs | 1 + src/mono/netcore/CoreFX.issues.rsp | 8 -------- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/src/libraries/System.Collections.Specialized/tests/NameValueCollection/NameValueCollection.CtorTests.cs b/src/libraries/System.Collections.Specialized/tests/NameValueCollection/NameValueCollection.CtorTests.cs index 0c8b980aa3fe0..47d50f25792ea 100644 --- a/src/libraries/System.Collections.Specialized/tests/NameValueCollection/NameValueCollection.CtorTests.cs +++ b/src/libraries/System.Collections.Specialized/tests/NameValueCollection/NameValueCollection.CtorTests.cs @@ -68,6 +68,7 @@ public void Ctor_Int(int capacity) } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/14858", TargetFrameworkMonikers.Mono)] public void Ctor_NegativeCapacity_ThrowsArgumentOutOfRangeException() { AssertExtensions.Throws("capacity", () => new NameValueCollection(-1)); diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 40b95acc292ef..67d83e4be780c 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -5,14 +5,6 @@ -notrait category=failing -notrait category=IgnoreForCI -#################################################################### -## System.Collections.Specialized.Tests -#################################################################### - -# TODO: Wrong exception -# https://github.com/mono/mono/issues/14858 --nomethod System.Collections.Specialized.Tests.NameValueCollectionCtorTests.Ctor_NegativeCapacity_ThrowsArgumentOutOfRangeException - #################################################################### ## System.Collections.Concurrent.Tests #################################################################### From d1d6386334661c04c59cd5d52c0f21de8c9849f7 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Thu, 23 Jan 2020 10:27:55 -0300 Subject: [PATCH 03/96] Remove System.Collections.Concurrent.Tests.ConcurrentQueueTests.ReferenceTypes_NulledAfterDequeue from rsp file because it passes on release mono --- src/mono/netcore/CoreFX.issues.rsp | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 67d83e4be780c..847de488f7fef 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -5,13 +5,6 @@ -notrait category=failing -notrait category=IgnoreForCI -#################################################################### -## System.Collections.Concurrent.Tests -#################################################################### - -# fails only with release mono --nomethod System.Collections.Concurrent.Tests.ConcurrentQueueTests.ReferenceTypes_NulledAfterDequeue - #################################################################### ## System.Diagnostics.Tracing.Tests #################################################################### From 62a31f4bc00206f520796040a29e6fd741c96e80 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Thu, 23 Jan 2020 10:30:29 -0300 Subject: [PATCH 04/96] Remove BasicEventSourceTests.TestsManifestNegative.Test_GenerateManifest_InvalidEventSources from rsp file because it passes locally --- src/mono/netcore/CoreFX.issues.rsp | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 847de488f7fef..d9f78b6845720 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -5,14 +5,6 @@ -notrait category=failing -notrait category=IgnoreForCI -#################################################################### -## System.Diagnostics.Tracing.Tests -#################################################################### - -# System.SR needs implemented. -# https://github.com/mono/mono/issues/14907 --nomethod BasicEventSourceTests.TestsManifestNegative.Test_GenerateManifest_InvalidEventSources - #################################################################### ## System.Drawing.Common.Tests #################################################################### From 1b21ae4546ea164fd89c0370df5d66288c3135f6 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Thu, 23 Jan 2020 12:23:33 -0300 Subject: [PATCH 05/96] Remove ManagedTests.DynamicCSharp.Conformance.dynamic.overloadResolution.Methods.Oneclass2methods.twoprms004.twoprms004.Test.DynamicCSharpRunTest from rsp file --- ...e.dynamic.overloadResolution.Methods.1class2methods.cs | 1 + src/mono/netcore/CoreFX.issues.rsp | 8 -------- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/src/libraries/System.Dynamic.Runtime/tests/Dynamic.OverloadResolution/Conformance.dynamic.overloadResolution.Methods.1class2methods.cs b/src/libraries/System.Dynamic.Runtime/tests/Dynamic.OverloadResolution/Conformance.dynamic.overloadResolution.Methods.1class2methods.cs index 870d9a20a4590..a6e0aa412bdfb 100644 --- a/src/libraries/System.Dynamic.Runtime/tests/Dynamic.OverloadResolution/Conformance.dynamic.overloadResolution.Methods.1class2methods.cs +++ b/src/libraries/System.Dynamic.Runtime/tests/Dynamic.OverloadResolution/Conformance.dynamic.overloadResolution.Methods.1class2methods.cs @@ -3995,6 +3995,7 @@ public void Method(int f, ref object x) public class Test { [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/14906", TargetFrameworkMonikers.Mono)] public static void DynamicCSharpRunTest() { Assert.Equal(0, MainMethod(null)); diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index d9f78b6845720..a98f133e79ac5 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -12,14 +12,6 @@ # System.ArgumentException Arg_ObjObjEx -nomethod System.Drawing.Imaging.Tests.ImageAttributesTests.SetColorMatrix_InvalidFlags_ThrowsArgumentException -#################################################################### -## System.Dynamic.Runtime.Tests -#################################################################### - -# ambigous methods -# https://github.com/mono/mono/issues/14906 --nomethod ManagedTests.DynamicCSharp.Conformance.dynamic.overloadResolution.Methods.Oneclass2methods.twoprms004.twoprms004.Test.DynamicCSharpRunTest - #################################################################### ## System.IO.Tests #################################################################### From f63488bd13f5911d775c3344b83978466b02c46a Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Thu, 23 Jan 2020 12:30:53 -0300 Subject: [PATCH 06/96] Remove System.IO.Tests.*.CopyFileWithData_MemberData from rsp file --- src/mono/netcore/CoreFX.issues.rsp | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index a98f133e79ac5..c103c2f418127 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -12,13 +12,6 @@ # System.ArgumentException Arg_ObjObjEx -nomethod System.Drawing.Imaging.Tests.ImageAttributesTests.SetColorMatrix_InvalidFlags_ThrowsArgumentException -#################################################################### -## System.IO.Tests -#################################################################### - -# flaky test (The process cannot access the file ...) --nomethod System.IO.Tests.*.CopyFileWithData_MemberData - #################################################################### ## System.Linq.Expressions.Tests #################################################################### From 5c9e2c22eadecc4cbae201c9c6a80afca247260c Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Thu, 23 Jan 2020 13:07:03 -0300 Subject: [PATCH 07/96] Move a set of skipped System.Linq.Expressions.Tests out of rsp file. --- .../tests/Array/NewArrayBoundsTests.cs | 1 + .../Coalesce/BinaryCoalesceTests.cs | 1 + .../tests/Block/BlockTests.cs | 1 + .../tests/CompilerTests.cs | 5 +++++ .../tests/Goto/Return.cs | 1 + .../tests/Lambda/LambdaTests.cs | 1 + .../tests/MemberInit/BindTests.cs | 1 + .../tests/StackSpillerTests.cs | 1 + ...naryArithmeticNegateCheckedNullableTests.cs | 1 + .../Unary/UnaryArithmeticNegateCheckedTests.cs | 1 + src/mono/netcore/CoreFX.issues.rsp | 18 ------------------ 11 files changed, 14 insertions(+), 18 deletions(-) diff --git a/src/libraries/System.Linq.Expressions/tests/Array/NewArrayBoundsTests.cs b/src/libraries/System.Linq.Expressions/tests/Array/NewArrayBoundsTests.cs index 0e970f0a4f1ce..bc0462658d7a1 100644 --- a/src/libraries/System.Linq.Expressions/tests/Array/NewArrayBoundsTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/Array/NewArrayBoundsTests.cs @@ -131,6 +131,7 @@ public static IEnumerable TestData() } [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/14912", TargetFrameworkMonikers.Mono)] [PerCompilationType(nameof(TestData))] public static void NewArrayBounds(Type arrayType, object size, Type sizeType, object defaultValue, bool useInterpreter) { diff --git a/src/libraries/System.Linq.Expressions/tests/BinaryOperators/Coalesce/BinaryCoalesceTests.cs b/src/libraries/System.Linq.Expressions/tests/BinaryOperators/Coalesce/BinaryCoalesceTests.cs index 37fb0129b94bd..b81e616ae794c 100644 --- a/src/libraries/System.Linq.Expressions/tests/BinaryOperators/Coalesce/BinaryCoalesceTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/BinaryOperators/Coalesce/BinaryCoalesceTests.cs @@ -497,6 +497,7 @@ public static void CoalesceReferenceToValueType(bool useInterpreter) #if FEATURE_COMPILE [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/14919", TargetFrameworkMonikers.Mono)] public static void VerifyIL_NullableIntCoalesceToNullableInt() { ParameterExpression x = Expression.Parameter(typeof(int?)); diff --git a/src/libraries/System.Linq.Expressions/tests/Block/BlockTests.cs b/src/libraries/System.Linq.Expressions/tests/Block/BlockTests.cs index 18d54ffbc97b2..09f2db3e72b00 100644 --- a/src/libraries/System.Linq.Expressions/tests/Block/BlockTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/Block/BlockTests.cs @@ -227,6 +227,7 @@ public static void ToStringTest() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/14919", TargetFrameworkMonikers.Mono)] public static void InsignificantBlock() { Expression nop = Expression.Lambda( diff --git a/src/libraries/System.Linq.Expressions/tests/CompilerTests.cs b/src/libraries/System.Linq.Expressions/tests/CompilerTests.cs index 531fe42e0f3b7..0838b4ca3c3e8 100644 --- a/src/libraries/System.Linq.Expressions/tests/CompilerTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/CompilerTests.cs @@ -167,6 +167,7 @@ public static void VariableBinder_CatchBlock_Filter2() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/14919", TargetFrameworkMonikers.Mono)] public static void VerifyIL_Simple() { Expression> f = () => Math.Abs(42); @@ -183,6 +184,7 @@ .maxstack 1 } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/14919", TargetFrameworkMonikers.Mono)] public static void VerifyIL_Exceptions() { ParameterExpression x = Expression.Parameter(typeof(int), "x"); @@ -243,6 +245,7 @@ [0] int32 } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/14919", TargetFrameworkMonikers.Mono)] public static void VerifyIL_Closure1() { Expression>> f = () => () => 42; @@ -277,6 +280,7 @@ .maxstack 1 } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/14919", TargetFrameworkMonikers.Mono)] public static void VerifyIL_Closure2() { Expression>> f = x => () => x; @@ -334,6 +338,7 @@ [0] object[] } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/14919", TargetFrameworkMonikers.Mono)] public static void VerifyIL_Closure3() { // Using an unchecked addition to ensure that an add instruction is emitted (and not add.ovf) diff --git a/src/libraries/System.Linq.Expressions/tests/Goto/Return.cs b/src/libraries/System.Linq.Expressions/tests/Goto/Return.cs index bccb6a921a9b0..026b5a1b63976 100644 --- a/src/libraries/System.Linq.Expressions/tests/Goto/Return.cs +++ b/src/libraries/System.Linq.Expressions/tests/Goto/Return.cs @@ -296,6 +296,7 @@ public static void DoNothing() } [Theory, ClassData(typeof(CompilationTypes))] + [ActiveIssue("https://github.com/mono/mono/issues/14919", TargetFrameworkMonikers.Mono)] public void TailCallThenReturn(bool useInterpreter) { LabelTarget target = Expression.Label(); diff --git a/src/libraries/System.Linq.Expressions/tests/Lambda/LambdaTests.cs b/src/libraries/System.Linq.Expressions/tests/Lambda/LambdaTests.cs index 970be08aef049..71c52fbeaecad 100644 --- a/src/libraries/System.Linq.Expressions/tests/Lambda/LambdaTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/Lambda/LambdaTests.cs @@ -12,6 +12,7 @@ namespace System.Linq.Expressions.Tests { [TestCaseOrderer("System.Linq.Expressions.Tests.TestOrderer", "System.Linq.Expressions.Tests")] + [ActiveIssue("https://github.com/mono/mono/issues/14919", TargetFrameworkMonikers.Mono)] public class LambdaTests { private delegate int IcosanaryInt32Func( diff --git a/src/libraries/System.Linq.Expressions/tests/MemberInit/BindTests.cs b/src/libraries/System.Linq.Expressions/tests/MemberInit/BindTests.cs index 060513a844ec8..6101d240061ac 100644 --- a/src/libraries/System.Linq.Expressions/tests/MemberInit/BindTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/MemberInit/BindTests.cs @@ -162,6 +162,7 @@ public void MemberAssignmentFromMethodInfo(bool useInterpreter) } [Theory, ClassData(typeof(CompilationTypes))] + [ActiveIssue("https://github.com/mono/mono/issues/14918", TargetFrameworkMonikers.Mono)] public void ConstantField(bool useInterpreter) { MemberInfo member = typeof(PropertyAndFields).GetMember(nameof(PropertyAndFields.ConstantString))[0]; diff --git a/src/libraries/System.Linq.Expressions/tests/StackSpillerTests.cs b/src/libraries/System.Linq.Expressions/tests/StackSpillerTests.cs index d5069970c7c96..df9c1b9eaa597 100644 --- a/src/libraries/System.Linq.Expressions/tests/StackSpillerTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/StackSpillerTests.cs @@ -9,6 +9,7 @@ namespace System.Linq.Expressions.Tests { + [ActiveIssue("https://github.com/mono/mono/issues/14919", TargetFrameworkMonikers.Mono)] public static class StackSpillerTests { [Fact] diff --git a/src/libraries/System.Linq.Expressions/tests/Unary/UnaryArithmeticNegateCheckedNullableTests.cs b/src/libraries/System.Linq.Expressions/tests/Unary/UnaryArithmeticNegateCheckedNullableTests.cs index f046b46238f37..3ee6cb38054ad 100644 --- a/src/libraries/System.Linq.Expressions/tests/Unary/UnaryArithmeticNegateCheckedNullableTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/Unary/UnaryArithmeticNegateCheckedNullableTests.cs @@ -204,6 +204,7 @@ private static void VerifyArithmeticNegateCheckedNullableShort(short? value, boo #if FEATURE_COMPILE [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/14919", TargetFrameworkMonikers.Mono)] public static void VerifyIL_NullableShortNegateChecked() { ParameterExpression param = Expression.Parameter(typeof(short?)); diff --git a/src/libraries/System.Linq.Expressions/tests/Unary/UnaryArithmeticNegateCheckedTests.cs b/src/libraries/System.Linq.Expressions/tests/Unary/UnaryArithmeticNegateCheckedTests.cs index bc76e11c387f0..d2aa6b68a1fae 100644 --- a/src/libraries/System.Linq.Expressions/tests/Unary/UnaryArithmeticNegateCheckedTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/Unary/UnaryArithmeticNegateCheckedTests.cs @@ -211,6 +211,7 @@ private static void VerifyArithmeticNegateCheckedShort(short value, bool useInte #if FEATURE_COMPILE [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/14919", TargetFrameworkMonikers.Mono)] public static void VerifyIL_ShortNegateChecked() { ParameterExpression param = Expression.Parameter(typeof(short)); diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index c103c2f418127..f4222a4d3025d 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -16,24 +16,6 @@ ## System.Linq.Expressions.Tests #################################################################### -# OOM Exception gets thrown for the 68 (currently) tests that fail. -# https://github.com/mono/mono/issues/14912 --nomethod System.Linq.Expressions.Tests.ArrayBoundsTests.NewArrayBounds* - -# Exceptions are different. -# https://github.com/mono/mono/issues/14918 --nomethod System.Linq.Expressions.Tests.BindTests.ConstantField - -# System.Reflection.Emit type load / init exception https://github.com/mono/mono/issues/14919 --nomethod System.Linq.Expressions.Tests.Return.TailCallThenReturn --nomethod System.Linq.Expressions.Tests.UnaryArithmeticNegateCheckedNullableTests.VerifyIL_NullableShortNegateChecked --noclass System.Linq.Expressions.Tests.StackSpillerTests --noclass System.Linq.Expressions.Tests.LambdaTests --nomethod System.Linq.Expressions.Tests.BinaryCoalesceTests.VerifyIL_NullableIntCoalesceToNullableInt --nomethod System.Linq.Expressions.Tests.UnaryArithmeticNegateCheckedTests.VerifyIL_ShortNegateChecked --nomethod System.Linq.Expressions.Tests.BlockTests.InsignificantBlock --nomethod System.Linq.Expressions.Tests.CompilerTests.VerifyIL_* - # InvalidOperationException - Sequence contains no matching element # https://github.com/mono/mono/issues/14920 -nomethod System.Linq.Expressions.Tests.ArrayAccessTests.ArrayAccess_MultiDimensionalOf1 From 8b7f4a7f9c7a61d24ceea687b36418519e32b086 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Fri, 24 Jan 2020 04:18:02 -0300 Subject: [PATCH 08/96] Annotate System.Collections.Concurrent.Tests.ConcurrentQueueTests.ReferenceTypes_NulledAfterDequeue with ActiveIssue attribute --- .../System.Collections.Concurrent/tests/ConcurrentQueueTests.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/System.Collections.Concurrent/tests/ConcurrentQueueTests.cs b/src/libraries/System.Collections.Concurrent/tests/ConcurrentQueueTests.cs index 4fa9bee5715a0..758813758bca0 100644 --- a/src/libraries/System.Collections.Concurrent/tests/ConcurrentQueueTests.cs +++ b/src/libraries/System.Collections.Concurrent/tests/ConcurrentQueueTests.cs @@ -212,6 +212,7 @@ public void IEnumerable_GetAllExpectedItems() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16413", TargetFrameworkMonikers.Mono)] public void ReferenceTypes_NulledAfterDequeue() { int iterations = 10; // any number <32 will do From 870a16aa2a749120dfeacfb153fe4f407b8e8680 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Fri, 24 Jan 2020 05:15:03 -0300 Subject: [PATCH 09/96] Move another set of skipped System.Linq.Expressions.Tests out of rsp file. --- .../tests/Array/ArrayAccessTests.cs | 3 ++ .../tests/Array/ArrayIndexTests.cs | 2 + .../tests/Array/NewArrayBoundsTests.cs | 2 + .../ExceptionHandlingExpressions.cs | 2 + .../IndexExpression/IndexExpressionTests.cs | 3 ++ .../tests/Member/MemberAccessTests.cs | 1 + src/mono/netcore/CoreFX.issues.rsp | 40 ------------------- 7 files changed, 13 insertions(+), 40 deletions(-) diff --git a/src/libraries/System.Linq.Expressions/tests/Array/ArrayAccessTests.cs b/src/libraries/System.Linq.Expressions/tests/Array/ArrayAccessTests.cs index 61a26681acbf4..5344890329672 100644 --- a/src/libraries/System.Linq.Expressions/tests/Array/ArrayAccessTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/Array/ArrayAccessTests.cs @@ -13,6 +13,7 @@ public static class ArrayAccessTests public static IEnumerable Ranks() => Enumerable.Range(1, 5).Select(i => new object[] {i}); [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNonZeroLowerBoundArraySupported))] + [ActiveIssue("https://github.com/mono/mono/issues/14920", TargetFrameworkMonikers.Mono)] [ClassData(typeof(CompilationTypes))] public static void ArrayAccess_MultiDimensionalOf1(bool useInterpreter) { @@ -31,6 +32,7 @@ public static void ArrayAccess_MultiDimensionalOf1(bool useInterpreter) } [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNonZeroLowerBoundArraySupported))] + [ActiveIssue("https://github.com/mono/mono/issues/14920", TargetFrameworkMonikers.Mono)] [ClassData(typeof(CompilationTypes))] public static void ArrayIndex_MultiDimensionalOf1(bool useInterpreter) { @@ -78,6 +80,7 @@ public static void UnreadableIndex() } [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNonZeroLowerBoundArraySupported))] + [ActiveIssue("https://github.com/mono/mono/issues/14921", TargetFrameworkMonikers.Mono)] [ClassData(typeof(CompilationTypes))] public static void NonZeroBasedOneDimensionalArrayAccess(bool useInterpreter) { diff --git a/src/libraries/System.Linq.Expressions/tests/Array/ArrayIndexTests.cs b/src/libraries/System.Linq.Expressions/tests/Array/ArrayIndexTests.cs index d09e34c661a9d..c7796a8c8fae2 100644 --- a/src/libraries/System.Linq.Expressions/tests/Array/ArrayIndexTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/Array/ArrayIndexTests.cs @@ -2771,6 +2771,7 @@ public static void UnreadableIndex() } [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNonZeroLowerBoundArraySupported))] + [ActiveIssue("https://github.com/mono/mono/issues/14930", TargetFrameworkMonikers.Mono)] [ClassData(typeof(CompilationTypes))] public static void NonZeroBasedOneDimensionalArrayIndex(bool useInterpreter) { @@ -2792,6 +2793,7 @@ public static void NonZeroBasedOneDimensionalArrayIndex(bool useInterpreter) } [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNonZeroLowerBoundArraySupported))] + [ActiveIssue("https://github.com/mono/mono/issues/14930", TargetFrameworkMonikers.Mono)] [ClassData(typeof(CompilationTypes))] public static void NonZeroBasedOneDimensionalArrayIndexMethod(bool useInterpreter) { diff --git a/src/libraries/System.Linq.Expressions/tests/Array/NewArrayBoundsTests.cs b/src/libraries/System.Linq.Expressions/tests/Array/NewArrayBoundsTests.cs index bc0462658d7a1..722b271b8bc07 100644 --- a/src/libraries/System.Linq.Expressions/tests/Array/NewArrayBoundsTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/Array/NewArrayBoundsTests.cs @@ -288,6 +288,7 @@ public static void UpdateNullThrows() } [Theory, ClassData(typeof(CompilationTypes))] + [ActiveIssue("https://github.com/mono/mono/issues/14933", TargetFrameworkMonikers.Mono)] public static void SingleNegativeBoundErrorMessage(bool useInterpreter) { string localizedMessage = null; @@ -308,6 +309,7 @@ public static void SingleNegativeBoundErrorMessage(bool useInterpreter) } [Theory, ClassData(typeof(CompilationTypes))] + [ActiveIssue("https://github.com/mono/mono/issues/14934", TargetFrameworkMonikers.Mono)] public static void MultipleNegativeBoundErrorMessage(bool useInterpreter) { string localizedMessage = null; diff --git a/src/libraries/System.Linq.Expressions/tests/ExceptionHandling/ExceptionHandlingExpressions.cs b/src/libraries/System.Linq.Expressions/tests/ExceptionHandling/ExceptionHandlingExpressions.cs index 8d1aed9ff0573..2dc3260786342 100644 --- a/src/libraries/System.Linq.Expressions/tests/ExceptionHandling/ExceptionHandlingExpressions.cs +++ b/src/libraries/System.Linq.Expressions/tests/ExceptionHandling/ExceptionHandlingExpressions.cs @@ -224,6 +224,7 @@ public void ThrownNonExceptionPassesThroughNonMatchingHandlers(bool useInterpret } [Theory, ClassData(typeof(CompilationTypes))] + [ActiveIssue("https://github.com/mono/mono/issues/14925", TargetFrameworkMonikers.Mono)] public void ExpressionsUnwrapeExternallyThrownRuntimeWrappedException(bool useInterpreter) { ParameterExpression exRWE = Expression.Variable(typeof(RuntimeWrappedException)); @@ -931,6 +932,7 @@ public void FilterBeforeInnerFault(bool useInterpreter) } [Theory, ClassData(typeof(CompilationTypes))] + [ActiveIssue("https://github.com/mono/mono/issues/14924", TargetFrameworkMonikers.Mono)] public void ExceptionThrownInFilter(bool useInterpreter) { // An exception in a filter should be eaten and the filter fail. diff --git a/src/libraries/System.Linq.Expressions/tests/IndexExpression/IndexExpressionTests.cs b/src/libraries/System.Linq.Expressions/tests/IndexExpression/IndexExpressionTests.cs index 1a1df7f7e5f73..c9de9c0fd6e27 100644 --- a/src/libraries/System.Linq.Expressions/tests/IndexExpression/IndexExpressionTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/IndexExpression/IndexExpressionTests.cs @@ -100,6 +100,7 @@ private static TypeBuilder GetTestTypeBuilder() => .DefineType("TestType"); [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/14920", TargetFrameworkMonikers.Mono)] public void NoAccessorIndexedProperty() { TypeBuilder typeBuild = GetTestTypeBuilder(); @@ -174,6 +175,7 @@ public void VoidIndexedProperty() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/14927", TargetFrameworkMonikers.Mono)] public void IndexedPropertyGetReturnsWrongType() { TypeBuilder typeBuild = GetTestTypeBuilder(); @@ -326,6 +328,7 @@ public void IndexedPropertyGetterInstanceSetterStatic() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/14927", TargetFrameworkMonikers.Mono)] public void IndexedPropertySetterValueTypeNotMatchPropertyType() { TypeBuilder typeBuild = GetTestTypeBuilder(); diff --git a/src/libraries/System.Linq.Expressions/tests/Member/MemberAccessTests.cs b/src/libraries/System.Linq.Expressions/tests/Member/MemberAccessTests.cs index 01c93ac8de91d..bd34b75a52901 100644 --- a/src/libraries/System.Linq.Expressions/tests/Member/MemberAccessTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/Member/MemberAccessTests.cs @@ -554,6 +554,7 @@ public static void MakeMemberAccess_MemberNotFieldOrProperty_ThrowsArgumentExcep #if FEATURE_COMPILE [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/14920", TargetFrameworkMonikers.Mono)] public static void Property_NoGetOrSetAccessors_ThrowsArgumentException() { AssemblyBuilder assembly = AssemblyBuilder.DefineDynamicAssembly(new AssemblyName("Name"), AssemblyBuilderAccess.RunAndCollect); diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index f4222a4d3025d..5502a198c5961 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -12,46 +12,6 @@ # System.ArgumentException Arg_ObjObjEx -nomethod System.Drawing.Imaging.Tests.ImageAttributesTests.SetColorMatrix_InvalidFlags_ThrowsArgumentException -#################################################################### -## System.Linq.Expressions.Tests -#################################################################### - -# InvalidOperationException - Sequence contains no matching element -# https://github.com/mono/mono/issues/14920 --nomethod System.Linq.Expressions.Tests.ArrayAccessTests.ArrayAccess_MultiDimensionalOf1 --nomethod System.Linq.Expressions.Tests.ArrayAccessTests.ArrayIndex_MultiDimensionalOf1 --nomethod System.Linq.Expressions.Tests.MemberAccessTests.Property_NoGetOrSetAccessors_ThrowsArgumentException --nomethod System.Linq.Expressions.Tests.IndexExpressionTests.NoAccessorIndexedProperty - -# IndexOutOfRangeException -# https://github.com/mono/mono/issues/14921 --nomethod System.Linq.Expressions.Tests.ArrayAccessTests.NonZeroBasedOneDimensionalArrayAccess - -# System.InvalidOperationException : Operation is not valid due to the current state of the object. -# https://github.com/mono/mono/issues/14924 --nomethod System.Linq.Expressions.Tests.ExceptionHandlingExpressions.ExceptionThrownInFilter - -# legit test failure... Expected 4 / actual 0 -# https://github.com/mono/mono/issues/14925 --nomethod System.Linq.Expressions.Tests.ExceptionHandlingExpressions.ExpressionsUnwrapeExternallyThrownRuntimeWrappedException - -# Expected exception but none was thrown -# https://github.com/mono/mono/issues/14927 --nomethod System.Linq.Expressions.Tests.IndexExpressionTests.IndexedPropertySetterValueTypeNotMatchPropertyType --nomethod System.Linq.Expressions.Tests.IndexExpressionTests.IndexedPropertyGetReturnsWrongType - -# Expected ArgumentException got IndexOutOfRangeException https://github.com/mono/mono/issues/14930 --nomethod System.Linq.Expressions.Tests.ArrayIndexTests.NonZeroBasedOneDimensionalArrayIndex --nomethod System.Linq.Expressions.Tests.ArrayIndexTests.NonZeroBasedOneDimensionalArrayIndexMethod - -# OOM Exception. Weird -# https://github.com/mono/mono/issues/14933 --nomethod System.Linq.Expressions.Tests.ArrayBoundsTests.SingleNegativeBoundErrorMessage - -# Arithmetic operation resulted in an overflow. -# https://github.com/mono/mono/issues/14934 --nomethod System.Linq.Expressions.Tests.ArrayBoundsTests.MultipleNegativeBoundErrorMessage - #################################################################### ## System.Linq.Parallel.Tests #################################################################### From fa9dfb52347735147e3efa54199c8dc17127094d Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Fri, 24 Jan 2020 05:23:18 -0300 Subject: [PATCH 10/96] Move skipped System.Linq.Parallel.Tests.PlinqModesTests.WithExecutionMode_Multiple test out of rsp file --- .../System.Linq.Parallel/tests/PlinqModesTests.cs | 1 + src/mono/netcore/CoreFX.issues.rsp | 7 ------- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/libraries/System.Linq.Parallel/tests/PlinqModesTests.cs b/src/libraries/System.Linq.Parallel/tests/PlinqModesTests.cs index 661abc92219d7..565cd172697da 100644 --- a/src/libraries/System.Linq.Parallel/tests/PlinqModesTests.cs +++ b/src/libraries/System.Linq.Parallel/tests/PlinqModesTests.cs @@ -159,6 +159,7 @@ public static void WithExecutionMode_ArgumentException(Labeled Date: Fri, 24 Jan 2020 05:38:29 -0300 Subject: [PATCH 11/96] Move skipped System.Memory.Tests out of rsp file --- .../ArrayBufferWriterTests.T.cs | 1 + .../System.Memory/tests/Span/Reflection.cs | 6 +++++ src/mono/netcore/CoreFX.issues.rsp | 25 ------------------- 3 files changed, 7 insertions(+), 25 deletions(-) diff --git a/src/libraries/System.Memory/tests/ArrayBufferWriter/ArrayBufferWriterTests.T.cs b/src/libraries/System.Memory/tests/ArrayBufferWriter/ArrayBufferWriterTests.T.cs index 1fb5c6228be96..59afa82516cae 100644 --- a/src/libraries/System.Memory/tests/ArrayBufferWriter/ArrayBufferWriterTests.T.cs +++ b/src/libraries/System.Memory/tests/ArrayBufferWriter/ArrayBufferWriterTests.T.cs @@ -39,6 +39,7 @@ public void ArrayBufferWriter_Ctor() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15002", TargetFrameworkMonikers.Mono)] public void Invalid_Ctor() { Assert.Throws(() => new ArrayBufferWriter(0)); diff --git a/src/libraries/System.Memory/tests/Span/Reflection.cs b/src/libraries/System.Memory/tests/Span/Reflection.cs index 652e0f161e2d0..4dbae22ba1473 100644 --- a/src/libraries/System.Memory/tests/Span/Reflection.cs +++ b/src/libraries/System.Memory/tests/Span/Reflection.cs @@ -66,6 +66,7 @@ public static void MemoryMarshal_GenericStaticReturningSpan() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/14993", TargetFrameworkMonikers.Mono)] public static void Span_Constructor() { Type type = typeof(Span); @@ -102,6 +103,7 @@ public static void Span_StaticOperator() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/14998", TargetFrameworkMonikers.Mono)] public static void Span_InstanceMethod() { Type type = typeof(Span); @@ -111,6 +113,7 @@ public static void Span_InstanceMethod() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/14993", TargetFrameworkMonikers.Mono)] public static void ReadOnlySpan_Constructor() { Type type = typeof(ReadOnlySpan); @@ -147,6 +150,7 @@ public static void ReadOnlySpan_Operator() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/14998", TargetFrameworkMonikers.Mono)] public static void ReadOnlySpan_InstanceMethod() { Type type = typeof(ReadOnlySpan); @@ -156,6 +160,7 @@ public static void ReadOnlySpan_InstanceMethod() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/14998", TargetFrameworkMonikers.Mono)] public static void Memory_PropertyReturningSpan() { Type type = typeof(Memory); @@ -165,6 +170,7 @@ public static void Memory_PropertyReturningSpan() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/14962", TargetFrameworkMonikers.Mono)] public static void ReadOnlyMemory_PropertyReturningReadOnlySpan() { Type type = typeof(ReadOnlyMemory); diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 9e0b83496e9c6..f43dff7f4a839 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -12,31 +12,6 @@ # System.ArgumentException Arg_ObjObjEx -nomethod System.Drawing.Imaging.Tests.ImageAttributesTests.SetColorMatrix_InvalidFlags_ThrowsArgumentException -#################################################################### -## System.Memory.Tests -#################################################################### - -# Reflection TargetException: Non-static method requires a target. -# https://github.com/mono/mono/issues/14962 --nomethod System.SpanTests.SpanTests.ReadOnlyMemory_PropertyReturningReadOnlySpan - -# Should throw NotSupportedException, but we do not. -# https://github.com/mono/mono/issues/14993 --nomethod System.SpanTests.SpanTests.ReadOnlySpan_Constructor --nomethod System.SpanTests.SpanTests.Span_Constructor - -# Should throw NotSupportedException - Non static method requires a target -# https://github.com/mono/mono/issues/14998 --nomethod System.SpanTests.SpanTests.Span_InstanceMethod --nomethod System.SpanTests.SpanTests.Memory_PropertyReturningSpan --nomethod System.SpanTests.SpanTests.ReadOnlySpan_InstanceMethod - -# Should throw OutOfMemory Exception, but does not throw -# https://github.com/mono/mono/issues/15002 --nomethod System.Buffers.Tests.ArrayBufferWriterTests_String.Invalid_Ctor --nomethod System.Buffers.Tests.ArrayBufferWriterTests_Char.Invalid_Ctor --nomethod System.Buffers.Tests.ArrayBufferWriterTests_Byte.Invalid_Ctor - #################################################################### ## System.Net.Http.Functional.Tests #################################################################### From 43f57d8b79f3502747be47c29319469f211ed2b7 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Fri, 24 Jan 2020 06:31:35 -0300 Subject: [PATCH 12/96] Move skipped System.Net.Http.Functional.Tests.PlatformHandler_HttpClientHandler.* tests out of rdp file --- .../tests/FunctionalTests/PlatformHandlerTest.cs | 1 + src/mono/netcore/CoreFX.issues.rsp | 4 ---- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/PlatformHandlerTest.cs b/src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/PlatformHandlerTest.cs index 499ba9bf5ae98..a3dd06ced74da 100644 --- a/src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/PlatformHandlerTest.cs +++ b/src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/PlatformHandlerTest.cs @@ -10,6 +10,7 @@ namespace System.Net.Http.Functional.Tests { + [ActiveIssue("https://github.com/mono/mono/issues/15005", TargetFrameworkMonikers.Mono)] public class PlatformHandler_HttpClientHandler : HttpClientHandlerTestBase { public PlatformHandler_HttpClientHandler(ITestOutputHelper output) : base(output) { } diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index f43dff7f4a839..cca94a6fdd4df 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -16,10 +16,6 @@ ## System.Net.Http.Functional.Tests #################################################################### -# TODO: Crashes runtime inside Interop.Http.MultiPerform (marshalling issue?) -# https://github.com/mono/mono/issues/15005 --nomethod *PlatformHandler* - # Works, but may trigger UI! # NOTE: KEEPING THIS HERE BUT COMMENTED OUT - in the event the UI is shown (wasn't for me) #-nomethod System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_DangerousAcceptAllCertificatesValidator_Test.SetDelegate_ConnectionSucceeds From 46cc919dd7515208d5bd2a2fdebf8b2e0d039716 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Fri, 24 Jan 2020 07:20:19 -0300 Subject: [PATCH 13/96] Remove System.Net.Sockets.Tests.SocketOptionNameTest.MulticastInterface_Set_AnyInterface_Succeeds because it passes locally. --- src/mono/netcore/CoreFX.issues.rsp | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index cca94a6fdd4df..8fc3cb1384776 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -23,13 +23,6 @@ # When test is run, xunit claims it's not a part of the test suite #-nomethod System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_ClientCertificates_Test.AutomaticOrManual_DoesntFailRegardlessOfWhetherClientCertsAreAvailable -#################################################################### -## System.Net.Sockets.Tests -#################################################################### - -# flaky test --nomethod System.Net.Sockets.Tests.SocketOptionNameTest.MulticastInterface_Set_AnyInterface_Succeeds - #################################################################### ## System.Reflection.Emit.ILGeneration.Tests #################################################################### From 310b879b77c73158bcc4c33a3bbd72b52f0c5c10 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Fri, 24 Jan 2020 09:47:08 -0300 Subject: [PATCH 14/96] Move System.Reflection tests with an active issue out of rsp file --- .../tests/ConstructorInfoTests.cs | 2 ++ .../tests/MemberInfoTests.cs | 1 + .../tests/MethodInfoTests.cs | 1 + .../tests/ParameterInfoTests.cs | 1 + .../tests/PropertyInfoTests.cs | 1 + .../System.Reflection/tests/TypeInfoTests.cs | 5 +++ src/mono/netcore/CoreFX.issues.rsp | 35 ------------------- 7 files changed, 11 insertions(+), 35 deletions(-) diff --git a/src/libraries/System.Reflection/tests/ConstructorInfoTests.cs b/src/libraries/System.Reflection/tests/ConstructorInfoTests.cs index d0532f2228460..407bc54f5eb5e 100644 --- a/src/libraries/System.Reflection/tests/ConstructorInfoTests.cs +++ b/src/libraries/System.Reflection/tests/ConstructorInfoTests.cs @@ -70,6 +70,7 @@ public void Invoke_StaticConstructor_NullObject_NullParameters() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15024", TargetFrameworkMonikers.Mono)] public void Invoke_StaticConstructor_ThrowsMemberAccessException() { ConstructorInfo[] constructors = GetConstructors(typeof(ClassWithStaticConstructor)); @@ -156,6 +157,7 @@ public void Invoke_ExistingInstance() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15026", TargetFrameworkMonikers.Mono)] public void Invoke_AbstractClass_ThrowsMemberAccessException() { ConstructorInfo[] constructors = GetConstructors(typeof(ConstructorInfoAbstractBase)); diff --git a/src/libraries/System.Reflection/tests/MemberInfoTests.cs b/src/libraries/System.Reflection/tests/MemberInfoTests.cs index 32beee75be73f..834266de3e59e 100644 --- a/src/libraries/System.Reflection/tests/MemberInfoTests.cs +++ b/src/libraries/System.Reflection/tests/MemberInfoTests.cs @@ -341,6 +341,7 @@ public static void HasSameMetadataDefinitionAs_NamedAndGenericTypes() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15069", TargetFrameworkMonikers.Mono)] public static void HasSameMetadataDefinitionAs_GenericTypeParameters() { Type theT = typeof(GenericTestClass<>).GetTypeInfo().GenericTypeParameters[0]; diff --git a/src/libraries/System.Reflection/tests/MethodInfoTests.cs b/src/libraries/System.Reflection/tests/MethodInfoTests.cs index e815e7a7ab320..fe6aaafd23ee6 100644 --- a/src/libraries/System.Reflection/tests/MethodInfoTests.cs +++ b/src/libraries/System.Reflection/tests/MethodInfoTests.cs @@ -328,6 +328,7 @@ public void Invoke_ParameterSpecification_ArrayOfMissing() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15025", TargetFrameworkMonikers.Mono)] public static void Invoke_OptionalParameterUnassingableFromMissing_WithMissingValue_ThrowsArgumentException() { AssertExtensions.Throws(null, () => GetMethod(typeof(MethodInfoDefaultParameters), "OptionalStringParameter").Invoke(new MethodInfoDefaultParameters(), new object[] { Type.Missing })); diff --git a/src/libraries/System.Reflection/tests/ParameterInfoTests.cs b/src/libraries/System.Reflection/tests/ParameterInfoTests.cs index 95d1112dd603d..3c9a84216be7f 100644 --- a/src/libraries/System.Reflection/tests/ParameterInfoTests.cs +++ b/src/libraries/System.Reflection/tests/ParameterInfoTests.cs @@ -109,6 +109,7 @@ public void RawDefaultValue_Enum() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15037", TargetFrameworkMonikers.Mono)] public void RawDefaultValueFromAttribute() { ParameterInfo p = GetParameterInfo(typeof(ParameterInfoMetadata), "Foo2", 0); diff --git a/src/libraries/System.Reflection/tests/PropertyInfoTests.cs b/src/libraries/System.Reflection/tests/PropertyInfoTests.cs index 4f4594ab5121d..2f5544b4efd30 100644 --- a/src/libraries/System.Reflection/tests/PropertyInfoTests.cs +++ b/src/libraries/System.Reflection/tests/PropertyInfoTests.cs @@ -82,6 +82,7 @@ public static IEnumerable GetValue_Invalid_TestData() } [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/15027", TargetFrameworkMonikers.Mono)] [MemberData(nameof(GetValue_Invalid_TestData))] public void GetValue_Invalid(Type type, string name, object obj, object[] index, Type exceptionType) { diff --git a/src/libraries/System.Reflection/tests/TypeInfoTests.cs b/src/libraries/System.Reflection/tests/TypeInfoTests.cs index d74f6fa7a7bb2..3e85282c1323d 100644 --- a/src/libraries/System.Reflection/tests/TypeInfoTests.cs +++ b/src/libraries/System.Reflection/tests/TypeInfoTests.cs @@ -471,6 +471,7 @@ public static void IsEnumDefined(object value, bool expected) } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15028", TargetFrameworkMonikers.Mono)] public void IsEnumDefined_Invalid() { AssertExtensions.Throws("", () => typeof(NonGenericClassWithNoInterfaces).GetTypeInfo().IsEnumDefined(10)); @@ -709,6 +710,7 @@ public void GetConstructor(Type[] types, int? expected) } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15029", TargetFrameworkMonikers.Mono)] public static void FindMembers() { MemberInfo[] members = typeof(MembersClass).GetTypeInfo().FindMembers(MemberTypes.All, BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance, (MemberInfo memberInfo, object c) => true, "notused"); @@ -792,6 +794,7 @@ public void GetProperty() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15029", TargetFrameworkMonikers.Mono)] public void GetMethod() { MethodInfo[] methods = typeof(MembersClass).GetTypeInfo().GetMethods(); @@ -810,6 +813,7 @@ public void GetMethod_Invalid() } [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/15029", TargetFrameworkMonikers.Mono)] [InlineData(BindingFlags.Default, 9)] [InlineData(BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance, 16)] public void GetMethods(BindingFlags bindingAttributes, int length) @@ -876,6 +880,7 @@ public void GetMember(string name, BindingFlags bindingAttributes, int length) } [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/15029", TargetFrameworkMonikers.Mono)] [InlineData(BindingFlags.Default, 15)] [InlineData(BindingFlags.NonPublic | BindingFlags.Instance, 13)] [InlineData(BindingFlags.Public | BindingFlags.Instance, 15)] diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 8fc3cb1384776..1511b34303cd0 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -164,44 +164,9 @@ ## System.Reflection.Tests #################################################################### -# Expected ArgumentException, but none was thrown -# https://github.com/mono/mono/issues/15024 --nomethod System.Reflection.Tests.MethodInfoTests.Invoke_OptionalParameterUnassingableFromMissing_WithMissingValue_ThrowsArgumentException - -# Static ctors cannot be invoke with one Invoke overload -# https://github.com/mono/mono/issues/15025 --nomethod System.Reflection.Tests.ConstructorInfoTests.Invoke_StaticConstructor_ThrowsMemberAccessException - -# Expected MemberAccessException, but we're throwing TargetException -# https://github.com/mono/mono/issues/15026 --nomethod System.Reflection.Tests.ConstructorInfoTests.Invoke_AbstractClass_ThrowsMemberAccessException - -# Expected TargetParameterCountException, but we have ArgumentException -# https://github.com/mono/mono/issues/15027 --nomethod System.Reflection.Tests.PropertyInfoTests.GetValue_Invalid - -# Expected empty string, but got enumType instead -# https://github.com/mono/mono/issues/15028 --nomethod System.Reflection.Tests.TypeInfoTests.IsEnumDefined_Invalid - -# Fails because our Object class has extra instance methods -# https://github.com/mono/mono/issues/15029 --nomethod System.Reflection.Tests.TypeInfoTests.FindMembers --nomethod System.Reflection.Tests.TypeInfoTests.GetMethods --nomethod System.Reflection.Tests.TypeInfoTests.GetMembers --nomethod System.Reflection.Tests.TypeInfoTests.GetMethod - -# CustomConstantAttribute not supported -# https://github.com/mono/mono/issues/15037 --nomethod System.Reflection.Tests.ParameterInfoTests.RawDefaultValueFromAttribute - # SKIPPED -nomethod System.Reflection.Tests.MemberInfoTests.HasSameMetadataDefinitionAs__CornerCase_HasElementTypes -# Assertion failed... Not sure why -# https://github.com/mono/mono/issues/15069 --nomethod System.Reflection.Tests.MemberInfoTests.HasSameMetadataDefinitionAs_GenericTypeParameters - # relies on specific exception message -nomethod System.Reflection.Tests.AssemblyTests.LoadFile_ValidPEBadIL_ThrowsBadImageFormatExceptionWithPath -nomethod System.Reflection.Tests.AssemblyTests.LoadFile_PartiallyQualifiedPath_ThrowsArgumentException From 81f97fc4e9a6b5e41f97b1a11dd89695d46aa555 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Fri, 24 Jan 2020 10:46:22 -0300 Subject: [PATCH 15/96] Move skipped System.Runtime.InteropServices.Tests out of rsp file --- .../Marshal/DestroyStructureTests.cs | 1 + .../Marshal/GetExceptionCodeTests.cs | 2 + .../Marshal/GetExceptionForHRTests.cs | 2 + .../Marshal/GetExceptionPointersTests.cs | 2 + .../GetFunctionPointerForDelegateTests.cs | 1 + .../InteropServices/Marshal/OffsetOfTests.cs | 1 + .../Marshal/PtrToStructureTests.cs | 1 + .../Marshal/ReadWrite/ByteTests.cs | 9 ++ .../Marshal/ReadWrite/Int16Tests.cs | 9 ++ .../Marshal/ReadWrite/Int32Tests.cs | 9 ++ .../Marshal/ReadWrite/Int64Tests.cs | 9 ++ .../Marshal/ReadWrite/IntPtrTests.cs | 9 ++ .../InteropServices/Marshal/SizeOfTests.cs | 1 + .../Marshal/StructureToPtrTests.cs | 3 + .../Marshal/ThrowExceptionForHRTests.cs | 2 + src/mono/netcore/CoreFX.issues.rsp | 85 ------------------- 16 files changed, 61 insertions(+), 85 deletions(-) diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/DestroyStructureTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/DestroyStructureTests.cs index 0e32157e4ab11..7d301f1bf8dc5 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/DestroyStructureTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/DestroyStructureTests.cs @@ -92,6 +92,7 @@ public static IEnumerable DestroyStructure_InvalidType_TestData() } [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/15087", TargetFrameworkMonikers.Mono)] [MemberData(nameof(DestroyStructure_InvalidType_TestData))] public void DestroyStructure_NonRuntimeType_ThrowsArgumentException(Type invalidType) { diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionCodeTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionCodeTests.cs index c3f4ababc893b..07cb19f0b9c00 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionCodeTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionCodeTests.cs @@ -3,11 +3,13 @@ // See the LICENSE file in the project root for more information. using Xunit; +using Microsoft.DotNet.XUnitExtensions.Attributes; #pragma warning disable CS0618 // Type or member is obsolete namespace System.Runtime.InteropServices.Tests { + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public class GetExceptionCodeTests { [Fact] diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionForHRTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionForHRTests.cs index 4322bfd83000d..19bc64f11ce30 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionForHRTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionForHRTests.cs @@ -10,6 +10,7 @@ namespace System.Runtime.InteropServices.Tests public class GetExceptionForHRTests { [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/15093", TargetFrameworkMonikers.Mono)] [InlineData(unchecked((int)0x80020006))] [InlineData(unchecked((int)0x80020101))] public void GetExceptionForHR_NoErrorInfo_ReturnsValidException(int errorCode) @@ -35,6 +36,7 @@ public static IEnumerable GetExceptionForHR_ErrorInfo_TestData() } [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/15093", TargetFrameworkMonikers.Mono)] [MemberData(nameof(GetExceptionForHR_ErrorInfo_TestData))] public void GetExceptionForHR_ErrorInfo_ReturnsValidException(int errorCode, IntPtr errorInfo) { diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionPointersTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionPointersTests.cs index ee6c552e3a50b..4f4af1a2eba75 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionPointersTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionPointersTests.cs @@ -3,12 +3,14 @@ // See the LICENSE file in the project root for more information. using Xunit; +using Microsoft.DotNet.XUnitExtensions.Attributes; namespace System.Runtime.InteropServices.Tests { public class GetExceptionPointersTests { [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void GetExceptionPointers_ReturnsExpected() { Assert.Equal(IntPtr.Zero, Marshal.GetExceptionPointers()); diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetFunctionPointerForDelegateTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetFunctionPointerForDelegateTests.cs index f4bfb08d23280..cecc0b0bb31c1 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetFunctionPointerForDelegateTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetFunctionPointerForDelegateTests.cs @@ -81,6 +81,7 @@ public void GetFunctionPointerForDelegate_ObjectNotDelegate_ThrowsInvalidCastExc } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15097", TargetFrameworkMonikers.Mono)] public void GetFunctionPointer_GenericDelegate_ThrowsArgumentException() { MethodInfo targetMethod = typeof(GetFunctionPointerForDelegateTests).GetMethod(nameof(Method), BindingFlags.NonPublic | BindingFlags.Static); diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/OffsetOfTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/OffsetOfTests.cs index c5bc193b638c0..9c35df5c56735 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/OffsetOfTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/OffsetOfTests.cs @@ -209,6 +209,7 @@ public static IEnumerable OffsetOf_NotMarshallable_TestData() } [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/15087", TargetFrameworkMonikers.Mono)] [MemberData(nameof(OffsetOf_NotMarshallable_TestData))] public void OffsetOf_NotMarshallable_ThrowsArgumentException(Type t, string fieldName) { diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/PtrToStructureTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/PtrToStructureTests.cs index 760944dca590a..e9e0339bcd7ba 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/PtrToStructureTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/PtrToStructureTests.cs @@ -126,6 +126,7 @@ public void PtrToStructure_ZeroPointerWithType_ReturnsNull() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15101", TargetFrameworkMonikers.Mono)] public void PtrToStructure_ZeroPointer_ThrowsArgumentNullException() { AssertExtensions.Throws("ptr", () => Marshal.PtrToStructure(IntPtr.Zero, (object)new SomeTestStruct())); diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/ByteTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/ByteTests.cs index 5877afdcadd6f..9c5f425230a43 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/ByteTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/ByteTests.cs @@ -5,6 +5,7 @@ using System.Reflection; using System.Reflection.Emit; using Xunit; +using Microsoft.DotNet.XUnitExtensions.Attributes; #pragma warning disable CS0618 // Type or member is obsolete @@ -44,6 +45,7 @@ public void WriteByte_Pointer_Roundtrips(byte[] values) } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void WriteByte_BlittableObject_Roundtrips() { int offset1 = Marshal.OffsetOf(nameof(BlittableStruct.value1)).ToInt32(); @@ -65,6 +67,7 @@ public void WriteByte_BlittableObject_Roundtrips() } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void WriteByte_StructWithReferenceTypes_ReturnsExpected() { int pointerOffset = Marshal.OffsetOf(nameof(StructWithReferenceTypes.pointerValue)).ToInt32(); @@ -89,6 +92,7 @@ public void WriteByte_StructWithReferenceTypes_ReturnsExpected() } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void ReadByte_BlittableObject_ReturnsExpected() { int offset1 = Marshal.OffsetOf(nameof(BlittableStruct.value1)).ToInt32(); @@ -105,6 +109,7 @@ public void ReadByte_BlittableObject_ReturnsExpected() } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void ReadByte_StructWithReferenceTypes_ReturnsExpected() { int pointerOffset = Marshal.OffsetOf(nameof(StructWithReferenceTypes.pointerValue)).ToInt32(); @@ -135,12 +140,14 @@ public void ReadByte_ZeroPointer_ThrowsException() } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void ReadByte_NullObject_ThrowsAccessViolationException() { Assert.Throws(() => Marshal.ReadByte(null, 2)); } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void ReadByte_NotReadable_ThrowsArgumentException() { AssemblyBuilder assemblyBuilder = AssemblyBuilder.DefineDynamicAssembly(new AssemblyName("Assembly"), AssemblyBuilderAccess.RunAndCollect); @@ -160,12 +167,14 @@ public void WriteByte_ZeroPointer_ThrowsException() } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void WriteByte_NullObject_ThrowsAccessViolationException() { Assert.Throws(() => Marshal.WriteByte(null, 2, 0)); } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void WriteByte_NotReadable_ThrowsArgumentException() { AssemblyBuilder assemblyBuilder = AssemblyBuilder.DefineDynamicAssembly(new AssemblyName("Assembly"), AssemblyBuilderAccess.RunAndCollect); diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int16Tests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int16Tests.cs index 4d364e13d2239..8a01732578608 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int16Tests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int16Tests.cs @@ -5,6 +5,7 @@ using System.Reflection; using System.Reflection.Emit; using Xunit; +using Microsoft.DotNet.XUnitExtensions.Attributes; #pragma warning disable CS0618 // Type or member is obsolete @@ -44,6 +45,7 @@ public void WriteInt16_Pointer_Roundtrips(short[] values) } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void WriteInt16_BlittableObject_Roundtrips() { int offset1 = Marshal.OffsetOf(nameof(BlittableStruct.value1)).ToInt32(); @@ -65,6 +67,7 @@ public void WriteInt16_BlittableObject_Roundtrips() } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void WriteInt16_StructWithReferenceTypes_ReturnsExpected() { int pointerOffset = Marshal.OffsetOf(nameof(StructWithReferenceTypes.pointerValue)).ToInt32(); @@ -89,6 +92,7 @@ public void WriteInt16_StructWithReferenceTypes_ReturnsExpected() } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void ReadInt16_BlittableObject_ReturnsExpected() { int offset1 = Marshal.OffsetOf(nameof(BlittableStruct.value1)).ToInt32(); @@ -105,6 +109,7 @@ public void ReadInt16_BlittableObject_ReturnsExpected() } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void ReadInt16_StructWithReferenceTypes_ReturnsExpected() { int pointerOffset = Marshal.OffsetOf(nameof(StructWithReferenceTypes.pointerValue)).ToInt32(); @@ -130,12 +135,14 @@ public void ReadInt16_ZeroPointer_ThrowsException() } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void ReadInt16_NullObject_ThrowsAccessViolationException() { Assert.Throws(() => Marshal.ReadInt16(null, 2)); } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void ReadInt16_NotReadable_ThrowsArgumentException() { AssemblyBuilder assemblyBuilder = AssemblyBuilder.DefineDynamicAssembly(new AssemblyName("Assembly"), AssemblyBuilderAccess.RunAndCollect); @@ -155,12 +162,14 @@ public void WriteInt16_ZeroPointer_ThrowsException() } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void WriteInt16_NullObject_ThrowsAccessViolationException() { Assert.Throws(() => Marshal.WriteInt16(null, 2, 0)); } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void WriteInt16_NotReadable_ThrowsArgumentException() { AssemblyBuilder assemblyBuilder = AssemblyBuilder.DefineDynamicAssembly(new AssemblyName("Assembly"), AssemblyBuilderAccess.RunAndCollect); diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int32Tests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int32Tests.cs index f1006e93e7bf1..b8470488faa90 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int32Tests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int32Tests.cs @@ -5,6 +5,7 @@ using System.Reflection; using System.Reflection.Emit; using Xunit; +using Microsoft.DotNet.XUnitExtensions.Attributes; #pragma warning disable CS0618 // Type or member is obsolete @@ -44,6 +45,7 @@ public void WriteInt32_Pointer_Roundtrips(int[] values) } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void WriteInt32_BlittableObject_Roundtrips() { int offset1 = Marshal.OffsetOf(nameof(BlittableStruct.value1)).ToInt32(); @@ -65,6 +67,7 @@ public void WriteInt32_BlittableObject_Roundtrips() } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void WriteInt32_StructWithReferenceTypes_ReturnsExpected() { int pointerOffset = Marshal.OffsetOf(nameof(StructWithReferenceTypes.pointerValue)).ToInt32(); @@ -90,6 +93,7 @@ public void WriteInt32_StructWithReferenceTypes_ReturnsExpected() } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void ReadInt32_BlittableObject_ReturnsExpected() { int offset1 = Marshal.OffsetOf(nameof(BlittableStruct.value1)).ToInt32(); @@ -106,6 +110,7 @@ public void ReadInt32_BlittableObject_ReturnsExpected() } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void ReadInt32_StructWithReferenceTypes_ReturnsExpected() { int pointerOffset = Marshal.OffsetOf(nameof(StructWithReferenceTypes.pointerValue)).ToInt32(); @@ -132,12 +137,14 @@ public void ReadInt32_ZeroPoint_ThrowsException() } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void ReadInt32_NullObject_ThrowsAccessViolationException() { Assert.Throws(() => Marshal.ReadInt32(null, 2)); } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void ReadInt32_NotReadable_ThrowsArgumentException() { AssemblyBuilder assemblyBuilder = AssemblyBuilder.DefineDynamicAssembly(new AssemblyName("Assembly"), AssemblyBuilderAccess.RunAndCollect); @@ -157,12 +164,14 @@ public void WriteInt32_ZeroPointer_ThrowsException() } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void WriteInt32_NullObject_ThrowsAccessViolationException() { Assert.Throws(() => Marshal.WriteInt32(null, 2, 0)); } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void WriteInt32_NotReadable_ThrowsArgumentException() { AssemblyBuilder assemblyBuilder = AssemblyBuilder.DefineDynamicAssembly(new AssemblyName("Assembly"), AssemblyBuilderAccess.RunAndCollect); diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int64Tests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int64Tests.cs index aa2869eb31c51..1bd8a3444d663 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int64Tests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int64Tests.cs @@ -5,6 +5,7 @@ using System.Reflection; using System.Reflection.Emit; using Xunit; +using Microsoft.DotNet.XUnitExtensions.Attributes; #pragma warning disable CS0618 // Type or member is obsolete @@ -44,6 +45,7 @@ public void WriteInt64_Pointer_Roundtrips(long[] values) } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void WriteInt64_BlittableObject_Roundtrips() { int offset1 = Marshal.OffsetOf(nameof(BlittableStruct.value1)).ToInt32(); @@ -65,6 +67,7 @@ public void WriteInt64_BlittableObject_Roundtrips() } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void WriteInt64_StructWithReferenceTypes_ReturnsExpected() { int pointerOffset = Marshal.OffsetOf(nameof(StructWithReferenceTypes.pointerValue)).ToInt32(); @@ -99,6 +102,7 @@ public void WriteInt64_StructWithReferenceTypes_ReturnsExpected() } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void ReadInt64_BlittableObject_ReturnsExpected() { int offset1 = Marshal.OffsetOf(nameof(BlittableStruct.value1)).ToInt32(); @@ -115,6 +119,7 @@ public void ReadInt64_BlittableObject_ReturnsExpected() } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void ReadInt64_StructWithReferenceTypes_ReturnsExpected() { int pointerOffset = Marshal.OffsetOf(nameof(StructWithReferenceTypes.pointerValue)).ToInt32(); @@ -144,12 +149,14 @@ public void ReadInt64_ZeroPointer_ThrowsException() } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void ReadInt64_NullObject_ThrowsAccessViolationException() { Assert.Throws(() => Marshal.ReadInt64(null, 2)); } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void ReadInt64_NotReadable_ThrowsArgumentException() { AssemblyBuilder assemblyBuilder = AssemblyBuilder.DefineDynamicAssembly(new AssemblyName("Assembly"), AssemblyBuilderAccess.RunAndCollect); @@ -169,12 +176,14 @@ public void WriteInt64_ZeroPointer_ThrowsException() } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void WriteInt64_NullObject_ThrowsAccessViolationException() { Assert.Throws(() => Marshal.WriteInt64(null, 2, 0)); } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void WriteInt64_NotReadable_ThrowsArgumentException() { AssemblyBuilder assemblyBuilder = AssemblyBuilder.DefineDynamicAssembly(new AssemblyName("Assembly"), AssemblyBuilderAccess.RunAndCollect); diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/IntPtrTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/IntPtrTests.cs index 0ede4ea14c6c3..0e5d71be5f7f1 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/IntPtrTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/IntPtrTests.cs @@ -7,6 +7,7 @@ using System.Reflection; using System.Reflection.Emit; using Xunit; +using Microsoft.DotNet.XUnitExtensions.Attributes; #pragma warning disable CS0618 // Type or member is obsolete @@ -51,6 +52,7 @@ public void WriteIntPtr_Pointer_Roundtrips(IntPtr[] values) } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void WriteIntPtr_BlittableObject_Roundtrips() { int offset1 = Marshal.OffsetOf(nameof(BlittableStruct.value1)).ToInt32(); @@ -72,6 +74,7 @@ public void WriteIntPtr_BlittableObject_Roundtrips() } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void WriteIntPtr_StructWithReferenceTypes_ReturnsExpected() { int pointerOffset = Marshal.OffsetOf(nameof(StructWithReferenceTypes.pointerValue)).ToInt32(); @@ -97,6 +100,7 @@ public void WriteIntPtr_StructWithReferenceTypes_ReturnsExpected() } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void ReadIntPtr_BlittableObject_ReturnsExpected() { int offset1 = Marshal.OffsetOf(nameof(BlittableStruct.value1)).ToInt32(); @@ -113,6 +117,7 @@ public void ReadIntPtr_BlittableObject_ReturnsExpected() } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void ReadIntPtr_StructWithReferenceTypes_ReturnsExpected() { int pointerOffset = Marshal.OffsetOf(nameof(StructWithReferenceTypes.pointerValue)).ToInt32(); @@ -139,12 +144,14 @@ public void ReadIntPtr_ZeroPointer_ThrowsException() } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void ReadIntPtr_NullObject_ThrowsAccessViolationException() { Assert.Throws(() => Marshal.ReadIntPtr(null, 2)); } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void ReadIntPtr_NotReadable_ThrowsArgumentException() { AssemblyBuilder assemblyBuilder = AssemblyBuilder.DefineDynamicAssembly(new AssemblyName("Assembly"), AssemblyBuilderAccess.RunAndCollect); @@ -164,12 +171,14 @@ public void WriteIntPtr_ZeroPointer_ThrowsException() } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void WriteIntPtr_NullObject_ThrowsAccessViolationException() { Assert.Throws(() => Marshal.WriteIntPtr(null, 2, (IntPtr)0)); } [Fact] + [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] public void WriteIntPtr_NotReadable_ThrowsArgumentException() { AssemblyBuilder assemblyBuilder = AssemblyBuilder.DefineDynamicAssembly(new AssemblyName("Assembly"), AssemblyBuilderAccess.RunAndCollect); diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/SizeOfTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/SizeOfTests.cs index 576e6db7f8be0..7a09a43a155a2 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/SizeOfTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/SizeOfTests.cs @@ -82,6 +82,7 @@ public static IEnumerable SizeOf_InvalidType_TestData() } [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/15087", TargetFrameworkMonikers.Mono)] [MemberData(nameof(SizeOf_InvalidType_TestData))] public void SizeOf_InvalidType_ThrowsArgumentException(Type type, string paramName) { diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/StructureToPtrTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/StructureToPtrTests.cs index a664e60c53b54..b13bdfec58249 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/StructureToPtrTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/StructureToPtrTests.cs @@ -11,6 +11,7 @@ namespace System.Runtime.InteropServices.Tests public class StructureToPtrTests { [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15102", TargetFrameworkMonikers.Mono)] public void StructureToPtr_ByValBoolArray_Success() { var structure1 = new StructWithBoolArray() @@ -90,6 +91,7 @@ public void StructureToPtr_OverflowByValArrayInStruct_Success() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15103", TargetFrameworkMonikers.Mono)] public void StructureToPtr_ByValDateArray_Success() { var structure = new StructWithDateArray() @@ -165,6 +167,7 @@ public void StructureToPtr_AutoLayout_ThrowsArgumentException() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15104", TargetFrameworkMonikers.Mono)] public void StructureToPtr_InvalidLengthByValArrayInStruct_ThrowsArgumentException() { var structure = new StructWithByValArray diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ThrowExceptionForHRTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ThrowExceptionForHRTests.cs index b82cb3608d3ea..28382d07020f3 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ThrowExceptionForHRTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ThrowExceptionForHRTests.cs @@ -11,6 +11,7 @@ namespace System.Runtime.InteropServices.Tests public class ThrowExceptionForHRTests { [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/15093", TargetFrameworkMonikers.Mono)] [InlineData(unchecked((int)0x80020006))] [InlineData(unchecked((int)0x80020101))] public void ThrowExceptionForHR_NoErrorInfo_ReturnsValidException(int errorCode) @@ -54,6 +55,7 @@ public static IEnumerable ThrowExceptionForHR_ErrorInfo_TestData() } [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/15093", TargetFrameworkMonikers.Mono)] [MemberData(nameof(ThrowExceptionForHR_ErrorInfo_TestData))] public void ThrowExceptionForHR_ErrorInfo_ReturnsValidException(int errorCode, IntPtr errorInfo) { diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 1511b34303cd0..f4e1eccf56c3b 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -175,91 +175,6 @@ # fails on Helix -nomethod System.Reflection.Tests.AssemblyTests.LoadFromStream_Location_IsEmpty -#################################################################### -## System.Runtime.InteropServices.Tests -#################################################################### - -# Marshal Methods WILL NOT BE Implemented in MonoVM -# https://github.com/mono/mono/issues/15085 --nomethod System.Runtime.InteropServices.Tests.IntPtrTests.ReadIntPtr_NotReadable_ThrowsArgumentException --nomethod System.Runtime.InteropServices.Tests.IntPtrTests.WriteIntPtr_BlittableObject_Roundtrips --nomethod System.Runtime.InteropServices.Tests.IntPtrTests.WriteIntPtr_StructWithReferenceTypes_ReturnsExpected --nomethod System.Runtime.InteropServices.Tests.Int64Tests.WriteInt64_StructWithReferenceTypes_ReturnsExpected --nomethod System.Runtime.InteropServices.Tests.Int64Tests.ReadInt64_BlittableObject_ReturnsExpected --nomethod System.Runtime.InteropServices.Tests.Int16Tests.ReadInt16_NullObject_ThrowsAccessViolationException --nomethod System.Runtime.InteropServices.Tests.Int16Tests.ReadInt16_NotReadable_ThrowsArgumentException --nomethod System.Runtime.InteropServices.Tests.Int16Tests.WriteInt16_NotReadable_ThrowsArgumentException --nomethod System.Runtime.InteropServices.Tests.Int16Tests.WriteInt16_BlittableObject_Roundtrips --nomethod System.Runtime.InteropServices.Tests.Int16Tests.ReadInt16_StructWithReferenceTypes_ReturnsExpected --nomethod System.Runtime.InteropServices.Tests.Int16Tests.WriteInt16_NullObject_ThrowsAccessViolationException --nomethod System.Runtime.InteropServices.Tests.Int16Tests.ReadInt16_BlittableObject_ReturnsExpected --nomethod System.Runtime.InteropServices.Tests.Int16Tests.WriteInt16_StructWithReferenceTypes_ReturnsExpected --nomethod System.Runtime.InteropServices.Tests.IntPtrTests.ReadIntPtr_BlittableObject_ReturnsExpected --nomethod System.Runtime.InteropServices.Tests.Int64Tests.WriteInt64_NotReadable_ThrowsArgumentException --nomethod System.Runtime.InteropServices.Tests.Int64Tests.WriteInt64_BlittableObject_Roundtrips --nomethod System.Runtime.InteropServices.Tests.Int64Tests.WriteInt64_NullObject_ThrowsAccessViolationException --nomethod System.Runtime.InteropServices.Tests.Int64Tests.ReadInt64_NotReadable_ThrowsArgumentException --nomethod System.Runtime.InteropServices.Tests.Int32Tests.ReadInt32_NullObject_ThrowsAccessViolationException --nomethod System.Runtime.InteropServices.Tests.Int32Tests.WriteInt32_NullObject_ThrowsAccessViolationException --nomethod System.Runtime.InteropServices.Tests.Int32Tests.WriteInt32_BlittableObject_Roundtrips --nomethod System.Runtime.InteropServices.Tests.Int32Tests.WriteInt32_NotReadable_ThrowsArgumentException --nomethod System.Runtime.InteropServices.Tests.Int32Tests.WriteInt32_StructWithReferenceTypes_ReturnsExpected --nomethod System.Runtime.InteropServices.Tests.Int32Tests.ReadInt32_StructWithReferenceTypes_ReturnsExpected --nomethod System.Runtime.InteropServices.Tests.Int32Tests.ReadInt32_NotReadable_ThrowsArgumentException --nomethod System.Runtime.InteropServices.Tests.Int32Tests.ReadInt32_BlittableObject_ReturnsExpected --nomethod System.Runtime.InteropServices.Tests.IntPtrTests.ReadIntPtr_NullObject_ThrowsAccessViolationException --nomethod System.Runtime.InteropServices.Tests.IntPtrTests.WriteIntPtr_NullObject_ThrowsAccessViolationException --nomethod System.Runtime.InteropServices.Tests.IntPtrTests.WriteIntPtr_NotReadable_ThrowsArgumentException --nomethod System.Runtime.InteropServices.Tests.IntPtrTests.ReadIntPtr_StructWithReferenceTypes_ReturnsExpected --nomethod System.Runtime.InteropServices.Tests.ByteTests.ReadByte_BlittableObject_ReturnsExpected --nomethod System.Runtime.InteropServices.Tests.ByteTests.WriteByte_NullObject_ThrowsAccessViolationException --nomethod System.Runtime.InteropServices.Tests.ByteTests.WriteByte_StructWithReferenceTypes_ReturnsExpected --nomethod System.Runtime.InteropServices.Tests.ByteTests.ReadByte_StructWithReferenceTypes_ReturnsExpected --nomethod System.Runtime.InteropServices.Tests.ByteTests.WriteByte_BlittableObject_Roundtrips --nomethod System.Runtime.InteropServices.Tests.ByteTests.WriteByte_NotReadable_ThrowsArgumentException --nomethod System.Runtime.InteropServices.Tests.ByteTests.ReadByte_NullObject_ThrowsAccessViolationException --nomethod System.Runtime.InteropServices.Tests.ByteTests.ReadByte_NotReadable_ThrowsArgumentException --nomethod System.Runtime.InteropServices.Tests.Int64Tests.ReadInt64_NullObject_ThrowsAccessViolationException --nomethod System.Runtime.InteropServices.Tests.Int64Tests.ReadInt64_StructWithReferenceTypes_ReturnsExpected --nomethod System.Runtime.InteropServices.Tests.GetExceptionCodeTests.* --nomethod System.Runtime.InteropServices.Tests.GetExceptionPointersTests.GetExceptionPointers_ReturnsExpected - - -# Not sure what to check -# Expected ArgumentException to be thrown, but none was -# https://github.com/mono/mono/issues/15087 --nomethod System.Runtime.InteropServices.Tests.DestroyStructureTests.DestroyStructure_NonRuntimeType_ThrowsArgumentException --nomethod System.Runtime.InteropServices.Tests.OffsetOfTests.OffsetOf_NotMarshallable_ThrowsArgumentException --nomethod System.Runtime.InteropServices.Tests.SizeOfTests.SizeOf_InvalidType_ThrowsArgumentException - -# Wants exception messages to be non-empty -# https://github.com/mono/mono/issues/15093 --nomethod System.Runtime.InteropServices.Tests.GetExceptionForHRTests.GetExceptionForHR_ErrorInfo_ReturnsValidException --nomethod System.Runtime.InteropServices.Tests.GetExceptionForHRTests.GetExceptionForHR_NoErrorInfo_ReturnsValidException --nomethod System.Runtime.InteropServices.Tests.ThrowExceptionForHRTests.ThrowExceptionForHR_NoErrorInfo_ReturnsValidException --nomethod System.Runtime.InteropServices.Tests.ThrowExceptionForHRTests.ThrowExceptionForHR_ErrorInfo_ReturnsValidException - -# Supported on Mono -# Expected ArgumentException -# https://github.com/mono/mono/issues/15097 --nomethod System.Runtime.InteropServices.Tests.GetFunctionPointerForDelegateTests.GetFunctionPointer_GenericDelegate_ThrowsArgumentException - -# AE with The structure must not be a value class; -# https://github.com/mono/mono/issues/15101 --nomethod System.Runtime.InteropServices.Tests.PtrToStructureTests.PtrToStructure_ZeroPointer_ThrowsArgumentNullException - -# Expected 255 / Actual 1 -# https://github.com/mono/mono/issues/15102 --nomethod System.Runtime.InteropServices.Tests.StructureToPtrTests.StructureToPtr_ByValBoolArray_Success - -# MarshalDirectiveException -# https://github.com/mono/mono/issues/15103 --nomethod System.Runtime.InteropServices.Tests.StructureToPtrTests.StructureToPtr_ByValDateArray_Success - -# Expects AE but none was thrown -# https://github.com/mono/mono/issues/15104 --nomethod System.Runtime.InteropServices.Tests.StructureToPtrTests.StructureToPtr_InvalidLengthByValArrayInStruct_ThrowsArgumentException - #################################################################### ## System.Runtime.Serialization.Formatters.Tests #################################################################### From b70501061a8a9bbb76402c020dd633c35a8f76dd Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Fri, 24 Jan 2020 11:22:46 -0300 Subject: [PATCH 16/96] Replace closed CoreFX GH issue with the active Runtime one --- .../Microsoft.VisualBasic.Core/tests/InteractionTests.cs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libraries/Microsoft.VisualBasic.Core/tests/InteractionTests.cs b/src/libraries/Microsoft.VisualBasic.Core/tests/InteractionTests.cs index 4e5de9a44222a..35e0fa1764fa5 100644 --- a/src/libraries/Microsoft.VisualBasic.Core/tests/InteractionTests.cs +++ b/src/libraries/Microsoft.VisualBasic.Core/tests/InteractionTests.cs @@ -138,7 +138,7 @@ public static IEnumerable IIf_TestData() } [Fact] - [ActiveIssue("https://github.com/dotnet/corefx/issues/40842#issuecomment-528858413", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2139", TargetFrameworkMonikers.Mono)] public void DeleteSetting() { if (!PlatformDetection.IsInAppContainer) @@ -208,7 +208,7 @@ private static (string, string)[] GetEnvironmentVariables() } [Fact] - [ActiveIssue("https://github.com/dotnet/corefx/issues/40842#issuecomment-528858413", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2139", TargetFrameworkMonikers.Mono)] public void GetAllSettings() { if (!PlatformDetection.IsInAppContainer) @@ -223,7 +223,7 @@ public void GetAllSettings() } [Fact] - [ActiveIssue("https://github.com/dotnet/corefx/issues/40842#issuecomment-528858413", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2139", TargetFrameworkMonikers.Mono)] public void GetSetting() { if (!PlatformDetection.IsInAppContainer) @@ -306,7 +306,7 @@ public void Partition_Overflow(long Number, long Start, long Stop, long Interval } [Fact] - [ActiveIssue("https://github.com/dotnet/corefx/issues/40842#issuecomment-528858413", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2139", TargetFrameworkMonikers.Mono)] public void SaveSetting() { if (!PlatformDetection.IsInAppContainer) From f444ffbb9c04b880ab8fec53a6b1952daef3c926 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Fri, 24 Jan 2020 11:34:34 -0300 Subject: [PATCH 17/96] Move skipped System.Runtime.Serialization.Formatters.Tests out of rsp file --- .../tests/BinaryFormatterTests.cs | 1 + .../tests/FormatterServicesTests.cs | 3 +++ .../tests/SerializationGuardTests.cs | 1 + src/mono/netcore/CoreFX.issues.rsp | 24 ------------------- 4 files changed, 5 insertions(+), 24 deletions(-) diff --git a/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs b/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs index 35e73a2392850..0e57249769e5c 100644 --- a/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs +++ b/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs @@ -62,6 +62,7 @@ public void ValidateBasicObjectsRoundtrip(object obj, FormatterAssemblyStyle ass [Theory] [SkipOnCoreClr("Takes too long on Checked", RuntimeConfiguration.Checked)] + [ActiveIssue("https://github.com/mono/mono/issues/15115", TargetFrameworkMonikers.Mono)] [MemberData(nameof(SerializableObjects_MemberData))] public void ValidateAgainstBlobs(object obj, TypeSerializableValue[] blobs) => ValidateAndRoundtrip(obj, blobs, false); diff --git a/src/libraries/System.Runtime.Serialization.Formatters/tests/FormatterServicesTests.cs b/src/libraries/System.Runtime.Serialization.Formatters/tests/FormatterServicesTests.cs index 16eb1e101ac5d..13d51bbd96223 100644 --- a/src/libraries/System.Runtime.Serialization.Formatters/tests/FormatterServicesTests.cs +++ b/src/libraries/System.Runtime.Serialization.Formatters/tests/FormatterServicesTests.cs @@ -55,6 +55,7 @@ public static IEnumerable GetUninitializedObject_NotSupportedType_Test } [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/15113", TargetFrameworkMonikers.Mono)] [MemberData(nameof(GetUninitializedObject_NotSupportedType_TestData))] public void GetUninitializedObject_NotSupportedType_ThrowsArgumentException(Type type) { @@ -84,6 +85,7 @@ public static IEnumerable GetUninitializedObject_OpenGenericClass_Test } [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/15111", TargetFrameworkMonikers.Mono)] [MemberData(nameof(GetUninitializedObject_OpenGenericClass_TestData))] public void GetUninitializedObject_OpenGenericClass_ThrowsMemberAccessException(Type type) { @@ -235,6 +237,7 @@ private class ObjectWithStaticField } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15114", TargetFrameworkMonikers.Mono)] public void GetUninitializedObject_StaticConstructorThrows_ThrowsTypeInitializationException() { TypeInitializationException ex = Assert.Throws(() => FormatterServices.GetUninitializedObject(typeof(StaticConstructorThrows))); diff --git a/src/libraries/System.Runtime.Serialization.Formatters/tests/SerializationGuardTests.cs b/src/libraries/System.Runtime.Serialization.Formatters/tests/SerializationGuardTests.cs index 66acfc3797f8c..8e3f96f9a37b0 100644 --- a/src/libraries/System.Runtime.Serialization.Formatters/tests/SerializationGuardTests.cs +++ b/src/libraries/System.Runtime.Serialization.Formatters/tests/SerializationGuardTests.cs @@ -34,6 +34,7 @@ public static void BlockFileWrites() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15112", TargetFrameworkMonikers.Mono)] public static void BlockReflectionDodging() { // Ensure that the deserialization tracker cannot be called by reflection. diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index f4e1eccf56c3b..8d7e4ddb9fd62 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -175,30 +175,6 @@ # fails on Helix -nomethod System.Reflection.Tests.AssemblyTests.LoadFromStream_Location_IsEmpty -#################################################################### -## System.Runtime.Serialization.Formatters.Tests -#################################################################### - -# Expected MemberAccessException but none was thrown -# https://github.com/mono/mono/issues/15111 --nomethod System.Runtime.Serialization.Formatters.Tests.FormatterServicesTests.GetUninitializedObject_OpenGenericClass_ThrowsMemberAccessException - -# NotNull Assertion failure -# https://github.com/mono/mono/issues/15112 --nomethod System.Runtime.Serialization.Formatters.Tests.SerializationGuardTests.BlockReflectionDodging - -# Expected AE but none thrown -# https://github.com/mono/mono/issues/15113 --nomethod System.Runtime.Serialization.Formatters.Tests.FormatterServicesTests.GetUninitializedObject_NotSupportedType_ThrowsArgumentException - -# Expected TypeInitializationException but none thrown -# https://github.com/mono/mono/issues/15114 --nomethod System.Runtime.Serialization.Formatters.Tests.FormatterServicesTests.GetUninitializedObject_StaticConstructorThrows_ThrowsTypeInitializationException - -# Object reference not set to an instance of an object error -# https://github.com/mono/mono/issues/15115 --nomethod System.Runtime.Serialization.Formatters.Tests.BinaryFormatterTests.ValidateAgainstBlobs - #################################################################### ## System.Runtime.Tests #################################################################### From 3311cccab2f2795dcedfb3b21ae2d061cc71585f Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Fri, 24 Jan 2020 12:10:10 -0300 Subject: [PATCH 18/96] Move skipped System.Runtime.Tests with an active issue out of rsp file --- .../tests/System/DelegateTests.cs | 3 +++ .../tests/System/ExceptionTests.cs | 5 ++++- .../System/Reflection/IsCollectibleTests.cs | 1 + .../tests/System/Reflection/PointerTests.cs | 1 + src/mono/netcore/CoreFX.issues.rsp | 19 ------------------- 5 files changed, 9 insertions(+), 20 deletions(-) diff --git a/src/libraries/System.Runtime/tests/System/DelegateTests.cs b/src/libraries/System.Runtime/tests/System/DelegateTests.cs index 1257581b24bc9..392097df6ecd0 100644 --- a/src/libraries/System.Runtime/tests/System/DelegateTests.cs +++ b/src/libraries/System.Runtime/tests/System/DelegateTests.cs @@ -383,6 +383,7 @@ public static void DynamicInvoke_OptionalParameter_WithExplicitValue() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15148", TargetFrameworkMonikers.Mono)] public static void DynamicInvoke_OptionalParameter_WithMissingValue() { Assert.Equal( @@ -391,6 +392,7 @@ public static void DynamicInvoke_OptionalParameter_WithMissingValue() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15148", TargetFrameworkMonikers.Mono)] public static void DynamicInvoke_OptionalParameterUnassingableFromMissing_WithMissingValue() { AssertExtensions.Throws(null, () => (new OptionalStringParameter(StringMethod)).DynamicInvoke(new object[] { Type.Missing })); @@ -405,6 +407,7 @@ public static void DynamicInvoke_ParameterSpecification_ArrayOfStrings() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15148", TargetFrameworkMonikers.Mono)] public static void DynamicInvoke_ParameterSpecification_ArrayOfMissing() { Assert.Same( diff --git a/src/libraries/System.Runtime/tests/System/ExceptionTests.cs b/src/libraries/System.Runtime/tests/System/ExceptionTests.cs index 64a4d43906ed6..faf39b7155e19 100644 --- a/src/libraries/System.Runtime/tests/System/ExceptionTests.cs +++ b/src/libraries/System.Runtime/tests/System/ExceptionTests.cs @@ -81,6 +81,7 @@ public static void Exception_TargetSite_Jit() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15140", TargetFrameworkMonikers.Mono)] public static void ThrowStatementDoesNotResetExceptionStackLineSameMethod() { (string, string, int) rethrownExceptionStackFrame = (null, null, 0); @@ -108,7 +109,9 @@ private static (string, string, int) ThrowAndRethrowSameMethod(out (string, stri } } - [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotArm64Process))] // [ActiveIssue(https://github.com/dotnet/runtime/issues/1871)] can't use ActiveIssue for archs + [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotArm64Process))] + // [ActiveIssue(https://github.com/dotnet/runtime/issues/1871)] can't use ActiveIssue for archs + // [ActiveIssue("https://github.com/mono/mono/issues/15141", TargetFrameworkMonikers.Mono)] public static void ThrowStatementDoesNotResetExceptionStackLineOtherMethod() { (string, string, int) rethrownExceptionStackFrame = (null, null, 0); diff --git a/src/libraries/System.Runtime/tests/System/Reflection/IsCollectibleTests.cs b/src/libraries/System.Runtime/tests/System/Reflection/IsCollectibleTests.cs index 59c6299c49f16..07272982f54c6 100644 --- a/src/libraries/System.Runtime/tests/System/Reflection/IsCollectibleTests.cs +++ b/src/libraries/System.Runtime/tests/System/Reflection/IsCollectibleTests.cs @@ -18,6 +18,7 @@ public TestAssemblyLoadContext() : base(true) {} protected override Assembly Load(AssemblyName assemblyName) => null; } + [ActiveIssue("https://github.com/mono/mono/issues/15142", TargetFrameworkMonikers.Mono)] public class IsCollectibleTests { public static string asmNameString = "TestCollectibleAssembly"; diff --git a/src/libraries/System.Runtime/tests/System/Reflection/PointerTests.cs b/src/libraries/System.Runtime/tests/System/Reflection/PointerTests.cs index 731a9ef48f91e..0703140060cf7 100644 --- a/src/libraries/System.Runtime/tests/System/Reflection/PointerTests.cs +++ b/src/libraries/System.Runtime/tests/System/Reflection/PointerTests.cs @@ -171,6 +171,7 @@ public void PointerPropertySetValue_InvalidType(int value) } [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/15152", TargetFrameworkMonikers.Mono)] [MemberData(nameof(Pointers))] public void PointerPropertyGetValue(int value) { diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 8d7e4ddb9fd62..997ce72cdc4d9 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -179,21 +179,6 @@ ## System.Runtime.Tests #################################################################### -# https://github.com/mono/mono/issues/14291 incorrect line numbers -# See https://github.com/mono/mono/issues/15140 and https://github.com/mono/mono/issues/15141 --nomethod System.Tests.ExceptionTests.ThrowStatementDoesNotResetExceptionStackLineSameMethod --nomethod System.Tests.ExceptionTests.ThrowStatementDoesNotResetExceptionStackLineOtherMethod - -# RuntimeAssembly.IsCollectible is not implemented yet -# Implementation task https://github.com/mono/mono/issues/15142 --nomethod System.Reflection.Tests.IsCollectibleTests.* - -# Mono ignores [Optional] attribute defined on parameters in delegates -# https://github.com/mono/mono/issues/15148 --nomethod System.Tests.DelegateTests.DynamicInvoke_OptionalParameterUnassingableFromMissing_WithMissingValue --nomethod System.Tests.DelegateTests.DynamicInvoke_OptionalParameter_WithMissingValue --nomethod System.Tests.DelegateTests.DynamicInvoke_ParameterSpecification_ArrayOfMissing - # mono doesn't support termination signals, the test kills a process via libc's kill(pid) # and expects it to trigger domain.ProcessExit event -nomethod System.Tests.ExitCodeTests.SigTermExitCode @@ -201,10 +186,6 @@ # error: Invalid IL code in (wrapper dynamic-method) object: (System.Xml.Xsl.Runtime.XmlQueryRuntime,System.Xml.XPath.XPathNavigator,double): IL_0179: ret -nomethod System.Tests.Types.VoidTests.IsByRef_Get_ReturnsExpected -# throws ArgumentException -# https://github.com/mono/mono/issues/15152 --nomethod System.Reflection.Tests.PointerTests.PointerPropertyGetValue - # GCSettings.LatencyMode is not implemented -nomethod System.Tests.GCTests.LatencyRoundtrips From d911dad231aa5ca752173500e1ed2c16f0d5dba9 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 27 Jan 2020 06:29:59 -0300 Subject: [PATCH 19/96] Move skipped System.Threading.Tests with an active issue out of rsp file --- .../System.Threading/tests/MutexTests.cs | 2 ++ .../System.Threading/tests/SemaphoreTests.cs | 2 ++ src/mono/netcore/CoreFX.issues.rsp | 25 ------------------- 3 files changed, 4 insertions(+), 25 deletions(-) diff --git a/src/libraries/System.Threading/tests/MutexTests.cs b/src/libraries/System.Threading/tests/MutexTests.cs index 40b37d16c985d..3149426d4f53c 100644 --- a/src/libraries/System.Threading/tests/MutexTests.cs +++ b/src/libraries/System.Threading/tests/MutexTests.cs @@ -38,6 +38,7 @@ public void Ctor_ConstructWaitRelease() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15159", TargetFrameworkMonikers.Mono)] [PlatformSpecific(TestPlatforms.AnyUnix)] public void Ctor_InvalidNames_Unix() { @@ -122,6 +123,7 @@ public void OpenExisting(string name) } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15158", TargetFrameworkMonikers.Mono)] public void OpenExisting_InvalidNames() { AssertExtensions.Throws("name", () => Mutex.OpenExisting(null)); diff --git a/src/libraries/System.Threading/tests/SemaphoreTests.cs b/src/libraries/System.Threading/tests/SemaphoreTests.cs index fd2c81f2a17aa..5591fb542da67 100644 --- a/src/libraries/System.Threading/tests/SemaphoreTests.cs +++ b/src/libraries/System.Threading/tests/SemaphoreTests.cs @@ -39,6 +39,7 @@ public void Ctor_ValidName_Windows(string name) } [PlatformSpecific(TestPlatforms.AnyUnix)] // named semaphores aren't supported on Unix + [ActiveIssue("https://github.com/mono/mono/issues/15161", TargetFrameworkMonikers.Mono)] [Fact] public void Ctor_NamesArentSupported_Unix() { @@ -189,6 +190,7 @@ public void NamedProducerConsumer() } [PlatformSpecific(TestPlatforms.AnyUnix)] // named semaphores aren't supported on Unix + [ActiveIssue("https://github.com/mono/mono/issues/15160", TargetFrameworkMonikers.Mono)] [Fact] public void OpenExisting_NotSupported_Unix() { diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 997ce72cdc4d9..e3be3b05aecfb 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -199,31 +199,6 @@ ## System.Threading.Tests #################################################################### -# Process hangs and test fails with [ERROR] FATAL UNHANDLED EXCEPTION: System.Threading.WaitHandleCannotBeOpenedException: No handle of the given name exists. -# https://github.com/mono/mono/issues/15157 --nomethod System.Threading.Tests.MutexTests.CrossProcess_NamedMutex_ProtectedFileAccessAtomic - -# Fails with typeof(System.Threading.WaitHandleCannotBeOpenedException): A WaitHandle with system-wide name '' cannot be created. A WaitHandle of a different type might have the same name. -# Expects an ArgumentException -# https://github.com/mono/mono/issues/15158 --nomethod System.Threading.Tests.MutexTests.OpenExisting_InvalidNames - -# Expects ArgumentException but none is thrown -# https://github.com/mono/mono/issues/15159 --nomethod System.Threading.Tests.MutexTests.Ctor_InvalidNames_Unix - -# Expects PlatformNotSupportedException, but we give an ArgumentNullException -# https://github.com/mono/mono/issues/15160 --nomethod System.Threading.Tests.SemaphoreTests.OpenExisting_NotSupported_Unix - -# Expects PlatformNotSupportedException but none thrown -# https://github.com/mono/mono/issues/15161 --nomethod System.Threading.Tests.SemaphoreTests.Ctor_NamesArentSupported_Unix - -#################################################################### -## System.Threading.Tests -#################################################################### - # Requires precise GC (should be ignored in dotnet/corefx for mono) -nomethod System.Threading.Tasks.Tests.ExecutionContextFlowTest.TaskCompletionSourceDoesntCaptureExecutionContext From b2782789b2acdead39ba35905dc54e1c54e3784b Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 27 Jan 2020 15:55:23 +0300 Subject: [PATCH 20/96] Remove skipped System.Data.Common.Tests because the related issue was addressed --- src/mono/netcore/CoreFX.issues.rsp | 23 ----------------------- 1 file changed, 23 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index e3be3b05aecfb..981f7a7bafab9 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -247,29 +247,6 @@ # Invalid IL - IL_00bc: castclass 0x0100000d -nomethod System.Data.Tests.SqlTypes.SqlCharsTest.ReadWriteXmlTest -# Invalid IL code in Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationReaderSqlInt32:Read1_int (): IL_00bc: castclass 0x0100000d -# https://github.com/mono/mono/issues/15174 --nomethod System.Data.Tests.SqlTypes.SqlInt32Test.ReadWriteXmlTest - -# System.InvalidProgramException : Invalid IL code in Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationReaderSqlInt64:Read1_long (): IL_00bc: castclass 0x0100000d -# https://github.com/mono/mono/issues/15175 --nomethod System.Data.Tests.SqlTypes.SqlInt64Test.ReadWriteXmlTest - -# System.InvalidProgramException : Invalid IL code in Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationReaderSqlDouble:Read1_double (): IL_00bc: castclass 0x0100000d -# https://github.com/mono/mono/issues/15176 --nomethod System.Data.Tests.SqlTypes.SqlDoubleTest.ReadWriteXmlTest - -# System.InvalidProgramException : Invalid IL code in Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationReaderSqlInt16:Read1_short (): IL_00bc: castclass 0x0100000d -# https://github.com/mono/mono/issues/15177 --nomethod System.Data.Tests.SqlTypes.SqlInt16Test.ReadWriteXmlTest - -# System.InvalidProgramException : Invalid IL code in Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationReaderSqlDecimal:Read1_decimal (): IL_00bc: castclass 0x0100000d -# https://github.com/mono/mono/issues/15178 --nomethod System.Data.Tests.SqlTypes.SqlDecimalTest.ReadWriteXmlTest - -# System.InvalidProgramException : Invalid IL code in Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationReaderSqlString:Read1_string (): IL_00bc: castclass 0x0100000d -# https://github.com/mono/mono/issues/15179 --nomethod System.Data.Tests.SqlTypes.SqlStringTest.ReadWriteXmlTest # Assert IsNotNull failure # https://github.com/mono/mono/issues/15180 From 3aa460e4d1e958f5ab8b8816d5516b33347d13fb Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 27 Jan 2020 15:56:17 +0300 Subject: [PATCH 21/96] Move skipped System.Data.Common.Tests.DbConnectionTests.ProviderFactoryTest with an active issue out of rsp file --- .../tests/System/Data/Common/DbConnectionTests.cs | 1 + src/mono/netcore/CoreFX.issues.rsp | 5 ----- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/libraries/System.Data.Common/tests/System/Data/Common/DbConnectionTests.cs b/src/libraries/System.Data.Common/tests/System/Data/Common/DbConnectionTests.cs index fd809e7101bf6..d28316a8b41a5 100644 --- a/src/libraries/System.Data.Common/tests/System/Data/Common/DbConnectionTests.cs +++ b/src/libraries/System.Data.Common/tests/System/Data/Common/DbConnectionTests.cs @@ -146,6 +146,7 @@ public void CanBeFinalized() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15180", TargetFrameworkMonikers.Mono)] public void ProviderFactoryTest() { DbProviderFactoryConnection con = new DbProviderFactoryConnection(); diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 981f7a7bafab9..51ca40fb7db25 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -247,11 +247,6 @@ # Invalid IL - IL_00bc: castclass 0x0100000d -nomethod System.Data.Tests.SqlTypes.SqlCharsTest.ReadWriteXmlTest - -# Assert IsNotNull failure -# https://github.com/mono/mono/issues/15180 --nomethod System.Data.Common.Tests.DbConnectionTests.ProviderFactoryTest - #################################################################### ## System.Diagnostics.StackTrace.Tests #################################################################### From e1a4e853ca8d6f74aa935a748bab5a87e9728495 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 27 Jan 2020 16:12:03 +0300 Subject: [PATCH 22/96] Move skipped System.Diagnostics.StackTrace.Tests with an active issue out of rsp file --- .../tests/StackFrameTests.cs | 4 ++++ src/mono/netcore/CoreFX.issues.rsp | 20 ------------------- 2 files changed, 4 insertions(+), 20 deletions(-) diff --git a/src/libraries/System.Diagnostics.StackTrace/tests/StackFrameTests.cs b/src/libraries/System.Diagnostics.StackTrace/tests/StackFrameTests.cs index 2fb5fe982632f..03d6363ee292b 100644 --- a/src/libraries/System.Diagnostics.StackTrace/tests/StackFrameTests.cs +++ b/src/libraries/System.Diagnostics.StackTrace/tests/StackFrameTests.cs @@ -34,6 +34,7 @@ public void Ctor_FNeedFileInfo(bool fNeedFileInfo) } [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/15183", TargetFrameworkMonikers.Mono)] [InlineData(StackFrame.OFFSET_UNKNOWN)] [InlineData(0)] [InlineData(1)] @@ -44,6 +45,7 @@ public void Ctor_SkipFrames(int skipFrames) } [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/15187", TargetFrameworkMonikers.Mono)] [InlineData(StackFrame.OFFSET_UNKNOWN, true)] [InlineData(0, true)] [InlineData(1, true)] @@ -91,6 +93,7 @@ public void Ctor_Filename_LineNumber(string fileName, int lineNumber) } [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/15184", TargetFrameworkMonikers.Mono)] [InlineData(null, StackFrame.OFFSET_UNKNOWN, 0)] [InlineData("", 0, StackFrame.OFFSET_UNKNOWN)] [InlineData("FileName", 1, 2)] @@ -115,6 +118,7 @@ public static IEnumerable ToString_TestData() } [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/15186", TargetFrameworkMonikers.Mono)] [MemberData(nameof(ToString_TestData))] public void ToString_Invoke_ReturnsExpected(StackFrame stackFrame, string expectedToString) { diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 51ca40fb7db25..62b34fdcd3515 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -251,26 +251,6 @@ ## System.Diagnostics.StackTrace.Tests #################################################################### -# Expected -1, but got 0 -# https://github.com/mono/mono/issues/15183 --nomethod System.Diagnostics.Tests.StackFrameTests.Ctor_SkipFrames - -# Assertion differences -# https://github.com/mono/mono/issues/15184 --nomethod System.Diagnostics.Tests.StackFrameTests.Ctor_Filename_LineNumber_ColNumber - -# A little off -# Assert.Equal() Failure -# ↓ (pos 0) -# Expected: MoveNext at offset 90 in file:line:column··· -# Actual: .ctor at offset 90 in file:line:column Fi··· -# https://github.com/mono/mono/issues/15186 --nomethod System.Diagnostics.Tests.StackFrameTests.ToString_Invoke_ReturnsExpected - -# Assertion differences. Expects -1, got 0 -# https://github.com/mono/mono/issues/15187 --nomethod System.Diagnostics.Tests.StackFrameTests.Ctor_SkipFrames_FNeedFileInfo - # JIT should not inline custom throw helpers -nomethod System.Diagnostics.Tests.StackTraceTests.Ctor_Exception_SkipFrames -nomethod System.Diagnostics.Tests.StackTraceTests.Ctor_Exception_SkipFrames_FNeedFileInfo From 920d42debca5f5eee8a7269c9f2c0f60dba42966 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 27 Jan 2020 16:20:05 +0300 Subject: [PATCH 23/96] Move skipped System.Numerics.Vectors.Tests with an active issue out of rsp file --- .../tests/GenericVectorTests.cs | 3 +++ src/mono/netcore/CoreFX.issues.rsp | 10 ---------- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs b/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs index 6067f0cbb4ab2..a9a74b26a6162 100644 --- a/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs +++ b/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs @@ -446,10 +446,13 @@ private void TestArrayIndexBasedConstructorLessElements() where T : struct #region Tests for constructors using unsupported types [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15190", TargetFrameworkMonikers.Mono)] public void ConstructorWithUnsupportedTypes_Guid() => TestConstructorWithUnsupportedTypes(); [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15190", TargetFrameworkMonikers.Mono)] public void ConstructorWithUnsupportedTypes_DateTime() => TestConstructorWithUnsupportedTypes(); [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15190", TargetFrameworkMonikers.Mono)] public void ConstructorWithUnsupportedTypes_Char() => TestConstructorWithUnsupportedTypes(); private void TestConstructorWithUnsupportedTypes() where T : struct diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 62b34fdcd3515..a9942a6934204 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -258,16 +258,6 @@ # Assert.Contains() Failure -nomethod System.Diagnostics.Tests.StackTraceTests.ToString_Invoke_ReturnsExpected -#################################################################### -## System.Numerics.Vectors.Tests -#################################################################### - -# Expects NotSupportedException, but actual was TypeInitializationException -# https://github.com/mono/mono/issues/15190 --nomethod System.Numerics.Tests.GenericVectorTests.ConstructorWithUnsupportedTypes_DateTime --nomethod System.Numerics.Tests.GenericVectorTests.ConstructorWithUnsupportedTypes_Char --nomethod System.Numerics.Tests.GenericVectorTests.ConstructorWithUnsupportedTypes_Guid - #################################################################### ## System.Reflection.Context.Tests #################################################################### From 07722f1feb9d47ba9656eebf9a4b8550ce85818c Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 27 Jan 2020 16:25:25 +0300 Subject: [PATCH 24/96] Move skipped System.Reflection.Context.Tests with an active issue out of rsp file --- .../tests/CustomReflectionContextTests.cs | 3 +++ src/mono/netcore/CoreFX.issues.rsp | 11 ----------- 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/src/libraries/System.Reflection.Context/tests/CustomReflectionContextTests.cs b/src/libraries/System.Reflection.Context/tests/CustomReflectionContextTests.cs index 93d7c0df88dae..1ef7b92b4aa61 100644 --- a/src/libraries/System.Reflection.Context/tests/CustomReflectionContextTests.cs +++ b/src/libraries/System.Reflection.Context/tests/CustomReflectionContextTests.cs @@ -31,6 +31,7 @@ public void MapType_Null_Throws() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15191", TargetFrameworkMonikers.Mono)] public void MapType_MemberAttributes_Success() { var customReflectionContext = new TestCustomReflectionContext(); @@ -45,6 +46,7 @@ public void MapType_MemberAttributes_Success() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15191", TargetFrameworkMonikers.Mono)] public void MapType_ParameterAttributes_Success() { var customReflectionContext = new TestCustomReflectionContext(); @@ -62,6 +64,7 @@ public void MapType_ParameterAttributes_Success() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15191", TargetFrameworkMonikers.Mono)] public void MapType_Interface_Throws() { var customReflectionContext = new TestCustomReflectionContext(); diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index a9942a6934204..f1460b7bb5b8f 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -258,17 +258,6 @@ # Assert.Contains() Failure -nomethod System.Diagnostics.Tests.StackTraceTests.ToString_Invoke_ReturnsExpected -#################################################################### -## System.Reflection.Context.Tests -#################################################################### - -# System.ArgumentNullException : Value cannot be null. -# Parameter name: attributeType -# https://github.com/mono/mono/issues/15191 --nomethod System.Reflection.Context.Tests.CustomReflectionContextTests.MapType_MemberAttributes_Success --nomethod System.Reflection.Context.Tests.CustomReflectionContextTests.MapType_ParameterAttributes_Success --nomethod System.Reflection.Context.Tests.CustomReflectionContextTests.MapType_Interface_Throws - #################################################################### ## System.Reflection.Metadata.Tests #################################################################### From 5d3788e2854661c264b4d8d947c571dda4057ef9 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 27 Jan 2020 16:47:42 +0300 Subject: [PATCH 25/96] Move skipped System.Threading.ThreadPools.Tests.ThreadPoolTests.SetMinMaxThreadsTest with an active issue out of rsp --- .../System.Threading.ThreadPool/tests/ThreadPoolTests.cs | 2 ++ src/mono/netcore/CoreFX.issues.rsp | 7 ------- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs b/src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs index 4a116c5c6cd63..fa628b28371c2 100644 --- a/src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs +++ b/src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs @@ -89,6 +89,8 @@ public static void GetAvailableThreadsTest() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15164", TargetFrameworkMonikers.Mono)] + public static void SetMinMaxThreadsTest() { int minw, minc, maxw, maxc; diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index f1460b7bb5b8f..06a694aaf482f 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -209,13 +209,6 @@ ## System.Threading.ThreadPool.Tests #################################################################### -# Tests for ThreadPool.SetMaxThreads(-1, -1) == true, which only happens to work on CoreCLR because -# the managed SetMaxThreadsNative prototype uses "int"s while the unmanaged code uses "DWORD"s and -# thus it interprets it as large positive numbers. -# -# https://github.com/mono/mono/issues/15164 --nomethod System.Threading.ThreadPools.Tests.ThreadPoolTests.SetMinMaxThreadsTest - # TODO: Differences in behaviour between NetFX and CoreFX -nomethod System.Threading.ThreadPools.Tests.ThreadPoolTests.SetMinThreadsTo0Test From 288b12d9ca9c8170e349fa8721ba7d0bee2ac8be Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 28 Jan 2020 12:05:57 +0300 Subject: [PATCH 26/96] Move skipped System.ComponentModel.Composition and Tests.Integration namespaces with an active issue out of rsp file --- .../Composition/AdvancedValueComposition.cs | 5 ++++ .../AllowNonPublicCompositionTests.cs | 7 +++++ .../AttributedModelCompositionTests.cs | 1 + .../AttributedModelDiscoveryTests.cs | 5 ++++ .../AttributedModel/INotifyImportTests.cs | 4 +++ .../AttributedModelServicesTests.cs | 6 ++++ .../Composition/ComponentServicesTests.cs | 1 + .../CompositionContainerCollectionTests.cs | 1 + .../CompositionContainerImportTests.cs | 1 + .../Composition/CompositionContainerTests.cs | 21 +++++++++++++ .../CompositionServiceExportFactoryTests.cs | 4 +++ .../Composition/CompositionServicesTests.cs | 1 + .../Composition/DynamicMetadata.cs | 3 ++ .../Composition/ExportAttributeTests.cs | 1 + .../Composition/ExportFactoryTests.cs | 1 + .../Composition/GenericsTests.cs | 16 ++++++++++ .../Hosting/CatalogExportProviderTests.cs | 1 + .../Hosting/CompositionBatchTests.cs | 1 + .../Hosting/FilteredCatalogTests.cs | 1 + .../FilteredCatalogTransitiveClosureTests.cs | 1 + .../Hosting/ScopeExtensionsTests.cs | 3 ++ .../Composition/ImportAttributeTests.cs | 1 + .../Composition/MetadataTests.cs | 2 ++ .../CompositionScopeDefinitionTests.cs | 4 +++ .../ReflectionComposablePartTests.cs | 25 ++++++++++++++++ .../Composition/ScopeExportFactoryTests.cs | 8 +++++ .../ScopedCompositionServicetests.cs | 1 + .../Integration/AdaptingCollectionTests.cs | 1 + .../Integration/CatalogFilteringTests.cs | 1 + ...itionContainerAttributedModelCycleTests.cs | 3 ++ .../Integration/ConstructorInjectionTests.cs | 2 ++ .../System/Integration/DelayLoadingTests.cs | 1 + .../Integration/DelegateCompositionTests.cs | 1 + .../System/Integration/DiscoveryTests.cs | 14 +++++++++ .../tests/System/Integration/LifetimeTests.cs | 30 +++++++++++++++++++ .../System/Integration/RecompositionTests.cs | 1 + .../System/Integration/RejectionTests.cs | 1 + .../RequiredCreationPolicyTests.cs | 1 + src/mono/netcore/CoreFX.issues.rsp | 5 ---- 39 files changed, 182 insertions(+), 5 deletions(-) diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AdvancedValueComposition.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AdvancedValueComposition.cs index ae396333e449f..d9963710d818e 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AdvancedValueComposition.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AdvancedValueComposition.cs @@ -24,6 +24,7 @@ public interface ITrans_CollectionOfStrings public class AdvancedValueComposition { [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void RepeatedContainerUse() { var container = ContainerFactory.Create(); @@ -41,6 +42,7 @@ public void RepeatedContainerUse() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void FunctionsFieldsAndProperties() { Consumer c; @@ -55,6 +57,7 @@ public void FunctionsFieldsAndProperties() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void FunctionsFieldsAndProperties2() { Consumer c; @@ -252,6 +255,7 @@ public void ImportIntoUntypedExportTest() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ImportIntoDerivationOfExportException() { var container = ContainerFactory.Create(); @@ -269,6 +273,7 @@ public void ImportIntoDerivationOfExportException() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ImportIntoDerivationOfExportsException() { var container = ContainerFactory.Create(); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AllowNonPublicCompositionTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AllowNonPublicCompositionTests.cs index 0d18d712a5975..2a94a7d95028b 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AllowNonPublicCompositionTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AllowNonPublicCompositionTests.cs @@ -8,9 +8,11 @@ namespace System.ComponentModel.Composition { + // [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public class AllowNonPublicCompositionTests { [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void PublicFromPublic() { var container = ContainerFactory.Create(); @@ -25,6 +27,7 @@ public void PublicFromPublic() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void PublicToSelf() { var container = ContainerFactory.Create(); @@ -38,6 +41,7 @@ public void PublicToSelf() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void PublicFromPrivate() { var container = ContainerFactory.Create(); @@ -52,6 +56,7 @@ public void PublicFromPrivate() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void PrivateFromPublic() { var container = ContainerFactory.Create(); @@ -66,6 +71,7 @@ public void PrivateFromPublic() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void PrivateToSelf() { var container = ContainerFactory.Create(); @@ -79,6 +85,7 @@ public void PrivateToSelf() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void PrivateData() { var container = ContainerFactory.Create(); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AttributedModelCompositionTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AttributedModelCompositionTests.cs index c197d1043c42a..6c79d4fdf671f 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AttributedModelCompositionTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AttributedModelCompositionTests.cs @@ -10,6 +10,7 @@ namespace System.ComponentModel.Composition.AttributedModel { + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public class AttributedModelCompositionTests { [Fact] diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AttributedModelDiscoveryTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AttributedModelDiscoveryTests.cs index c534a20d8b1f2..e51b92cc33795 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AttributedModelDiscoveryTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AttributedModelDiscoveryTests.cs @@ -16,6 +16,7 @@ namespace System.ComponentModel.Composition.AttributedModel public class AttributedModelDiscoveryTests { [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void CreatePartDefinition_TypeWithExports_ShouldHaveMultipleExports() { var definition = CreateDefinition(typeof(PublicComponentWithPublicExports)); @@ -34,6 +35,7 @@ public class DerivedClassWithInheritedPropertyExports : BaseClassWithPropertyExp } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void CreatePartDefinition_TypeWithImports_ShouldHaveMultipleImports() { var definition = CreateDefinition(typeof(PublicImportsExpectingPublicExports)); @@ -156,6 +158,7 @@ public void CreatePartDefinition_MultipleMarkedConstructorsAsPartTypeArgument_Sh } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void CreatePartDefinition_OneMarkedConstructorsAsPartTypeArgument_ShouldSetConstructorToMarked() { var definition = CreateDefinition(typeof(SimpleConstructorInjectedObject)); @@ -167,6 +170,7 @@ public void CreatePartDefinition_OneMarkedConstructorsAsPartTypeArgument_ShouldS } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void CreatePartDefinition_OneDefaultConstructorAsPartTypeArgument_ShouldSetConstructorToDefault() { var definition = CreateDefinition(typeof(PublicComponentWithPublicExports)); @@ -179,6 +183,7 @@ public void CreatePartDefinition_OneDefaultConstructorAsPartTypeArgument_ShouldS } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void CreatePartDefinition_OneMarkedAndOneDefaultConstructorsAsPartTypeArgument_ShouldSetConstructorToMarked() { var definition = CreateDefinition(typeof(ClassWithOneMarkedAndOneDefaultConstructor)); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/INotifyImportTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/INotifyImportTests.cs index 5be65a203dd53..8237f8ca0b612 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/INotifyImportTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/INotifyImportTests.cs @@ -23,6 +23,7 @@ public void OnImportsSatisfied() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ImportsSatisfiedOnComponentWithoutImports() { CompositionContainer container = ContainerFactory.CreateWithAttributedCatalog(typeof(PartWithoutImports)); @@ -35,6 +36,7 @@ public void ImportsSatisfiedOnComponentWithoutImports() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ImportCompletedTest() { var container = ContainerFactory.Create(); @@ -56,6 +58,7 @@ public void ImportCompletedTest() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ImportCompletedWithRecomposing() { var container = ContainerFactory.Create(); @@ -94,6 +97,7 @@ public void ImportCompletedWithRecomposing() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ImportCompletedAddPartAndBindComponent() { var container = ContainerFactory.Create(); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModelServicesTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModelServicesTests.cs index 0355f4e2cc6ba..f7e25be06e156 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModelServicesTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModelServicesTests.cs @@ -145,6 +145,7 @@ public void Imports_Throws_OnNullContractName() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void Imports() { ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart(); @@ -158,6 +159,7 @@ public void Imports() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void Imports_CardinalityIgnored_WhenNotSpecified() { ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart(); @@ -170,6 +172,7 @@ public void Imports_CardinalityIgnored_WhenNotSpecified() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void Imports_CardinalityNotIgnored_WhenSpecified() { ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart(); @@ -200,6 +203,7 @@ public void ImportsGeneric_Throws_OnNullPart() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ImportsGeneric() { ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart(); @@ -213,6 +217,7 @@ public void ImportsGeneric() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ImportsGeneric_CardinalityIgnored_WhenNotSpecified() { ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart(); @@ -225,6 +230,7 @@ public void ImportsGeneric_CardinalityIgnored_WhenNotSpecified() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ImportsGeneric_CardinalityNotIgnored_WhenSpecified() { ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart(); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ComponentServicesTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ComponentServicesTests.cs index b397beef287c6..febb8fac0a99d 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ComponentServicesTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ComponentServicesTests.cs @@ -74,6 +74,7 @@ public void GetValuesTest() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void NoResolverExceptionTest() { var container = ContainerFactory.Create(); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerCollectionTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerCollectionTests.cs index ca2c7fcc07d3e..917de93e03393 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerCollectionTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerCollectionTests.cs @@ -13,6 +13,7 @@ namespace System.ComponentModel.Composition { + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public class CompositionContainerCollectionTests { public class SupportedImportCollectionAssignments diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerImportTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerImportTests.cs index a6821758c0765..52849ce8cdcd7 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerImportTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerImportTests.cs @@ -13,6 +13,7 @@ namespace System.ComponentModel.Composition { + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public class CompositionContainerImportTests { // Exporting collectin values is not supported diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerTests.cs index 9bfd35e6650fe..39832f52b5990 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerTests.cs @@ -1726,6 +1726,7 @@ public void GetExports2_TypeAsMetadataViewTypeArgument_IsUsedAsMetadataConstrain } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void GetExportsOfTTMetadataView1_TypeAsMetadataViewTypeArgument_IsUsedAsMetadataConstraint() { var metadata = new Dictionary(); @@ -1870,6 +1871,7 @@ public void RemovePart_PartAlreadyRemovedAsPartArgument_ShouldNotThrow() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void TryComposeSimple() { var container = CreateCompositionContainer(); @@ -1883,6 +1885,7 @@ public void TryComposeSimple() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void TryComposeSimpleFail() { var container = CreateCompositionContainer(); @@ -1900,6 +1903,7 @@ public void TryComposeSimpleFail() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ComposeDisposableChildContainer() { var outerContainer = CreateCompositionContainer(); @@ -1959,6 +1963,7 @@ public void RemoveValueTest() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] [Trait("Type", "Integration")] public void OptionalImportsOfValueTypeBoundToDefaultValueShouldNotAffectAvailableValues() { @@ -1978,6 +1983,7 @@ public void OptionalImportsOfValueTypeBoundToDefaultValueShouldNotAffectAvailabl } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] [Trait("Type", "Integration")] public void OptionalImportsOfNullableValueTypeBoundToDefaultValueShouldNotAffectAvailableValues() { @@ -1997,6 +2003,7 @@ public void OptionalImportsOfNullableValueTypeBoundToDefaultValueShouldNotAffect } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] [Trait("Type", "Integration")] public void OptionalImportsOfReferenceTypeBoundToDefaultValueShouldNotAffectAvailableValues() { @@ -2405,6 +2412,7 @@ public void TryGetValueWithCatalogVerifyExecptionDuringGet() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void TryGetExportedValueWhileLockedForNotify() { var container = CreateCompositionContainer(); @@ -2480,6 +2488,7 @@ public void RemoveFromWrongContainerTest() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] [Trait("Type", "Integration")] public void AddPartSimple() { @@ -2494,6 +2503,7 @@ public void AddPartSimple() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] [Trait("Type", "Integration")] public void AddPart() { @@ -2508,6 +2518,7 @@ public void AddPart() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ComposeReentrantChildContainerDisposed() { var container = CreateCompositionContainer(); @@ -2537,6 +2548,7 @@ public void ComposeReentrantChildContainerDisposed() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ComposeSimple() { var container = CreateCompositionContainer(); @@ -2550,6 +2562,7 @@ public void ComposeSimple() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ComposeSimpleFail() { var container = CreateCompositionContainer(); @@ -2567,6 +2580,7 @@ public void ComposeSimpleFail() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ExceptionDuringNotify() { var container = CreateCompositionContainer(); @@ -2584,6 +2598,7 @@ public void ExceptionDuringNotify() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void NeutralComposeWhileNotified() { var container = CreateCompositionContainer(); @@ -2641,6 +2656,7 @@ public class SimpleExporter } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ThreadSafeCompositionContainer() { TypeCatalog catalog = new TypeCatalog(typeof(SimpleExporter)); @@ -2660,6 +2676,7 @@ public void ThreadSafeCompositionContainer() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ThreadSafeCompositionOptionsCompositionContainer() { TypeCatalog catalog = new TypeCatalog(typeof(SimpleExporter)); @@ -2678,6 +2695,7 @@ public void ThreadSafeCompositionOptionsCompositionContainer() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void DisableSilentRejectionCompositionOptionsCompositionContainer() { TypeCatalog catalog = new TypeCatalog(typeof(SimpleExporter)); @@ -2696,6 +2714,7 @@ public void DisableSilentRejectionCompositionOptionsCompositionContainer() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void DisableSilentRejectionThreadSafeCompositionOptionsCompositionContainer() { TypeCatalog catalog = new TypeCatalog(typeof(SimpleExporter)); @@ -2947,6 +2966,7 @@ public void ComposeExportedValueOfT_ValidContractName_ExportedValue_ImportsAreNo } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void TestExportedValueCachesNullValue() { var container = ContainerFactory.Create(); @@ -2960,6 +2980,7 @@ public void TestExportedValueCachesNullValue() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void TestExportedValueUsingWhereClause_ExportSuccessful() { CompositionContainer container = new CompositionContainer(new TypeCatalog(typeof(MefCollection<,>))); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionServiceExportFactoryTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionServiceExportFactoryTests.cs index 5facc6c902f12..4cd7faedb496b 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionServiceExportFactoryTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionServiceExportFactoryTests.cs @@ -42,6 +42,7 @@ public class App } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] [Description("Verifies CompositionServices.SatisfyImportsOne with Scoped ExportFactories")] public void ComposeAppInNewScopeChildrenInRoot_ShouldSucceed() { @@ -66,6 +67,7 @@ public void ComposeAppInNewScopeChildrenInRoot_ShouldSucceed() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] [Description("Verifies CompositionServices.SatisfyImportsOne with Scoped ExportFactories")] public void ComposeAppInNewScopeChildrenInScope_ShouldSucceed() { @@ -90,6 +92,7 @@ public void ComposeAppInNewScopeChildrenInScope_ShouldSucceed() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] [Description("Verifies CompositionServices.SatisfyImportsOne with Scoped ExportFactories")] public void ComposeAppInNewScopeChildrenInBoth_ShouldSucceed() { @@ -114,6 +117,7 @@ public void ComposeAppInNewScopeChildrenInBoth_ShouldSucceed() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] [Description("Verifies CompositionServices.SatisfyImportsOne with NonScoped ExportFactories")] public void ComposeAppInRootScope_ShouldSucceed() { diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionServicesTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionServicesTests.cs index 0b01085fe86c3..ae1335351ffc9 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionServicesTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionServicesTests.cs @@ -38,6 +38,7 @@ public void ContractNameServicesAddCustomModifiersTest() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15168", TargetFrameworkMonikers.Mono)] [Description("Verifies CompositionServices.GetDefaultContractName method.")] public void GetDefaultContractNameTest() { diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/DynamicMetadata.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/DynamicMetadata.cs index 9da62f0771500..a5b942d5f5906 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/DynamicMetadata.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/DynamicMetadata.cs @@ -13,6 +13,7 @@ namespace System.ComponentModel.Composition public class DynamicMetadata : IDisposable { [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SimpleAttachment() { MetadataStore.Container = new CompositionContainer(); @@ -34,6 +35,7 @@ public void SimpleAttachment() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void LocalContainer() { var container1 = new CompositionContainer(); @@ -60,6 +62,7 @@ public void LocalContainer() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void DualContainers() { var container1 = new CompositionContainer(); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportAttributeTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportAttributeTests.cs index 8f5b5db508c9a..c8b03a26b0fac 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportAttributeTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportAttributeTests.cs @@ -71,6 +71,7 @@ public void Constructor2_ValueAsContractNameArgument_ShouldSetContractNameProper } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ExportIndexers_ShouldThrowSomething() { var con = new CompositionContainer( diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportFactoryTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportFactoryTests.cs index 03bf5f822aa95..69cc36b03230e 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportFactoryTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportFactoryTests.cs @@ -14,6 +14,7 @@ namespace Tests.Integration { + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public class ExportFactoryTests { public interface IId diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/GenericsTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/GenericsTests.cs index 0eb4967277131..65a1c4c066f6a 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/GenericsTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/GenericsTests.cs @@ -304,6 +304,7 @@ public class OpenGenericPartWithClosedGenericImport : IExport } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SelfExportWithClosedGenericImportTest() { TypeCatalog catalog = new TypeCatalog(typeof(SelfImport<>), typeof(OpenGenericPartWithClosedGenericImport<>)); @@ -331,6 +332,7 @@ public void SelfExportTest() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void PropertyExportTest() { TypeCatalog catalog = new TypeCatalog(typeof(PropertyExport<,>)); @@ -344,6 +346,7 @@ public void PropertyExportTest() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void PropertyExportWithContractInferredTest() { TypeCatalog catalog = new TypeCatalog(typeof(PropertyExportWithContractInferred<,>)); @@ -357,6 +360,7 @@ public void PropertyExportWithContractInferredTest() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SelfExportWithPropertyImportTest() { TypeCatalog catalog = new TypeCatalog(typeof(SelfExportWithPropertyImport<,>), typeof(SelfImport<,>)); @@ -371,6 +375,7 @@ public void SelfExportWithPropertyImportTest() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SelfExportWithLazyPropertyImportTest() { TypeCatalog catalog = new TypeCatalog(typeof(SelfExportWithLazyPropertyImport<,>), typeof(SelfImport<,>)); @@ -385,6 +390,7 @@ public void SelfExportWithLazyPropertyImportTest() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SelfExportWithNakedLazyPropertyImportTest() { TypeCatalog catalog = new TypeCatalog(typeof(SelfExportWithNakedLazyPropertyImport<>), typeof(Foo)); @@ -399,6 +405,7 @@ public void SelfExportWithNakedLazyPropertyImportTest() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SelfExportWithExportFactoryPropertyImportTest() { TypeCatalog catalog = new TypeCatalog(typeof(SelfExportWithExportFactoryPropertyImport<,>), typeof(SelfImport<,>)); @@ -420,6 +427,7 @@ public void SelfExportWithExportFactoryPropertyImportTest() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SelfExportWithNakedExportFactoryPropertyImportTest() { TypeCatalog catalog = new TypeCatalog(typeof(SelfExportWithNakedExportFactoryPropertyImport<>), typeof(Foo)); @@ -441,6 +449,7 @@ public void SelfExportWithNakedExportFactoryPropertyImportTest() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SelfExportWithExportFactoryParameterImportTest() { TypeCatalog catalog = new TypeCatalog(typeof(SelfExportWithExportFactoryParameterImport<,>), typeof(SelfImport<,>)); @@ -462,6 +471,7 @@ public void SelfExportWithExportFactoryParameterImportTest() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SelfExportWithCollectionPropertyImportTest() { TypeCatalog catalog = new TypeCatalog(typeof(SelfExportWithCollectionPropertyImport<,>), typeof(SelfImport<,>)); @@ -476,6 +486,7 @@ public void SelfExportWithCollectionPropertyImportTest() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SelfExportWithLazyCollectionPropertyImportTest() { TypeCatalog catalog = new TypeCatalog(typeof(SelfExportWithLazyCollectionPropertyImport<,>), typeof(SelfImport<,>)); @@ -490,6 +501,7 @@ public void SelfExportWithLazyCollectionPropertyImportTest() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SelfExportWithPropertyImportWithContractInferredTest() { TypeCatalog catalog = new TypeCatalog(typeof(SelfExportWithPropertyImportWithContractInferred<,>), typeof(SelfImport<,>)); @@ -504,6 +516,7 @@ public void SelfExportWithPropertyImportWithContractInferredTest() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SelfExportWithParameterImportTest() { TypeCatalog catalog = new TypeCatalog(typeof(SelfExportWithParameterImport<,>), typeof(SelfImport<,>)); @@ -518,6 +531,7 @@ public void SelfExportWithParameterImportTest() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SelfExportWithMultipleGenericImportsTest() { TypeCatalog catalog = new TypeCatalog(typeof(SelfExportWithMultipleGenericImports<,>), typeof(SelfImport<,>), typeof(SelfImport<>), typeof(Foo)); @@ -549,6 +563,7 @@ public void SpecilzationMakesGeneric() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SingletonBehavior() { TypeCatalog catalog = new TypeCatalog(typeof(SingletonExport<,>)); @@ -707,6 +722,7 @@ public void PartWithNakedConstraintTest() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void PartWithExportParametersInReverseOrder() { TypeCatalog catalog = new TypeCatalog(typeof(PropertyExportWithChangedParameterOrder<,>)); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/CatalogExportProviderTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/CatalogExportProviderTests.cs index 3784aa2c16bb1..c79b5cfd249d9 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/CatalogExportProviderTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/CatalogExportProviderTests.cs @@ -339,6 +339,7 @@ public void CanBeCollectedAfterDispose() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void RemovingAndReAddingMultipleDefinitionsFromCatalog() { var fixedParts = new TypeCatalog(typeof(RootMultipleImporter), typeof(ExportedService)); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/CompositionBatchTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/CompositionBatchTests.cs index 705051f7df188..9ceb0f236ca63 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/CompositionBatchTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/CompositionBatchTests.cs @@ -803,6 +803,7 @@ public void AddPart_ReturnedComposablePart_NullAsExportsArgumentToSetImports_Sho } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void AddPart_ReturnedComposablePart_ExportsArrayWithNullElementAsExportsArgumentToSetImports_ShouldThrowArgument() { CompositionBatch batch = new CompositionBatch(); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/FilteredCatalogTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/FilteredCatalogTests.cs index 54695ae388754..27fbe5fc92b39 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/FilteredCatalogTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/FilteredCatalogTests.cs @@ -81,6 +81,7 @@ public void GetExports() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void GetExportsWithGenerics() { var originalCatalog = new TypeCatalog(typeof(GenericExporter<,>), typeof(Exporter11), typeof(Exporter22)); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/FilteredCatalogTransitiveClosureTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/FilteredCatalogTransitiveClosureTests.cs index 3b8a5534a54e7..1bc7bedbd30bf 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/FilteredCatalogTransitiveClosureTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/FilteredCatalogTransitiveClosureTests.cs @@ -8,6 +8,7 @@ namespace System.ComponentModel.Composition.Hosting { + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public class FilteredCatalogTransitiveClosureTests { public interface IContract1 { } diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/ScopeExtensionsTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/ScopeExtensionsTests.cs index 08100595b7ca0..d6b8fa2e05f14 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/ScopeExtensionsTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/ScopeExtensionsTests.cs @@ -68,6 +68,7 @@ public void Imports_Throws_OnNullContractName() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void Imports() { ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart(); @@ -81,6 +82,7 @@ public void Imports() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void Imports_CardinalityIgnored_WhenNotSpecified() { ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart(); @@ -93,6 +95,7 @@ public void Imports_CardinalityIgnored_WhenNotSpecified() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void Imports_CardinalityNotIgnored_WhenSpecified() { ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart(); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ImportAttributeTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ImportAttributeTests.cs index cb667c1bc96b8..ea6fb3956f3cd 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ImportAttributeTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ImportAttributeTests.cs @@ -169,6 +169,7 @@ public void AllowRecomposition_ValueAsValueArgument_ShouldSetProperty() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ImportIndexers_ShouldThrowSomething() { var con = new CompositionContainer( diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/MetadataTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/MetadataTests.cs index b46e1a40af1ba..7e75e76f6a0ea 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/MetadataTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/MetadataTests.cs @@ -273,6 +273,7 @@ public class ClassWithInvalidDuplicateMetadataOnMember } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void InvalidDuplicateMetadataOnMember_ShouldThrow() { var part = AttributedModelServices.CreatePart(new ClassWithInvalidDuplicateMetadataOnMember()); @@ -319,6 +320,7 @@ public class ClassWithDuplicateMetadataOnMember } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ValidDuplicateMetadataOnMember_ShouldDiscoverAllMetadata() { var container = ContainerFactory.Create(); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Primitives/CompositionScopeDefinitionTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Primitives/CompositionScopeDefinitionTests.cs index d5aa3170520af..5cece3a265561 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Primitives/CompositionScopeDefinitionTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Primitives/CompositionScopeDefinitionTests.cs @@ -133,6 +133,7 @@ public void Parts_DelegateToCatalog() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void Constructor_PublicSurface() { var catalog = new TypeCatalog(typeof(FooImpl), typeof(FooImpl2), typeof(FooImpl2)); @@ -152,6 +153,7 @@ public void Constructor_PublicSurface_MultipleExportsPerPart() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void GetExports_DelegateToCatalog() { var parts = new TypeCatalog(typeof(FooImpl), typeof(FooImpl2), typeof(FooImpl2)).Parts; @@ -214,6 +216,7 @@ public void Notifications() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void Dispose() { var parts = new TypeCatalog(typeof(FooImpl), typeof(FooImpl2), typeof(FooImpl2)).Parts; @@ -250,6 +253,7 @@ public void Dispose() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SimpleComposition() { var catalog = new TypeCatalog(typeof(FooImpl), typeof(FooImpl2), typeof(FooImpl2)); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ReflectionModel/ReflectionComposablePartTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ReflectionModel/ReflectionComposablePartTests.cs index 8b90ffe7e6b23..4548a715a4399 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ReflectionModel/ReflectionComposablePartTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ReflectionModel/ReflectionComposablePartTests.cs @@ -141,6 +141,7 @@ public void OnComposed_WhenDisposed_ShouldThrowObjectDisposed() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void OnComposed_MissingPostImportsOnInstance_ShouldThrowComposition() { var part = CreatePart(new MySharedPartExport()); @@ -153,6 +154,7 @@ public void OnComposed_MissingPostImportsOnInstance_ShouldThrowComposition() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void OnComposed_ProperlyComposed_ShouldSucceed() { var import = new TrivialImporter(); @@ -167,6 +169,7 @@ public void OnComposed_ProperlyComposed_ShouldSucceed() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void OnComposed_UnhandledExceptionThrowInOnImportsSatisfied_ShouldThrowComposablePart() { var part = CreatePart(typeof(ExceptionDuringINotifyImport)); @@ -180,6 +183,7 @@ public void OnComposed_UnhandledExceptionThrowInOnImportsSatisfied_ShouldThrowCo } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SetImport_WhenDisposed_ShouldThrowObjectDisposed() { var part = CreateDefaultDisposablePart(); @@ -205,6 +209,7 @@ public void SetImport_NullAsImportDefinitionArgument_ShouldThrowArgumentNull() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SetImport_NullAsExportsArgument_ShouldThrowArgumentNull() { var part = CreatePart(typeof(MySharedPartExport)); @@ -217,6 +222,7 @@ public void SetImport_NullAsExportsArgument_ShouldThrowArgumentNull() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SetImport_ExportsArrayWithNullElementAsExportsArgument_ShouldThrowArgument() { var part = CreatePart(typeof(MySharedPartExport)); @@ -242,6 +248,7 @@ public void SetImport_WrongDefinitionAsDefinitionArgument_ShouldThrowArgument() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SetImport_SetNonRecomposableDefinitionAsDefinitionArgumentAfterOnComposed_ShouldThrowInvalidOperation() { var part = CreatePartWithNonRecomposableImport(); @@ -257,6 +264,7 @@ public void SetImport_SetNonRecomposableDefinitionAsDefinitionArgumentAfterOnCom } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SetImport_ZeroOrOneDefinitionAsDefinitionArgumentAndTwoExportsAsExportsArgument_ShouldThrowArgument() { var part = CreatePartWithZeroOrOneImport(); @@ -271,6 +279,7 @@ public void SetImport_ZeroOrOneDefinitionAsDefinitionArgumentAndTwoExportsAsExpo } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SetImport_ExactlyOneDefinitionAsDefinitionArgumentAndTwoExportsAsExportsArgument_ShouldThrowArgument() { var part = CreatePartWithExactlyOneImport(); @@ -285,6 +294,7 @@ public void SetImport_ExactlyOneDefinitionAsDefinitionArgumentAndTwoExportsAsExp } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SetImport_ExactlyOneDefinitionAsDefinitionArgumentAndEmptyExportsAsExportsArgument_ShouldThrowArgument() { var part = CreatePartWithExactlyOneImport(); @@ -299,6 +309,7 @@ public void SetImport_ExactlyOneDefinitionAsDefinitionArgumentAndEmptyExportsAsE } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SetImport_WrongTypeExportGiven_ShouldThrowComposablePart() { var part = CreatePart(new MySharedPartExport()); @@ -311,6 +322,7 @@ public void SetImport_WrongTypeExportGiven_ShouldThrowComposablePart() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SetImport_SetPostValueAndSetAgainOnInstance_ShouldSetProperty() { var import = new MySharedPartExport(); @@ -334,6 +346,7 @@ public void SetImport_SetPostValueAndSetAgainOnInstance_ShouldSetProperty() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void GetExportedValue_WhenDisposed_ShouldThrowObjectDisposed() { var part = CreateDefaultDisposablePart(); @@ -371,6 +384,7 @@ public void GetExportedValue_WrongDefinitionAsDefinitionArgument_ShouldThrowArgu } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void GetExportedValue_MissingPrerequisiteImport_ShouldThrowInvalidOperation() { var part = CreatePart(typeof(SimpleConstructorInjectedObject)); @@ -409,6 +423,7 @@ public void GetExportedValue_UnhandledExceptionThrowInConstructor_ShouldThrowCom } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void GetExportedValue_GetObjectAfterSetPreImport_ShouldGetValue() { var part = CreatePart(typeof(SimpleConstructorInjectedObject)); @@ -425,6 +440,7 @@ public void GetExportedValue_GetObjectAfterSetPreImport_ShouldGetValue() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void GetExportedValue_GetObjectAfterSetPostImport_ShouldGetValue() { var part = CreatePart(typeof(MySharedPartExport)); @@ -442,6 +458,7 @@ public void GetExportedValue_GetObjectAfterSetPostImport_ShouldGetValue() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void GetExportedValue_CallMultipleTimes_ShouldReturnSame() { var part = CreatePart(typeof(MySharedPartExport)); @@ -471,6 +488,7 @@ public void GetExportedValue_FromStaticClass_ShouldReturnExport() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void GetExportedValue_OptionalPostNotGiven_ShouldReturnValidObject() { var part = CreatePart(typeof(ClassWithOptionalPostImport)); @@ -483,6 +501,7 @@ public void GetExportedValue_OptionalPostNotGiven_ShouldReturnValidObject() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void GetExportedValue_OptionalPreNotGiven_ShouldReturnValidObject() { var part = CreatePart(typeof(ClassWithOptionalPreImport)); @@ -548,6 +567,7 @@ public class TypeExporter } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void GetExportedObjectAlwaysReturnsSameReference_ForProperty() { var cp = CreatePart(new PropertyExporter()); @@ -558,6 +578,7 @@ public void GetExportedObjectAlwaysReturnsSameReference_ForProperty() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void GetExportedObjectAlwaysReturnsSameReference_ForField() { var exporter = new FieldExporter(); @@ -628,6 +649,7 @@ void InvalidImport() { } } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ImportDefinitions_ImportWithCustomAttributeImports() { var part = CreatePart(typeof(ImportWithCustomImport)); @@ -661,6 +683,7 @@ void InvalidImportMany() { } } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ImportDefinitions_ImportManyWithCustomAttributeImportManys() { var part = CreatePart(typeof(ImportManyWithCustomImportMany)); @@ -729,6 +752,7 @@ void InvalidImportingConstructor() { } } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ImportDefinitions_ImportingConstructorWithCustomAttributeImportingConstructors() { var part = CreatePart(typeof(ImportingConstructorWithCustomImportingConstructor)); @@ -741,6 +765,7 @@ public void ImportDefinitions_ImportingConstructorWithCustomAttributeImportingCo } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ImportDefinitions_ImportingConstructorWithCustomAttributeImportingConstructorsWithAllowMultiple_ShouldNotThrowInvalidOperation() { var part = CreatePart(typeof(ImportingConstructorWithCustomImportingConstructorAllowMultiple)); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ScopeExportFactoryTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ScopeExportFactoryTests.cs index 15e8c016a8965..7bbbd776b5add 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ScopeExportFactoryTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ScopeExportFactoryTests.cs @@ -8,6 +8,7 @@ namespace System.ComponentModel.Composition { + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public class ScopeExportFactoryTests { public interface IFooContract @@ -269,6 +270,7 @@ public void ExportFactoryCausesRejectionBasedOnCardinality() } } + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public class ScopeExportFactoryWithPublicSurface { [Export] public class ClassA { } @@ -311,6 +313,7 @@ public void FilteredScopeFactoryOfTM_ShouldSucceed() } } + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public class ScopeFactoryAutoResolveFromAncestorScope { [Export] public class Root { } @@ -368,6 +371,7 @@ public void ScopeFactoryAutoResolveFromAncestorScopeShouldSucceed() } } + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public class DeeplyNestedCatalog { [Export] @@ -446,6 +450,7 @@ public void DeeplyNestedCatalogOverlappedCatalog_ShouldWork() } } + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public class LocalSharedNonLocalInSameContainer { [Export] @@ -542,6 +547,7 @@ public void LocalSharedNonLocalInSameContainer_ShouldSucceed() } } + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public class ScopeBridgingAdaptersConstructorInjection { [Export] @@ -630,6 +636,7 @@ public void ScopeBridgingAdapters_ShouldSucceed() } } + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public class ScopeBridgingAdaptersImportExportProperty { [Export] @@ -713,6 +720,7 @@ public void ScopeBridgingAdaptersImportExportProperty_ShouldSucceed() } } + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public class SelfExportFromExportFactory { [Export] diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ScopedCompositionServicetests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ScopedCompositionServicetests.cs index d33b20462eb61..7ed541c1f51f0 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ScopedCompositionServicetests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ScopedCompositionServicetests.cs @@ -8,6 +8,7 @@ namespace System.ComponentModel.Composition { + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public class ScopedCompositionServiceTests { [Export] diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/AdaptingCollectionTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/AdaptingCollectionTests.cs index 6cd24c4e13ab9..3abd071c0f512 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/AdaptingCollectionTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/AdaptingCollectionTests.cs @@ -155,6 +155,7 @@ public bool Remove(Lazy item) #endregion } + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public class AdaptingCollectionTests { public interface IContract { } diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/CatalogFilteringTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/CatalogFilteringTests.cs index 516a6689d3ac9..73d64ef5e4fd7 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/CatalogFilteringTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/CatalogFilteringTests.cs @@ -9,6 +9,7 @@ namespace System.ComponentModel.Composition { + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public class CatalogFilteringTests { [Fact] diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/CompositionContainerAttributedModelCycleTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/CompositionContainerAttributedModelCycleTests.cs index 73bf3e56db448..30b812914348e 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/CompositionContainerAttributedModelCycleTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/CompositionContainerAttributedModelCycleTests.cs @@ -30,6 +30,7 @@ public class CompositionContainerAttributedModelCycleTests // [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void APrerequisiteDependsOnBPrerequisite_ShouldThrowComposition() { AssertCycle(typeof(APrerequisiteDependsOnBPrerequisite), @@ -37,6 +38,7 @@ public void APrerequisiteDependsOnBPrerequisite_ShouldThrowComposition() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void APrerequisiteDependsOnBPost_ShouldThrowComposition() { AssertCycle(typeof(APrerequisiteDependsOnBPost), @@ -52,6 +54,7 @@ public void APrerequisiteDependsOnBNone_ShouldNotThrow() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void APostDependsOnBPrerequisite_ShouldThrowComposition() { AssertCycle(typeof(APostDependsOnBPrerequisite), diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/ConstructorInjectionTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/ConstructorInjectionTests.cs index e4afd108a306a..0d95a0854c113 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/ConstructorInjectionTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/ConstructorInjectionTests.cs @@ -13,6 +13,7 @@ namespace Tests.Integration public class ConstructorInjectionTests { [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SimpleConstructorInjection() { var container = ContainerFactory.Create(); @@ -177,6 +178,7 @@ public InvalidImportManyCI( } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ImportMany_ConstructorParameter_OnNonAssiganbleType_ShouldThrowCompositionException() { var container = ContainerFactory.CreateWithAttributedCatalog(typeof(InvalidImportManyCI)); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DelayLoadingTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DelayLoadingTests.cs index 3bc754a234c1c..cf92afe259e1e 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DelayLoadingTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DelayLoadingTests.cs @@ -14,6 +14,7 @@ namespace Tests.Integration { + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public class DelayLoadingTests { [Fact] diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DelegateCompositionTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DelegateCompositionTests.cs index 7bd54f8be79c7..a975c47243d96 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DelegateCompositionTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DelegateCompositionTests.cs @@ -175,6 +175,7 @@ public class ImportCustomExportedDelegates } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void CustomExportedDelegate_ShouldWork() { var container = ContainerFactory.CreateWithAttributedCatalog( diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DiscoveryTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DiscoveryTests.cs index fec0fb4cca21d..b2c64e33a3a58 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DiscoveryTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DiscoveryTests.cs @@ -72,6 +72,7 @@ public class DerivedBaseWithNonPublicImportAndExport : BaseWithNonPublicImportAn } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void Import_PrivateOnClass_ShouldSetImport() { var container = ContainerFactory.CreateWithAttributedCatalog(typeof(BaseWithNonPublicImportAndExport)); @@ -82,6 +83,7 @@ public void Import_PrivateOnClass_ShouldSetImport() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void Import_PrivateOnBase_ShouldSetImport() { var container = ContainerFactory.CreateWithAttributedCatalog(typeof(DerivedBaseWithNonPublicImportAndExport)); @@ -120,6 +122,7 @@ public class ClassWithInterfaceInheritedImport : InterfaceWithImport } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void Import_InheritImportFromInterface_ShouldExposeImport() { var container = ContainerFactory.CreateWithAttributedCatalog( @@ -168,6 +171,7 @@ public class DerivedWithOverrideExport : BaseWithVirtualExport } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void Export_BaseAndDerivedShouldAmountInTwoExports() { var container = ContainerFactory.CreateWithAttributedCatalog( @@ -303,6 +307,7 @@ public class Plugin1 : Plugin } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void Export_Plugin1() { var container = ContainerFactory.CreateWithAttributedCatalog( @@ -327,6 +332,7 @@ public override int Version } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void Export_Plugin2() { var container = ContainerFactory.CreateWithAttributedCatalog( @@ -354,6 +360,7 @@ public override int Version } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void Export_Plugin3() { var container = ContainerFactory.CreateWithAttributedCatalog( @@ -386,6 +393,7 @@ public override int Version } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void Export_Plugin4() { var container = ContainerFactory.CreateWithAttributedCatalog( @@ -406,6 +414,7 @@ public class MyPlugin : IPlugin } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void Export_MyPlugin() { var container = ContainerFactory.CreateWithAttributedCatalog( @@ -441,6 +450,7 @@ public class MyToolbarPlugin : IToolbarPlugin } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void TestInterfaces() { var container = ContainerFactory.CreateWithAttributedCatalog( @@ -499,6 +509,7 @@ public override int VirtualImport } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void Import_VirtualPropertyOverrideWithSameContract_ShouldSucceed() { var container = ContainerFactory.Create(); @@ -530,6 +541,7 @@ public override int VirtualImport } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void Import_VirtualPropertyOverrideWithDifferentContract_ShouldSucceed() { var container = ContainerFactory.Create(); @@ -715,6 +727,7 @@ public int Property } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void Test_CustomInheritedExportAttribute_OnInterface() { var container = ContainerFactory.CreateWithAttributedCatalog(typeof(UsesCustomInheritedExportOnInterface)); @@ -737,6 +750,7 @@ public DerivedFromBaseWithCustomInheritedExport() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void Test_CustomInheritedExportAttribute_OnBaseClass() { var container = ContainerFactory.CreateWithAttributedCatalog(typeof(DerivedFromBaseWithCustomInheritedExport)); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/LifetimeTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/LifetimeTests.cs index b16921ec3b958..7b1360bf5fd81 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/LifetimeTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/LifetimeTests.cs @@ -55,6 +55,7 @@ public void Dispose() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void PartAddedViaAddExportedValue_ShouldNotBeDisposedWithContainer() { var container = new CompositionContainer(); @@ -68,6 +69,7 @@ public void PartAddedViaAddExportedValue_ShouldNotBeDisposedWithContainer() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void PartAddedTwice_AppearsTwice() { // You probably shouldn't be adding a part to the container twice, but it's not something we're going to check for and throw an exception on @@ -105,6 +107,7 @@ public void AnyPart_Simple_ShouldNotBeCollected() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void AnyPart_Disposable_ShouldNotBeCollected() { var catalog = new TypeCatalog(typeof(AnyPartDisposable)); @@ -119,6 +122,7 @@ public void AnyPart_Disposable_ShouldNotBeCollected() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void AnyPart_Disposable_ShouldBeDisposedWithContainer() { var catalog = new TypeCatalog(typeof(AnyPartDisposable)); @@ -134,6 +138,7 @@ public void AnyPart_Disposable_ShouldBeDisposedWithContainer() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void AnyPart_RecomposabeImport_ShouldNotBeCollected() { var catalog = new TypeCatalog(typeof(AnyPartRecomposable)); @@ -165,6 +170,7 @@ public void AnyPart_RecomposabeImport_ShouldNotBeCollected() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void AnyPart_DisposableRecomposabeImport_ShouldNotBeCollected() { var catalog = new TypeCatalog(typeof(AnyPartDisposableRecomposable)); @@ -259,6 +265,7 @@ public void SharedPart_Simple_ShouldNotBeCollected() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SharedPart_Disposable_ShouldNotBeCollected() { var catalog = new TypeCatalog(typeof(SharedPartDisposable)); @@ -275,6 +282,7 @@ public void SharedPart_Disposable_ShouldNotBeCollected() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SharedPart_Disposable_ShouldBeDisposedWithContainer() { var catalog = new TypeCatalog(typeof(SharedPartDisposable)); @@ -290,6 +298,7 @@ public void SharedPart_Disposable_ShouldBeDisposedWithContainer() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SharedPart_RecomposabeImport_ShouldNotBeCollected() { var catalog = new TypeCatalog(typeof(SharedPartRecomposable)); @@ -322,6 +331,7 @@ public void SharedPart_RecomposabeImport_ShouldNotBeCollected() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void SharedPart_DisposableRecomposabeImport_ShouldNotBeCollected() { var catalog = new TypeCatalog(typeof(SharedPartDisposableRecomposable)); @@ -414,6 +424,7 @@ public void Dispose() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void NonSharedPart_Disposable_ShouldNotBeCollected() { var catalog = new TypeCatalog(typeof(NonSharedPartDisposable)); @@ -430,6 +441,7 @@ public void NonSharedPart_Disposable_ShouldNotBeCollected() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void NonSharedPart_Disposable_ShouldBeDisposedWithContainer() { var catalog = new TypeCatalog(typeof(NonSharedPartDisposable)); @@ -445,6 +457,7 @@ public void NonSharedPart_Disposable_ShouldBeDisposedWithContainer() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void NonSharedPart_RecomposableImport_WithReference_ShouldNotBeCollected() { var catalog = new TypeCatalog(typeof(NonSharedPartRecomposable)); @@ -477,6 +490,7 @@ public void NonSharedPart_RecomposableImport_WithReference_ShouldNotBeCollected( } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void NonSharedPart_DisposableRecomposabeImport_NoReference_ShouldNotBeCollected() { var catalog = new TypeCatalog(typeof(NonSharedPartDisposableRecomposable)); @@ -531,6 +545,7 @@ public class NonSharedState } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void NonSharedPart_TwoRecomposablePartsSameExportedValue() { // This test is primarily used to ensure that we allow for multiple parts to be associated @@ -590,6 +605,7 @@ private static CompositionContainer GetContainer() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void GetReleaseExport_SharedRoot_ShouldNotDisposeChain() { var container = GetContainer(); @@ -604,6 +620,7 @@ public void GetReleaseExport_SharedRoot_ShouldNotDisposeChain() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void AddRemovePart_SharedRoot_ShouldNotDisposeChain() { var container = GetContainer(); @@ -623,6 +640,7 @@ public void AddRemovePart_SharedRoot_ShouldNotDisposeChain() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ContainerDispose_SharedRoot_ShouldDisposeChain() { var container = GetContainer(); @@ -637,6 +655,7 @@ public void ContainerDispose_SharedRoot_ShouldDisposeChain() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void GetReleaseExport_NonSharedRoot_ShouldDisposeChain() { var container = GetContainer(); @@ -667,6 +686,7 @@ public void GetReleaseExport_NonSharedRoot_ShouldDisposeChain() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void GetReleaseExport_NonSharedRoot_ShouldDisposeChain_WithMetadata() { var container = GetContainer(); @@ -697,6 +717,7 @@ public void GetReleaseExport_NonSharedRoot_ShouldDisposeChain_WithMetadata() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ReleaseExports_ShouldDispose_NonSharedParts() { var container = GetContainer(); @@ -717,6 +738,7 @@ public void ReleaseExports_ShouldDispose_NonSharedParts() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void AddRemovePart_NonSharedRoot_ShouldDisposeChain() { var container = GetContainer(); @@ -736,6 +758,7 @@ public void AddRemovePart_NonSharedRoot_ShouldDisposeChain() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ContainerDispose_NonSharedRoot_ShouldNotDisposeChain() { var container = GetContainer(); @@ -750,6 +773,7 @@ public void ContainerDispose_NonSharedRoot_ShouldNotDisposeChain() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void GetReleaseExport_NonSharedPart_ShouldNotRecomposeAfterRelease() { var catalog = new TypeCatalog(typeof(NonSharedPartRecomposable)); @@ -777,6 +801,7 @@ public void GetReleaseExport_NonSharedPart_ShouldNotRecomposeAfterRelease() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void GetExportManualDisposeThenRecompose_NonSharedDisposableRecomposablePart_ShouldThrowComposition() { var catalog = new TypeCatalog(typeof(NonSharedPartDisposableRecomposable)); @@ -817,6 +842,7 @@ public class MyImporter } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void RecomposeCausesOldImportedValuesToBeDisposed() { var cat = new AggregateCatalog(); @@ -859,6 +885,7 @@ private static CompositionContainer CreateParentChildContainerWithNonSharedImpor } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ChildContainerGetReleaseExport_NonSharedRoot_ShouldDisposeChain() { var child = CreateParentChildContainerWithNonSharedImporter(); @@ -873,6 +900,7 @@ public void ChildContainerGetReleaseExport_NonSharedRoot_ShouldDisposeChain() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ChildContainerAddRemovePart_NonSharedRoot_ShouldDisposeChain() { var child = CreateParentChildContainerWithNonSharedImporter(); @@ -892,6 +920,7 @@ public void ChildContainerAddRemovePart_NonSharedRoot_ShouldDisposeChain() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ChildContainerAddRemovePart_NonSharedRoot_ShouldNotDisposeChain() { var child = CreateParentChildContainerWithNonSharedImporter(); @@ -1262,6 +1291,7 @@ public void GetReleaseExport_NonSharedPart_ShouldCollectWholeObjectChain() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void ReleaseExports_ShouldWorkWithExportCollection() { var container = GetContainer(); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/RecompositionTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/RecompositionTests.cs index 6e7b4812366ca..5734ba8a5589e 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/RecompositionTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/RecompositionTests.cs @@ -11,6 +11,7 @@ namespace Tests.Integration { + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public class RecompositionTests { public class Class_OptIn_AllowRecompositionImports diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/RejectionTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/RejectionTests.cs index 51d84c355e62b..b03583aa41292 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/RejectionTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/RejectionTests.cs @@ -12,6 +12,7 @@ namespace Tests.Integration { + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public class RejectionTests { public interface IExtension diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/RequiredCreationPolicyTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/RequiredCreationPolicyTests.cs index 74505c8891f03..e1975483cb016 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/RequiredCreationPolicyTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/RequiredCreationPolicyTests.cs @@ -12,6 +12,7 @@ namespace Tests.Integration { + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public class RequiredCreationPolicyTests { // Matrix that details which policy to use for a given part to satisfy a given import. diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 06a694aaf482f..b7c166bd24b71 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -219,7 +219,6 @@ ## System.ComponentModel.Composition.Tests #################################################################### --nomethod System.ComponentModel.Composition.CompositionServicesTests.GetDefaultContractNameTest -nomethod System.ComponentModel.Composition.MetadataViewProviderTests.GetMetadataView_InterfaceWithIndexer_ShouldThrowNotSupportedException -nomethod Tests.Integration.ExportFactoryTests.ExportFactoryStandardImports_ShouldWorkProperly @@ -228,10 +227,6 @@ -nomethod System.ComponentModel.Composition.MetadataAttributeTests.StronglyTypedStructureTestWithTransparentViews -nomethod System.ComponentModel.Composition.MetadataViewProviderTests.GetMetadataView_IMetadataViewWithDefaultedInt64 -nomethod System.ComponentModel.Composition.ExportCollectionTests.ImportCollectionsFromContainerOnly -# disable the whole namespace, https://github.com/mono/mono/issues/16417 --nonamespace System.ComponentModel.Composition -# same issue (only System.ComponentModel.Composition uses this namespace) --nonamespace Tests.Integration #################################################################### ## System.Data.Common.Tests From e146c57d18c107563673f1e992e47ffd97492fad Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 28 Jan 2020 12:30:18 +0300 Subject: [PATCH 27/96] Update a message in skipped System.Runtime.InteropServices.Tests --- .../Marshal/GetExceptionCodeTests.cs | 2 +- .../Marshal/GetExceptionPointersTests.cs | 2 +- .../Marshal/ReadWrite/ByteTests.cs | 16 ++++++++-------- .../Marshal/ReadWrite/Int16Tests.cs | 16 ++++++++-------- .../Marshal/ReadWrite/Int32Tests.cs | 16 ++++++++-------- .../Marshal/ReadWrite/Int64Tests.cs | 16 ++++++++-------- .../Marshal/ReadWrite/IntPtrTests.cs | 16 ++++++++-------- 7 files changed, 42 insertions(+), 42 deletions(-) diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionCodeTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionCodeTests.cs index 07cb19f0b9c00..1090dd474a508 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionCodeTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionCodeTests.cs @@ -9,7 +9,7 @@ namespace System.Runtime.InteropServices.Tests { - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.GetExceptionCode will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public class GetExceptionCodeTests { [Fact] diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionPointersTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionPointersTests.cs index 4f4af1a2eba75..47721d93f79db 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionPointersTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionPointersTests.cs @@ -10,7 +10,7 @@ namespace System.Runtime.InteropServices.Tests public class GetExceptionPointersTests { [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.GetExceptionPointers will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void GetExceptionPointers_ReturnsExpected() { Assert.Equal(IntPtr.Zero, Marshal.GetExceptionPointers()); diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/ByteTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/ByteTests.cs index 9c5f425230a43..2e299bd2a1ccf 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/ByteTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/ByteTests.cs @@ -45,7 +45,7 @@ public void WriteByte_Pointer_Roundtrips(byte[] values) } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.WriteByte will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void WriteByte_BlittableObject_Roundtrips() { int offset1 = Marshal.OffsetOf(nameof(BlittableStruct.value1)).ToInt32(); @@ -67,7 +67,7 @@ public void WriteByte_BlittableObject_Roundtrips() } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.WriteByte will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void WriteByte_StructWithReferenceTypes_ReturnsExpected() { int pointerOffset = Marshal.OffsetOf(nameof(StructWithReferenceTypes.pointerValue)).ToInt32(); @@ -92,7 +92,7 @@ public void WriteByte_StructWithReferenceTypes_ReturnsExpected() } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.ReadByte will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void ReadByte_BlittableObject_ReturnsExpected() { int offset1 = Marshal.OffsetOf(nameof(BlittableStruct.value1)).ToInt32(); @@ -109,7 +109,7 @@ public void ReadByte_BlittableObject_ReturnsExpected() } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.ReadByte will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void ReadByte_StructWithReferenceTypes_ReturnsExpected() { int pointerOffset = Marshal.OffsetOf(nameof(StructWithReferenceTypes.pointerValue)).ToInt32(); @@ -140,14 +140,14 @@ public void ReadByte_ZeroPointer_ThrowsException() } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.ReadByte will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void ReadByte_NullObject_ThrowsAccessViolationException() { Assert.Throws(() => Marshal.ReadByte(null, 2)); } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.ReadByte will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void ReadByte_NotReadable_ThrowsArgumentException() { AssemblyBuilder assemblyBuilder = AssemblyBuilder.DefineDynamicAssembly(new AssemblyName("Assembly"), AssemblyBuilderAccess.RunAndCollect); @@ -167,14 +167,14 @@ public void WriteByte_ZeroPointer_ThrowsException() } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.WriteByte will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void WriteByte_NullObject_ThrowsAccessViolationException() { Assert.Throws(() => Marshal.WriteByte(null, 2, 0)); } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.WriteByte will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void WriteByte_NotReadable_ThrowsArgumentException() { AssemblyBuilder assemblyBuilder = AssemblyBuilder.DefineDynamicAssembly(new AssemblyName("Assembly"), AssemblyBuilderAccess.RunAndCollect); diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int16Tests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int16Tests.cs index 8a01732578608..72fdb943ac1fb 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int16Tests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int16Tests.cs @@ -45,7 +45,7 @@ public void WriteInt16_Pointer_Roundtrips(short[] values) } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.WriteInt16 will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void WriteInt16_BlittableObject_Roundtrips() { int offset1 = Marshal.OffsetOf(nameof(BlittableStruct.value1)).ToInt32(); @@ -67,7 +67,7 @@ public void WriteInt16_BlittableObject_Roundtrips() } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.WriteInt16 will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void WriteInt16_StructWithReferenceTypes_ReturnsExpected() { int pointerOffset = Marshal.OffsetOf(nameof(StructWithReferenceTypes.pointerValue)).ToInt32(); @@ -92,7 +92,7 @@ public void WriteInt16_StructWithReferenceTypes_ReturnsExpected() } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.ReadInt16 will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void ReadInt16_BlittableObject_ReturnsExpected() { int offset1 = Marshal.OffsetOf(nameof(BlittableStruct.value1)).ToInt32(); @@ -109,7 +109,7 @@ public void ReadInt16_BlittableObject_ReturnsExpected() } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.ReadInt16 will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void ReadInt16_StructWithReferenceTypes_ReturnsExpected() { int pointerOffset = Marshal.OffsetOf(nameof(StructWithReferenceTypes.pointerValue)).ToInt32(); @@ -135,14 +135,14 @@ public void ReadInt16_ZeroPointer_ThrowsException() } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.ReadInt16 will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void ReadInt16_NullObject_ThrowsAccessViolationException() { Assert.Throws(() => Marshal.ReadInt16(null, 2)); } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.ReadInt16 will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void ReadInt16_NotReadable_ThrowsArgumentException() { AssemblyBuilder assemblyBuilder = AssemblyBuilder.DefineDynamicAssembly(new AssemblyName("Assembly"), AssemblyBuilderAccess.RunAndCollect); @@ -162,14 +162,14 @@ public void WriteInt16_ZeroPointer_ThrowsException() } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.WriteInt16 will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void WriteInt16_NullObject_ThrowsAccessViolationException() { Assert.Throws(() => Marshal.WriteInt16(null, 2, 0)); } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.WriteInt16 will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void WriteInt16_NotReadable_ThrowsArgumentException() { AssemblyBuilder assemblyBuilder = AssemblyBuilder.DefineDynamicAssembly(new AssemblyName("Assembly"), AssemblyBuilderAccess.RunAndCollect); diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int32Tests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int32Tests.cs index b8470488faa90..58b1429d139d5 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int32Tests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int32Tests.cs @@ -45,7 +45,7 @@ public void WriteInt32_Pointer_Roundtrips(int[] values) } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.WriteInt32 will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void WriteInt32_BlittableObject_Roundtrips() { int offset1 = Marshal.OffsetOf(nameof(BlittableStruct.value1)).ToInt32(); @@ -67,7 +67,7 @@ public void WriteInt32_BlittableObject_Roundtrips() } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.WriteInt32 will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void WriteInt32_StructWithReferenceTypes_ReturnsExpected() { int pointerOffset = Marshal.OffsetOf(nameof(StructWithReferenceTypes.pointerValue)).ToInt32(); @@ -93,7 +93,7 @@ public void WriteInt32_StructWithReferenceTypes_ReturnsExpected() } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.ReadInt32 will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void ReadInt32_BlittableObject_ReturnsExpected() { int offset1 = Marshal.OffsetOf(nameof(BlittableStruct.value1)).ToInt32(); @@ -110,7 +110,7 @@ public void ReadInt32_BlittableObject_ReturnsExpected() } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.ReadInt32 will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void ReadInt32_StructWithReferenceTypes_ReturnsExpected() { int pointerOffset = Marshal.OffsetOf(nameof(StructWithReferenceTypes.pointerValue)).ToInt32(); @@ -137,14 +137,14 @@ public void ReadInt32_ZeroPoint_ThrowsException() } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.ReadInt32 will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void ReadInt32_NullObject_ThrowsAccessViolationException() { Assert.Throws(() => Marshal.ReadInt32(null, 2)); } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.ReadInt32 will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void ReadInt32_NotReadable_ThrowsArgumentException() { AssemblyBuilder assemblyBuilder = AssemblyBuilder.DefineDynamicAssembly(new AssemblyName("Assembly"), AssemblyBuilderAccess.RunAndCollect); @@ -164,14 +164,14 @@ public void WriteInt32_ZeroPointer_ThrowsException() } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.WriteInt32 will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void WriteInt32_NullObject_ThrowsAccessViolationException() { Assert.Throws(() => Marshal.WriteInt32(null, 2, 0)); } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.WriteInt32 will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void WriteInt32_NotReadable_ThrowsArgumentException() { AssemblyBuilder assemblyBuilder = AssemblyBuilder.DefineDynamicAssembly(new AssemblyName("Assembly"), AssemblyBuilderAccess.RunAndCollect); diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int64Tests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int64Tests.cs index 1bd8a3444d663..2edcf099b0e52 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int64Tests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int64Tests.cs @@ -45,7 +45,7 @@ public void WriteInt64_Pointer_Roundtrips(long[] values) } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.WriteInt64 will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void WriteInt64_BlittableObject_Roundtrips() { int offset1 = Marshal.OffsetOf(nameof(BlittableStruct.value1)).ToInt32(); @@ -67,7 +67,7 @@ public void WriteInt64_BlittableObject_Roundtrips() } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.WriteInt64 will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void WriteInt64_StructWithReferenceTypes_ReturnsExpected() { int pointerOffset = Marshal.OffsetOf(nameof(StructWithReferenceTypes.pointerValue)).ToInt32(); @@ -102,7 +102,7 @@ public void WriteInt64_StructWithReferenceTypes_ReturnsExpected() } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.ReadInt64 will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void ReadInt64_BlittableObject_ReturnsExpected() { int offset1 = Marshal.OffsetOf(nameof(BlittableStruct.value1)).ToInt32(); @@ -119,7 +119,7 @@ public void ReadInt64_BlittableObject_ReturnsExpected() } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.ReadInt64 will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void ReadInt64_StructWithReferenceTypes_ReturnsExpected() { int pointerOffset = Marshal.OffsetOf(nameof(StructWithReferenceTypes.pointerValue)).ToInt32(); @@ -149,14 +149,14 @@ public void ReadInt64_ZeroPointer_ThrowsException() } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.ReadInt64 will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void ReadInt64_NullObject_ThrowsAccessViolationException() { Assert.Throws(() => Marshal.ReadInt64(null, 2)); } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.ReadInt64 will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void ReadInt64_NotReadable_ThrowsArgumentException() { AssemblyBuilder assemblyBuilder = AssemblyBuilder.DefineDynamicAssembly(new AssemblyName("Assembly"), AssemblyBuilderAccess.RunAndCollect); @@ -176,14 +176,14 @@ public void WriteInt64_ZeroPointer_ThrowsException() } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.WriteInt64 will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void WriteInt64_NullObject_ThrowsAccessViolationException() { Assert.Throws(() => Marshal.WriteInt64(null, 2, 0)); } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.WriteInt64 will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void WriteInt64_NotReadable_ThrowsArgumentException() { AssemblyBuilder assemblyBuilder = AssemblyBuilder.DefineDynamicAssembly(new AssemblyName("Assembly"), AssemblyBuilderAccess.RunAndCollect); diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/IntPtrTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/IntPtrTests.cs index 0e5d71be5f7f1..e80e9573d12fb 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/IntPtrTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/IntPtrTests.cs @@ -52,7 +52,7 @@ public void WriteIntPtr_Pointer_Roundtrips(IntPtr[] values) } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.WriteIntPtr will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void WriteIntPtr_BlittableObject_Roundtrips() { int offset1 = Marshal.OffsetOf(nameof(BlittableStruct.value1)).ToInt32(); @@ -74,7 +74,7 @@ public void WriteIntPtr_BlittableObject_Roundtrips() } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.WriteIntPtr will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void WriteIntPtr_StructWithReferenceTypes_ReturnsExpected() { int pointerOffset = Marshal.OffsetOf(nameof(StructWithReferenceTypes.pointerValue)).ToInt32(); @@ -100,7 +100,7 @@ public void WriteIntPtr_StructWithReferenceTypes_ReturnsExpected() } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.ReadIntPtr will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void ReadIntPtr_BlittableObject_ReturnsExpected() { int offset1 = Marshal.OffsetOf(nameof(BlittableStruct.value1)).ToInt32(); @@ -117,7 +117,7 @@ public void ReadIntPtr_BlittableObject_ReturnsExpected() } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.ReadIntPtr will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void ReadIntPtr_StructWithReferenceTypes_ReturnsExpected() { int pointerOffset = Marshal.OffsetOf(nameof(StructWithReferenceTypes.pointerValue)).ToInt32(); @@ -144,14 +144,14 @@ public void ReadIntPtr_ZeroPointer_ThrowsException() } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.ReadIntPtr will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void ReadIntPtr_NullObject_ThrowsAccessViolationException() { Assert.Throws(() => Marshal.ReadIntPtr(null, 2)); } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.ReadIntPtr will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void ReadIntPtr_NotReadable_ThrowsArgumentException() { AssemblyBuilder assemblyBuilder = AssemblyBuilder.DefineDynamicAssembly(new AssemblyName("Assembly"), AssemblyBuilderAccess.RunAndCollect); @@ -171,14 +171,14 @@ public void WriteIntPtr_ZeroPointer_ThrowsException() } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.WriteIntPtr will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void WriteIntPtr_NullObject_ThrowsAccessViolationException() { Assert.Throws(() => Marshal.WriteIntPtr(null, 2, (IntPtr)0)); } [Fact] - [SkipOnMono("https://github.com/mono/mono/issues/15085 - Marshal Methods WILL NOT BE Implemented in MonoVM")] + [SkipOnMono("Marshal.WriteIntPtr will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")] public void WriteIntPtr_NotReadable_ThrowsArgumentException() { AssemblyBuilder assemblyBuilder = AssemblyBuilder.DefineDynamicAssembly(new AssemblyName("Assembly"), AssemblyBuilderAccess.RunAndCollect); From d9cd430258b6e76b9d46f33f87eb63750d550b02 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 28 Jan 2020 12:40:10 +0300 Subject: [PATCH 28/96] Move skipped System.Reflection.Tests.MetadataTokenTests.SuccessImpliesNonNilWithCorrectTable with an active issue out of rsp file --- .../tests/MetadataTokenTests.cs | 1 + src/mono/netcore/CoreFX.issues.rsp | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/libraries/System.Reflection.TypeExtensions/tests/MetadataTokenTests.cs b/src/libraries/System.Reflection.TypeExtensions/tests/MetadataTokenTests.cs index e24b3bee6f992..f293eb5784bf0 100644 --- a/src/libraries/System.Reflection.TypeExtensions/tests/MetadataTokenTests.cs +++ b/src/libraries/System.Reflection.TypeExtensions/tests/MetadataTokenTests.cs @@ -37,6 +37,7 @@ public event EventHandler Event { add { } remove { } } new object[] { typeof(Test<>).GetGenericArguments()[0].GetTypeInfo(), 0x2A } }; + [ActiveIssue("https://github.com/mono/mono/issues/15194", TargetFrameworkMonikers.Mono)] [ConditionalTheory(nameof(GetMetadataTokenSupported))] [MemberData(nameof(MembersWithExpectedTableIndex))] public void SuccessImpliesNonNilWithCorrectTable(MemberInfo member, int expectedTableIndex) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index b7c166bd24b71..f14b9b0f78dc3 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -250,9 +250,6 @@ ## System.Reflection.Metadata.Tests #################################################################### -# Assertion... Expected true, got false -# https://github.com/mono/mono/issues/15194 --nomethod System.Reflection.Tests.MetadataTokenTests.SuccessImpliesNonNilWithCorrectTable # Test broken on Mono, added in https://github.com/dotnet/corefx/pull/40581 -nomethod System.Reflection.Tests.MetadataLoadContextTests.RelocatableAssembly From fd2b05f762f3c9658401bb726b786d6cd38ab642 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 28 Jan 2020 13:25:00 +0300 Subject: [PATCH 29/96] Move skipped/no repro System.Threading.Overlapped.Tests with an active issue out of rsp file --- .../tests/OverlappedTests.cs | 1 + ...BoundHandle_PreAllocatedOverlappedTests.cs | 2 ++ src/mono/netcore/CoreFX.issues.rsp | 23 ------------------- 3 files changed, 3 insertions(+), 23 deletions(-) diff --git a/src/libraries/System.Threading.Overlapped/tests/OverlappedTests.cs b/src/libraries/System.Threading.Overlapped/tests/OverlappedTests.cs index ce5ed265ba076..23d61895ea813 100644 --- a/src/libraries/System.Threading.Overlapped/tests/OverlappedTests.cs +++ b/src/libraries/System.Threading.Overlapped/tests/OverlappedTests.cs @@ -62,6 +62,7 @@ public static void PropertyTest2() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15311", TargetFrameworkMonikers.Mono)] public static void PropertyTest3() { IAsyncResult asyncResult = new Task(() => Console.WriteLine("this is a dummy task")); diff --git a/src/libraries/System.Threading.Overlapped/tests/ThreadPoolBoundHandle_PreAllocatedOverlappedTests.cs b/src/libraries/System.Threading.Overlapped/tests/ThreadPoolBoundHandle_PreAllocatedOverlappedTests.cs index 447185832edee..aae5594f79946 100644 --- a/src/libraries/System.Threading.Overlapped/tests/ThreadPoolBoundHandle_PreAllocatedOverlappedTests.cs +++ b/src/libraries/System.Threading.Overlapped/tests/ThreadPoolBoundHandle_PreAllocatedOverlappedTests.cs @@ -41,6 +41,7 @@ public unsafe void PreAllocatedOverlapped_EmptyArrayAsPinData_DoesNotThrow() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15313", TargetFrameworkMonikers.Mono)] public unsafe void PreAllocatedOverlapped_NonBlittableTypeAsPinData_Throws() { AssertExtensions.Throws(null, () => new PreAllocatedOverlapped((_, __, ___) => { }, new object(), new NonBlittableType() { s = "foo" })); @@ -68,6 +69,7 @@ public unsafe void PreAllocatedOverlapped_ObjectArrayAsPinData_DoesNotThrow() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15313", TargetFrameworkMonikers.Mono)] public unsafe void PreAllocatedOverlapped_ObjectArrayWithNonBlittableTypeAsPinData_Throws() { object[] array = new object[] diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index f14b9b0f78dc3..7594dbb5245aa 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -264,29 +264,6 @@ ## System.Threading.Overlapped.Tests #################################################################### -# Overflow Exception -# https://github.com/mono/mono/issues/15197 -# https://github.com/mono/mono/issues/15311 -# These tests should be ignored on x64 in dotnet/corefx --nomethod OverlappedTests.PropertyTest2 --nomethod OverlappedTests.PropertyTest3 - -# NRE -# https://github.com/mono/mono/issues/15312 --nomethod ThreadPoolBoundHandleTests.BindHandle_MinusOneAsHandle_ThrowsArgumentException - -# No Exception thrown -# https://github.com/mono/mono/issues/15313 --nomethod ThreadPoolBoundHandleTests.PreAllocatedOverlapped_NonBlittableTypeAsPinData_Throws --nomethod ThreadPoolBoundHandleTests.PreAllocatedOverlapped_ObjectArrayWithNonBlittableTypeAsPinData_Throws --nomethod ThreadPoolBoundHandleTests.GetNativeOverlappedState_NullAsNativeOverlapped_ThrowsArgumentNullException - -# NRE on BindHandle -# https://github.com/mono/mono/issues/15314 --nomethod ThreadPoolBoundHandleTests.BindHandle_ZeroAsHandle_ThrowsArgumentException --nomethod ThreadPoolBoundHandleTests.BindHandle_NullAsHandle_ThrowsArgumentNullException --nomethod ThreadPoolBoundHandleTests.BindHandle_ValidHandle_ThrowsPlatformNotSupportedException - # Test not run -nomethod ThreadPoolBoundHandleTests.PreAllocatedOverlapped_NullAsCallback_ThrowsArgumentNullException From d0c9bd7516f14eea69dd72c37658ed3ad0db917f Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 28 Jan 2020 14:18:36 +0300 Subject: [PATCH 30/96] Move skipped System.Runtime.Extensions with an active issue out of rsp file --- .../tests/System/AppDomainTests.cs | 4 ++++ .../tests/System/Environment.StackTrace.cs | 1 + src/mono/netcore/CoreFX.issues.rsp | 11 ----------- 3 files changed, 5 insertions(+), 11 deletions(-) diff --git a/src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs b/src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs index 47f1ef16c4763..44e2ae70b16f5 100644 --- a/src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs +++ b/src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs @@ -167,6 +167,7 @@ public void FirstChanceException_Add_Remove() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16246", TargetFrameworkMonikers.Mono)] public void FirstChanceException_Called() { RemoteExecutor.Invoke(() => { @@ -606,6 +607,7 @@ public void AssemblyResolve_RequestingAssembly() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16246", TargetFrameworkMonikers.Mono)] public void AssemblyResolve_IsNotCalledForCoreLibResources() { RemoteExecutor.Invoke(() => @@ -668,6 +670,7 @@ public void TypeResolve() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16246", TargetFrameworkMonikers.Mono)] public void ResourceResolve() { RemoteExecutor.Invoke(() => { @@ -907,6 +910,7 @@ public static IEnumerable TestingCreateInstanceObjectHandleFullSignatu } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16246", TargetFrameworkMonikers.Mono)] public void AssemblyResolve_FirstChanceException() { RemoteExecutor.Invoke(() => { diff --git a/src/libraries/System.Runtime.Extensions/tests/System/Environment.StackTrace.cs b/src/libraries/System.Runtime.Extensions/tests/System/Environment.StackTrace.cs index 4865e9dab394e..85d63c32b879f 100644 --- a/src/libraries/System.Runtime.Extensions/tests/System/Environment.StackTrace.cs +++ b/src/libraries/System.Runtime.Extensions/tests/System/Environment.StackTrace.cs @@ -16,6 +16,7 @@ public class EnvironmentStackTrace static string s_stackTrace; [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15315", TargetFrameworkMonikers.Mono)] public void StackTraceTest() { //arrange diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 7594dbb5245aa..67393321c7785 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -271,17 +271,6 @@ ## System.Runtime.Extensions.Tests #################################################################### -# Mono expands generic Types in stacktraces unlike the .NET Core (sounds more like a feature: https://gist.github.com/EgorBo/3abb37d2ff4fc904bc7472c62498f933) -# https://github.com/mono/mono/issues/15315 --nomethod System.Tests.EnvironmentStackTrace.StackTraceTest - -# These events are not wired up in mono -# https://github.com/mono/mono/issues/16246 --nomethod System.Tests.AppDomainTests.ResourceResolve --nomethod System.Tests.AppDomainTests.FirstChanceException_Called --nomethod System.Tests.AppDomainTests.AssemblyResolve_FirstChanceException --nomethod System.Tests.AppDomainTests.AssemblyResolve_IsNotCalledForCoreLibResources - # AssemblyLoadContext.SetProfileOptimizationRoot is no-op (not implemented) -nomethod System.Runtime.Tests.ProfileOptimizationTest.ProfileOptimization_CheckFileExists From a0c84bf3f0b609f3ba45f700ef13742f00b50c99 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 28 Jan 2020 14:32:05 +0300 Subject: [PATCH 31/96] Re-enable skipped System.Runtime.Handles.Tests because the related issue was addressed --- src/mono/netcore/CoreFX.issues.rsp | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 67393321c7785..1c4cd0f28ab52 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -274,15 +274,6 @@ # AssemblyLoadContext.SetProfileOptimizationRoot is no-op (not implemented) -nomethod System.Runtime.Tests.ProfileOptimizationTest.ProfileOptimization_CheckFileExists -#################################################################### -## System.Runtime.Handles.Tests -#################################################################### - -# NRE in SafeHandle.Dispose -# https://github.com/mono/mono/issues/17224 --noclass SafeWaitHandleExtensions_4000_Tests --noclass SafeWaitHandle_4000_Tests - #################################################################### ## System.Reflection.TypeExtensions.Tests #################################################################### From 8612c52dec07bc232647eacc44a3d75a37a78dd7 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 28 Jan 2020 15:10:23 +0300 Subject: [PATCH 32/96] Move skipped System.Reflection.TypeExtensions.Tests with an active issue out of rsp file --- .../ConstructorInfoInvokeArrayTests.cs | 2 ++ .../ConstructorInfo/ConstructorInfoTests.cs | 1 + .../tests/PropertyInfoTests.cs | 1 + .../tests/TypeTests.cs | 1 + src/mono/netcore/CoreFX.issues.rsp | 24 ------------------- 5 files changed, 5 insertions(+), 24 deletions(-) diff --git a/src/libraries/System.Reflection.TypeExtensions/tests/ConstructorInfo/ConstructorInfoInvokeArrayTests.cs b/src/libraries/System.Reflection.TypeExtensions/tests/ConstructorInfo/ConstructorInfoInvokeArrayTests.cs index 4f3918bfee79e..f66066e4ecaa8 100644 --- a/src/libraries/System.Reflection.TypeExtensions/tests/ConstructorInfo/ConstructorInfoInvokeArrayTests.cs +++ b/src/libraries/System.Reflection.TypeExtensions/tests/ConstructorInfo/ConstructorInfoInvokeArrayTests.cs @@ -33,6 +33,7 @@ public void Invoke_SZArrayConstructor() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15316", TargetFrameworkMonikers.Mono)] public void Invoke_1DArrayConstructor() { Type type = Type.GetType("System.Char[*]"); @@ -220,6 +221,7 @@ public void Invoke_2DArrayConstructor() } } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15318", TargetFrameworkMonikers.Mono)] public void Invoke_LargeDimensionalArrayConstructor() { Type type = Type.GetType("System.Type[,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,]"); diff --git a/src/libraries/System.Reflection.TypeExtensions/tests/ConstructorInfo/ConstructorInfoTests.cs b/src/libraries/System.Reflection.TypeExtensions/tests/ConstructorInfo/ConstructorInfoTests.cs index 052f887a20caf..82eb23ef8ce23 100644 --- a/src/libraries/System.Reflection.TypeExtensions/tests/ConstructorInfo/ConstructorInfoTests.cs +++ b/src/libraries/System.Reflection.TypeExtensions/tests/ConstructorInfo/ConstructorInfoTests.cs @@ -64,6 +64,7 @@ public static IEnumerable Invoke_Invalid_TestData() } [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/15317", TargetFrameworkMonikers.Mono)] [MemberData(nameof(Invoke_Invalid_TestData))] public void Invoke_Invalid(Type constructorParent, Type[] constructorTypeParameters, object[] parameters, Type exceptionType) { diff --git a/src/libraries/System.Reflection.TypeExtensions/tests/PropertyInfoTests.cs b/src/libraries/System.Reflection.TypeExtensions/tests/PropertyInfoTests.cs index 8a730c335fb8e..d3dc30d66dca8 100644 --- a/src/libraries/System.Reflection.TypeExtensions/tests/PropertyInfoTests.cs +++ b/src/libraries/System.Reflection.TypeExtensions/tests/PropertyInfoTests.cs @@ -33,6 +33,7 @@ public void SetValue_CantWrite_ThrowsArgumentException() } [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/15319", TargetFrameworkMonikers.Mono)] [InlineData(typeof(PI_BaseClass), nameof(PI_BaseClass.PublicGetPublicSetProperty), true, false, true, false)] [InlineData(typeof(PI_BaseClass), nameof(PI_BaseClass.PublicGetProperty1), true, false, false, false)] [InlineData(typeof(PI_BaseClass), nameof(PI_BaseClass.PublicSetProperty), false, false, true, false)] diff --git a/src/libraries/System.Reflection.TypeExtensions/tests/TypeTests.cs b/src/libraries/System.Reflection.TypeExtensions/tests/TypeTests.cs index ea5602d052b0c..bd0bd7b3668d8 100644 --- a/src/libraries/System.Reflection.TypeExtensions/tests/TypeTests.cs +++ b/src/libraries/System.Reflection.TypeExtensions/tests/TypeTests.cs @@ -329,6 +329,7 @@ public static IEnumerable GetMethods_TestData() } [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/15320", TargetFrameworkMonikers.Mono)] [MemberData(nameof(GetMethods_TestData))] public void GetMethods(Type type, BindingFlags bindingAttributes, string[] expectedNames) { diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 1c4cd0f28ab52..11869a0b3ea3d 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -274,30 +274,6 @@ # AssemblyLoadContext.SetProfileOptimizationRoot is no-op (not implemented) -nomethod System.Runtime.Tests.ProfileOptimizationTest.ProfileOptimization_CheckFileExists -#################################################################### -## System.Reflection.TypeExtensions.Tests -#################################################################### - -# Assertion difference. Expects 2, but got 1 -# https://github.com/mono/mono/issues/15316 --nomethod System.Reflection.Tests.ConstructorInfoInvokeArrayTests.Invoke_1DArrayConstructor - -# Exception difference -# https://github.com/mono/mono/issues/15317 --nomethod System.Reflection.Tests.ConstructorInfoTests.Invoke_Invalid - -# Large Array support -# https://github.com/mono/mono/issues/15318 --nomethod System.Reflection.Tests.ConstructorInfoInvokeArrayTests.Invoke_LargeDimensionalArrayConstructor - -# Throws a lot of different exceptions -# https://github.com/mono/mono/issues/15319 --nomethod System.Reflection.Tests.PropertyInfoTests.GetGetMethod_GetSetMethod - -# Extra methods -# https://github.com/mono/mono/issues/15320 --nomethod System.Reflection.Tests.TypeTests.GetMethods - #################################################################### ## System.Reflection.Emit.Lightweight.Tests #################################################################### From bab4de686e2397cd453da3dc8ba7d9742c9bafb8 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 28 Jan 2020 15:29:28 +0300 Subject: [PATCH 33/96] Move skipped System.Reflection.Emit.Lightweight.Tests with an active issue out of rsp file --- .../tests/DynamicILInfoTests.cs | 2 ++ .../tests/DynamicMethodGetILGenerator.cs | 2 ++ src/mono/netcore/CoreFX.issues.rsp | 11 ----------- 3 files changed, 4 insertions(+), 11 deletions(-) diff --git a/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicILInfoTests.cs b/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicILInfoTests.cs index ca77880b5004e..76e293728c323 100644 --- a/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicILInfoTests.cs +++ b/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicILInfoTests.cs @@ -184,6 +184,7 @@ private static int SumInteger() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15321", TargetFrameworkMonikers.Mono)] public void GetTokenFor_IntGenerics_Success() { DynamicMethod dynamicMethod = new DynamicMethod(nameof(SumInteger), typeof(int), new Type[] { }, typeof(DynamicILInfoTests), false); @@ -659,6 +660,7 @@ public unsafe void SetX_NullInput_ThrowsArgumentNullException(bool skipVisibilit } [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/15334", TargetFrameworkMonikers.Mono)] [InlineData(true)] [InlineData(false)] public unsafe void SetX_NegativeInputSize_ThrowsArgumentOutOfRangeException(bool skipVisibility) diff --git a/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicMethodGetILGenerator.cs b/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicMethodGetILGenerator.cs index d66c1e23f71c2..88d706d3b4e9f 100644 --- a/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicMethodGetILGenerator.cs +++ b/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicMethodGetILGenerator.cs @@ -29,6 +29,7 @@ public void GetILGenerator_Int_Owner(bool skipVisibility) } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15321", TargetFrameworkMonikers.Mono)] [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "The coreclr ignores the skipVisibility value of DynamicMethod.")] public void GetILGenerator_Int_Module_CoreclrIgnoresSkipVisibility() { @@ -73,6 +74,7 @@ public void GetILGenerator_Owner(bool skipVisibility) } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15321", TargetFrameworkMonikers.Mono)] [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "The coreclr ignores the skipVisibility value of DynamicMethod.")] public void GetILGenerator_Module_CoreclrIgnoresSkipVisibility() { diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 11869a0b3ea3d..9ad0d503d5e18 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -278,12 +278,6 @@ ## System.Reflection.Emit.Lightweight.Tests #################################################################### -# A different CreateDelegate issue -# https://github.com/mono/mono/issues/15321 --nomethod System.Reflection.Emit.Tests.DynamicMethodGetILGenerator1.GetILGenerator_Int_Module_CoreclrIgnoresSkipVisibility --nomethod System.Reflection.Emit.Tests.DynamicMethodGetILGenerator1.GetILGenerator_Module_CoreclrIgnoresSkipVisibility --nomethod System.Reflection.Emit.Tests.DynamicILInfoTests.GetTokenFor_IntGenerics_Success - # Need to implement System.Reflection.Emit.DynamicILInfo.SetLocalSignature(Byte[] localSignature) -nomethod System.Reflection.Emit.Tests.DynamicILInfoTests.Test_TwoDimTest -nomethod System.Reflection.Emit.Tests.DynamicILInfoTests.Test_GenericMethod @@ -298,11 +292,6 @@ -nomethod System.Reflection.Emit.Tests.DynamicILInfoTests.SetX_NullInput_ThrowsArgumentNullException -nomethod System.Reflection.Emit.Tests.DynamicMethodctor1.InvalidOwner_ThrowsArgumentException -# Expected: typeof(System.ArgumentOutOfRangeException) -# Actual: typeof(System.OverflowException): Arithmetic operation resulted in an overflow. -# https://github.com/mono/mono/issues/15334 --nomethod System.Reflection.Emit.Tests.DynamicILInfoTests.SetX_NegativeInputSize_ThrowsArgumentOutOfRangeException - #################################################################### ## System.Runtime.Loader.Tests #################################################################### From 90e0f05dc293da9c1bff76bb3f665f679878f91a Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 28 Jan 2020 16:34:13 +0300 Subject: [PATCH 34/96] Move skipped System.Reflection.MetadataLoadContext.Tests with an active issue out of rsp file --- .../Tests/CustomAttributes/DllImportTests.cs | 2 ++ .../tests/src/Tests/Parameter/ParameterTests.cs | 1 + .../tests/src/Tests/Type/TypeInvariants.cs | 1 + .../tests/src/Tests/Type/TypeTests.cs | 1 + .../TypeInfo_ImplementedInterfacesTests.cs | 3 +++ src/mono/netcore/CoreFX.issues.rsp | 17 ----------------- 6 files changed, 8 insertions(+), 17 deletions(-) diff --git a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/CustomAttributes/DllImportTests.cs b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/CustomAttributes/DllImportTests.cs index 3cefbb680be90..8d13e17532c11 100644 --- a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/CustomAttributes/DllImportTests.cs +++ b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/CustomAttributes/DllImportTests.cs @@ -14,6 +14,7 @@ namespace System.Reflection.Tests { public static partial class CustomAttributeTests { + [ActiveIssue("https://github.com/mono/mono/issues/15340", TargetFrameworkMonikers.Mono)] [Fact] public static void TestDllImportPseudoCustomAttribute() { @@ -47,6 +48,7 @@ private static void AssertEqual(DllImportAttribute d1, DllImportAttribute d2) } [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/15340", TargetFrameworkMonikers.Mono)] [MemberData(nameof(MarshalAsTheoryData))] public static void TestMarshalAsPseudoCustomAttribute(string fieldName, MarshalAsAttribute expected) { diff --git a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Parameter/ParameterTests.cs b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Parameter/ParameterTests.cs index 3e7242535044a..88920d44a563e 100644 --- a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Parameter/ParameterTests.cs +++ b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Parameter/ParameterTests.cs @@ -68,6 +68,7 @@ public static void TestRawDefaultValue6() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15340", TargetFrameworkMonikers.Mono)] public static void TestPseudoCustomAttributes() { MethodInfo m = typeof(ParametersWithPseudoCustomtAttributes).Project().GetTypeInfo().GetDeclaredMethod("Foo"); diff --git a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeInvariants.cs b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeInvariants.cs index 0cc5dd6a940c3..315b3e19c7c94 100644 --- a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeInvariants.cs +++ b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeInvariants.cs @@ -14,6 +14,7 @@ namespace System.Reflection.Tests public static class TypeInvariants { [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15344", TargetFrameworkMonikers.Mono)] public static void TestInvariantCode() { // These run some *runtime*-implemented Type objects through our invariant battery. diff --git a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeTests.cs b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeTests.cs index 1ae1a72f601b5..3a5fbdc07cbf9 100644 --- a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeTests.cs +++ b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeTests.cs @@ -481,6 +481,7 @@ public static void TestComImportPseudoCustomAttribute() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15340", TargetFrameworkMonikers.Mono)] public static void TestExplicitOffsetPseudoCustomAttribute() { Type t = typeof(ExplicitFieldOffsets).Project(); diff --git a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/TypeInfoFromProjectN/TypeInfo_ImplementedInterfacesTests.cs b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/TypeInfoFromProjectN/TypeInfo_ImplementedInterfacesTests.cs index 1d7a115427732..4c3820e769d01 100644 --- a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/TypeInfoFromProjectN/TypeInfo_ImplementedInterfacesTests.cs +++ b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/TypeInfoFromProjectN/TypeInfo_ImplementedInterfacesTests.cs @@ -32,6 +32,7 @@ public static void TestInterFaces3() // Verify implemented interfaces [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/18294", TargetFrameworkMonikers.Mono)] public static void TestInterFaces4() { VerifyInterfaces(typeof(D1).Project(), new Type[] { typeof(ImI1).Project(), typeof(I0).Project(), typeof(I21).Project() }); @@ -39,6 +40,7 @@ public static void TestInterFaces4() // Verify implemented interfaces [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/18294", TargetFrameworkMonikers.Mono)] public static void TestInterFaces5() { VerifyInterfaces(typeof(D2<>).Project(), new Type[] { typeof(ImI1).Project(), typeof(I0).Project(), typeof(I21).Project() }); @@ -46,6 +48,7 @@ public static void TestInterFaces5() // Verify implemented interfaces [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/18294", TargetFrameworkMonikers.Mono)] public static void TestInterFaces6() { VerifyInterfaces(typeof(D2).Project(), new Type[] { typeof(ImI1).Project(), typeof(I0).Project(), typeof(I21).Project() }); diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 9ad0d503d5e18..893630b4a6549 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -319,23 +319,6 @@ -nomethod System.Runtime.Loader.Tests.AssemblyLoadContextTest.LoadAssemblyByStream_ValidUserAssembly -nomethod System.Runtime.Loader.Tests.AssemblyLoadContextTest.LoadFromAssemblyName_ValidTrustedPlatformAssembly -#################################################################### -## System.Reflection.MetadataLoadContext.Tests -#################################################################### - -# https://github.com/mono/mono/issues/15340 --nomethod System.Reflection.Tests.CustomAttributeTests.TestDllImportPseudoCustomAttribute --nomethod System.Reflection.Tests.CustomAttributeTests.TestMarshalAsPseudoCustomAttribute --nomethod System.Reflection.Tests.ParameterTests.TestPseudoCustomAttributes --nomethod System.Reflection.Tests.TypeTests.TestExplicitOffsetPseudoCustomAttribute - -# Assertion failure: Expected: true, Actual: false -# https://github.com/mono/mono/issues/15344 --nomethod System.Reflection.Tests.TypeInvariants.TestInvariantCode - -# flaky tests --nomethod System.Reflection.Tests.TypeInfoDeclaredImplementedInterfacesTests.* - #################################################################### ## System.Utf8String.Experimental.Tests #################################################################### From 8fc9fc84a73f214dc70e9ff52ed6fe5555c8cf91 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 28 Jan 2020 16:51:13 +0300 Subject: [PATCH 35/96] Move skipped System.Xml.Xsl.XslTransformApi.Tests with an active issue out of rsp file --- .../tests/Xslt/XslTransformApi/CXslTransform.cs | 2 ++ src/mono/netcore/CoreFX.issues.rsp | 9 --------- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/src/libraries/System.Private.Xml/tests/Xslt/XslTransformApi/CXslTransform.cs b/src/libraries/System.Private.Xml/tests/Xslt/XslTransformApi/CXslTransform.cs index 027f55762a7ae..829e8d25b3b54 100644 --- a/src/libraries/System.Private.Xml/tests/Xslt/XslTransformApi/CXslTransform.cs +++ b/src/libraries/System.Private.Xml/tests/Xslt/XslTransformApi/CXslTransform.cs @@ -474,6 +474,7 @@ public void TC_Xslt_Document_Function_Use_XmlUrlResolver(InputType inputType, Re [InlineData(InputType.Navigator, ReaderType.XmlValidatingReader, TransformType.Stream, DocType.XPathDocument)] [InlineData(InputType.Navigator, ReaderType.XmlValidatingReader, TransformType.TextWriter, DocType.XPathDocument)] [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/15353", TargetFrameworkMonikers.Mono)] public void TC_AbsolutePath_Transform(InputType inputType, ReaderType readerType, TransformType transformType, DocType docType) { TestUsingTemporaryCopyOfResolverDocument(() => @@ -2097,6 +2098,7 @@ public void TC_Xslt_Document_Function_Use_XmlUrlResolver(InputType inputType, Re [InlineData(InputType.Navigator, ReaderType.XmlValidatingReader, TransformType.Stream, DocType.XPathDocument)] [InlineData(InputType.Navigator, ReaderType.XmlValidatingReader, TransformType.TextWriter, DocType.XPathDocument)] [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/15353", TargetFrameworkMonikers.Mono)] public void TC_AbsolutePath_Transform(InputType inputType, ReaderType readerType, TransformType transformType, DocType docType) { TestUsingTemporaryCopyOfResolverDocument(() => diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 893630b4a6549..2f668bd67889b 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -359,15 +359,6 @@ -nomethod System.ComponentModel.Composition.Registration.Tests.PartBuilderInterfaceTests.* -nomethod System.ComponentModel.Composition.Registration.Tests.ExportInterfacesContractExclusionTests.* -#################################################################### -## System.Xml.Xsl.XslTransformApi.Tests -#################################################################### - -# Xml differences... Looks like the parsing isn't working -# https://github.com/mono/mono/issues/15353 --nomethod System.Xml.Tests.CXmlResolverTest.TC_AbsolutePath_Transform --nomethod System.Xml.Tests.CTransformResolverTest.TC_AbsolutePath_Transform - #################################################################### ## System.Security.Cryptography.X509Certificates.Tests #################################################################### From fc5784fd19407ae24814a379b18a1e7875e84904 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 28 Jan 2020 17:10:46 +0300 Subject: [PATCH 36/96] Move skipped System.Security.Cryptography.Encoding.Tests with an active issue out of rsp file --- .../System.Security.Cryptography.Encoding/tests/Oid.cs | 4 ++++ src/mono/netcore/CoreFX.issues.rsp | 6 ------ 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/libraries/System.Security.Cryptography.Encoding/tests/Oid.cs b/src/libraries/System.Security.Cryptography.Encoding/tests/Oid.cs index 3f908a29a481d..e22dc3aa26b35 100644 --- a/src/libraries/System.Security.Cryptography.Encoding/tests/Oid.cs +++ b/src/libraries/System.Security.Cryptography.Encoding/tests/Oid.cs @@ -23,6 +23,7 @@ public static void EmptyOid() } [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/16686", TargetFrameworkMonikers.Mono)] [MemberData(nameof(ValidOidFriendlyNamePairs))] public static void LookupOidByValue_Ctor(string oidValue, string friendlyName) { @@ -33,6 +34,7 @@ public static void LookupOidByValue_Ctor(string oidValue, string friendlyName) } [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/16686", TargetFrameworkMonikers.Mono)] [MemberData(nameof(ValidOidFriendlyNamePairs))] public static void LookupOidByFriendlyName_Ctor(string oidValue, string friendlyName) { @@ -68,6 +70,7 @@ public static void Oid_StringString_BothNull() } [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/16686", TargetFrameworkMonikers.Mono)] [MemberData(nameof(ValidOidFriendlyNamePairs))] public static void Oid_StringString_NullFriendlyName(string oidValue, string expectedFriendlyName) { @@ -223,6 +226,7 @@ public static void LookupOidByFriendlyName_Method_EncryptionAlgorithm(string oid } [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/16686", TargetFrameworkMonikers.Mono)] [MemberData(nameof(ValidOidFriendlyNamePairs))] public static void LookupOidByFriendlyName_Method_InverseCase(string oidValue, string friendlyName) { diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 2f668bd67889b..d8de4b65f0405 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -395,10 +395,4 @@ ## System.Security.Cryptography.Encoding.Tests #################################################################### -# Broken array copying (https://github.com/mono/mono/issues/16686) --nomethod System.Security.Cryptography.Encoding.Tests.OidTests.LookupOidByFriendlyName_Method_InverseCase --nomethod System.Security.Cryptography.Encoding.Tests.OidTests.LookupOidByValue_Ctor --nomethod System.Security.Cryptography.Encoding.Tests.OidTests.Oid_StringString_NullFriendlyName --nomethod System.Security.Cryptography.Encoding.Tests.OidTests.LookupOidByFriendlyName_Ctor - -nomethod System.Tests.StringComparerTests.CreateCultureOptions_InvalidArguments_Throws From 3d0e18f4f59304688ba66ff98bad2888f4cc73a4 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Wed, 29 Jan 2020 13:05:11 +0300 Subject: [PATCH 37/96] Move System.Drawing.Imaging.Tests.ImageAttributesTests.SetColorMatrix_InvalidFlags_ThrowsArgumentException out of rsp file --- src/mono/netcore/CoreFX.issues.rsp | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index d8de4b65f0405..d17b721499241 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -5,13 +5,6 @@ -notrait category=failing -notrait category=IgnoreForCI -#################################################################### -## System.Drawing.Common.Tests -#################################################################### - -# System.ArgumentException Arg_ObjObjEx --nomethod System.Drawing.Imaging.Tests.ImageAttributesTests.SetColorMatrix_InvalidFlags_ThrowsArgumentException - #################################################################### ## System.Net.Http.Functional.Tests #################################################################### From 110dd50ba5c624f5db0d149190d836ec9ad517a5 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Wed, 29 Jan 2020 15:02:52 +0300 Subject: [PATCH 38/96] Add an active issue attribute to System.Drawing.Imaging.Tests.ImageAttributesTests.SetColorMatrix_InvalidFlags_ThrowsArgumentException test; add a comment about libgdiplus dependency to PlatformDetection.IsDrawingSupported method. --- .../CoreFx.Private.TestUtilities/System/PlatformDetection.cs | 2 ++ .../System.Drawing.Common/tests/Imaging/ImageAttributesTests.cs | 1 + 2 files changed, 3 insertions(+) diff --git a/src/libraries/Common/tests/CoreFx.Private.TestUtilities/System/PlatformDetection.cs b/src/libraries/Common/tests/CoreFx.Private.TestUtilities/System/PlatformDetection.cs index c5d4184533aab..7b0df3581c16a 100644 --- a/src/libraries/Common/tests/CoreFx.Private.TestUtilities/System/PlatformDetection.cs +++ b/src/libraries/Common/tests/CoreFx.Private.TestUtilities/System/PlatformDetection.cs @@ -33,6 +33,8 @@ public static partial class PlatformDetection public static bool IsArgIteratorNotSupported => !IsArgIteratorSupported; public static bool Is32BitProcess => IntPtr.Size == 4; + // Please make sure that you have the libgdiplus dependency installed. + // For details, see https://docs.microsoft.com/dotnet/core/install/dependencies?pivots=os-macos&tabs=netcore31#libgdiplus public static bool IsDrawingSupported { get diff --git a/src/libraries/System.Drawing.Common/tests/Imaging/ImageAttributesTests.cs b/src/libraries/System.Drawing.Common/tests/Imaging/ImageAttributesTests.cs index 1e45c9d89a7dc..aff8564c54bf3 100644 --- a/src/libraries/System.Drawing.Common/tests/Imaging/ImageAttributesTests.cs +++ b/src/libraries/System.Drawing.Common/tests/Imaging/ImageAttributesTests.cs @@ -282,6 +282,7 @@ public static IEnumerable ColorMatrixFlag_InvalidFlags_TestData() [ConditionalTheory(Helpers.IsDrawingSupported)] [MemberData(nameof(ColorAdjustType_InvalidTypes_TestData))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2337", TargetFrameworkMonikers.Mono)] public void SetColorMatrix_InvalidFlags_ThrowsArgumentException(ColorMatrixFlag flag) { using (var imageAttr = new ImageAttributes()) From 9c845ef4dd7d41ec626eeab7d164a585d5b8166b Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Wed, 29 Jan 2020 16:17:43 +0300 Subject: [PATCH 39/96] Move System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_ClientCertificates_Test.AutomaticOrManual_DoesntFailRegardlessOfWhetherClientCertsAreAvailable out of rsp because it has an active corefx issue; see https://github.com/dotnet/corefx/issues/37336 --- src/mono/netcore/CoreFX.issues.rsp | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index d17b721499241..5c2909b28ebcf 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -13,9 +13,6 @@ # NOTE: KEEPING THIS HERE BUT COMMENTED OUT - in the event the UI is shown (wasn't for me) #-nomethod System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_DangerousAcceptAllCertificatesValidator_Test.SetDelegate_ConnectionSucceeds -# When test is run, xunit claims it's not a part of the test suite -#-nomethod System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_ClientCertificates_Test.AutomaticOrManual_DoesntFailRegardlessOfWhetherClientCertsAreAvailable - #################################################################### ## System.Reflection.Emit.ILGeneration.Tests #################################################################### From 5b9f525525b29cffda919d5b0cf136d87333a872 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Wed, 29 Jan 2020 16:35:24 +0300 Subject: [PATCH 40/96] Remove System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_DangerousAcceptAllCertificatesValidator_Test.SetDelegate_ConnectionSucceeds from rsp because it's already disabled as part of system.net.* tests; see https://github.com/dotnet/runtime/pull/2318 --- src/mono/netcore/CoreFX.issues.rsp | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 5c2909b28ebcf..db39a976294c1 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -5,14 +5,6 @@ -notrait category=failing -notrait category=IgnoreForCI -#################################################################### -## System.Net.Http.Functional.Tests -#################################################################### - -# Works, but may trigger UI! -# NOTE: KEEPING THIS HERE BUT COMMENTED OUT - in the event the UI is shown (wasn't for me) -#-nomethod System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_DangerousAcceptAllCertificatesValidator_Test.SetDelegate_ConnectionSucceeds - #################################################################### ## System.Reflection.Emit.ILGeneration.Tests #################################################################### From 798166e8ef84fcd98c63766cb414847101e06f08 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Thu, 30 Jan 2020 13:34:09 +0300 Subject: [PATCH 41/96] Move skipped System.Reflection.Emit.ILGeneration.Tests with an active issue out of rsp file --- .../tests/CustomAttributeBuilderTests.cs | 26 +++++++++++++++++++ .../tests/ILGenerator/DeclareLocalTests.cs | 2 ++ .../tests/ILGenerator/Emit2Tests.cs | 2 ++ .../tests/ILGenerator/Emit3Tests.cs | 1 + .../tests/ILGenerator/Emit4Tests.cs | 1 + .../SetCustomAttributeTests.cs | 1 + .../SignatureHelperAddArgument.cs | 5 ++++ .../SignatureHelperAddArguments.cs | 5 ++++ .../SignatureHelperGetMethodSigHelper.cs | 4 +++ .../SignatureHelperGetPropertySigHelper.cs | 6 +++++ src/mono/netcore/CoreFX.issues.rsp | 25 ------------------ 11 files changed, 53 insertions(+), 25 deletions(-) diff --git a/src/libraries/System.Reflection.Emit.ILGeneration/tests/CustomAttributeBuilderTests.cs b/src/libraries/System.Reflection.Emit.ILGeneration/tests/CustomAttributeBuilderTests.cs index 9a5cb69a63785..cdd908505ceb9 100644 --- a/src/libraries/System.Reflection.Emit.ILGeneration/tests/CustomAttributeBuilderTests.cs +++ b/src/libraries/System.Reflection.Emit.ILGeneration/tests/CustomAttributeBuilderTests.cs @@ -256,6 +256,7 @@ private static void VerifyCustomAttributeBuilder(CustomAttributeBuilder builder, } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public static void Ctor_AllPrimitives() { ConstructorInfo con = typeof(Primitives).GetConstructors()[0]; @@ -451,6 +452,7 @@ public static IEnumerable Ctor_RefEmitParameters_TestData() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] [MemberData(nameof(Ctor_RefEmitParameters_TestData))] public static void Ctor_RefEmitParameters(ConstructorInfo con, object[] constructorArgs, PropertyInfo[] namedProperties, object[] propertyValues, @@ -466,6 +468,7 @@ public static void Ctor_RefEmitParameters(ConstructorInfo con, object[] construc } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] [InlineData(nameof(TestAttribute.ReadonlyField))] [InlineData(nameof(TestAttribute.StaticField))] [InlineData(nameof(TestAttribute.StaticReadonlyField))] @@ -499,6 +502,7 @@ public void NamedProperties_StaticProperty_Works() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] [InlineData(typeof(PrivateAttribute))] [InlineData(typeof(NotAnAttribute))] public static void ClassNotSupportedAsAttribute_DoesNotThrow_DoesNotSet(Type type) @@ -544,6 +548,7 @@ public static void PrivateConstructor_ThrowsArgumentException() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] [InlineData(CallingConventions.Any)] [InlineData(CallingConventions.VarArgs)] public static void ConstructorHasNonStandardCallingConvention_ThrowsArgumentException(CallingConventions callingConvention) @@ -645,6 +650,7 @@ public static IEnumerable InvalidAttributeTypes_TestData() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "Coreclr fixed an issue where IntPtr/UIntPtr in constructorParameters causes a corrupt created binary.")] [MemberData(nameof(IntPtrAttributeTypes_TestData))] public void ConstructorParametersContainsIntPtrOrUIntPtrArgument_ThrowsArgumentException(Type type, object value) @@ -653,6 +659,7 @@ public void ConstructorParametersContainsIntPtrOrUIntPtrArgument_ThrowsArgumentE } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] [MemberData(nameof(InvalidAttributeTypes_TestData))] public void ConstructorParametersNotSupportedInAttributes_ThrowsArgumentException(Type type, object value) { @@ -667,6 +674,7 @@ public void ConstructorParametersNotSupportedInAttributes_ThrowsArgumentExceptio } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "Used to throw a NullReferenceException, see https://github.com/dotnet/corefx/issues/11702.")] public void NullValueForPrimitiveTypeInConstructorArgs_ThrowsArgumentNullException() { @@ -686,6 +694,7 @@ public static IEnumerable NotSupportedPrimitives_TestData() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "Coreclr fixed an issue where IntPtr/UIntPtr in constructorArgs causes a corrupt created binary.")] [MemberData(nameof(NotSupportedPrimitives_TestData))] public static void NotSupportedPrimitiveInConstructorArgs_ThrowsArgumentException(object value) @@ -700,6 +709,7 @@ public static void NotSupportedPrimitiveInConstructorArgs_ThrowsArgumentExceptio } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public static void DynamicTypeInConstructorArgs_ThrowsFileNotFoundExceptionOnCreation() { AssemblyBuilder assembly = Helpers.DynamicAssembly(); @@ -746,6 +756,7 @@ public static IEnumerable FieldDoesntBelongToConstructorDeclaringType_ } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] [MemberData(nameof(FieldDoesntBelongToConstructorDeclaringType_TestData))] public void NamedFields_FieldDoesntBelongToConstructorDeclaringType_ThrowsArgumentException(ConstructorInfo con, FieldInfo field) { @@ -756,6 +767,7 @@ public void NamedFields_FieldDoesntBelongToConstructorDeclaringType_ThrowsArgume } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public void NamedFields_ContainsConstField_ThrowsArgumentException() { ConstructorInfo con = typeof(TestAttribute).GetConstructor(new Type[0]); @@ -781,6 +793,7 @@ public static void NullFieldValues_ThrowsArgumentNullException() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public static void NullObjectInNamedFields_ThrowsArgumentNullException() { ConstructorInfo con = typeof(TestAttribute).GetConstructor(new Type[0]); @@ -791,6 +804,7 @@ public static void NullObjectInNamedFields_ThrowsArgumentNullException() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public static void NullObjectInFieldValues_ThrowsArgumentNullException() { ConstructorInfo con = typeof(TestAttribute).GetConstructor(new Type[0]); @@ -802,6 +816,7 @@ public static void NullObjectInFieldValues_ThrowsArgumentNullException() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] [MemberData(nameof(NotSupportedObject_Others_TestData))] public static void NotSupportedObjectInFieldValues_ThrowsArgumentException(object value) { @@ -814,6 +829,7 @@ public static void NotSupportedObjectInFieldValues_ThrowsArgumentException(objec } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public static void ZeroCountMultidimensionalArrayInFieldValues_ChangesToZeroCountJaggedArray() { ConstructorInfo con = typeof(TestAttribute).GetConstructor(new Type[0]); @@ -831,6 +847,7 @@ public static void ZeroCountMultidimensionalArrayInFieldValues_ChangesToZeroCoun } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] [MemberData(nameof(NotSupportedPrimitives_TestData))] [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "Coreclr fixed an issue where IntPtr/UIntPtr in fieldValues causes a corrupt created binary.")] public static void NotSupportedPrimitiveInFieldValues_ThrowsArgumentException(object value) @@ -847,6 +864,7 @@ public static void NotSupportedPrimitiveInFieldValues_ThrowsArgumentException(ob } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public static void DynamicTypeInPropertyValues_ThrowsFileNotFoundExceptionOnCreation() { AssemblyBuilder assembly = Helpers.DynamicAssembly(); @@ -894,6 +912,7 @@ public static void NullPropertyValues_ThrowsArgumentNullException() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public static void NullObjectInNamedProperties_ThrowsArgumentNullException() { ConstructorInfo con = typeof(TestAttribute).GetConstructor(new Type[0]); @@ -904,6 +923,7 @@ public static void NullObjectInNamedProperties_ThrowsArgumentNullException() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public static void IndexerInNamedProperties_ThrowsCustomAttributeFormatExceptionOnCreation() { ConstructorInfo con = typeof(IndexerAttribute).GetConstructor(new Type[0]); @@ -943,6 +963,7 @@ public static IEnumerable PropertyDoesntBelongToConstructorDeclaringTy } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] [MemberData(nameof(PropertyDoesntBelongToConstructorDeclaringType_TestData))] public void NamedProperties_PropertyDoesntBelongToConstructorDeclaringType_ThrowsArgumentException(ConstructorInfo con, PropertyInfo property) { @@ -953,6 +974,7 @@ public void NamedProperties_PropertyDoesntBelongToConstructorDeclaringType_Throw } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public static void NullObjectInPropertyValues_ThrowsArgumentNullException() { ConstructorInfo con = typeof(TestAttribute).GetConstructor(new Type[0]); @@ -964,6 +986,7 @@ public static void NullObjectInPropertyValues_ThrowsArgumentNullException() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] [MemberData(nameof(NotSupportedObject_Others_TestData))] public static void NotSupportedObjectInPropertyValues_ThrowsArgumentException(object value) { @@ -976,6 +999,7 @@ public static void NotSupportedObjectInPropertyValues_ThrowsArgumentException(ob } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public static void ZeroCountMultidimensionalArrayInPropertyValues_ChangesToZeroCountJaggedArray() { ConstructorInfo con = typeof(TestAttribute).GetConstructor(new Type[0]); @@ -993,6 +1017,7 @@ public static void ZeroCountMultidimensionalArrayInPropertyValues_ChangesToZeroC } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] [MemberData(nameof(NotSupportedPrimitives_TestData))] [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "Coreclr fixed an issue where IntPtr/UIntPtr in propertValues causes a corrupt created binary.")] public static void NotSupportedPrimitiveInPropertyValues_ThrowsArgumentException(object value) @@ -1006,6 +1031,7 @@ public static void NotSupportedPrimitiveInPropertyValues_ThrowsArgumentException } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public static void DynamicTypeInFieldValues_ThrowsFileNotFoundExceptionOnCreation() { AssemblyBuilder assembly = Helpers.DynamicAssembly(); diff --git a/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/DeclareLocalTests.cs b/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/DeclareLocalTests.cs index 7006bebed11d3..0b94ebc4f5789 100644 --- a/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/DeclareLocalTests.cs +++ b/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/DeclareLocalTests.cs @@ -95,6 +95,7 @@ public void DeclareLocal_NullLocalType_ThrowsArgumentNullException() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public void DeclareLocal_TypeCreated_ThrowsInvalidOperationException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.NotPublic); @@ -107,6 +108,7 @@ public void DeclareLocal_TypeCreated_ThrowsInvalidOperationException() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public void DeclareLocal_GlobalFunctionsCreated_ThrowsInvalidOperationException() { ModuleBuilder module = Helpers.DynamicModule(); diff --git a/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit2Tests.cs b/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit2Tests.cs index a98de1f875274..df94573ce5889 100644 --- a/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit2Tests.cs +++ b/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit2Tests.cs @@ -147,6 +147,7 @@ public void Emit_OpCodes_LocalBuilder_NullLocal_ThrowsArgumentNullException() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public void Emit_OpCodes_LocalBuilder_LocalFromDifferentMethod_ThrowsArgumentException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.NotPublic); @@ -159,6 +160,7 @@ public void Emit_OpCodes_LocalBuilder_LocalFromDifferentMethod_ThrowsArgumentExc } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public void Emit_OpCodes_LocalBuilder_TooManyLocals_ThrowsInvalidOperationException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.NotPublic); diff --git a/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit3Tests.cs b/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit3Tests.cs index ab8b8e771b1cb..bb908ddb04793 100644 --- a/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit3Tests.cs +++ b/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit3Tests.cs @@ -223,6 +223,7 @@ public void Emit_OpCodes_LocalBuilder_NullLocal_ThrowsArgumentNullException() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public void Emit_OpCodes_LocalBuilder_LocalFromDifferentMethod_ThrowsArgumentException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.NotPublic); diff --git a/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit4Tests.cs b/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit4Tests.cs index 3002a335f92c7..f3606b81676c1 100644 --- a/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit4Tests.cs +++ b/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit4Tests.cs @@ -74,6 +74,7 @@ public void TestDynamicMethodEmitCalliBlittable() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public void TestEmitCalliNonBlittable() { string input = "Test string!", result = "!gnirts tseT"; diff --git a/src/libraries/System.Reflection.Emit.ILGeneration/tests/ParameterBuilder/SetCustomAttributeTests.cs b/src/libraries/System.Reflection.Emit.ILGeneration/tests/ParameterBuilder/SetCustomAttributeTests.cs index 847ffb87ab2c4..6208e01a81e09 100644 --- a/src/libraries/System.Reflection.Emit.ILGeneration/tests/ParameterBuilder/SetCustomAttributeTests.cs +++ b/src/libraries/System.Reflection.Emit.ILGeneration/tests/ParameterBuilder/SetCustomAttributeTests.cs @@ -59,6 +59,7 @@ public void SetCustomAttribute_ConstructorInfo_ByteArray() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public void SetCustomAttribute_NullArgument_ThrowsArgumentNullException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.NotPublic); diff --git a/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperAddArgument.cs b/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperAddArgument.cs index 54364074f2312..6bb7369c88902 100644 --- a/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperAddArgument.cs +++ b/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperAddArgument.cs @@ -19,6 +19,7 @@ public void AddArgument_Type() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] [InlineData(true, 3)] [InlineData(false, 2)] public void AddArgument_Type_Bool(bool pinned, int expectedLength) @@ -31,6 +32,7 @@ public void AddArgument_Type_Bool(bool pinned, int expectedLength) } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] [InlineData(null, null, 2)] [InlineData(new Type[] { typeof(int) }, null, 4)] [InlineData(null, new Type[] { typeof(Type) }, 4)] @@ -45,6 +47,7 @@ public void AddArgument_Type_TypeArray_TypeArray(Type[] requiredCustomModifiers, } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public void AddArgument_NullType_ThrowsArgumentNullException() { ModuleBuilder module = Helpers.DynamicModule(); @@ -56,6 +59,7 @@ public void AddArgument_NullType_ThrowsArgumentNullException() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public void AddArgument_SignatureFinished_ThrowsArgumentException() { ModuleBuilder module = Helpers.DynamicModule(); @@ -67,6 +71,7 @@ public void AddArgument_SignatureFinished_ThrowsArgumentException() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public void AddArgument_DifferentCountsForCustomModifiers_ThrowsArgumentException() { ModuleBuilder module = Helpers.DynamicModule(); diff --git a/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperAddArguments.cs b/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperAddArguments.cs index c1f801f05b13e..6f97c120f724e 100644 --- a/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperAddArguments.cs +++ b/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperAddArguments.cs @@ -18,6 +18,7 @@ public static IEnumerable AddArguments_TestData() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] [MemberData(nameof(AddArguments_TestData))] public void AddArguments(Type[][] requiredCustomModifiers, Type[][] optionalCustomModifiers, int expectedLength) { @@ -38,6 +39,7 @@ public void AddArguments_NullObjectInTypeArguments_ThrowsArgumentNullException() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public void AddArguments_SignatureFinished_ThrowsArgumentException() { ModuleBuilder module = Helpers.DynamicModule(); @@ -48,6 +50,7 @@ public void AddArguments_SignatureFinished_ThrowsArgumentException() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public void AddArgument_NullObjectInRequiredCustomModifiers_ThrowsArgumentNullException() { ModuleBuilder module = Helpers.DynamicModule(); @@ -57,6 +60,7 @@ public void AddArgument_NullObjectInRequiredCustomModifiers_ThrowsArgumentNullEx } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public void AddArgument_DifferentCountsForCustomModifiers_ThrowsArgumentException() { ModuleBuilder module = Helpers.DynamicModule(); @@ -70,6 +74,7 @@ public void AddArgument_DifferentCountsForCustomModifiers_ThrowsArgumentExceptio } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public void AddArgument_NullObjectInOptionalCustomModifiers_ThrowsArgumentNullException() { ModuleBuilder module = Helpers.DynamicModule(); diff --git a/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperGetMethodSigHelper.cs b/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperGetMethodSigHelper.cs index 11f24545fe2e3..d1daaf1ba3d4e 100644 --- a/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperGetMethodSigHelper.cs +++ b/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperGetMethodSigHelper.cs @@ -9,6 +9,7 @@ namespace System.Reflection.Emit.Tests public class SignatureHelperGetMethodSigHelper { [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] [InlineData(CallingConventions.Any, typeof(int))] [InlineData(CallingConventions.ExplicitThis, typeof(string))] [InlineData(CallingConventions.HasThis, typeof(string))] @@ -21,6 +22,7 @@ public void GetMethodSigHelper_CallingConventions_Type_Length_ReturnsThree(Calli } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] [InlineData(CallingConventions.Any, typeof(int))] [InlineData(CallingConventions.ExplicitThis, typeof(string))] [InlineData(CallingConventions.HasThis, typeof(string))] @@ -37,6 +39,7 @@ public void GetMethodSigHelper_Module_CallingConventions_Type_Length_ReturnsThre } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public void GetMethodSigHelper_Module_Type_TypeArray() { ModuleBuilder module = Helpers.DynamicModule(); @@ -48,6 +51,7 @@ public void GetMethodSigHelper_Module_Type_TypeArray() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public void GetMethodSigHelper_Module_Type_TypeArray_NullObjectInParameterType_ThrowsArgumentNullException() { ModuleBuilder module = Helpers.DynamicModule(); diff --git a/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperGetPropertySigHelper.cs b/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperGetPropertySigHelper.cs index 3ff99ca22a23c..6e4f3ce77ddaf 100644 --- a/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperGetPropertySigHelper.cs +++ b/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperGetPropertySigHelper.cs @@ -10,6 +10,7 @@ namespace System.Reflection.Emit.Tests public class SignatureHelperGetPropertySigHelper { [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] [InlineData(typeof(string), new Type[] { typeof(Delegate), typeof(int) }, 6)] [InlineData(typeof(Type), new Type[] { typeof(char), typeof(object) }, 6)] public void GetPropertySigHelper_Module_Type_TypeArray(Type returnType, Type[] parameterTypes, int expectedLength) @@ -20,6 +21,7 @@ public void GetPropertySigHelper_Module_Type_TypeArray(Type returnType, Type[] p } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public void GetPropertySigHelper_Module_Type_TypeArray_NullModule_DoesNotThrow() { SignatureHelper helper = SignatureHelper.GetPropertySigHelper(null, typeof(string), new Type[] { typeof(string), typeof(int) }); @@ -27,6 +29,7 @@ public void GetPropertySigHelper_Module_Type_TypeArray_NullModule_DoesNotThrow() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public void GetPropertySigHelper_Module_Type_TypeArray_NullObjectInParameterTypes_ThrowsArgumentNullException() { ModuleBuilder module = Helpers.DynamicModule(); @@ -41,6 +44,7 @@ public static IEnumerable GetPropertySigHelper_TestData() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] [MemberData(nameof(GetPropertySigHelper_TestData))] public void GetProperySigHelper_Module_Type_TypeArray_TypeArray_TypeArrayArray_TypeArrayArray(Type[] types, int expectedLength) { @@ -52,6 +56,7 @@ public void GetProperySigHelper_Module_Type_TypeArray_TypeArray_TypeArrayArray_T } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public void GetPropertySigHelper_NullModule_ThrowsNullReferenceException() { Type[] types = new Type[] { typeof(short), typeof(bool) }; @@ -62,6 +67,7 @@ public void GetPropertySigHelper_NullModule_ThrowsNullReferenceException() [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] public void GetPropertySigHelper_NullTypeInParameterTypes_ThrowsArgumentNullException() { Type[] types = new Type[] { typeof(short), null }; diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index db39a976294c1..955847b82f576 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -5,31 +5,6 @@ -notrait category=failing -notrait category=IgnoreForCI -#################################################################### -## System.Reflection.Emit.ILGeneration.Tests -#################################################################### - -# System.Reflection implementation to do. --noclass System.Reflection.Emit.Tests.CustomAttributeBuilderTests --nomethod System.Reflection.Emit.Tests.SignatureHelperAddArgument.* --nomethod System.Reflection.Emit.Tests.SignatureHelperGetPropertySigHelper.* --nomethod System.Reflection.Emit.Tests.ILGeneratorEmit3.Emit_OpCodes_LocalBuilder_LocalFromDifferentMethod_ThrowsArgumentException --nomethod System.Reflection.Emit.Tests.ILGeneratorDeclareLocal.DeclareLocal_TypeCreated_ThrowsInvalidOperationException --nomethod System.Reflection.Emit.Tests.ILGeneratorDeclareLocal.DeclareLocal_GlobalFunctionsCreated_ThrowsInvalidOperationException --nomethod System.Reflection.Emit.Tests.SignatureHelperGetMethodSigHelper.GetMethodSigHelper_Module_CallingConventions_Type_Length_ReturnsThree --nomethod System.Reflection.Emit.Tests.SignatureHelperGetMethodSigHelper.GetMethodSigHelper_Module_Type_TypeArray --nomethod System.Reflection.Emit.Tests.SignatureHelperGetMethodSigHelper.GetMethodSigHelper_CallingConventions_Type_Length_ReturnsThree --nomethod System.Reflection.Emit.Tests.SignatureHelperGetMethodSigHelper.GetMethodSigHelper_Module_Type_TypeArray_NullObjectInParameterType_ThrowsArgumentNullException --nomethod System.Reflection.Emit.Tests.ILGeneratorEmit2.Emit_OpCodes_LocalBuilder_TooManyLocals_ThrowsInvalidOperationException --nomethod System.Reflection.Emit.Tests.ILGeneratorEmit2.Emit_OpCodes_LocalBuilder_LocalFromDifferentMethod_ThrowsArgumentException --nomethod System.Reflection.Emit.Tests.SetCustomAttributeTests.SetCustomAttribute_NullArgument_ThrowsArgumentNullException --nomethod System.Reflection.Emit.Tests.ILGeneratorEmit4.TestEmitCalliNonBlittable --nomethod System.Reflection.Emit.Tests.SignatureHelperAddArguments.AddArgument_NullObjectInRequiredCustomModifiers_ThrowsArgumentNullException --nomethod System.Reflection.Emit.Tests.SignatureHelperAddArguments.AddArgument_NullObjectInOptionalCustomModifiers_ThrowsArgumentNullException --nomethod System.Reflection.Emit.Tests.SignatureHelperAddArguments.AddArgument_DifferentCountsForCustomModifiers_ThrowsArgumentException --nomethod System.Reflection.Emit.Tests.SignatureHelperAddArguments.AddArguments_SignatureFinished_ThrowsArgumentException --nomethod System.Reflection.Emit.Tests.SignatureHelperAddArguments.AddArguments - #################################################################### ## System.Reflection.Emit.Tests #################################################################### From 5bb95df228a1c70f7a5ace5b3a6dca944193bb63 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Thu, 30 Jan 2020 18:34:41 +0300 Subject: [PATCH 42/96] Move skipped System.Reflection.Emit.Tests with an active issue out of rsp file --- .../tests/AssemblyBuilderTests.cs | 3 + .../ConstructorBuilderToString.cs | 2 + .../EnumBuilder/EnumBuilder.Methods.Tests.cs | 4 + .../EnumBuilder.Properties.Tests.cs | 1 + .../FieldBuilder/FieldBuilderSetConstant.cs | 1 + ...ParameterBuilderSetInterfaceConstraints.cs | 2 + .../MethodBuilderDefineGenericParameters.cs | 4 + .../MethodBuilder/MethodBuilderEquals.cs | 1 + .../MethodBuilderGetGenericArguments.cs | 1 + .../MethodBuilderGetILGenerator.cs | 1 + .../MethodBuilderMakeGenericMethod.cs | 3 + .../MethodBuilderReturnParameter.cs | 1 + .../MethodBuilderSetParameters.cs | 2 + .../MethodBuilderSetReturnType.cs | 1 + .../MethodBuilderSetSignature.cs | 2 + .../MethodBuilder/MethodBuilderToString.cs | 5 + .../ModuleBuilder/ModuleBuilderDefineEnum.cs | 3 + .../ModuleBuilder/ModuleBuilderDefineType.cs | 1 + .../ModuleBuilderGetArrayMethod.cs | 10 ++ .../PropertyBuilderAddOtherMethod.cs | 1 + .../PropertyBuilderSetConstant.cs | 2 + .../PropertyBuilderSetCustomAttribute.cs | 2 + .../PropertyBuilderSetSetMethod.cs | 1 + .../PropertyBuilderSetValue.cs | 1 + .../TypeBuilderAddInterfaceImplementaion.cs | 2 + .../TypeBuilderAssemblyQualifiedName.cs | 1 + .../TypeBuilder/TypeBuilderCreateType.cs | 1 + .../TypeBuilder/TypeBuilderCreateTypeInfo.cs | 1 + .../TypeBuilderDefineConstructor.cs | 2 + .../TypeBuilderDefineDefaultConstructor.cs | 1 + .../TypeBuilder/TypeBuilderDefineEvent.cs | 1 + .../TypeBuilder/TypeBuilderDefineField.cs | 3 + .../TypeBuilderDefineGenericParameters.cs | 1 + .../TypeBuilder/TypeBuilderDefineMethod.cs | 1 + .../TypeBuilderDefineMethodOverride.cs | 5 + .../TypeBuilderDefineNestedType.cs | 5 + .../TypeBuilder/TypeBuilderDefineProperty.cs | 7 ++ .../TypeBuilderDefineTypeInitializer.cs | 1 + .../tests/TypeBuilder/TypeBuilderGUID.cs | 1 + .../TypeBuilder/TypeBuilderGetConstructor.cs | 3 + .../tests/TypeBuilder/TypeBuilderGetField.cs | 3 + .../tests/TypeBuilder/TypeBuilderGetMethod.cs | 4 + src/mono/netcore/CoreFX.issues.rsp | 112 ------------------ 43 files changed, 98 insertions(+), 112 deletions(-) diff --git a/src/libraries/System.Reflection.Emit/tests/AssemblyBuilderTests.cs b/src/libraries/System.Reflection.Emit/tests/AssemblyBuilderTests.cs index e2caa25117acc..3edc022a63340 100644 --- a/src/libraries/System.Reflection.Emit/tests/AssemblyBuilderTests.cs +++ b/src/libraries/System.Reflection.Emit/tests/AssemblyBuilderTests.cs @@ -37,6 +37,7 @@ public static IEnumerable DefineDynamicAssembly_TestData() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(DefineDynamicAssembly_TestData))] public void DefineDynamicAssembly_AssemblyName_AssemblyBuilderAccess(AssemblyName name, AssemblyBuilderAccess access) { @@ -57,6 +58,7 @@ public static IEnumerable DefineDynamicAssembly_CustomAttributes_TestD } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(DefineDynamicAssembly_CustomAttributes_TestData))] public void DefineDynamicAssembly_AssemblyName_AssemblyBuilderAccess_CustomAttributeBuilder(AssemblyName name, AssemblyBuilderAccess access, IEnumerable attributes) { @@ -113,6 +115,7 @@ public static IEnumerable DefineDynamicModule_TestData() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(DefineDynamicModule_TestData))] public void DefineDynamicModule(string name) { diff --git a/src/libraries/System.Reflection.Emit/tests/ConstructorBuilder/ConstructorBuilderToString.cs b/src/libraries/System.Reflection.Emit/tests/ConstructorBuilder/ConstructorBuilderToString.cs index 3f7eec9113fd0..6fd344a334964 100644 --- a/src/libraries/System.Reflection.Emit/tests/ConstructorBuilder/ConstructorBuilderToString.cs +++ b/src/libraries/System.Reflection.Emit/tests/ConstructorBuilder/ConstructorBuilderToString.cs @@ -9,6 +9,7 @@ namespace System.Reflection.Emit.Tests public class ConstructorBuilderToString { [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void ToString_NullRequiredOptionalCustomModifiers() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); @@ -19,6 +20,7 @@ public void ToString_NullRequiredOptionalCustomModifiers() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void ToString_NoRequiredOptionalCustomModifiers() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.Emit/tests/EnumBuilder/EnumBuilder.Methods.Tests.cs b/src/libraries/System.Reflection.Emit/tests/EnumBuilder/EnumBuilder.Methods.Tests.cs index cd60995012f86..461a3ceaee06e 100644 --- a/src/libraries/System.Reflection.Emit/tests/EnumBuilder/EnumBuilder.Methods.Tests.cs +++ b/src/libraries/System.Reflection.Emit/tests/EnumBuilder/EnumBuilder.Methods.Tests.cs @@ -50,6 +50,7 @@ public static IEnumerable DefineLiteral_TestData() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(DefineLiteral_TestData))] public void DefineLiteral(Type underlyingType, object literalValue) { @@ -113,6 +114,7 @@ public static IEnumerable DefineLiteral_InvalidLiteralValue_ThrowsArgu } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(DefineLiteral_InvalidLiteralValue_ThrowsArgumentException_TestData))] public void DefineLiteral_InvalidLiteralValue_ThrowsArgumentException(Type underlyingType, object literalValue) { @@ -207,6 +209,7 @@ public void MakePointerType() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void SetCustomAttribute_ConstructorInfo_ByteArray() { EnumBuilder enumBuilder = Helpers.DynamicEnum(TypeAttributes.Public, typeof(int)); @@ -220,6 +223,7 @@ public void SetCustomAttribute_ConstructorInfo_ByteArray() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void SetCustomAttribute_CustomAttributeBuilder() { EnumBuilder enumBuilder = Helpers.DynamicEnum(TypeAttributes.Public, typeof(int)); diff --git a/src/libraries/System.Reflection.Emit/tests/EnumBuilder/EnumBuilder.Properties.Tests.cs b/src/libraries/System.Reflection.Emit/tests/EnumBuilder/EnumBuilder.Properties.Tests.cs index 6767aa0e2042c..a3b3e35d60846 100644 --- a/src/libraries/System.Reflection.Emit/tests/EnumBuilder/EnumBuilder.Properties.Tests.cs +++ b/src/libraries/System.Reflection.Emit/tests/EnumBuilder/EnumBuilder.Properties.Tests.cs @@ -9,6 +9,7 @@ namespace System.Reflection.Emit.Tests public class EnumBuilderPropertyTests { [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void Guid_TypeCreated() { EnumBuilder enumBuilder = Helpers.DynamicEnum(TypeAttributes.Public, typeof(int)); diff --git a/src/libraries/System.Reflection.Emit/tests/FieldBuilder/FieldBuilderSetConstant.cs b/src/libraries/System.Reflection.Emit/tests/FieldBuilder/FieldBuilderSetConstant.cs index 237a2d308ea9f..220eb255aca30 100644 --- a/src/libraries/System.Reflection.Emit/tests/FieldBuilder/FieldBuilderSetConstant.cs +++ b/src/libraries/System.Reflection.Emit/tests/FieldBuilder/FieldBuilderSetConstant.cs @@ -258,6 +258,7 @@ public static IEnumerable SetConstant_Invalid_TestData() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(SetConstant_Invalid_TestData))] public void SetConstant_InvalidType_ThrowsArgumentException(FieldBuilder field, object defaultValue) { diff --git a/src/libraries/System.Reflection.Emit/tests/GenericTypeParameterBuilder/GenericTypeParameterBuilderSetInterfaceConstraints.cs b/src/libraries/System.Reflection.Emit/tests/GenericTypeParameterBuilder/GenericTypeParameterBuilderSetInterfaceConstraints.cs index 9fb4f4d4ef868..d634a50348ec6 100644 --- a/src/libraries/System.Reflection.Emit/tests/GenericTypeParameterBuilder/GenericTypeParameterBuilderSetInterfaceConstraints.cs +++ b/src/libraries/System.Reflection.Emit/tests/GenericTypeParameterBuilder/GenericTypeParameterBuilderSetInterfaceConstraints.cs @@ -9,6 +9,7 @@ namespace System.Reflection.Emit.Tests public class GenericTypeParameterBuilderSetInterfaceConstraints { [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void SetInterfaceConstraints_OneCustomInterface() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); @@ -39,6 +40,7 @@ public void SetInterfaceConstraints_Null() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void SetInterfaceConstraints_MultipleCustomInterfaces() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderDefineGenericParameters.cs b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderDefineGenericParameters.cs index 6a7c39ca41998..2d6d8e68570c4 100644 --- a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderDefineGenericParameters.cs +++ b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderDefineGenericParameters.cs @@ -55,6 +55,7 @@ public void DefineGenericParameter_MultipleParameters() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void DefineGenericParameters_SingleTypeParameter_SetImplementationFlagsCalled_ThrowsInvalidOperationException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.NotPublic); @@ -64,6 +65,7 @@ public void DefineGenericParameters_SingleTypeParameter_SetImplementationFlagsCa } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void DefineGenericParameters_TwoTypeParameters_SetImplementationFlagsCalled_ThrowsInvalidOperationException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.NotPublic); @@ -75,6 +77,7 @@ public void DefineGenericParameters_TwoTypeParameters_SetImplementationFlagsCall } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void DefineGenericParameters_SingleTypeParameter_AlreadyDefined_ThrowsInvalidOperationException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.NotPublic); @@ -85,6 +88,7 @@ public void DefineGenericParameters_SingleTypeParameter_AlreadyDefined_ThrowsInv } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void DefineGenericParameters_TwoTypeParameters_AlreadyDefined_ThrowsInvalidOperationException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.NotPublic); diff --git a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderEquals.cs b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderEquals.cs index 0dc6aab3195a0..198d1df5e90ec 100644 --- a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderEquals.cs +++ b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderEquals.cs @@ -72,6 +72,7 @@ public static IEnumerable Equals_TestData() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(Equals_TestData))] public void Equals(MethodBuilder builder, object obj, bool expected) { diff --git a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderGetGenericArguments.cs b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderGetGenericArguments.cs index b13dc77374d08..884d7dc794c94 100644 --- a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderGetGenericArguments.cs +++ b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderGetGenericArguments.cs @@ -10,6 +10,7 @@ namespace System.Reflection.Emit.Tests public class MethodBuilderGetGenericArguments { [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void GetGenericArguments_NonGenericMethod_ReturnsEmptyArray() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Abstract); diff --git a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderGetILGenerator.cs b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderGetILGenerator.cs index 70b54995703c3..1988ff20a3e87 100644 --- a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderGetILGenerator.cs +++ b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderGetILGenerator.cs @@ -27,6 +27,7 @@ public void GetILGenerator_Int(int size) } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [InlineData(TypeAttributes.Public, MethodAttributes.Public | MethodAttributes.PinvokeImpl)] [InlineData(TypeAttributes.Abstract, MethodAttributes.PinvokeImpl)] [InlineData(TypeAttributes.Abstract, MethodAttributes.Abstract | MethodAttributes.PinvokeImpl)] diff --git a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderMakeGenericMethod.cs b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderMakeGenericMethod.cs index 20faceae32238..27191950c56aa 100644 --- a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderMakeGenericMethod.cs +++ b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderMakeGenericMethod.cs @@ -32,6 +32,7 @@ public void MakeGenericMethod(string[] names, Type[] typeArguments, Type returnT } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void TestNotThrowsExceptionOnNull() { Type returnType = typeof(void); @@ -45,6 +46,7 @@ public void TestNotThrowsExceptionOnNull() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void TestNotThrowsExceptionOnEmptyArray1() { Type returnType = typeof(void); @@ -59,6 +61,7 @@ public void TestNotThrowsExceptionOnEmptyArray1() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void TestNotThrowsExceptionOnEmptyArray2() { Type returnType = typeof(void); diff --git a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderReturnParameter.cs b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderReturnParameter.cs index eed0b310a543c..106328c8e0f22 100644 --- a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderReturnParameter.cs +++ b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderReturnParameter.cs @@ -48,6 +48,7 @@ public void ReturnParameter_TypeNotCreated_ThrowsInvalidOperationException() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void ReturnParameter_NoBody_ThrowsInvalidOperationException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Abstract); diff --git a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetParameters.cs b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetParameters.cs index aefe008a1d633..56dafcc54d08c 100644 --- a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetParameters.cs +++ b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetParameters.cs @@ -18,6 +18,7 @@ public static IEnumerable SetParameters_TestData() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(SetParameters_TestData))] public void SetParameters(Type[] parameterTypes, string[] typeParamNames) { @@ -101,6 +102,7 @@ public void SetParameters_NoParameterTypes() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void SetParameters_NullParameter_ThrowsArgumentNullException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Abstract); diff --git a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetReturnType.cs b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetReturnType.cs index 9399227f27777..95aa4e2b70155 100644 --- a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetReturnType.cs +++ b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetReturnType.cs @@ -133,6 +133,7 @@ public void SetReturnType_TypeCreated_Works() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void SetReturnType_NullReturnType_ReturnsVoid() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Abstract); diff --git a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetSignature.cs b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetSignature.cs index b86525971be94..310c9a46dd00c 100644 --- a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetSignature.cs +++ b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetSignature.cs @@ -192,6 +192,7 @@ public void SetSignature_NonGenericMethod() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void SetSignature_AllParametersNull() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Abstract); @@ -202,6 +203,7 @@ public void SetSignature_AllParametersNull() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void SetSignature_NullReturnType_CustomModifiersSetToWrongTypes() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Abstract); diff --git a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderToString.cs b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderToString.cs index 65495e848576b..8b6ed2da178fe 100644 --- a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderToString.cs +++ b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderToString.cs @@ -9,6 +9,7 @@ namespace System.Reflection.Emit.Tests public class MethodBuilderToString { [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void ToString_AllFieldsSet() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Abstract); @@ -25,6 +26,7 @@ public void ToString_AllFieldsSet() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void ToString_NameAndAttributeSet() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Abstract); @@ -34,6 +36,7 @@ public void ToString_NameAndAttributeSet() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void ToString_NameAttributeAndSignatureSetSet() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Abstract); @@ -44,6 +47,7 @@ public void ToString_NameAttributeAndSignatureSetSet() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void ToString_NonGenericMethod() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); @@ -59,6 +63,7 @@ public void ToString_NonGenericMethod() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void ToString_GenericMethod() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderDefineEnum.cs b/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderDefineEnum.cs index b882e0a3b7c74..4609ee9184884 100644 --- a/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderDefineEnum.cs +++ b/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderDefineEnum.cs @@ -30,6 +30,7 @@ public static IEnumerable DefineEnum_TestData() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(DefineEnum_TestData))] public void DefineEnum(string name, TypeAttributes visibility, Type underlyingType) { @@ -77,6 +78,7 @@ public void DefineEnum(string name, TypeAttributes visibility, Type underlyingTy } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void DefineEnum_DynamicUnderlyingType_Works() { ModuleBuilder module = Helpers.DynamicModule(); @@ -159,6 +161,7 @@ public void DefineEnum_VoidUnderlyingType_ThrowsArgumentException() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void DefineEnum_ByRefUnderlyingType_ThrowsCOMExceptionOnCreation() { ModuleBuilder module = Helpers.DynamicModule(); diff --git a/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderDefineType.cs b/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderDefineType.cs index 844dcb8d18119..cbcd89e583e4d 100644 --- a/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderDefineType.cs +++ b/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderDefineType.cs @@ -33,6 +33,7 @@ public static IEnumerable TestData() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(TestData))] public void DefineType(string name, TypeAttributes attributes, Type parent, PackingSize packingSize, int typesize, Type[] implementedInterfaces) { diff --git a/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderGetArrayMethod.cs b/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderGetArrayMethod.cs index 973cf1d9e3608..33c55fa2230f5 100644 --- a/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderGetArrayMethod.cs +++ b/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderGetArrayMethod.cs @@ -25,6 +25,7 @@ public static IEnumerable CallingConventions_TestData() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(CallingConventions_TestData))] public void GetArrayMethod_ValidArrayValues_VoidReturnType(CallingConventions callingConvention) { @@ -33,6 +34,7 @@ public void GetArrayMethod_ValidArrayValues_VoidReturnType(CallingConventions ca } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(CallingConventions_TestData))] public void GetArrayMethod_ValidArrayValues_ValueReturnType(CallingConventions callingConvention) { @@ -41,6 +43,7 @@ public void GetArrayMethod_ValidArrayValues_ValueReturnType(CallingConventions c } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(CallingConventions_TestData))] public void GetArrayMethod_ValidArrayValues_ReferenceReturnType(CallingConventions callingConvention) { @@ -49,6 +52,7 @@ public void GetArrayMethod_ValidArrayValues_ReferenceReturnType(CallingConventio } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(CallingConventions_TestData))] public void GetArrayMethod_ValidArrayValues_ValueParameterType(CallingConventions callingConvention) { @@ -59,6 +63,7 @@ public void GetArrayMethod_ValidArrayValues_ValueParameterType(CallingConvention } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(CallingConventions_TestData))] public void GetArrayMethod_ValidArrayValues_ReferenceParameterType(CallingConventions callingConvention) { @@ -69,6 +74,7 @@ public void GetArrayMethod_ValidArrayValues_ReferenceParameterType(CallingConven } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(CallingConventions_TestData))] public void GetArrayMethod_JaggedArray(CallingConventions callingConvention) { @@ -79,6 +85,7 @@ public void GetArrayMethod_JaggedArray(CallingConventions callingConvention) } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(CallingConventions_TestData))] public void GetArrayMethod_MultiDimensionalArray(CallingConventions callingConvention) { @@ -89,6 +96,7 @@ public void GetArrayMethod_MultiDimensionalArray(CallingConventions callingConve } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(CallingConventions_TestData))] public void GetArrayMethod_NullParameters(CallingConventions callingConvention) { @@ -97,6 +105,7 @@ public void GetArrayMethod_NullParameters(CallingConventions callingConvention) } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [InlineData(typeof(ModuleBuilderGetArrayMethod))] [InlineData(typeof(int))] [InlineData(typeof(Array))] @@ -108,6 +117,7 @@ public void GetArrayMethod_ArrayClassNotArray_ThrowsArgumentException(Type array } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void GetArrayMethod_InvalidArgument_ThrowsArgumentException() { ModuleBuilder module = Helpers.DynamicModule(); diff --git a/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderAddOtherMethod.cs b/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderAddOtherMethod.cs index 6db64d1fa8975..144bac8775a65 100644 --- a/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderAddOtherMethod.cs +++ b/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderAddOtherMethod.cs @@ -9,6 +9,7 @@ namespace System.Reflection.Emit.Tests public class PropertyBuilderTest2 { [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [InlineData(MethodAttributes.Public, CallingConventions.HasThis, BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance)] [InlineData(MethodAttributes.Private, CallingConventions.HasThis, BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance)] [InlineData(MethodAttributes.Public | MethodAttributes.Static, CallingConventions.Any, BindingFlags.Public | BindingFlags.Static | BindingFlags.NonPublic | BindingFlags.Instance)] diff --git a/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetConstant.cs b/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetConstant.cs index 9a38fb9384146..f95f33057ad17 100644 --- a/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetConstant.cs +++ b/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetConstant.cs @@ -42,6 +42,7 @@ public static IEnumerable SetConstant_TestData() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(SetConstant_TestData))] public void SetConstant(Type returnType, object defaultValue) { @@ -83,6 +84,7 @@ public void SetConstant_TypeAlreadyCreated_ThrowsInvalidOperationException() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void SetConstant_TypeNotConstant_ThrowsArgumentException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Class | TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetCustomAttribute.cs b/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetCustomAttribute.cs index f7a8dc77644c0..86622e69fd540 100644 --- a/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetCustomAttribute.cs +++ b/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetCustomAttribute.cs @@ -53,6 +53,7 @@ public void SetCustomAttribute_CustomAttributeBuilder_NullBuilder_ThrowsArgument } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void SetCustomAttribute_CustomAttributeBuilder_TypeNotCreated_ThrowsInvalidOperationException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Class | TypeAttributes.Public); @@ -116,6 +117,7 @@ public void SetCustomAttribute_ConstructorInfo_ByteArray_NullConstructorInfo_Thr [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void SetCustomAttribute_ConstructorInfo_ByteArray_TypeAlreadyCreated_ThrowsInvalidOperationException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Class | TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetSetMethod.cs b/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetSetMethod.cs index 251937ee18784..8c50bce0e1e14 100644 --- a/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetSetMethod.cs +++ b/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetSetMethod.cs @@ -35,6 +35,7 @@ public void SetSetMethod_NullMethodBuilder_ThrowsArgumentNullException() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void TestThrowsExceptionForCreateTypeCalled() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Class | TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetValue.cs b/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetValue.cs index ce35cdcfcb5b4..2db407e2f61d9 100644 --- a/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetValue.cs +++ b/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetValue.cs @@ -9,6 +9,7 @@ namespace System.Reflection.Emit.Tests public class PropertyBuilderTest16 { [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void SetValue_ThrowsNotSupportedException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Class | TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderAddInterfaceImplementaion.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderAddInterfaceImplementaion.cs index b8ae31f62551a..e755d8f705baa 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderAddInterfaceImplementaion.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderAddInterfaceImplementaion.cs @@ -93,6 +93,7 @@ public static IEnumerable NonInterfaceTypes_TestData() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(NonInterfaceTypes_TestData))] public void AddInterfaceImplementation_TypeNotInterface_ThrowsTypeLoadExceptionOnCreation(Type interfaceType) { @@ -114,6 +115,7 @@ public void AddInterfaceImplementation_OpenGenericType_ThrowsBadImageFormatExcep } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void AddInterfaceImplementation_TypeDoesntImplementInterface_ThrowsTypeLoadExceptionOnCreation() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderAssemblyQualifiedName.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderAssemblyQualifiedName.cs index 9be6b1cdb55da..e16521cba5711 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderAssemblyQualifiedName.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderAssemblyQualifiedName.cs @@ -9,6 +9,7 @@ namespace System.Reflection.Emit.Tests public class TypeBuilderAssemblyQualifiedName { [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [InlineData("TypeName", "ad df df")] [InlineData("TypeName", "assemblyname")] [InlineData("type name ", "assembly name ")] diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderCreateType.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderCreateType.cs index 1dcbc83a054d4..a4ff0ab56b041 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderCreateType.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderCreateType.cs @@ -31,6 +31,7 @@ public void CreateType(TypeAttributes attributes) } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [InlineData(TypeAttributes.ClassSemanticsMask)] [InlineData(TypeAttributes.HasSecurity)] [InlineData(TypeAttributes.LayoutMask)] diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderCreateTypeInfo.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderCreateTypeInfo.cs index aadf3a8cbbb49..bbba624f24665 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderCreateTypeInfo.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderCreateTypeInfo.cs @@ -51,6 +51,7 @@ public void CreateType_GenericType() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [InlineData(TypeAttributes.ClassSemanticsMask, typeof(InvalidOperationException))] [InlineData(TypeAttributes.HasSecurity, typeof(ArgumentException))] [InlineData(TypeAttributes.LayoutMask, typeof(ArgumentException))] diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineConstructor.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineConstructor.cs index 44a216e894b8a..c5dbda45d8ae9 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineConstructor.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineConstructor.cs @@ -35,6 +35,7 @@ public static IEnumerable TestData() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(TestData))] public void DefineConstructor(MethodAttributes attributes, Type[] parameterTypes, CallingConventions callingConvention) { @@ -64,6 +65,7 @@ public void DefineConstructor(MethodAttributes attributes, Type[] parameterTypes } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(TestData))] public void DefineConstructor_NullRequiredAndOptionalCustomModifiers(MethodAttributes attributes, Type[] parameterTypes, CallingConventions callingConvention) { diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineDefaultConstructor.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineDefaultConstructor.cs index b0a23a849eda3..4616c0b940d2b 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineDefaultConstructor.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineDefaultConstructor.cs @@ -10,6 +10,7 @@ namespace System.Reflection.Emit.Tests public class TypeBuilderDefineDefaultConstructor { [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [InlineData(MethodAttributes.Public)] [InlineData(MethodAttributes.Static)] [InlineData(MethodAttributes.Family)] diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineEvent.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineEvent.cs index 04134cb2ecc55..fbdf79b530758 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineEvent.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineEvent.cs @@ -27,6 +27,7 @@ public static IEnumerable TestData() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(TestData))] public void DefineEvent(string name, EventAttributes attributes, Type eventType, string expectedName, EventAttributes expectedAttributes) { diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineField.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineField.cs index a9aaefbe7b8f0..f6ee4550f421e 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineField.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineField.cs @@ -33,6 +33,7 @@ public static IEnumerable TestData() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(TestData))] public void DefineField(string name, Type fieldType, FieldAttributes attributes, FieldAttributes expectedAttributes) { @@ -112,6 +113,7 @@ public void DefineField_ByRefFieldType_ThrowsCOMExceptionOnCreation() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [InlineData((FieldAttributes)(-1), (FieldAttributes)(-38145))] [InlineData(FieldAttributes.FieldAccessMask, FieldAttributes.FieldAccessMask)] [InlineData((FieldAttributes)int.MaxValue, (FieldAttributes)2147445503)] @@ -125,6 +127,7 @@ public void DefineField_InvalidFieldAttributes_ThrowsTypeLoadExceptionOnCreation } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void DefineField_DynamicFieldTypeNotCreated_ThrowsTypeLoadException() { ModuleBuilder module = Helpers.DynamicModule(); diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineGenericParameters.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineGenericParameters.cs index c00ccf842fb4c..616075349ca8c 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineGenericParameters.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineGenericParameters.cs @@ -73,6 +73,7 @@ public void DefineGenericParameters_NullName_ThrowsArgumentNullException() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void DefineGenericParameters_AlreadyDefinedGenericParameters_ThrowsInvalidOperationException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineMethod.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineMethod.cs index 91dfe8bc14f68..5cf5f5d2fc9fa 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineMethod.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineMethod.cs @@ -63,6 +63,7 @@ public static IEnumerable TestData() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(TestData))] public void DefineMethod(string name, MethodAttributes attributes, CallingConventions callingConvention, Type returnType, Type[] parameterTypes) { diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineMethodOverride.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineMethodOverride.cs index e967e76ab3301..ab100b4d76d36 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineMethodOverride.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineMethodOverride.cs @@ -168,6 +168,7 @@ public void DefineMethodOverride_MethodNotVirtual_ThrowsTypeLoadExceptionOnCreat } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void DefineMethodOverride_NothingToOverride_ThrowsTypeLoadExceptionOnCreation() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); @@ -180,6 +181,7 @@ public void DefineMethodOverride_NothingToOverride_ThrowsTypeLoadExceptionOnCrea } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [InlineData(typeof(GenericInterface<>), nameof(GenericInterface.Method))] [InlineData(typeof(DefineMethodOverrideInterface), nameof(DefineMethodOverrideInterface.M))] public void DefineMethodOverride_ClassDoesNotImplementOrInheritMethod_ThrowsTypeLoadExceptionOnCreation(Type methodType, string methodName) @@ -196,6 +198,7 @@ public void DefineMethodOverride_ClassDoesNotImplementOrInheritMethod_ThrowsType } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void DefineMethodOverride_BodyAndDeclarationTheSame_ThrowsTypeLoadExceptionOnCreation() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); @@ -210,6 +213,7 @@ public void DefineMethodOverride_BodyAndDeclarationTheSame_ThrowsTypeLoadExcepti } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void DefineMethodOverride_CalledTwiceWithDifferentBodies_ThrowsTypeLoadExceptionOnCreation() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); @@ -232,6 +236,7 @@ public void DefineMethodOverride_CalledTwiceWithDifferentBodies_ThrowsTypeLoadEx } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [InlineData(typeof(int), new Type[0])] [InlineData(typeof(int), new Type[] { typeof(int), typeof(int) })] [InlineData(typeof(int), new Type[] { typeof(string), typeof(string) })] diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineNestedType.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineNestedType.cs index dd82904de5295..234bb96286063 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineNestedType.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineNestedType.cs @@ -55,6 +55,7 @@ public static IEnumerable TestData() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(TestData))] public void DefineNestedType(string name, TypeAttributes attributes, Type parent, PackingSize packingSize, int typesize, Type[] implementedInterfaces) { @@ -144,6 +145,7 @@ public void DefineNestedType_EmptyName_ThrowsArgumentException(string fullname) } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void DefineNestedType_LongName_ThrowsArgumentException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.NotPublic); @@ -151,6 +153,7 @@ public void DefineNestedType_LongName_ThrowsArgumentException() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [InlineData(TypeAttributes.Public, "attr")] [InlineData(TypeAttributes.NotPublic, "attr")] [InlineData(TypeAttributes.Interface, "attr")] @@ -166,6 +169,7 @@ public void DefineNestedType_InvalidAttributes_ThrowsArgumentException(TypeAttri } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void DefineNestedType_InvalidParent_ThrowsArgumentException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); @@ -226,6 +230,7 @@ public static IEnumerable InvalidInterfaceType_TestData() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(InvalidInterfaceType_TestData))] public void DefineNestedType_InvalidInterfaceType_ThrowsTypeLoadExceptionOnCreation(Type interfaceType) { diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineProperty.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineProperty.cs index d994c8b915974..350030c798479 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineProperty.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineProperty.cs @@ -30,6 +30,7 @@ public static IEnumerable TestData() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] [MemberData(nameof(TestData))] public void DefineProperty(string name, PropertyAttributes attributes, Type returnType, Type[] parameterTypes, string expectedName, PropertyAttributes expectedPropertyAttributes) { @@ -137,6 +138,7 @@ public void DefineProperty_TypeCreated_ThrowsInvalidOperationException() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void DefineProperty_OpenGenericReturnType_ThrowsBadImageFormatExceptionGettingCreatedPropertyType() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); @@ -148,6 +150,7 @@ public void DefineProperty_OpenGenericReturnType_ThrowsBadImageFormatExceptionGe } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void DefineProperty_NullParameterType_ThrowsArgumentNullException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); @@ -155,6 +158,7 @@ public void DefineProperty_NullParameterType_ThrowsArgumentNullException() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void DefineProperty_OpenGenericParameterType_ThrowsBadImageFormatExceptionGettingCreatedPropertyType() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); @@ -166,6 +170,7 @@ public void DefineProperty_OpenGenericParameterType_ThrowsBadImageFormatExceptio } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void DefineProperty_DynamicPropertyTypeNotCreated_ThrowsTypeLoadException() { ModuleBuilder module = Helpers.DynamicModule(); @@ -182,6 +187,7 @@ public void DefineProperty_DynamicPropertyTypeNotCreated_ThrowsTypeLoadException } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void DefineProperty_DynamicParameterTypeNotCreated_ThrowsTypeLoadException() { ModuleBuilder module = Helpers.DynamicModule(); @@ -198,6 +204,7 @@ public void DefineProperty_DynamicParameterTypeNotCreated_ThrowsTypeLoadExceptio } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void DefineProperty_CalledMultipleTimes_Works() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Class | TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineTypeInitializer.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineTypeInitializer.cs index c662cc824f6eb..d720151e0d856 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineTypeInitializer.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineTypeInitializer.cs @@ -9,6 +9,7 @@ namespace System.Reflection.Emit.Tests public class MethodBuilderDefineTypeInitializer { [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void DefineTypeInitializer() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGUID.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGUID.cs index cffcba9955996..0579c5b5760a8 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGUID.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGUID.cs @@ -9,6 +9,7 @@ namespace System.Reflection.Emit.Tests public class TypeBuilderGUID { [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void Guid_TypeCreated_NotEmpty() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.NotPublic); diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGetConstructor.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGetConstructor.cs index aaa4c951f22ce..2086341cd697e 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGetConstructor.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGetConstructor.cs @@ -33,12 +33,14 @@ public void GetConstructor() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void GetConstructor_TypeNotTypeBuilder_ThrowsArgumentException() { AssertExtensions.Throws(null, () => TypeBuilder.GetConstructor(typeof(int), typeof(int).GetConstructor(new Type[0]))); } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void GetConstructor_DeclaringTypeOfConstructorNotGenericTypeDefinitionOfType_ThrowsArgumentException() { ModuleBuilder module = Helpers.DynamicModule(); @@ -57,6 +59,7 @@ public void GetConstructor_DeclaringTypeOfConstructorNotGenericTypeDefinitionOfT } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void GetConstructor_TypeNotGeneric_ThrowsArgumentException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Class | TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGetField.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGetField.cs index b3b0e43b8cab9..61369c6749d2b 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGetField.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGetField.cs @@ -33,12 +33,14 @@ public void GetField() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void GetField_TypeNotTypeBuilder_ThrowsArgumentException() { AssertExtensions.Throws(null, () => TypeBuilder.GetField(typeof(int), typeof(int).GetField("MaxValue"))); } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void GetField_DeclaringTypeOfFieldNotGenericTypeDefinitionOfType_ThrowsArgumentException() { ModuleBuilder module = Helpers.DynamicModule(); @@ -56,6 +58,7 @@ public void GetField_DeclaringTypeOfFieldNotGenericTypeDefinitionOfType_ThrowsAr } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void GetField_TypeNotGeneric_ThrowsArgumentException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Class | TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGetMethod.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGetMethod.cs index 48f04daf7c57a..02ce79aad0b8c 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGetMethod.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGetMethod.cs @@ -42,12 +42,14 @@ public void GetMethod_ConstructedTypeMethod() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void GetMethod_TypeNotTypeBuilder_ThrowsArgumentException() { AssertExtensions.Throws(null, () => TypeBuilder.GetMethod(typeof(int), typeof(int).GetMethod("Parse", new Type[] { typeof(string) }))); } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void GetMethod_MethodDefinitionNotInTypeGenericDefinition_ThrowsArgumentException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Class | TypeAttributes.Public); @@ -63,6 +65,7 @@ public void GetMethod_MethodDefinitionNotInTypeGenericDefinition_ThrowsArgumentE } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void GetMethod_MethodNotGenericTypeDefinition_ThrowsArgumentException() { ModuleBuilder module = Helpers.DynamicModule(); @@ -85,6 +88,7 @@ public void GetMethod_MethodNotGenericTypeDefinition_ThrowsArgumentException() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] public void GetMethod_TypeIsNotGeneric_ThrowsArgumentException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Class | TypeAttributes.Public); diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 955847b82f576..8282b08ebfd3f 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -5,118 +5,6 @@ -notrait category=failing -notrait category=IgnoreForCI -#################################################################### -## System.Reflection.Emit.Tests -#################################################################### - -# Mono behaves like coreclr but the test doesn't detect it --nomethod System.Reflection.Emit.Tests.AssemblyTests.DefineDynamicModule - --nomethod System.Reflection.Emit.Tests.MethodBuilderEquals.Equals --nomethod System.Reflection.Emit.Tests.ConstructorBuilderToString.ToString_NullRequiredOptionalCustomModifiers --nomethod System.Reflection.Emit.Tests.ConstructorBuilderToString.ToString_NoRequiredOptionalCustomModifiers --nomethod System.Reflection.Emit.Tests.EnumBuilderMethodTests.DefineLiteral --nomethod System.Reflection.Emit.Tests.EnumBuilderMethodTests.DefineLiteral_InvalidLiteralValue_ThrowsArgumentException --nomethod System.Reflection.Emit.Tests.EnumBuilderMethodTests.SetCustomAttribute_ConstructorInfo_ByteArray --nomethod System.Reflection.Emit.Tests.EnumBuilderMethodTests.SetCustomAttribute_CustomAttributeBuilder --nomethod System.Reflection.Emit.Tests.EnumBuilderPropertyTests.Guid_TypeCreated --nomethod System.Reflection.Emit.Tests.FieldBuilderSetConstant.SetConstant_InvalidType_ThrowsArgumentException --nomethod System.Reflection.Emit.Tests.GenericTypeParameterBuilderSetInterfaceConstraints.SetInterfaceConstraints_OneCustomInterface --nomethod System.Reflection.Emit.Tests.GenericTypeParameterBuilderSetInterfaceConstraints.SetInterfaceConstraints_MultipleCustomInterfaces --nomethod System.Reflection.Emit.Tests.MethodBuilderDefineGenericParameters.DefineGenericParameters_SingleTypeParameter_SetImplementationFlagsCalled_ThrowsInvalidOperationException --nomethod System.Reflection.Emit.Tests.MethodBuilderDefineGenericParameters.DefineGenericParameters_TwoTypeParameters_SetImplementationFlagsCalled_ThrowsInvalidOperationException --nomethod System.Reflection.Emit.Tests.MethodBuilderDefineGenericParameters.DefineGenericParameters_SingleTypeParameter_AlreadyDefined_ThrowsInvalidOperationException --nomethod System.Reflection.Emit.Tests.MethodBuilderDefineGenericParameters.DefineGenericParameters_TwoTypeParameters_AlreadyDefined_ThrowsInvalidOperationException --nomethod System.Reflection.Emit.Tests.MethodBuilderGetILGenerator.GetILGenerator_NoMethodBody_ThrowsInvalidOperationException --nomethod System.Reflection.Emit.Tests.MethodBuilderMakeGenericMethod.TestNotThrowsExceptionOnNull --nomethod System.Reflection.Emit.Tests.MethodBuilderMakeGenericMethod.TestNotThrowsExceptionOnEmptyArray1 --nomethod System.Reflection.Emit.Tests.MethodBuilderMakeGenericMethod.TestNotThrowsExceptionOnEmptyArray2 --nomethod System.Reflection.Emit.Tests.MethodBuilderReturnParameter.ReturnParameter_NoBody_ThrowsInvalidOperationException --nomethod System.Reflection.Emit.Tests.MethodBuilderSetParameters.SetParameters --nomethod System.Reflection.Emit.Tests.MethodBuilderSetParameters.SetParameters_NullParameter_ThrowsArgumentNullException --nomethod System.Reflection.Emit.Tests.MethodBuilderToString.ToString_AllFieldsSet --nomethod System.Reflection.Emit.Tests.MethodBuilderToString.ToString_NameAndAttributeSet --nomethod System.Reflection.Emit.Tests.MethodBuilderToString.ToString_NameAttributeAndSignatureSetSet --nomethod System.Reflection.Emit.Tests.MethodBuilderToString.ToString_NonGenericMethod --nomethod System.Reflection.Emit.Tests.MethodBuilderToString.ToString_GenericMethod --nomethod System.Reflection.Emit.Tests.ModuleBuilderDefineEnum.DefineEnum --nomethod System.Reflection.Emit.Tests.ModuleBuilderDefineEnum.DefineEnum_DynamicUnderlyingType_Works --nomethod System.Reflection.Emit.Tests.ModuleBuilderDefineEnum.DefineEnum_ByRefUnderlyingType_ThrowsCOMExceptionOnCreation --nomethod System.Reflection.Emit.Tests.ModuleBuilderDefineType.DefineType --nomethod System.Reflection.Emit.Tests.ModuleBuilderGetArrayMethod.GetArrayMethod_ValidArrayValues_VoidReturnType --nomethod System.Reflection.Emit.Tests.ModuleBuilderGetArrayMethod.GetArrayMethod_ValidArrayValues_ValueReturnType --nomethod System.Reflection.Emit.Tests.ModuleBuilderGetArrayMethod.GetArrayMethod_ValidArrayValues_ReferenceReturnType --nomethod System.Reflection.Emit.Tests.ModuleBuilderGetArrayMethod.GetArrayMethod_ValidArrayValues_ValueParameterType --nomethod System.Reflection.Emit.Tests.ModuleBuilderGetArrayMethod.GetArrayMethod_ValidArrayValues_ReferenceParameterType --nomethod System.Reflection.Emit.Tests.ModuleBuilderGetArrayMethod.GetArrayMethod_JaggedArray --nomethod System.Reflection.Emit.Tests.ModuleBuilderGetArrayMethod.GetArrayMethod_MultiDimensionalArray --nomethod System.Reflection.Emit.Tests.ModuleBuilderGetArrayMethod.GetArrayMethod_NullParameters --nomethod System.Reflection.Emit.Tests.ModuleBuilderGetArrayMethod.GetArrayMethod_ArrayClassNotArray_ThrowsArgumentException --nomethod System.Reflection.Emit.Tests.ModuleBuilderGetArrayMethod.GetArrayMethod_InvalidArgument_ThrowsArgumentException --nomethod System.Reflection.Emit.Tests.PropertyBuilderTest2.AddOtherMethod --nomethod System.Reflection.Emit.Tests.PropertyBuilderTest11.SetConstant --nomethod System.Reflection.Emit.Tests.PropertyBuilderTest11.SetConstant_TypeNotConstant_ThrowsArgumentException --nomethod System.Reflection.Emit.Tests.PropertyBuilderTest12.SetCustomAttribute_CustomAttributeBuilder_TypeNotCreated_ThrowsInvalidOperationException --nomethod System.Reflection.Emit.Tests.PropertyBuilderTest12.SetCustomAttribute_ConstructorInfo_ByteArray_TypeAlreadyCreated_ThrowsInvalidOperationException --nomethod System.Reflection.Emit.Tests.PropertyBuilderTest15.TestThrowsExceptionForCreateTypeCalled --nomethod System.Reflection.Emit.Tests.PropertyBuilderTest16.SetValue_ThrowsNotSupportedException --nomethod System.Reflection.Emit.Tests.TypeBuilderAddInterfaceImplementation.AddInterfaceImplementation_TypeNotInterface_ThrowsTypeLoadExceptionOnCreation --nomethod System.Reflection.Emit.Tests.TypeBuilderAddInterfaceImplementation.AddInterfaceImplementation_TypeDoesntImplementInterface_ThrowsTypeLoadExceptionOnCreation --nomethod System.Reflection.Emit.Tests.TypeBuilderAssemblyQualifiedName.AssemblyQualifiedName --nomethod System.Reflection.Emit.Tests.TypeBuilderCreateType.CreateType_BadAttributes --nomethod System.Reflection.Emit.Tests.TypeBuilderCreateTypeInfo.CreateType_InvalidTypeAttributes_Throws - -# Extra RTSpecialName attribute --nomethod System.Reflection.Emit.Tests.TypeBuilderDefineConstructor.DefineConstructor --nomethod System.Reflection.Emit.Tests.TypeBuilderDefineConstructor.DefineConstructor_NullRequiredAndOptionalCustomModifiers --nomethod System.Reflection.Emit.Tests.TypeBuilderDefineDefaultConstructor.DefineDefaultConstructor --nomethod System.Reflection.Emit.Tests.MethodBuilderDefineTypeInitializer.DefineTypeInitializer - --nomethod System.Reflection.Emit.Tests.TypeBuilderDefineMethodTests.DefineMethod --nomethod System.Reflection.Emit.Tests.TypeBuilderDefineFieldTests.DefineField --nomethod System.Reflection.Emit.Tests.TypeBuilderDefineFieldTests.DefineField_InvalidFieldAttributes_ThrowsTypeLoadExceptionOnCreation --nomethod System.Reflection.Emit.Tests.TypeBuilderDefineFieldTests.DefineField_DynamicFieldTypeNotCreated_ThrowsTypeLoadException --nomethod System.Reflection.Emit.Tests.TypeBuilderDefineGenericParameters.DefineGenericParameters_AlreadyDefinedGenericParameters_ThrowsInvalidOperationException --nomethod System.Reflection.Emit.Tests.TypeBuilderDefineEvent.DefineEvent --nomethod System.Reflection.Emit.Tests.TypeBuilderDefineEvent.DefineProperty_InvalidUnicodeChars --nomethod System.Reflection.Emit.Tests.MethodBuilderDefineMethodOverride.DefineMethodOverride_NothingToOverride_ThrowsTypeLoadExceptionOnCreation --nomethod System.Reflection.Emit.Tests.MethodBuilderDefineMethodOverride.DefineMethodOverride_ClassDoesNotImplementOrInheritMethod_ThrowsTypeLoadExceptionOnCreation --nomethod System.Reflection.Emit.Tests.MethodBuilderDefineMethodOverride.DefineMethodOverride_BodyAndDeclarationTheSame_ThrowsTypeLoadExceptionOnCreation --nomethod System.Reflection.Emit.Tests.MethodBuilderDefineMethodOverride.DefineMethodOverride_CalledTwiceWithDifferentBodies_ThrowsTypeLoadExceptionOnCreation --nomethod System.Reflection.Emit.Tests.MethodBuilderDefineMethodOverride.DefineMethodOverride_BodyAndDeclarationHaveDifferentSignatures_ThrowsTypeLoadExceptionOnCreation --nomethod System.Reflection.Emit.Tests.TypeBuilderDefineNestedType.DefineNestedType --nomethod System.Reflection.Emit.Tests.TypeBuilderDefineNestedType.DefineNestedType_LongName_ThrowsArgumentException --nomethod System.Reflection.Emit.Tests.TypeBuilderDefineNestedType.DefineNestedType_InvalidAttributes_ThrowsArgumentException --nomethod System.Reflection.Emit.Tests.TypeBuilderDefineNestedType.DefineNestedType_InvalidParent_ThrowsArgumentException --nomethod System.Reflection.Emit.Tests.TypeBuilderDefineNestedType.DefineNestedType_InvalidInterfaceType_ThrowsTypeLoadExceptionOnCreation --nomethod System.Reflection.Emit.Tests.TypeBuilderDefineProperty.DefineProperty --nomethod System.Reflection.Emit.Tests.TypeBuilderDefineProperty.DefineProperty_OpenGenericReturnType_ThrowsBadImageFormatExceptionGettingCreatedPropertyType --nomethod System.Reflection.Emit.Tests.TypeBuilderDefineProperty.DefineProperty_NullParameterType_ThrowsArgumentNullException --nomethod System.Reflection.Emit.Tests.TypeBuilderDefineProperty.DefineProperty_OpenGenericParameterType_ThrowsBadImageFormatExceptionGettingCreatedPropertyType --nomethod System.Reflection.Emit.Tests.TypeBuilderDefineProperty.DefineProperty_DynamicPropertyTypeNotCreated_ThrowsTypeLoadException --nomethod System.Reflection.Emit.Tests.TypeBuilderDefineProperty.DefineProperty_DynamicParameterTypeNotCreated_ThrowsTypeLoadException --nomethod System.Reflection.Emit.Tests.TypeBuilderDefineProperty.DefineProperty_CalledMultipleTimes_Works --nomethod System.Reflection.Emit.Tests.TypeBuilderGetConstructor.GetConstructor_TypeNotTypeBuilder_ThrowsArgumentException --nomethod System.Reflection.Emit.Tests.TypeBuilderGetConstructor.GetConstructor_DeclaringTypeOfConstructorNotGenericTypeDefinitionOfType_ThrowsArgumentException --nomethod System.Reflection.Emit.Tests.TypeBuilderGetConstructor.GetConstructor_TypeNotGeneric_ThrowsArgumentException --nomethod System.Reflection.Emit.Tests.TypeBuilderGetField.GetField_TypeNotTypeBuilder_ThrowsArgumentException --nomethod System.Reflection.Emit.Tests.TypeBuilderGetField.GetField_DeclaringTypeOfFieldNotGenericTypeDefinitionOfType_ThrowsArgumentException --nomethod System.Reflection.Emit.Tests.TypeBuilderGetField.GetField_TypeNotGeneric_ThrowsArgumentException --nomethod System.Reflection.Emit.Tests.TypeBuilderGetMethod.GetMethod_TypeNotTypeBuilder_ThrowsArgumentException --nomethod System.Reflection.Emit.Tests.TypeBuilderGetMethod.GetMethod_MethodDefinitionNotInTypeGenericDefinition_ThrowsArgumentException --nomethod System.Reflection.Emit.Tests.TypeBuilderGetMethod.GetMethod_MethodNotGenericTypeDefinition_ThrowsArgumentException --nomethod System.Reflection.Emit.Tests.TypeBuilderGetMethod.GetMethod_TypeIsNotGeneric_ThrowsArgumentException --nomethod System.Reflection.Emit.Tests.TypeBuilderGUID.Guid_TypeCreated_NotEmpty - --nomethod System.Reflection.Emit.Tests.AssemblyTests.DefineDynamicAssembly_AssemblyName_AssemblyBuilderAccess --nomethod System.Reflection.Emit.Tests.AssemblyTests.DefineDynamicAssembly_AssemblyName_AssemblyBuilderAccess_CustomAttributeBuilder - -# need to reflect https://github.com/dotnet/coreclr/pull/24937 changes --nomethod System.Reflection.Emit.Tests.MethodBuilderSetSignature.SetSignature_AllParametersNull --nomethod System.Reflection.Emit.Tests.MethodBuilderSetReturnType.SetReturnType_NullReturnType_ReturnsVoid --nomethod System.Reflection.Emit.Tests.MethodBuilderGetGenericArguments.GetGenericArguments_NonGenericMethod_ReturnsEmptyArray --nomethod System.Reflection.Emit.Tests.MethodBuilderSetSignature.SetSignature_NullReturnType_CustomModifiersSetToWrongTypes - #################################################################### ## System.Reflection.Tests #################################################################### From fd36223a72909f510e2cb13683fba84d683beabb Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Fri, 31 Jan 2020 15:58:49 +0300 Subject: [PATCH 43/96] Remove skipped System.Reflection.Tests from rsp file because they pass locally --- src/mono/netcore/CoreFX.issues.rsp | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 8282b08ebfd3f..aed9a799c9351 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -5,18 +5,6 @@ -notrait category=failing -notrait category=IgnoreForCI -#################################################################### -## System.Reflection.Tests -#################################################################### - -# SKIPPED --nomethod System.Reflection.Tests.MemberInfoTests.HasSameMetadataDefinitionAs__CornerCase_HasElementTypes - -# relies on specific exception message --nomethod System.Reflection.Tests.AssemblyTests.LoadFile_ValidPEBadIL_ThrowsBadImageFormatExceptionWithPath --nomethod System.Reflection.Tests.AssemblyTests.LoadFile_PartiallyQualifiedPath_ThrowsArgumentException --nomethod System.Reflection.Tests.AssemblyTests.LoadFile_NoSuchPath_ThrowsFileNotFoundException - # fails on Helix -nomethod System.Reflection.Tests.AssemblyTests.LoadFromStream_Location_IsEmpty From 30b1399650b20947fe72c65c14eba127531be177 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Fri, 31 Jan 2020 16:42:03 +0300 Subject: [PATCH 44/96] Try to re-enabled skipped System.Reflection.Tests.AssemblyTests.LoadFromStream_Location_IsEmpty --- src/mono/netcore/CoreFX.issues.rsp | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index aed9a799c9351..a660c7ff41703 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -5,9 +5,6 @@ -notrait category=failing -notrait category=IgnoreForCI -# fails on Helix --nomethod System.Reflection.Tests.AssemblyTests.LoadFromStream_Location_IsEmpty - #################################################################### ## System.Runtime.Tests #################################################################### From 991973d2566e12971bd44734b5742d5e24fb2bc4 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Fri, 31 Jan 2020 17:53:41 +0300 Subject: [PATCH 45/96] Remove broken namespace --- .../Runtime/InteropServices/Marshal/GetExceptionCodeTests.cs | 1 - .../Runtime/InteropServices/Marshal/GetExceptionPointersTests.cs | 1 - .../Runtime/InteropServices/Marshal/ReadWrite/ByteTests.cs | 1 - .../Runtime/InteropServices/Marshal/ReadWrite/Int16Tests.cs | 1 - .../Runtime/InteropServices/Marshal/ReadWrite/Int32Tests.cs | 1 - .../Runtime/InteropServices/Marshal/ReadWrite/Int64Tests.cs | 1 - .../Runtime/InteropServices/Marshal/ReadWrite/IntPtrTests.cs | 1 - 7 files changed, 7 deletions(-) diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionCodeTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionCodeTests.cs index 1090dd474a508..f89c73ab5c6cc 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionCodeTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionCodeTests.cs @@ -3,7 +3,6 @@ // See the LICENSE file in the project root for more information. using Xunit; -using Microsoft.DotNet.XUnitExtensions.Attributes; #pragma warning disable CS0618 // Type or member is obsolete diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionPointersTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionPointersTests.cs index 47721d93f79db..1403d42b28fae 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionPointersTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionPointersTests.cs @@ -3,7 +3,6 @@ // See the LICENSE file in the project root for more information. using Xunit; -using Microsoft.DotNet.XUnitExtensions.Attributes; namespace System.Runtime.InteropServices.Tests { diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/ByteTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/ByteTests.cs index 2e299bd2a1ccf..750dca4d26343 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/ByteTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/ByteTests.cs @@ -5,7 +5,6 @@ using System.Reflection; using System.Reflection.Emit; using Xunit; -using Microsoft.DotNet.XUnitExtensions.Attributes; #pragma warning disable CS0618 // Type or member is obsolete diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int16Tests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int16Tests.cs index 72fdb943ac1fb..656fdffef1abf 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int16Tests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int16Tests.cs @@ -5,7 +5,6 @@ using System.Reflection; using System.Reflection.Emit; using Xunit; -using Microsoft.DotNet.XUnitExtensions.Attributes; #pragma warning disable CS0618 // Type or member is obsolete diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int32Tests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int32Tests.cs index 58b1429d139d5..42e0e7e64d525 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int32Tests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int32Tests.cs @@ -5,7 +5,6 @@ using System.Reflection; using System.Reflection.Emit; using Xunit; -using Microsoft.DotNet.XUnitExtensions.Attributes; #pragma warning disable CS0618 // Type or member is obsolete diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int64Tests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int64Tests.cs index 2edcf099b0e52..01e78d2ace851 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int64Tests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/Int64Tests.cs @@ -5,7 +5,6 @@ using System.Reflection; using System.Reflection.Emit; using Xunit; -using Microsoft.DotNet.XUnitExtensions.Attributes; #pragma warning disable CS0618 // Type or member is obsolete diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/IntPtrTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/IntPtrTests.cs index e80e9573d12fb..6ecf6a028354b 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/IntPtrTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReadWrite/IntPtrTests.cs @@ -7,7 +7,6 @@ using System.Reflection; using System.Reflection.Emit; using Xunit; -using Microsoft.DotNet.XUnitExtensions.Attributes; #pragma warning disable CS0618 // Type or member is obsolete From daa2f60c460d19ff10e4b5097986456743f048a9 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Fri, 31 Jan 2020 19:16:07 +0300 Subject: [PATCH 46/96] Add an active issue to System.Reflection.Tests.AssemblyTests.LoadFromStream_Location_IsEmpty --- src/libraries/System.Reflection/tests/CoreCLR/AssemblyTests.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/System.Reflection/tests/CoreCLR/AssemblyTests.cs b/src/libraries/System.Reflection/tests/CoreCLR/AssemblyTests.cs index dcc602eed93e9..9f3e75a185dc5 100644 --- a/src/libraries/System.Reflection/tests/CoreCLR/AssemblyTests.cs +++ b/src/libraries/System.Reflection/tests/CoreCLR/AssemblyTests.cs @@ -24,6 +24,7 @@ public void CurrentLocation_HasLocaton() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/22110", TargetFrameworkMonikers.Mono)] public void LoadFromStream_Location_IsEmpty() { Assembly assembly = new TestStreamLoadContext().LoadFromAssemblyName(new AssemblyName("TinyAssembly")); From 542826bf2cacae1a0ec327d94c84f4386e4eb1fb Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 3 Feb 2020 11:12:22 +0300 Subject: [PATCH 47/96] Add an active issue to several System.Reflection tests --- src/libraries/System.Reflection/tests/AssemblyTests.cs | 2 ++ src/libraries/System.Reflection/tests/MemberInfoTests.cs | 1 + 2 files changed, 3 insertions(+) diff --git a/src/libraries/System.Reflection/tests/AssemblyTests.cs b/src/libraries/System.Reflection/tests/AssemblyTests.cs index 7d16eadadc061..4b072cc84ed2e 100644 --- a/src/libraries/System.Reflection/tests/AssemblyTests.cs +++ b/src/libraries/System.Reflection/tests/AssemblyTests.cs @@ -319,6 +319,7 @@ public void LoadFile_NullPath_ThrowsArgumentNullException() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31650", TargetFrameworkMonikers.Mono)] public void LoadFile_NoSuchPath_ThrowsFileNotFoundException() { string rootedPath = Path.GetFullPath(Guid.NewGuid().ToString("N")); @@ -347,6 +348,7 @@ public void LoadFile_ValidPEBadIL_ThrowsBadImageFormatExceptionWithPath() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31649", TargetFrameworkMonikers.Mono)] [InlineData(0)] [InlineData(5)] [InlineData(50)] diff --git a/src/libraries/System.Reflection/tests/MemberInfoTests.cs b/src/libraries/System.Reflection/tests/MemberInfoTests.cs index 834266de3e59e..4d2da9126ee6b 100644 --- a/src/libraries/System.Reflection/tests/MemberInfoTests.cs +++ b/src/libraries/System.Reflection/tests/MemberInfoTests.cs @@ -463,6 +463,7 @@ private static IEnumerable NegativeTypeDataRaw } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31648", TargetFrameworkMonikers.Mono)] public static void HasSameMetadataDefinitionAs__CornerCase_HasElementTypes() { // HasSameMetadataDefinitionAs on an array/byref/pointer type is uninteresting (they'll never be an actual member of a type) From 0d3519b5a0eb2cf091242a10011a51e3b67417a5 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 3 Feb 2020 11:51:02 +0300 Subject: [PATCH 48/96] Remove skipped System.Tests.ExitCodeTests.SigTermExitCode because it passes locally. --- src/mono/netcore/CoreFX.issues.rsp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index a660c7ff41703..12b2b80fe9128 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -9,10 +9,6 @@ ## System.Runtime.Tests #################################################################### -# mono doesn't support termination signals, the test kills a process via libc's kill(pid) -# and expects it to trigger domain.ProcessExit event --nomethod System.Tests.ExitCodeTests.SigTermExitCode - # error: Invalid IL code in (wrapper dynamic-method) object: (System.Xml.Xsl.Runtime.XmlQueryRuntime,System.Xml.XPath.XPathNavigator,double): IL_0179: ret -nomethod System.Tests.Types.VoidTests.IsByRef_Get_ReturnsExpected From eb8e36778135face2ff4c5c07c9ce0f5689d64f5 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 3 Feb 2020 11:52:37 +0300 Subject: [PATCH 49/96] Remove skipped System.Tests.Types.VoidTests.IsByRef_Get_ReturnsExpected from rsp file because it passes locally --- src/mono/netcore/CoreFX.issues.rsp | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 12b2b80fe9128..bbb675144ca8c 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -9,9 +9,6 @@ ## System.Runtime.Tests #################################################################### -# error: Invalid IL code in (wrapper dynamic-method) object: (System.Xml.Xsl.Runtime.XmlQueryRuntime,System.Xml.XPath.XPathNavigator,double): IL_0179: ret --nomethod System.Tests.Types.VoidTests.IsByRef_Get_ReturnsExpected - # GCSettings.LatencyMode is not implemented -nomethod System.Tests.GCTests.LatencyRoundtrips From 3838bca7b97acf0580dfd49eb11c6c31286c0f30 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 3 Feb 2020 11:57:23 +0300 Subject: [PATCH 50/96] Remove skipped System.Tests.GCTests.LatencyRoundtrips from rsp file because it passes locally --- src/mono/netcore/CoreFX.issues.rsp | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index bbb675144ca8c..058a6cc3e01b7 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -9,9 +9,6 @@ ## System.Runtime.Tests #################################################################### -# GCSettings.LatencyMode is not implemented --nomethod System.Tests.GCTests.LatencyRoundtrips - # GC.GetGCMemoryInfo is not implemented -nomethod System.Tests.GCExtendedTests.GetGCMemoryInfo From 4fd0db25f49edd1b487b3737d9d7554c16b12035 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 3 Feb 2020 12:04:58 +0300 Subject: [PATCH 51/96] Remove skipped System.Tests.GCExtendedTests.GetGCMemoryInfo from rsp-file because the related functionality has been implemented (see https://github.com/mono/mono/issues/15236) --- src/mono/netcore/CoreFX.issues.rsp | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 058a6cc3e01b7..bfffc6b62f18b 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -9,9 +9,6 @@ ## System.Runtime.Tests #################################################################### -# GC.GetGCMemoryInfo is not implemented --nomethod System.Tests.GCExtendedTests.GetGCMemoryInfo - # flaky test, System.ArgumentNullException : Key cannot be null. Parameter name: key -nomethod System.Tests.GetEnvironmentVariable.EnvironmentVariablesAreHashtable From bb40fb89426b5905d3fa81fc6d6569be4b42ad4b Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 3 Feb 2020 12:11:28 +0300 Subject: [PATCH 52/96] Remove skipped System.Tests.GetEnvironmentVariable.EnvironmentVariablesAreHashtable from rsp file because it passes locally --- src/mono/netcore/CoreFX.issues.rsp | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index bfffc6b62f18b..ee4b1f9cf117e 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -5,13 +5,6 @@ -notrait category=failing -notrait category=IgnoreForCI -#################################################################### -## System.Runtime.Tests -#################################################################### - -# flaky test, System.ArgumentNullException : Key cannot be null. Parameter name: key --nomethod System.Tests.GetEnvironmentVariable.EnvironmentVariablesAreHashtable - #################################################################### ## System.Threading.Tests #################################################################### From ce32cbcbc03cc276cd27471ae622a4016e73c615 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 3 Feb 2020 12:33:04 +0300 Subject: [PATCH 53/96] Turn System.Threading.Tasks.Tests.ExecutionContextFlowTest.TaskCompletionSourceDoesntCaptureExecutionContext into a conditional theory because it requires precise GC --- .../tests/Task/ExecutionContextFlowTest.cs | 2 +- src/mono/netcore/CoreFX.issues.rsp | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/libraries/System.Threading.Tasks/tests/Task/ExecutionContextFlowTest.cs b/src/libraries/System.Threading.Tasks/tests/Task/ExecutionContextFlowTest.cs index e562d7440859b..b59747ade4f74 100644 --- a/src/libraries/System.Threading.Tasks/tests/Task/ExecutionContextFlowTest.cs +++ b/src/libraries/System.Threading.Tasks/tests/Task/ExecutionContextFlowTest.cs @@ -82,7 +82,7 @@ public static IEnumerable TaskCompletionSourceDoesntCaptureExecutionCo yield return new object[] { new Func>(() => new TaskCompletionSource(new object(), TaskCreationOptions.RunContinuationsAsynchronously)) }; } - [Theory] + [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsPreciseGcSupported))] [MemberData(nameof(TaskCompletionSourceDoesntCaptureExecutionContext_MemberData))] public static async Task TaskCompletionSourceDoesntCaptureExecutionContext(Func> tcsFactory) { diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index ee4b1f9cf117e..cf062cced1327 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -9,9 +9,6 @@ ## System.Threading.Tests #################################################################### -# Requires precise GC (should be ignored in dotnet/corefx for mono) --nomethod System.Threading.Tasks.Tests.ExecutionContextFlowTest.TaskCompletionSourceDoesntCaptureExecutionContext - # flaky, causes stack overflow -nomethod System.Threading.Tasks.Tests.TaskContinueWithTests.LongContinuationChain_ContinueWith_DoesNotStackOverflow From f5127c0aa47b127e5fc2f789ae38a0a4c2ee2d0c Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 3 Feb 2020 12:36:27 +0300 Subject: [PATCH 54/96] Try to re-enable System.Threading.Tasks.Tests.TaskContinueWithTests.LongContinuationChain_ContinueWith_DoesNotStackOverflow --- src/mono/netcore/CoreFX.issues.rsp | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index cf062cced1327..09b8a34e4605d 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -5,13 +5,6 @@ -notrait category=failing -notrait category=IgnoreForCI -#################################################################### -## System.Threading.Tests -#################################################################### - -# flaky, causes stack overflow --nomethod System.Threading.Tasks.Tests.TaskContinueWithTests.LongContinuationChain_ContinueWith_DoesNotStackOverflow - #################################################################### ## System.Threading.ThreadPool.Tests #################################################################### From 3a17e8fc97a5bd9b36bd306ca4bca800242ffac9 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 3 Feb 2020 12:48:09 +0300 Subject: [PATCH 55/96] Remove skipped System.Threading.ThreadPools.Tests.ThreadPoolTests.SetMinThreadsTo0Test from rsp file because it passes locally --- src/mono/netcore/CoreFX.issues.rsp | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 09b8a34e4605d..6b8db30f6285a 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -9,9 +9,6 @@ ## System.Threading.ThreadPool.Tests #################################################################### -# TODO: Differences in behaviour between NetFX and CoreFX --nomethod System.Threading.ThreadPools.Tests.ThreadPoolTests.SetMinThreadsTo0Test - # Explicitly skipped if it's MonoVM (SkipOnTargetFramework) -nomethod System.Threading.ThreadPools.Tests.ThreadPoolTests.SetMinMaxThreadsTest_ChangedInDotNetCore From 380a7077023554bb22c3b710946aa23e559c0a32 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 3 Feb 2020 12:49:59 +0300 Subject: [PATCH 56/96] Remove System.Threading.ThreadPools.Tests.ThreadPoolTests.SetMinMaxThreadsTest_ChangedInDotNetCore from rsp file because it's explicitly skipped on Mono using SkipOnTargetFramework attribute --- src/mono/netcore/CoreFX.issues.rsp | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 6b8db30f6285a..0c1100c68fbdf 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -5,13 +5,6 @@ -notrait category=failing -notrait category=IgnoreForCI -#################################################################### -## System.Threading.ThreadPool.Tests -#################################################################### - -# Explicitly skipped if it's MonoVM (SkipOnTargetFramework) --nomethod System.Threading.ThreadPools.Tests.ThreadPoolTests.SetMinMaxThreadsTest_ChangedInDotNetCore - #################################################################### ## System.ComponentModel.Composition.Tests #################################################################### From 92efedc3fa36f72afa6b387461da15bdfca019c9 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 3 Feb 2020 16:33:50 +0300 Subject: [PATCH 57/96] Add an active issue to System.Tests.ExitCodeTests.SigTermExitCode and System.Tests.GCTests.LatencyRoundtrips tests --- src/libraries/System.Runtime/tests/System/ExitCodeTests.Unix.cs | 1 + src/libraries/System.Runtime/tests/System/GCTests.cs | 1 + 2 files changed, 2 insertions(+) diff --git a/src/libraries/System.Runtime/tests/System/ExitCodeTests.Unix.cs b/src/libraries/System.Runtime/tests/System/ExitCodeTests.Unix.cs index 3bf81ef230b0f..2e82dee2a1fed 100644 --- a/src/libraries/System.Runtime/tests/System/ExitCodeTests.Unix.cs +++ b/src/libraries/System.Runtime/tests/System/ExitCodeTests.Unix.cs @@ -17,6 +17,7 @@ public class ExitCodeTests private static extern int kill(int pid, int sig); [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31656", TargetFrameworkMonikers.Mono)] [InlineData(null)] [InlineData(0)] [InlineData(42)] diff --git a/src/libraries/System.Runtime/tests/System/GCTests.cs b/src/libraries/System.Runtime/tests/System/GCTests.cs index 865250d579fd0..aa61d854dd58c 100644 --- a/src/libraries/System.Runtime/tests/System/GCTests.cs +++ b/src/libraries/System.Runtime/tests/System/GCTests.cs @@ -399,6 +399,7 @@ public static void LargeObjectHeapCompactionModeRoundTrips(GCLargeObjectHeapComp } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31657", TargetFrameworkMonikers.Mono)] [InlineData(GCLatencyMode.Batch)] [InlineData(GCLatencyMode.Interactive)] public static void LatencyRoundtrips(GCLatencyMode value) From 9edaa39dd0f8a5467822e92ddd7c36ba8c8a3f75 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 3 Feb 2020 16:56:30 +0300 Subject: [PATCH 58/96] Remove skipped System.Data.Tests.SqlTypes.SqlCharsTest.ReadWriteXmlTest from rsp file because it passes locally --- src/mono/netcore/CoreFX.issues.rsp | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 0c1100c68fbdf..fc1c8fb4ce434 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -18,13 +18,6 @@ -nomethod System.ComponentModel.Composition.MetadataViewProviderTests.GetMetadataView_IMetadataViewWithDefaultedInt64 -nomethod System.ComponentModel.Composition.ExportCollectionTests.ImportCollectionsFromContainerOnly -#################################################################### -## System.Data.Common.Tests -#################################################################### - -# Invalid IL - IL_00bc: castclass 0x0100000d --nomethod System.Data.Tests.SqlTypes.SqlCharsTest.ReadWriteXmlTest - #################################################################### ## System.Diagnostics.StackTrace.Tests #################################################################### From adc725950f010e11175e5d30a7a0e0c25886fce2 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 3 Feb 2020 20:39:39 +0300 Subject: [PATCH 59/96] Add an active issue to System.Tests.GCExtendedTests.GetGCMemoryInfo because it fails on helix --- src/libraries/System.Runtime/tests/System/GCTests.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/System.Runtime/tests/System/GCTests.cs b/src/libraries/System.Runtime/tests/System/GCTests.cs index aa61d854dd58c..7aef31969f247 100644 --- a/src/libraries/System.Runtime/tests/System/GCTests.cs +++ b/src/libraries/System.Runtime/tests/System/GCTests.cs @@ -782,6 +782,7 @@ public static void GetAllocatedBytesForCurrentThread(int size) } [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotArmProcess))] // [ActiveIssue("https://github.com/dotnet/corefx/issues/37378")] + [ActiveIssue("https://github.com/mono/mono/issues/15236", TargetFrameworkMonikers.Mono)] public static void GetGCMemoryInfo() { RemoteExecutor.Invoke(() => From 9919b2adee9214657061f06de4df7dff8ea44cd5 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 4 Feb 2020 16:31:26 +0300 Subject: [PATCH 60/96] Add an active issue --- .../System.Runtime/tests/System/Type/TypePropertyTests.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/System.Runtime/tests/System/Type/TypePropertyTests.cs b/src/libraries/System.Runtime/tests/System/Type/TypePropertyTests.cs index 65d19f0f202ae..61c170d870a80 100644 --- a/src/libraries/System.Runtime/tests/System/Type/TypePropertyTests.cs +++ b/src/libraries/System.Runtime/tests/System/Type/TypePropertyTests.cs @@ -531,6 +531,7 @@ public class EnumTypeTests : ClassTypeTestBase public override Type BaseType => typeof(ValueType); } + [ActiveIssue("https://github.com/dotnet/runtime/issues/31713", TargetFrameworkMonikers.Mono)] public class VoidTests : StructTypeTestBase { public override Type CreateType() => typeof(void); From cc07bdf0cfb518fa8782763c00ea1dc0f9f7efb0 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 4 Feb 2020 18:43:03 +0300 Subject: [PATCH 61/96] Add an active issue --- .../ComponentModel/Composition/CompositionContainerTests.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerTests.cs index 39832f52b5990..3d98248288614 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerTests.cs @@ -1751,6 +1751,7 @@ public void GetExportsOfTTMetadataView1_TypeAsMetadataViewTypeArgument_IsUsedAsM } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void GetExportsOfTTMetadataView2_TypeAsMetadataViewTypeArgument_IsUsedAsMetadataConstraint() { var metadata = new Dictionary(); From 938ae1e290949b5dbe034686ba77a503a280e486 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Wed, 5 Feb 2020 12:46:54 +0300 Subject: [PATCH 62/96] Re-add an active issue to System.Tests.ExceptionTests.ThrowStatementDoesNotResetExceptionStackLineOtherMethod --- src/libraries/System.Runtime/tests/System/ExceptionTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Runtime/tests/System/ExceptionTests.cs b/src/libraries/System.Runtime/tests/System/ExceptionTests.cs index faf39b7155e19..aa92c0f804e8d 100644 --- a/src/libraries/System.Runtime/tests/System/ExceptionTests.cs +++ b/src/libraries/System.Runtime/tests/System/ExceptionTests.cs @@ -111,7 +111,7 @@ private static (string, string, int) ThrowAndRethrowSameMethod(out (string, stri [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotArm64Process))] // [ActiveIssue(https://github.com/dotnet/runtime/issues/1871)] can't use ActiveIssue for archs - // [ActiveIssue("https://github.com/mono/mono/issues/15141", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15141", TargetFrameworkMonikers.Mono)] public static void ThrowStatementDoesNotResetExceptionStackLineOtherMethod() { (string, string, int) rethrownExceptionStackFrame = (null, null, 0); From c58858fd38b4f20a4d3fff7cc8cec0c2d11eda2a Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Wed, 5 Feb 2020 12:57:15 +0300 Subject: [PATCH 63/96] Move skipped System.ComponentModel.Composition.MetadataViewProviderTests.GetMetadataView_InterfaceWithIndexer_ShouldThrowNotSupportedException with an active issue out of rsp file (see https://github.com/mono/mono/issues/15169) --- .../ComponentModel/Composition/MetadataViewProviderTests.cs | 1 + src/mono/netcore/CoreFX.issues.rsp | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/MetadataViewProviderTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/MetadataViewProviderTests.cs index fe2ef1eb4ea2f..54aa79f975f83 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/MetadataViewProviderTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/MetadataViewProviderTests.cs @@ -93,6 +93,7 @@ public void GetMetadataView_InterfaceWithEvent_ShouldThrowNotSupportedException( } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15169", TargetFrameworkMonikers.Mono)] public void GetMetadataView_InterfaceWithIndexer_ShouldThrowNotSupportedException() { var metadata = new Dictionary(); diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index fc1c8fb4ce434..31eb9664125d6 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -9,7 +9,6 @@ ## System.ComponentModel.Composition.Tests #################################################################### --nomethod System.ComponentModel.Composition.MetadataViewProviderTests.GetMetadataView_InterfaceWithIndexer_ShouldThrowNotSupportedException -nomethod Tests.Integration.ExportFactoryTests.ExportFactoryStandardImports_ShouldWorkProperly # flaky test - System.TypeLoadException : Could not load type '_proxy_System.ComponentModel.Composition.IStronglyTypedStructure_3b7f133d-79c7-449e-8f68-22aa093dbb8d' from assembly ''. From 239a4fe3fa86103675d279aef03a56360f0c3fc5 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Wed, 5 Feb 2020 13:04:09 +0300 Subject: [PATCH 64/96] Remove skipped Tests.Integration.ExportFactoryTests.ExportFactoryStandardImports_ShouldWorkProperly from rsp file because it's already disabled within the entire Tests.Integration.ExportFactoryTests class (see https://github.com/mono/mono/issues/16417) --- src/mono/netcore/CoreFX.issues.rsp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 31eb9664125d6..79e51315072df 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -9,8 +9,6 @@ ## System.ComponentModel.Composition.Tests #################################################################### --nomethod Tests.Integration.ExportFactoryTests.ExportFactoryStandardImports_ShouldWorkProperly - # flaky test - System.TypeLoadException : Could not load type '_proxy_System.ComponentModel.Composition.IStronglyTypedStructure_3b7f133d-79c7-449e-8f68-22aa093dbb8d' from assembly ''. -nomethod System.ComponentModel.Composition.MetadataAttributeTests.StronglyTypedStructureTest -nomethod System.ComponentModel.Composition.MetadataAttributeTests.StronglyTypedStructureTestWithTransparentViews From 6dbe8619048c4f214e681abab46ef3e03fb1446e Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Wed, 5 Feb 2020 13:25:44 +0300 Subject: [PATCH 65/96] Remove several skipped System.ComponentModel.Composition.Tests from rsp file because they pass locally. --- src/mono/netcore/CoreFX.issues.rsp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 79e51315072df..2d995f3437cdf 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -9,10 +9,6 @@ ## System.ComponentModel.Composition.Tests #################################################################### -# flaky test - System.TypeLoadException : Could not load type '_proxy_System.ComponentModel.Composition.IStronglyTypedStructure_3b7f133d-79c7-449e-8f68-22aa093dbb8d' from assembly ''. --nomethod System.ComponentModel.Composition.MetadataAttributeTests.StronglyTypedStructureTest --nomethod System.ComponentModel.Composition.MetadataAttributeTests.StronglyTypedStructureTestWithTransparentViews --nomethod System.ComponentModel.Composition.MetadataViewProviderTests.GetMetadataView_IMetadataViewWithDefaultedInt64 -nomethod System.ComponentModel.Composition.ExportCollectionTests.ImportCollectionsFromContainerOnly #################################################################### From 1d3c353a86bf0c5b0101df97fed66a26fce0cb27 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Wed, 5 Feb 2020 13:26:58 +0300 Subject: [PATCH 66/96] Move skipped System.ComponentModel.Composition.ExportCollectionTests.ImportCollectionsFromContainerOnly with an active issue out of rsp file --- .../ComponentModel/Composition/ExportCollectionTests.cs | 1 + src/mono/netcore/CoreFX.issues.rsp | 6 ------ 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportCollectionTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportCollectionTests.cs index 2844d0dac13da..1ddab0579459c 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportCollectionTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportCollectionTests.cs @@ -142,6 +142,7 @@ public class ExporterDefault42 } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31792", TargetFrameworkMonikers.Mono)] [Trait("Type", "Integration")] public void ImportCollectionsFromContainerOnly() { diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 2d995f3437cdf..3f0c1dfea4852 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -5,12 +5,6 @@ -notrait category=failing -notrait category=IgnoreForCI -#################################################################### -## System.ComponentModel.Composition.Tests -#################################################################### - --nomethod System.ComponentModel.Composition.ExportCollectionTests.ImportCollectionsFromContainerOnly - #################################################################### ## System.Diagnostics.StackTrace.Tests #################################################################### From 5a036643caeb4afc19913683f841026ea7a60f0f Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Wed, 5 Feb 2020 15:46:36 +0300 Subject: [PATCH 67/96] Move skipped System.Diagnostics.Tests.StackTraceTests.Ctor_Exception_SkipFrames and System.Diagnostics.Tests.StackTraceTests.Ctor_Exception_SkipFrames_FNeedFileInfo tests with an active issue out of rsp file. --- .../tests/StackTraceTests.cs | 2 ++ src/mono/netcore/CoreFX.issues.rsp | 8 -------- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/libraries/System.Diagnostics.StackTrace/tests/StackTraceTests.cs b/src/libraries/System.Diagnostics.StackTrace/tests/StackTraceTests.cs index 27c3b54e60a52..93ead0564a723 100644 --- a/src/libraries/System.Diagnostics.StackTrace/tests/StackTraceTests.cs +++ b/src/libraries/System.Diagnostics.StackTrace/tests/StackTraceTests.cs @@ -143,6 +143,7 @@ public void Ctor_EmptyException_FNeedFileInfo(bool fNeedFileInfo) } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31796", TargetFrameworkMonikers.Mono)] [InlineData(0)] [InlineData(1)] public void Ctor_Exception_SkipFrames(int skipFrames) @@ -181,6 +182,7 @@ public void Ctor_EmptyException_SkipFrames() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31796", TargetFrameworkMonikers.Mono)] [InlineData(0, true)] [InlineData(1, true)] [InlineData(0, false)] diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 3f0c1dfea4852..e5b8269520381 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -5,14 +5,6 @@ -notrait category=failing -notrait category=IgnoreForCI -#################################################################### -## System.Diagnostics.StackTrace.Tests -#################################################################### - -# JIT should not inline custom throw helpers --nomethod System.Diagnostics.Tests.StackTraceTests.Ctor_Exception_SkipFrames --nomethod System.Diagnostics.Tests.StackTraceTests.Ctor_Exception_SkipFrames_FNeedFileInfo - # Assert.Contains() Failure -nomethod System.Diagnostics.Tests.StackTraceTests.ToString_Invoke_ReturnsExpected From 4e11c6773648bba3bc8b7a4532fe5064eb7ba6a1 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Wed, 5 Feb 2020 16:12:48 +0300 Subject: [PATCH 68/96] Move skipped System.Diagnostics.Tests.StackTraceTests.ToString_Invoke_ReturnsExpected with an active issue out of rsp file --- .../System.Diagnostics.StackTrace/tests/StackTraceTests.cs | 1 + src/mono/netcore/CoreFX.issues.rsp | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/libraries/System.Diagnostics.StackTrace/tests/StackTraceTests.cs b/src/libraries/System.Diagnostics.StackTrace/tests/StackTraceTests.cs index 93ead0564a723..824241e4f929e 100644 --- a/src/libraries/System.Diagnostics.StackTrace/tests/StackTraceTests.cs +++ b/src/libraries/System.Diagnostics.StackTrace/tests/StackTraceTests.cs @@ -274,6 +274,7 @@ public void GetFrame_InvalidIndex_ReturnsNull() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31797", TargetFrameworkMonikers.Mono)] [MemberData(nameof(ToString_TestData))] public void ToString_Invoke_ReturnsExpected(StackTrace stackTrace, string expectedToString) { diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index e5b8269520381..ccc5ec46ff045 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -5,9 +5,6 @@ -notrait category=failing -notrait category=IgnoreForCI -# Assert.Contains() Failure --nomethod System.Diagnostics.Tests.StackTraceTests.ToString_Invoke_ReturnsExpected - #################################################################### ## System.Reflection.Metadata.Tests #################################################################### From 49fa1e9220ecc69d45f59ad6d0eb3a53ed7193f7 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Wed, 5 Feb 2020 17:15:20 +0300 Subject: [PATCH 69/96] Remove skipped System.Reflection.Tests.MetadataLoadContextTests.RelocatableAssembly from rsp file because it passes locally. --- src/mono/netcore/CoreFX.issues.rsp | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index ccc5ec46ff045..4af6bddec86cf 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -5,13 +5,6 @@ -notrait category=failing -notrait category=IgnoreForCI -#################################################################### -## System.Reflection.Metadata.Tests -#################################################################### - -# Test broken on Mono, added in https://github.com/dotnet/corefx/pull/40581 --nomethod System.Reflection.Tests.MetadataLoadContextTests.RelocatableAssembly - #################################################################### ## System.Runtime.Loader.RefEmitLoadContext.Tests #################################################################### From b8b2796712422d3b18af82018615b98b480d446c Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Wed, 5 Feb 2020 18:09:58 +0300 Subject: [PATCH 70/96] Move skipped System.Runtime.Loader.Tests.RefEmitLoadContextTests.LoadRefEmitAssembly with an active issue out of rsp file --- .../tests/RefEmitLoadContext/RefEmitLoadContextTest.cs | 1 + src/mono/netcore/CoreFX.issues.rsp | 7 ------- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/libraries/System.Runtime.Loader/tests/RefEmitLoadContext/RefEmitLoadContextTest.cs b/src/libraries/System.Runtime.Loader/tests/RefEmitLoadContext/RefEmitLoadContextTest.cs index 1034f6dddc240..e26f9f754b608 100644 --- a/src/libraries/System.Runtime.Loader/tests/RefEmitLoadContext/RefEmitLoadContextTest.cs +++ b/src/libraries/System.Runtime.Loader/tests/RefEmitLoadContext/RefEmitLoadContextTest.cs @@ -69,6 +69,7 @@ private static void DeleteDirectory() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31804", TargetFrameworkMonikers.Mono)] public static void LoadRefEmitAssembly() { Init(); diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 4af6bddec86cf..9e7f28605666f 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -5,13 +5,6 @@ -notrait category=failing -notrait category=IgnoreForCI -#################################################################### -## System.Runtime.Loader.RefEmitLoadContext.Tests -#################################################################### - -# Relies on AssemblyLoadContext.GetLoadContext, which is not implemented --nomethod System.Runtime.Loader.Tests.RefEmitLoadContextTests.LoadRefEmitAssembly - #################################################################### ## System.Threading.Overlapped.Tests #################################################################### From 50990eb1028db2bdf771207211e63154affbaa00 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Wed, 5 Feb 2020 18:31:56 +0300 Subject: [PATCH 71/96] Moved skipped ThreadPoolBoundHandleTests.PreAllocatedOverlapped_NullAsCallback_ThrowsArgumentNullException with an active issue out of rsp file (see https://github.com/mono/mono/issues/15313) --- .../ThreadPoolBoundHandle_PreAllocatedOverlappedTests.cs | 1 + src/mono/netcore/CoreFX.issues.rsp | 7 ------- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/libraries/System.Threading.Overlapped/tests/ThreadPoolBoundHandle_PreAllocatedOverlappedTests.cs b/src/libraries/System.Threading.Overlapped/tests/ThreadPoolBoundHandle_PreAllocatedOverlappedTests.cs index aae5594f79946..9ed9422b72c97 100644 --- a/src/libraries/System.Threading.Overlapped/tests/ThreadPoolBoundHandle_PreAllocatedOverlappedTests.cs +++ b/src/libraries/System.Threading.Overlapped/tests/ThreadPoolBoundHandle_PreAllocatedOverlappedTests.cs @@ -10,6 +10,7 @@ public partial class ThreadPoolBoundHandleTests { [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15313", TargetFrameworkMonikers.Mono)] public unsafe void PreAllocatedOverlapped_NullAsCallback_ThrowsArgumentNullException() { AssertExtensions.Throws("callback", () => diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 9e7f28605666f..bc68b4e166f40 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -5,13 +5,6 @@ -notrait category=failing -notrait category=IgnoreForCI -#################################################################### -## System.Threading.Overlapped.Tests -#################################################################### - -# Test not run --nomethod ThreadPoolBoundHandleTests.PreAllocatedOverlapped_NullAsCallback_ThrowsArgumentNullException - #################################################################### ## System.Runtime.Extensions.Tests #################################################################### From 7e33476d822d73d1d7aa6cc736da8e69ad4cdc64 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Thu, 6 Feb 2020 16:10:22 +0300 Subject: [PATCH 72/96] Move skipped System.Runtime.Tests.ProfileOptimizationTest.ProfileOptimization_CheckFileExists with an active issue out of rsp file --- .../tests/System/Runtime/ProfileOptimization.cs | 1 + src/mono/netcore/CoreFX.issues.rsp | 7 ------- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/libraries/System.Runtime.Extensions/tests/System/Runtime/ProfileOptimization.cs b/src/libraries/System.Runtime.Extensions/tests/System/Runtime/ProfileOptimization.cs index 83ef8f947ac2f..9c39e28e2e0bd 100644 --- a/src/libraries/System.Runtime.Extensions/tests/System/Runtime/ProfileOptimization.cs +++ b/src/libraries/System.Runtime.Extensions/tests/System/Runtime/ProfileOptimization.cs @@ -12,6 +12,7 @@ namespace System.Runtime.Tests public class ProfileOptimizationTest : FileCleanupTestBase { [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31853", TargetFrameworkMonikers.Mono)] public void ProfileOptimization_CheckFileExists() { string profileFile = GetTestFileName(); diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index bc68b4e166f40..0ae6c3022f56a 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -5,13 +5,6 @@ -notrait category=failing -notrait category=IgnoreForCI -#################################################################### -## System.Runtime.Extensions.Tests -#################################################################### - -# AssemblyLoadContext.SetProfileOptimizationRoot is no-op (not implemented) --nomethod System.Runtime.Tests.ProfileOptimizationTest.ProfileOptimization_CheckFileExists - #################################################################### ## System.Reflection.Emit.Lightweight.Tests #################################################################### From 69c299e9deb04bab05e375ed0f6b2e2e882d3de0 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Thu, 6 Feb 2020 17:08:09 +0300 Subject: [PATCH 73/96] Move skipped System.Reflection.Emit.Tests.DynamicILInfoTests with an active issue out of rsp file --- .../tests/DynamicILInfoTests.cs | 8 ++++++++ src/mono/netcore/CoreFX.issues.rsp | 10 ---------- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicILInfoTests.cs b/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicILInfoTests.cs index 76e293728c323..b5c977b493892 100644 --- a/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicILInfoTests.cs +++ b/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicILInfoTests.cs @@ -13,6 +13,7 @@ public class DynamicILInfoTests private static string HelloWorld() => "hello, world".ToUpper(); [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31857", TargetFrameworkMonikers.Mono)] public void GetTokenFor_String_Success() { DynamicMethod dynamicMethod = new DynamicMethod(nameof(HelloWorld), typeof(string), new Type[] { }, typeof(DynamicILInfoTests), false); @@ -43,6 +44,7 @@ private static long Fib(long value) } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31857", TargetFrameworkMonikers.Mono)] public void GetTokenFor_DynamicMethod_Success() { // Calling DynamicMethod recursively @@ -117,6 +119,7 @@ public override int GetHashCode() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31857", TargetFrameworkMonikers.Mono)] public void GetTokenFor_CtorMethodAndField_Success() { DynamicMethod dynamicMethod = new DynamicMethod(nameof(Mock), typeof(Person), new Type[] { }, typeof(DynamicILInfoTests), false); @@ -248,6 +251,7 @@ private static string ContactString() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31857", TargetFrameworkMonikers.Mono)] public void GetTokenFor_StringGenerics_Success() { DynamicMethod dynamicMethod = new DynamicMethod(nameof(ContactString), typeof(string), Type.EmptyTypes, typeof(DynamicILInfoTests), false); @@ -343,6 +347,7 @@ private static int ExceptionTest() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31857", TargetFrameworkMonikers.Mono)] public void GetTokenFor_Exception_Success() { DynamicMethod dynamicMethod = new DynamicMethod(nameof(ExceptionTest), typeof(int), Type.EmptyTypes, typeof(DynamicILInfoTests), false); @@ -424,6 +429,7 @@ private static bool GenericMethod() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31857", TargetFrameworkMonikers.Mono)] public void Test_GenericMethod() { DynamicMethod dynamicMethod = new DynamicMethod(nameof(GenericMethod), typeof(bool), Type.EmptyTypes, typeof(DynamicILInfoTests), false); @@ -503,6 +509,7 @@ private static int TwoDimTest() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31857", TargetFrameworkMonikers.Mono)] public void Test_TwoDimTest() { // 2-D array (set/address/get) @@ -576,6 +583,7 @@ private static string CallGM() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31857", TargetFrameworkMonikers.Mono)] public void Test_CallGM() { // GenericMethod inside GenericType diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 0ae6c3022f56a..c03b28a2b2028 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -9,16 +9,6 @@ ## System.Reflection.Emit.Lightweight.Tests #################################################################### -# Need to implement System.Reflection.Emit.DynamicILInfo.SetLocalSignature(Byte[] localSignature) --nomethod System.Reflection.Emit.Tests.DynamicILInfoTests.Test_TwoDimTest --nomethod System.Reflection.Emit.Tests.DynamicILInfoTests.Test_GenericMethod --nomethod System.Reflection.Emit.Tests.DynamicILInfoTests.GetTokenFor_CtorMethodAndField_Success --nomethod System.Reflection.Emit.Tests.DynamicILInfoTests.GetTokenFor_String_Success --nomethod System.Reflection.Emit.Tests.DynamicILInfoTests.GetTokenFor_StringGenerics_Success --nomethod System.Reflection.Emit.Tests.DynamicILInfoTests.Test_CallGM --nomethod System.Reflection.Emit.Tests.DynamicILInfoTests.GetTokenFor_Exception_Success --nomethod System.Reflection.Emit.Tests.DynamicILInfoTests.GetTokenFor_DynamicMethod_Success - # Need to implement System.Reflection.Emit.DynamicILInfo.SetExceptions(Byte* exceptions, Int32 exceptionsSize) -nomethod System.Reflection.Emit.Tests.DynamicILInfoTests.SetX_NullInput_ThrowsArgumentNullException -nomethod System.Reflection.Emit.Tests.DynamicMethodctor1.InvalidOwner_ThrowsArgumentException From 23b2e97d596b3689d46cc619dcbc4496e2c8c9e9 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Thu, 6 Feb 2020 17:24:22 +0300 Subject: [PATCH 74/96] Move skipped System.Reflection.Emit.Tests.DynamicILInfoTests.SetX_NullInput_ThrowsArgumentNullException and System.Reflection.Emit.Tests.DynamicMethodctor1.InvalidOwner_ThrowsArgumentException with an active issue out of rsp file --- .../tests/DynamicILInfoTests.cs | 1 + .../tests/DynamicMethodCtor.cs | 1 + src/mono/netcore/CoreFX.issues.rsp | 8 -------- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicILInfoTests.cs b/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicILInfoTests.cs index b5c977b493892..1c9c3af692bd8 100644 --- a/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicILInfoTests.cs +++ b/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicILInfoTests.cs @@ -655,6 +655,7 @@ private static void PutInteger4(int value, int startPos, byte[] array) } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31858", TargetFrameworkMonikers.Mono)] [InlineData(true)] [InlineData(false)] public unsafe void SetX_NullInput_ThrowsArgumentNullException(bool skipVisibility) diff --git a/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicMethodCtor.cs b/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicMethodCtor.cs index e35fba88e7fc6..5c5010aa4ffb0 100644 --- a/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicMethodCtor.cs +++ b/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicMethodCtor.cs @@ -160,6 +160,7 @@ public void NullOwner_ThrowsArgumentNullException() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31858", TargetFrameworkMonikers.Mono)] [InlineData(typeof(int[]))] [InlineData(typeof(TestInterface))] [InlineData(typeof(GenericClass<>))] diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index c03b28a2b2028..1ce1857b6d271 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -5,14 +5,6 @@ -notrait category=failing -notrait category=IgnoreForCI -#################################################################### -## System.Reflection.Emit.Lightweight.Tests -#################################################################### - -# Need to implement System.Reflection.Emit.DynamicILInfo.SetExceptions(Byte* exceptions, Int32 exceptionsSize) --nomethod System.Reflection.Emit.Tests.DynamicILInfoTests.SetX_NullInput_ThrowsArgumentNullException --nomethod System.Reflection.Emit.Tests.DynamicMethodctor1.InvalidOwner_ThrowsArgumentException - #################################################################### ## System.Runtime.Loader.Tests #################################################################### From 7c50f19a27697a9471f7b6ec325f55989f64dad3 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Fri, 7 Feb 2020 15:50:43 +0300 Subject: [PATCH 75/96] Add an active issue to System.Threading.Tasks.Tests.TaskContinueWithTests.LongContinuationChain_ContinueWith_DoesNotStackOverflow because it's flaky --- .../System.Threading.Tasks/tests/Task/TaskContinueWithTests.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/System.Threading.Tasks/tests/Task/TaskContinueWithTests.cs b/src/libraries/System.Threading.Tasks/tests/Task/TaskContinueWithTests.cs index 6ac41c1800351..9e31b295c8237 100644 --- a/src/libraries/System.Threading.Tasks/tests/Task/TaskContinueWithTests.cs +++ b/src/libraries/System.Threading.Tasks/tests/Task/TaskContinueWithTests.cs @@ -1212,6 +1212,7 @@ public static void RunLazyCancellationTests_Negative() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2084", TargetFrameworkMonikers.Mono)] public static void LongContinuationChain_ContinueWith_DoesNotStackOverflow() { const int DiveDepth = 12_000; From 1e43fdb57fb59379a5932e59ba26ad3f7678a663 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Sat, 8 Feb 2020 20:51:43 +0300 Subject: [PATCH 76/96] Add an active issue to Tests.Integration.DiscoveryTests.DiscoverAddinsWithCombinedCustomExportAndMetadataAttribute --- .../tests/System/Integration/DiscoveryTests.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DiscoveryTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DiscoveryTests.cs index b2c64e33a3a58..da864d09ac47b 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DiscoveryTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DiscoveryTests.cs @@ -669,6 +669,7 @@ public void Shutdown() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] public void DiscoverAddinsWithCombinedCustomExportAndMetadataAttribute() { var container = ContainerFactory.CreateWithAttributedCatalog(typeof(Addin1), typeof(Addin2), typeof(Addin3)); From 55fb2fe874711ec583d521b26da1cdab0e0af5ae Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 10 Feb 2020 14:36:05 +0300 Subject: [PATCH 77/96] Add an active issue to System.Threading.ThreadPools.Tests.ThreadPoolTests.SetMinMaxThreadsTest_ChangedInDotNetCore --- .../System.Threading.ThreadPool/tests/ThreadPoolTests.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs b/src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs index fa628b28371c2..1e01611abda0d 100644 --- a/src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs +++ b/src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs @@ -151,6 +151,7 @@ public static void SetMinMaxThreadsTest() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/32020", TargetFrameworkMonikers.Mono)] public static void SetMinMaxThreadsTest_ChangedInDotNetCore() { int minw, minc, maxw, maxc; From 6d62ffb9d76d99c25bf79ff19aa67fbb0cbfcebe Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 10 Feb 2020 18:54:38 +0300 Subject: [PATCH 78/96] Add an active issue to System.ComponentModel.Composition.MetadataAttributeTests.StronglyTypedStructureTestWithTransparentViews --- .../ComponentModel/Composition/ExportableAttributeTests.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportableAttributeTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportableAttributeTests.cs index 95c2934d4fd49..cdd22c54f1d33 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportableAttributeTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportableAttributeTests.cs @@ -56,6 +56,7 @@ public void StronglyTypedStructureTest() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/32030", TargetFrameworkMonikers.Mono)] [Trait("Type", "Integration")] public void StronglyTypedStructureTestWithTransparentViews() { From 20395ca9944dc19e1e72d5ec519f4d4a9cfba43b Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Thu, 13 Feb 2020 09:38:10 +0300 Subject: [PATCH 79/96] Replace TargetFrameworkMonikers.Mono with TestRuntimes.Mono --- .../tests/ErrObjectTests.cs | 2 +- .../tests/InteractionTests.cs | 8 +-- .../tests/ConcurrentQueueTests.cs | 2 +- .../NameValueCollection.CtorTests.cs | 2 +- .../Composition/AdvancedValueComposition.cs | 10 ++-- .../AllowNonPublicCompositionTests.cs | 14 ++--- .../AttributedModelCompositionTests.cs | 2 +- .../AttributedModelDiscoveryTests.cs | 10 ++-- .../AttributedModel/INotifyImportTests.cs | 8 +-- .../AttributedModelServicesTests.cs | 12 ++-- .../Composition/ComponentServicesTests.cs | 2 +- .../CompositionContainerCollectionTests.cs | 2 +- .../CompositionContainerImportTests.cs | 2 +- .../Composition/CompositionContainerTests.cs | 44 +++++++------- .../CompositionServiceExportFactoryTests.cs | 8 +-- .../Composition/CompositionServicesTests.cs | 2 +- .../Composition/DynamicMetadata.cs | 6 +- .../Composition/ExportAttributeTests.cs | 2 +- .../Composition/ExportCollectionTests.cs | 2 +- .../Composition/ExportFactoryTests.cs | 2 +- .../Composition/ExportableAttributeTests.cs | 2 +- .../Composition/GenericsTests.cs | 32 +++++----- .../Hosting/CatalogExportProviderTests.cs | 2 +- .../Hosting/CompositionBatchTests.cs | 2 +- .../Hosting/FilteredCatalogTests.cs | 2 +- .../FilteredCatalogTransitiveClosureTests.cs | 2 +- .../Hosting/ScopeExtensionsTests.cs | 6 +- .../Composition/ImportAttributeTests.cs | 2 +- .../Composition/MetadataTests.cs | 4 +- .../Composition/MetadataViewProviderTests.cs | 2 +- .../CompositionScopeDefinitionTests.cs | 8 +-- .../ReflectionComposablePartTests.cs | 50 ++++++++-------- .../Composition/ScopeExportFactoryTests.cs | 16 ++--- .../ScopedCompositionServicetests.cs | 2 +- .../Integration/AdaptingCollectionTests.cs | 2 +- .../Integration/CatalogFilteringTests.cs | 2 +- ...itionContainerAttributedModelCycleTests.cs | 6 +- .../Integration/ConstructorInjectionTests.cs | 4 +- .../System/Integration/DelayLoadingTests.cs | 2 +- .../Integration/DelegateCompositionTests.cs | 2 +- .../System/Integration/DiscoveryTests.cs | 30 +++++----- .../tests/System/Integration/LifetimeTests.cs | 60 +++++++++---------- .../System/Integration/RecompositionTests.cs | 2 +- .../System/Integration/RejectionTests.cs | 2 +- .../RequiredCreationPolicyTests.cs | 2 +- .../System/Data/Common/DbConnectionTests.cs | 2 +- .../tests/StackFrameTests.cs | 8 +-- .../tests/StackTraceTests.cs | 6 +- .../tests/Imaging/ImageAttributesTests.cs | 2 +- ...erloadResolution.Methods.1class2methods.cs | 2 +- .../tests/Array/ArrayAccessTests.cs | 6 +- .../tests/Array/ArrayIndexTests.cs | 4 +- .../tests/Array/NewArrayBoundsTests.cs | 6 +- .../Coalesce/BinaryCoalesceTests.cs | 2 +- .../tests/Block/BlockTests.cs | 2 +- .../tests/CompilerTests.cs | 10 ++-- .../ExceptionHandlingExpressions.cs | 4 +- .../tests/Goto/Return.cs | 2 +- .../IndexExpression/IndexExpressionTests.cs | 6 +- .../tests/Lambda/LambdaTests.cs | 2 +- .../tests/Member/MemberAccessTests.cs | 2 +- .../tests/MemberInit/BindTests.cs | 2 +- .../tests/StackSpillerTests.cs | 2 +- ...aryArithmeticNegateCheckedNullableTests.cs | 2 +- .../UnaryArithmeticNegateCheckedTests.cs | 2 +- .../tests/PlinqModesTests.cs | 2 +- .../ArrayBufferWriterTests.T.cs | 2 +- .../System.Memory/tests/Span/Reflection.cs | 12 ++-- .../FunctionalTests/PlatformHandlerTest.cs | 2 +- .../tests/GenericVectorTests.cs | 6 +- .../Xslt/XslTransformApi/CXslTransform.cs | 4 +- .../tests/CustomReflectionContextTests.cs | 6 +- .../tests/CustomAttributeBuilderTests.cs | 52 ++++++++-------- .../tests/ILGenerator/DeclareLocalTests.cs | 4 +- .../tests/ILGenerator/Emit2Tests.cs | 4 +- .../tests/ILGenerator/Emit3Tests.cs | 2 +- .../tests/ILGenerator/Emit4Tests.cs | 2 +- .../SetCustomAttributeTests.cs | 2 +- .../SignatureHelperAddArgument.cs | 10 ++-- .../SignatureHelperAddArguments.cs | 10 ++-- .../SignatureHelperGetMethodSigHelper.cs | 8 +-- .../SignatureHelperGetPropertySigHelper.cs | 12 ++-- .../tests/DynamicILInfoTests.cs | 22 +++---- .../tests/DynamicMethodCtor.cs | 2 +- .../tests/DynamicMethodGetILGenerator.cs | 4 +- .../tests/AssemblyBuilderTests.cs | 6 +- .../ConstructorBuilderToString.cs | 4 +- .../EnumBuilder/EnumBuilder.Methods.Tests.cs | 8 +-- .../EnumBuilder.Properties.Tests.cs | 2 +- .../FieldBuilder/FieldBuilderSetConstant.cs | 2 +- ...ParameterBuilderSetInterfaceConstraints.cs | 4 +- .../MethodBuilderDefineGenericParameters.cs | 8 +-- .../MethodBuilder/MethodBuilderEquals.cs | 2 +- .../MethodBuilderGetGenericArguments.cs | 2 +- .../MethodBuilderGetILGenerator.cs | 2 +- .../MethodBuilderMakeGenericMethod.cs | 6 +- .../MethodBuilderReturnParameter.cs | 2 +- .../MethodBuilderSetParameters.cs | 4 +- .../MethodBuilderSetReturnType.cs | 2 +- .../MethodBuilderSetSignature.cs | 4 +- .../MethodBuilder/MethodBuilderToString.cs | 10 ++-- .../ModuleBuilder/ModuleBuilderDefineEnum.cs | 6 +- .../ModuleBuilder/ModuleBuilderDefineType.cs | 2 +- .../ModuleBuilderGetArrayMethod.cs | 20 +++---- .../PropertyBuilderAddOtherMethod.cs | 2 +- .../PropertyBuilderSetConstant.cs | 4 +- .../PropertyBuilderSetCustomAttribute.cs | 4 +- .../PropertyBuilderSetSetMethod.cs | 2 +- .../PropertyBuilderSetValue.cs | 2 +- .../TypeBuilderAddInterfaceImplementaion.cs | 4 +- .../TypeBuilderAssemblyQualifiedName.cs | 2 +- .../TypeBuilder/TypeBuilderCreateType.cs | 2 +- .../TypeBuilder/TypeBuilderCreateTypeInfo.cs | 2 +- .../TypeBuilderDefineConstructor.cs | 4 +- .../TypeBuilderDefineDefaultConstructor.cs | 2 +- .../TypeBuilder/TypeBuilderDefineEvent.cs | 2 +- .../TypeBuilder/TypeBuilderDefineField.cs | 6 +- .../TypeBuilderDefineGenericParameters.cs | 2 +- .../TypeBuilder/TypeBuilderDefineMethod.cs | 2 +- .../TypeBuilderDefineMethodOverride.cs | 10 ++-- .../TypeBuilderDefineNestedType.cs | 10 ++-- .../TypeBuilder/TypeBuilderDefineProperty.cs | 14 ++--- .../TypeBuilderDefineTypeInitializer.cs | 2 +- .../tests/TypeBuilder/TypeBuilderGUID.cs | 2 +- .../TypeBuilder/TypeBuilderGetConstructor.cs | 6 +- .../tests/TypeBuilder/TypeBuilderGetField.cs | 6 +- .../tests/TypeBuilder/TypeBuilderGetMethod.cs | 8 +-- .../Tests/CustomAttributes/DllImportTests.cs | 4 +- .../src/Tests/Parameter/ParameterTests.cs | 2 +- .../tests/src/Tests/Type/TypeInvariants.cs | 2 +- .../tests/src/Tests/Type/TypeTests.cs | 2 +- .../TypeInfo_ImplementedInterfacesTests.cs | 6 +- .../ConstructorInfoInvokeArrayTests.cs | 4 +- .../ConstructorInfo/ConstructorInfoTests.cs | 2 +- .../tests/MetadataTokenTests.cs | 2 +- .../tests/PropertyInfoTests.cs | 2 +- .../tests/TypeTests.cs | 2 +- .../System.Reflection/tests/AssemblyTests.cs | 4 +- .../tests/ConstructorInfoTests.cs | 4 +- .../tests/CoreCLR/AssemblyTests.cs | 2 +- .../tests/MemberInfoTests.cs | 4 +- .../tests/MethodInfoTests.cs | 2 +- .../tests/ParameterInfoTests.cs | 2 +- .../tests/PropertyInfoTests.cs | 2 +- .../System.Reflection/tests/TypeInfoTests.cs | 10 ++-- .../tests/System/AppDomainTests.cs | 8 +-- .../tests/System/Environment.StackTrace.cs | 2 +- .../System/Runtime/ProfileOptimization.cs | 2 +- .../Marshal/DestroyStructureTests.cs | 2 +- .../Marshal/GetExceptionForHRTests.cs | 4 +- .../GetFunctionPointerForDelegateTests.cs | 2 +- .../InteropServices/Marshal/OffsetOfTests.cs | 2 +- .../Marshal/PtrToStructureTests.cs | 2 +- .../InteropServices/Marshal/SizeOfTests.cs | 2 +- .../Marshal/StructureToPtrTests.cs | 6 +- .../Marshal/ThrowExceptionForHRTests.cs | 4 +- .../RefEmitLoadContextTest.cs | 2 +- .../tests/BinaryFormatterTests.cs | 2 +- .../tests/FormatterServicesTests.cs | 6 +- .../tests/SerializationGuardTests.cs | 2 +- .../tests/System/DelegateTests.cs | 6 +- .../tests/System/ExceptionTests.cs | 4 +- .../tests/System/ExitCodeTests.Unix.cs | 2 +- .../System.Runtime/tests/System/GCTests.cs | 4 +- .../System/Reflection/IsCollectibleTests.cs | 2 +- .../tests/System/Reflection/PointerTests.cs | 2 +- .../tests/System/Type/TypePropertyTests.cs | 2 +- .../tests/Oid.cs | 8 +-- .../tests/OverlappedTests.cs | 2 +- ...BoundHandle_PreAllocatedOverlappedTests.cs | 6 +- .../tests/Task/TaskContinueWithTests.cs | 2 +- .../tests/ThreadPoolTests.cs | 4 +- .../System.Threading/tests/MutexTests.cs | 4 +- .../System.Threading/tests/SemaphoreTests.cs | 4 +- 174 files changed, 492 insertions(+), 492 deletions(-) diff --git a/src/libraries/Microsoft.VisualBasic.Core/tests/ErrObjectTests.cs b/src/libraries/Microsoft.VisualBasic.Core/tests/ErrObjectTests.cs index 36c2c0c82ad64..9708195070dc2 100644 --- a/src/libraries/Microsoft.VisualBasic.Core/tests/ErrObjectTests.cs +++ b/src/libraries/Microsoft.VisualBasic.Core/tests/ErrObjectTests.cs @@ -11,7 +11,7 @@ namespace Microsoft.VisualBasic.Tests public class ErrObjectTests { [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/14854", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14854", TestRuntimes.Mono)] public void Clear() { ProjectData.ClearProjectError(); diff --git a/src/libraries/Microsoft.VisualBasic.Core/tests/InteractionTests.cs b/src/libraries/Microsoft.VisualBasic.Core/tests/InteractionTests.cs index 35e0fa1764fa5..4ee3004cf6853 100644 --- a/src/libraries/Microsoft.VisualBasic.Core/tests/InteractionTests.cs +++ b/src/libraries/Microsoft.VisualBasic.Core/tests/InteractionTests.cs @@ -138,7 +138,7 @@ public static IEnumerable IIf_TestData() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2139", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2139", TestRuntimes.Mono)] public void DeleteSetting() { if (!PlatformDetection.IsInAppContainer) @@ -208,7 +208,7 @@ private static (string, string)[] GetEnvironmentVariables() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2139", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2139", TestRuntimes.Mono)] public void GetAllSettings() { if (!PlatformDetection.IsInAppContainer) @@ -223,7 +223,7 @@ public void GetAllSettings() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2139", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2139", TestRuntimes.Mono)] public void GetSetting() { if (!PlatformDetection.IsInAppContainer) @@ -306,7 +306,7 @@ public void Partition_Overflow(long Number, long Start, long Stop, long Interval } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2139", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2139", TestRuntimes.Mono)] public void SaveSetting() { if (!PlatformDetection.IsInAppContainer) diff --git a/src/libraries/System.Collections.Concurrent/tests/ConcurrentQueueTests.cs b/src/libraries/System.Collections.Concurrent/tests/ConcurrentQueueTests.cs index 758813758bca0..0372629d7f860 100644 --- a/src/libraries/System.Collections.Concurrent/tests/ConcurrentQueueTests.cs +++ b/src/libraries/System.Collections.Concurrent/tests/ConcurrentQueueTests.cs @@ -212,7 +212,7 @@ public void IEnumerable_GetAllExpectedItems() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16413", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16413", TestRuntimes.Mono)] public void ReferenceTypes_NulledAfterDequeue() { int iterations = 10; // any number <32 will do diff --git a/src/libraries/System.Collections.Specialized/tests/NameValueCollection/NameValueCollection.CtorTests.cs b/src/libraries/System.Collections.Specialized/tests/NameValueCollection/NameValueCollection.CtorTests.cs index 47d50f25792ea..95e9c402f0d43 100644 --- a/src/libraries/System.Collections.Specialized/tests/NameValueCollection/NameValueCollection.CtorTests.cs +++ b/src/libraries/System.Collections.Specialized/tests/NameValueCollection/NameValueCollection.CtorTests.cs @@ -68,7 +68,7 @@ public void Ctor_Int(int capacity) } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/14858", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14858", TestRuntimes.Mono)] public void Ctor_NegativeCapacity_ThrowsArgumentOutOfRangeException() { AssertExtensions.Throws("capacity", () => new NameValueCollection(-1)); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AdvancedValueComposition.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AdvancedValueComposition.cs index d9963710d818e..0712402e761c1 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AdvancedValueComposition.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AdvancedValueComposition.cs @@ -24,7 +24,7 @@ public interface ITrans_CollectionOfStrings public class AdvancedValueComposition { [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void RepeatedContainerUse() { var container = ContainerFactory.Create(); @@ -42,7 +42,7 @@ public void RepeatedContainerUse() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void FunctionsFieldsAndProperties() { Consumer c; @@ -57,7 +57,7 @@ public void FunctionsFieldsAndProperties() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void FunctionsFieldsAndProperties2() { Consumer c; @@ -255,7 +255,7 @@ public void ImportIntoUntypedExportTest() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ImportIntoDerivationOfExportException() { var container = ContainerFactory.Create(); @@ -273,7 +273,7 @@ public void ImportIntoDerivationOfExportException() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ImportIntoDerivationOfExportsException() { var container = ContainerFactory.Create(); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AllowNonPublicCompositionTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AllowNonPublicCompositionTests.cs index 2a94a7d95028b..fccfc9c9fd0df 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AllowNonPublicCompositionTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AllowNonPublicCompositionTests.cs @@ -8,11 +8,11 @@ namespace System.ComponentModel.Composition { - // [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + // [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public class AllowNonPublicCompositionTests { [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void PublicFromPublic() { var container = ContainerFactory.Create(); @@ -27,7 +27,7 @@ public void PublicFromPublic() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void PublicToSelf() { var container = ContainerFactory.Create(); @@ -41,7 +41,7 @@ public void PublicToSelf() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void PublicFromPrivate() { var container = ContainerFactory.Create(); @@ -56,7 +56,7 @@ public void PublicFromPrivate() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void PrivateFromPublic() { var container = ContainerFactory.Create(); @@ -71,7 +71,7 @@ public void PrivateFromPublic() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void PrivateToSelf() { var container = ContainerFactory.Create(); @@ -85,7 +85,7 @@ public void PrivateToSelf() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void PrivateData() { var container = ContainerFactory.Create(); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AttributedModelCompositionTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AttributedModelCompositionTests.cs index 6c79d4fdf671f..f3e5e85fac75c 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AttributedModelCompositionTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AttributedModelCompositionTests.cs @@ -10,7 +10,7 @@ namespace System.ComponentModel.Composition.AttributedModel { - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public class AttributedModelCompositionTests { [Fact] diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AttributedModelDiscoveryTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AttributedModelDiscoveryTests.cs index e51b92cc33795..d0abdecda1aa9 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AttributedModelDiscoveryTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AttributedModelDiscoveryTests.cs @@ -16,7 +16,7 @@ namespace System.ComponentModel.Composition.AttributedModel public class AttributedModelDiscoveryTests { [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void CreatePartDefinition_TypeWithExports_ShouldHaveMultipleExports() { var definition = CreateDefinition(typeof(PublicComponentWithPublicExports)); @@ -35,7 +35,7 @@ public class DerivedClassWithInheritedPropertyExports : BaseClassWithPropertyExp } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void CreatePartDefinition_TypeWithImports_ShouldHaveMultipleImports() { var definition = CreateDefinition(typeof(PublicImportsExpectingPublicExports)); @@ -158,7 +158,7 @@ public void CreatePartDefinition_MultipleMarkedConstructorsAsPartTypeArgument_Sh } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void CreatePartDefinition_OneMarkedConstructorsAsPartTypeArgument_ShouldSetConstructorToMarked() { var definition = CreateDefinition(typeof(SimpleConstructorInjectedObject)); @@ -170,7 +170,7 @@ public void CreatePartDefinition_OneMarkedConstructorsAsPartTypeArgument_ShouldS } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void CreatePartDefinition_OneDefaultConstructorAsPartTypeArgument_ShouldSetConstructorToDefault() { var definition = CreateDefinition(typeof(PublicComponentWithPublicExports)); @@ -183,7 +183,7 @@ public void CreatePartDefinition_OneDefaultConstructorAsPartTypeArgument_ShouldS } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void CreatePartDefinition_OneMarkedAndOneDefaultConstructorsAsPartTypeArgument_ShouldSetConstructorToMarked() { var definition = CreateDefinition(typeof(ClassWithOneMarkedAndOneDefaultConstructor)); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/INotifyImportTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/INotifyImportTests.cs index 8237f8ca0b612..bc1fbc122d5b4 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/INotifyImportTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/INotifyImportTests.cs @@ -23,7 +23,7 @@ public void OnImportsSatisfied() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ImportsSatisfiedOnComponentWithoutImports() { CompositionContainer container = ContainerFactory.CreateWithAttributedCatalog(typeof(PartWithoutImports)); @@ -36,7 +36,7 @@ public void ImportsSatisfiedOnComponentWithoutImports() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ImportCompletedTest() { var container = ContainerFactory.Create(); @@ -58,7 +58,7 @@ public void ImportCompletedTest() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ImportCompletedWithRecomposing() { var container = ContainerFactory.Create(); @@ -97,7 +97,7 @@ public void ImportCompletedWithRecomposing() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ImportCompletedAddPartAndBindComponent() { var container = ContainerFactory.Create(); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModelServicesTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModelServicesTests.cs index f7e25be06e156..a86ba6ea643eb 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModelServicesTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModelServicesTests.cs @@ -145,7 +145,7 @@ public void Imports_Throws_OnNullContractName() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void Imports() { ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart(); @@ -159,7 +159,7 @@ public void Imports() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void Imports_CardinalityIgnored_WhenNotSpecified() { ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart(); @@ -172,7 +172,7 @@ public void Imports_CardinalityIgnored_WhenNotSpecified() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void Imports_CardinalityNotIgnored_WhenSpecified() { ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart(); @@ -203,7 +203,7 @@ public void ImportsGeneric_Throws_OnNullPart() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ImportsGeneric() { ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart(); @@ -217,7 +217,7 @@ public void ImportsGeneric() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ImportsGeneric_CardinalityIgnored_WhenNotSpecified() { ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart(); @@ -230,7 +230,7 @@ public void ImportsGeneric_CardinalityIgnored_WhenNotSpecified() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ImportsGeneric_CardinalityNotIgnored_WhenSpecified() { ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart(); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ComponentServicesTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ComponentServicesTests.cs index febb8fac0a99d..7bc778b5734ff 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ComponentServicesTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ComponentServicesTests.cs @@ -74,7 +74,7 @@ public void GetValuesTest() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void NoResolverExceptionTest() { var container = ContainerFactory.Create(); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerCollectionTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerCollectionTests.cs index 917de93e03393..a81915a67b703 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerCollectionTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerCollectionTests.cs @@ -13,7 +13,7 @@ namespace System.ComponentModel.Composition { - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public class CompositionContainerCollectionTests { public class SupportedImportCollectionAssignments diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerImportTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerImportTests.cs index 52849ce8cdcd7..991a2f889e1e5 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerImportTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerImportTests.cs @@ -13,7 +13,7 @@ namespace System.ComponentModel.Composition { - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public class CompositionContainerImportTests { // Exporting collectin values is not supported diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerTests.cs index 3d98248288614..81459728af7cb 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerTests.cs @@ -1726,7 +1726,7 @@ public void GetExports2_TypeAsMetadataViewTypeArgument_IsUsedAsMetadataConstrain } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void GetExportsOfTTMetadataView1_TypeAsMetadataViewTypeArgument_IsUsedAsMetadataConstraint() { var metadata = new Dictionary(); @@ -1751,7 +1751,7 @@ public void GetExportsOfTTMetadataView1_TypeAsMetadataViewTypeArgument_IsUsedAsM } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void GetExportsOfTTMetadataView2_TypeAsMetadataViewTypeArgument_IsUsedAsMetadataConstraint() { var metadata = new Dictionary(); @@ -1872,7 +1872,7 @@ public void RemovePart_PartAlreadyRemovedAsPartArgument_ShouldNotThrow() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void TryComposeSimple() { var container = CreateCompositionContainer(); @@ -1886,7 +1886,7 @@ public void TryComposeSimple() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void TryComposeSimpleFail() { var container = CreateCompositionContainer(); @@ -1904,7 +1904,7 @@ public void TryComposeSimpleFail() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ComposeDisposableChildContainer() { var outerContainer = CreateCompositionContainer(); @@ -1964,7 +1964,7 @@ public void RemoveValueTest() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] [Trait("Type", "Integration")] public void OptionalImportsOfValueTypeBoundToDefaultValueShouldNotAffectAvailableValues() { @@ -1984,7 +1984,7 @@ public void OptionalImportsOfValueTypeBoundToDefaultValueShouldNotAffectAvailabl } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] [Trait("Type", "Integration")] public void OptionalImportsOfNullableValueTypeBoundToDefaultValueShouldNotAffectAvailableValues() { @@ -2004,7 +2004,7 @@ public void OptionalImportsOfNullableValueTypeBoundToDefaultValueShouldNotAffect } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] [Trait("Type", "Integration")] public void OptionalImportsOfReferenceTypeBoundToDefaultValueShouldNotAffectAvailableValues() { @@ -2413,7 +2413,7 @@ public void TryGetValueWithCatalogVerifyExecptionDuringGet() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void TryGetExportedValueWhileLockedForNotify() { var container = CreateCompositionContainer(); @@ -2489,7 +2489,7 @@ public void RemoveFromWrongContainerTest() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] [Trait("Type", "Integration")] public void AddPartSimple() { @@ -2504,7 +2504,7 @@ public void AddPartSimple() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] [Trait("Type", "Integration")] public void AddPart() { @@ -2519,7 +2519,7 @@ public void AddPart() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ComposeReentrantChildContainerDisposed() { var container = CreateCompositionContainer(); @@ -2549,7 +2549,7 @@ public void ComposeReentrantChildContainerDisposed() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ComposeSimple() { var container = CreateCompositionContainer(); @@ -2563,7 +2563,7 @@ public void ComposeSimple() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ComposeSimpleFail() { var container = CreateCompositionContainer(); @@ -2581,7 +2581,7 @@ public void ComposeSimpleFail() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ExceptionDuringNotify() { var container = CreateCompositionContainer(); @@ -2599,7 +2599,7 @@ public void ExceptionDuringNotify() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void NeutralComposeWhileNotified() { var container = CreateCompositionContainer(); @@ -2657,7 +2657,7 @@ public class SimpleExporter } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ThreadSafeCompositionContainer() { TypeCatalog catalog = new TypeCatalog(typeof(SimpleExporter)); @@ -2677,7 +2677,7 @@ public void ThreadSafeCompositionContainer() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ThreadSafeCompositionOptionsCompositionContainer() { TypeCatalog catalog = new TypeCatalog(typeof(SimpleExporter)); @@ -2696,7 +2696,7 @@ public void ThreadSafeCompositionOptionsCompositionContainer() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void DisableSilentRejectionCompositionOptionsCompositionContainer() { TypeCatalog catalog = new TypeCatalog(typeof(SimpleExporter)); @@ -2715,7 +2715,7 @@ public void DisableSilentRejectionCompositionOptionsCompositionContainer() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void DisableSilentRejectionThreadSafeCompositionOptionsCompositionContainer() { TypeCatalog catalog = new TypeCatalog(typeof(SimpleExporter)); @@ -2967,7 +2967,7 @@ public void ComposeExportedValueOfT_ValidContractName_ExportedValue_ImportsAreNo } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void TestExportedValueCachesNullValue() { var container = ContainerFactory.Create(); @@ -2981,7 +2981,7 @@ public void TestExportedValueCachesNullValue() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void TestExportedValueUsingWhereClause_ExportSuccessful() { CompositionContainer container = new CompositionContainer(new TypeCatalog(typeof(MefCollection<,>))); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionServiceExportFactoryTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionServiceExportFactoryTests.cs index 4cd7faedb496b..c28a6c40746cf 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionServiceExportFactoryTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionServiceExportFactoryTests.cs @@ -42,7 +42,7 @@ public class App } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] [Description("Verifies CompositionServices.SatisfyImportsOne with Scoped ExportFactories")] public void ComposeAppInNewScopeChildrenInRoot_ShouldSucceed() { @@ -67,7 +67,7 @@ public void ComposeAppInNewScopeChildrenInRoot_ShouldSucceed() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] [Description("Verifies CompositionServices.SatisfyImportsOne with Scoped ExportFactories")] public void ComposeAppInNewScopeChildrenInScope_ShouldSucceed() { @@ -92,7 +92,7 @@ public void ComposeAppInNewScopeChildrenInScope_ShouldSucceed() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] [Description("Verifies CompositionServices.SatisfyImportsOne with Scoped ExportFactories")] public void ComposeAppInNewScopeChildrenInBoth_ShouldSucceed() { @@ -117,7 +117,7 @@ public void ComposeAppInNewScopeChildrenInBoth_ShouldSucceed() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] [Description("Verifies CompositionServices.SatisfyImportsOne with NonScoped ExportFactories")] public void ComposeAppInRootScope_ShouldSucceed() { diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionServicesTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionServicesTests.cs index ae1335351ffc9..d9a4e347106ea 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionServicesTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionServicesTests.cs @@ -38,7 +38,7 @@ public void ContractNameServicesAddCustomModifiersTest() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15168", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15168", TestRuntimes.Mono)] [Description("Verifies CompositionServices.GetDefaultContractName method.")] public void GetDefaultContractNameTest() { diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/DynamicMetadata.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/DynamicMetadata.cs index a5b942d5f5906..dc33c46ee8a93 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/DynamicMetadata.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/DynamicMetadata.cs @@ -13,7 +13,7 @@ namespace System.ComponentModel.Composition public class DynamicMetadata : IDisposable { [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SimpleAttachment() { MetadataStore.Container = new CompositionContainer(); @@ -35,7 +35,7 @@ public void SimpleAttachment() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void LocalContainer() { var container1 = new CompositionContainer(); @@ -62,7 +62,7 @@ public void LocalContainer() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void DualContainers() { var container1 = new CompositionContainer(); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportAttributeTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportAttributeTests.cs index c8b03a26b0fac..e4698493c9ea7 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportAttributeTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportAttributeTests.cs @@ -71,7 +71,7 @@ public void Constructor2_ValueAsContractNameArgument_ShouldSetContractNameProper } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ExportIndexers_ShouldThrowSomething() { var con = new CompositionContainer( diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportCollectionTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportCollectionTests.cs index 1ddab0579459c..2b91be712f1fe 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportCollectionTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportCollectionTests.cs @@ -142,7 +142,7 @@ public class ExporterDefault42 } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/31792", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31792", TestRuntimes.Mono)] [Trait("Type", "Integration")] public void ImportCollectionsFromContainerOnly() { diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportFactoryTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportFactoryTests.cs index 69cc36b03230e..ab9f58b652c32 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportFactoryTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportFactoryTests.cs @@ -14,7 +14,7 @@ namespace Tests.Integration { - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public class ExportFactoryTests { public interface IId diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportableAttributeTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportableAttributeTests.cs index cdd22c54f1d33..f057a66876d25 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportableAttributeTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportableAttributeTests.cs @@ -56,7 +56,7 @@ public void StronglyTypedStructureTest() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/32030", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/32030", TestRuntimes.Mono)] [Trait("Type", "Integration")] public void StronglyTypedStructureTestWithTransparentViews() { diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/GenericsTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/GenericsTests.cs index 65a1c4c066f6a..afc7a0290563a 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/GenericsTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/GenericsTests.cs @@ -304,7 +304,7 @@ public class OpenGenericPartWithClosedGenericImport : IExport } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SelfExportWithClosedGenericImportTest() { TypeCatalog catalog = new TypeCatalog(typeof(SelfImport<>), typeof(OpenGenericPartWithClosedGenericImport<>)); @@ -332,7 +332,7 @@ public void SelfExportTest() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void PropertyExportTest() { TypeCatalog catalog = new TypeCatalog(typeof(PropertyExport<,>)); @@ -346,7 +346,7 @@ public void PropertyExportTest() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void PropertyExportWithContractInferredTest() { TypeCatalog catalog = new TypeCatalog(typeof(PropertyExportWithContractInferred<,>)); @@ -360,7 +360,7 @@ public void PropertyExportWithContractInferredTest() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SelfExportWithPropertyImportTest() { TypeCatalog catalog = new TypeCatalog(typeof(SelfExportWithPropertyImport<,>), typeof(SelfImport<,>)); @@ -375,7 +375,7 @@ public void SelfExportWithPropertyImportTest() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SelfExportWithLazyPropertyImportTest() { TypeCatalog catalog = new TypeCatalog(typeof(SelfExportWithLazyPropertyImport<,>), typeof(SelfImport<,>)); @@ -390,7 +390,7 @@ public void SelfExportWithLazyPropertyImportTest() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SelfExportWithNakedLazyPropertyImportTest() { TypeCatalog catalog = new TypeCatalog(typeof(SelfExportWithNakedLazyPropertyImport<>), typeof(Foo)); @@ -405,7 +405,7 @@ public void SelfExportWithNakedLazyPropertyImportTest() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SelfExportWithExportFactoryPropertyImportTest() { TypeCatalog catalog = new TypeCatalog(typeof(SelfExportWithExportFactoryPropertyImport<,>), typeof(SelfImport<,>)); @@ -427,7 +427,7 @@ public void SelfExportWithExportFactoryPropertyImportTest() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SelfExportWithNakedExportFactoryPropertyImportTest() { TypeCatalog catalog = new TypeCatalog(typeof(SelfExportWithNakedExportFactoryPropertyImport<>), typeof(Foo)); @@ -449,7 +449,7 @@ public void SelfExportWithNakedExportFactoryPropertyImportTest() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SelfExportWithExportFactoryParameterImportTest() { TypeCatalog catalog = new TypeCatalog(typeof(SelfExportWithExportFactoryParameterImport<,>), typeof(SelfImport<,>)); @@ -471,7 +471,7 @@ public void SelfExportWithExportFactoryParameterImportTest() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SelfExportWithCollectionPropertyImportTest() { TypeCatalog catalog = new TypeCatalog(typeof(SelfExportWithCollectionPropertyImport<,>), typeof(SelfImport<,>)); @@ -486,7 +486,7 @@ public void SelfExportWithCollectionPropertyImportTest() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SelfExportWithLazyCollectionPropertyImportTest() { TypeCatalog catalog = new TypeCatalog(typeof(SelfExportWithLazyCollectionPropertyImport<,>), typeof(SelfImport<,>)); @@ -501,7 +501,7 @@ public void SelfExportWithLazyCollectionPropertyImportTest() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SelfExportWithPropertyImportWithContractInferredTest() { TypeCatalog catalog = new TypeCatalog(typeof(SelfExportWithPropertyImportWithContractInferred<,>), typeof(SelfImport<,>)); @@ -516,7 +516,7 @@ public void SelfExportWithPropertyImportWithContractInferredTest() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SelfExportWithParameterImportTest() { TypeCatalog catalog = new TypeCatalog(typeof(SelfExportWithParameterImport<,>), typeof(SelfImport<,>)); @@ -531,7 +531,7 @@ public void SelfExportWithParameterImportTest() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SelfExportWithMultipleGenericImportsTest() { TypeCatalog catalog = new TypeCatalog(typeof(SelfExportWithMultipleGenericImports<,>), typeof(SelfImport<,>), typeof(SelfImport<>), typeof(Foo)); @@ -563,7 +563,7 @@ public void SpecilzationMakesGeneric() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SingletonBehavior() { TypeCatalog catalog = new TypeCatalog(typeof(SingletonExport<,>)); @@ -722,7 +722,7 @@ public void PartWithNakedConstraintTest() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void PartWithExportParametersInReverseOrder() { TypeCatalog catalog = new TypeCatalog(typeof(PropertyExportWithChangedParameterOrder<,>)); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/CatalogExportProviderTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/CatalogExportProviderTests.cs index c79b5cfd249d9..eb3dfd6f9dc6b 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/CatalogExportProviderTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/CatalogExportProviderTests.cs @@ -339,7 +339,7 @@ public void CanBeCollectedAfterDispose() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void RemovingAndReAddingMultipleDefinitionsFromCatalog() { var fixedParts = new TypeCatalog(typeof(RootMultipleImporter), typeof(ExportedService)); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/CompositionBatchTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/CompositionBatchTests.cs index 9ceb0f236ca63..48d9eebe73856 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/CompositionBatchTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/CompositionBatchTests.cs @@ -803,7 +803,7 @@ public void AddPart_ReturnedComposablePart_NullAsExportsArgumentToSetImports_Sho } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void AddPart_ReturnedComposablePart_ExportsArrayWithNullElementAsExportsArgumentToSetImports_ShouldThrowArgument() { CompositionBatch batch = new CompositionBatch(); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/FilteredCatalogTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/FilteredCatalogTests.cs index 27fbe5fc92b39..7790a5c85a96a 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/FilteredCatalogTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/FilteredCatalogTests.cs @@ -81,7 +81,7 @@ public void GetExports() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void GetExportsWithGenerics() { var originalCatalog = new TypeCatalog(typeof(GenericExporter<,>), typeof(Exporter11), typeof(Exporter22)); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/FilteredCatalogTransitiveClosureTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/FilteredCatalogTransitiveClosureTests.cs index 1bc7bedbd30bf..0587151ba3ef6 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/FilteredCatalogTransitiveClosureTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/FilteredCatalogTransitiveClosureTests.cs @@ -8,7 +8,7 @@ namespace System.ComponentModel.Composition.Hosting { - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public class FilteredCatalogTransitiveClosureTests { public interface IContract1 { } diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/ScopeExtensionsTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/ScopeExtensionsTests.cs index d6b8fa2e05f14..019efb3a3871e 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/ScopeExtensionsTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Hosting/ScopeExtensionsTests.cs @@ -68,7 +68,7 @@ public void Imports_Throws_OnNullContractName() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void Imports() { ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart(); @@ -82,7 +82,7 @@ public void Imports() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void Imports_CardinalityIgnored_WhenNotSpecified() { ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart(); @@ -95,7 +95,7 @@ public void Imports_CardinalityIgnored_WhenNotSpecified() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void Imports_CardinalityNotIgnored_WhenSpecified() { ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart(); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ImportAttributeTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ImportAttributeTests.cs index ea6fb3956f3cd..bee7c342120ed 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ImportAttributeTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ImportAttributeTests.cs @@ -169,7 +169,7 @@ public void AllowRecomposition_ValueAsValueArgument_ShouldSetProperty() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ImportIndexers_ShouldThrowSomething() { var con = new CompositionContainer( diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/MetadataTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/MetadataTests.cs index 7e75e76f6a0ea..495646196fc71 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/MetadataTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/MetadataTests.cs @@ -273,7 +273,7 @@ public class ClassWithInvalidDuplicateMetadataOnMember } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void InvalidDuplicateMetadataOnMember_ShouldThrow() { var part = AttributedModelServices.CreatePart(new ClassWithInvalidDuplicateMetadataOnMember()); @@ -320,7 +320,7 @@ public class ClassWithDuplicateMetadataOnMember } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ValidDuplicateMetadataOnMember_ShouldDiscoverAllMetadata() { var container = ContainerFactory.Create(); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/MetadataViewProviderTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/MetadataViewProviderTests.cs index 54aa79f975f83..8e3bea04518c3 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/MetadataViewProviderTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/MetadataViewProviderTests.cs @@ -93,7 +93,7 @@ public void GetMetadataView_InterfaceWithEvent_ShouldThrowNotSupportedException( } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15169", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15169", TestRuntimes.Mono)] public void GetMetadataView_InterfaceWithIndexer_ShouldThrowNotSupportedException() { var metadata = new Dictionary(); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Primitives/CompositionScopeDefinitionTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Primitives/CompositionScopeDefinitionTests.cs index 5cece3a265561..631b09737c319 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Primitives/CompositionScopeDefinitionTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/Primitives/CompositionScopeDefinitionTests.cs @@ -133,7 +133,7 @@ public void Parts_DelegateToCatalog() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void Constructor_PublicSurface() { var catalog = new TypeCatalog(typeof(FooImpl), typeof(FooImpl2), typeof(FooImpl2)); @@ -153,7 +153,7 @@ public void Constructor_PublicSurface_MultipleExportsPerPart() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void GetExports_DelegateToCatalog() { var parts = new TypeCatalog(typeof(FooImpl), typeof(FooImpl2), typeof(FooImpl2)).Parts; @@ -216,7 +216,7 @@ public void Notifications() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void Dispose() { var parts = new TypeCatalog(typeof(FooImpl), typeof(FooImpl2), typeof(FooImpl2)).Parts; @@ -253,7 +253,7 @@ public void Dispose() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SimpleComposition() { var catalog = new TypeCatalog(typeof(FooImpl), typeof(FooImpl2), typeof(FooImpl2)); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ReflectionModel/ReflectionComposablePartTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ReflectionModel/ReflectionComposablePartTests.cs index 4548a715a4399..dbaf6728bed81 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ReflectionModel/ReflectionComposablePartTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ReflectionModel/ReflectionComposablePartTests.cs @@ -141,7 +141,7 @@ public void OnComposed_WhenDisposed_ShouldThrowObjectDisposed() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void OnComposed_MissingPostImportsOnInstance_ShouldThrowComposition() { var part = CreatePart(new MySharedPartExport()); @@ -154,7 +154,7 @@ public void OnComposed_MissingPostImportsOnInstance_ShouldThrowComposition() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void OnComposed_ProperlyComposed_ShouldSucceed() { var import = new TrivialImporter(); @@ -169,7 +169,7 @@ public void OnComposed_ProperlyComposed_ShouldSucceed() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void OnComposed_UnhandledExceptionThrowInOnImportsSatisfied_ShouldThrowComposablePart() { var part = CreatePart(typeof(ExceptionDuringINotifyImport)); @@ -183,7 +183,7 @@ public void OnComposed_UnhandledExceptionThrowInOnImportsSatisfied_ShouldThrowCo } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SetImport_WhenDisposed_ShouldThrowObjectDisposed() { var part = CreateDefaultDisposablePart(); @@ -209,7 +209,7 @@ public void SetImport_NullAsImportDefinitionArgument_ShouldThrowArgumentNull() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SetImport_NullAsExportsArgument_ShouldThrowArgumentNull() { var part = CreatePart(typeof(MySharedPartExport)); @@ -222,7 +222,7 @@ public void SetImport_NullAsExportsArgument_ShouldThrowArgumentNull() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SetImport_ExportsArrayWithNullElementAsExportsArgument_ShouldThrowArgument() { var part = CreatePart(typeof(MySharedPartExport)); @@ -248,7 +248,7 @@ public void SetImport_WrongDefinitionAsDefinitionArgument_ShouldThrowArgument() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SetImport_SetNonRecomposableDefinitionAsDefinitionArgumentAfterOnComposed_ShouldThrowInvalidOperation() { var part = CreatePartWithNonRecomposableImport(); @@ -264,7 +264,7 @@ public void SetImport_SetNonRecomposableDefinitionAsDefinitionArgumentAfterOnCom } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SetImport_ZeroOrOneDefinitionAsDefinitionArgumentAndTwoExportsAsExportsArgument_ShouldThrowArgument() { var part = CreatePartWithZeroOrOneImport(); @@ -279,7 +279,7 @@ public void SetImport_ZeroOrOneDefinitionAsDefinitionArgumentAndTwoExportsAsExpo } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SetImport_ExactlyOneDefinitionAsDefinitionArgumentAndTwoExportsAsExportsArgument_ShouldThrowArgument() { var part = CreatePartWithExactlyOneImport(); @@ -294,7 +294,7 @@ public void SetImport_ExactlyOneDefinitionAsDefinitionArgumentAndTwoExportsAsExp } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SetImport_ExactlyOneDefinitionAsDefinitionArgumentAndEmptyExportsAsExportsArgument_ShouldThrowArgument() { var part = CreatePartWithExactlyOneImport(); @@ -309,7 +309,7 @@ public void SetImport_ExactlyOneDefinitionAsDefinitionArgumentAndEmptyExportsAsE } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SetImport_WrongTypeExportGiven_ShouldThrowComposablePart() { var part = CreatePart(new MySharedPartExport()); @@ -322,7 +322,7 @@ public void SetImport_WrongTypeExportGiven_ShouldThrowComposablePart() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SetImport_SetPostValueAndSetAgainOnInstance_ShouldSetProperty() { var import = new MySharedPartExport(); @@ -346,7 +346,7 @@ public void SetImport_SetPostValueAndSetAgainOnInstance_ShouldSetProperty() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void GetExportedValue_WhenDisposed_ShouldThrowObjectDisposed() { var part = CreateDefaultDisposablePart(); @@ -384,7 +384,7 @@ public void GetExportedValue_WrongDefinitionAsDefinitionArgument_ShouldThrowArgu } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void GetExportedValue_MissingPrerequisiteImport_ShouldThrowInvalidOperation() { var part = CreatePart(typeof(SimpleConstructorInjectedObject)); @@ -423,7 +423,7 @@ public void GetExportedValue_UnhandledExceptionThrowInConstructor_ShouldThrowCom } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void GetExportedValue_GetObjectAfterSetPreImport_ShouldGetValue() { var part = CreatePart(typeof(SimpleConstructorInjectedObject)); @@ -440,7 +440,7 @@ public void GetExportedValue_GetObjectAfterSetPreImport_ShouldGetValue() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void GetExportedValue_GetObjectAfterSetPostImport_ShouldGetValue() { var part = CreatePart(typeof(MySharedPartExport)); @@ -458,7 +458,7 @@ public void GetExportedValue_GetObjectAfterSetPostImport_ShouldGetValue() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void GetExportedValue_CallMultipleTimes_ShouldReturnSame() { var part = CreatePart(typeof(MySharedPartExport)); @@ -488,7 +488,7 @@ public void GetExportedValue_FromStaticClass_ShouldReturnExport() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void GetExportedValue_OptionalPostNotGiven_ShouldReturnValidObject() { var part = CreatePart(typeof(ClassWithOptionalPostImport)); @@ -501,7 +501,7 @@ public void GetExportedValue_OptionalPostNotGiven_ShouldReturnValidObject() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void GetExportedValue_OptionalPreNotGiven_ShouldReturnValidObject() { var part = CreatePart(typeof(ClassWithOptionalPreImport)); @@ -567,7 +567,7 @@ public class TypeExporter } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void GetExportedObjectAlwaysReturnsSameReference_ForProperty() { var cp = CreatePart(new PropertyExporter()); @@ -578,7 +578,7 @@ public void GetExportedObjectAlwaysReturnsSameReference_ForProperty() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void GetExportedObjectAlwaysReturnsSameReference_ForField() { var exporter = new FieldExporter(); @@ -649,7 +649,7 @@ void InvalidImport() { } } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ImportDefinitions_ImportWithCustomAttributeImports() { var part = CreatePart(typeof(ImportWithCustomImport)); @@ -683,7 +683,7 @@ void InvalidImportMany() { } } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ImportDefinitions_ImportManyWithCustomAttributeImportManys() { var part = CreatePart(typeof(ImportManyWithCustomImportMany)); @@ -752,7 +752,7 @@ void InvalidImportingConstructor() { } } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ImportDefinitions_ImportingConstructorWithCustomAttributeImportingConstructors() { var part = CreatePart(typeof(ImportingConstructorWithCustomImportingConstructor)); @@ -765,7 +765,7 @@ public void ImportDefinitions_ImportingConstructorWithCustomAttributeImportingCo } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ImportDefinitions_ImportingConstructorWithCustomAttributeImportingConstructorsWithAllowMultiple_ShouldNotThrowInvalidOperation() { var part = CreatePart(typeof(ImportingConstructorWithCustomImportingConstructorAllowMultiple)); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ScopeExportFactoryTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ScopeExportFactoryTests.cs index 7bbbd776b5add..c2675ed408f8d 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ScopeExportFactoryTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ScopeExportFactoryTests.cs @@ -8,7 +8,7 @@ namespace System.ComponentModel.Composition { - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public class ScopeExportFactoryTests { public interface IFooContract @@ -270,7 +270,7 @@ public void ExportFactoryCausesRejectionBasedOnCardinality() } } - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public class ScopeExportFactoryWithPublicSurface { [Export] public class ClassA { } @@ -313,7 +313,7 @@ public void FilteredScopeFactoryOfTM_ShouldSucceed() } } - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public class ScopeFactoryAutoResolveFromAncestorScope { [Export] public class Root { } @@ -371,7 +371,7 @@ public void ScopeFactoryAutoResolveFromAncestorScopeShouldSucceed() } } - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public class DeeplyNestedCatalog { [Export] @@ -450,7 +450,7 @@ public void DeeplyNestedCatalogOverlappedCatalog_ShouldWork() } } - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public class LocalSharedNonLocalInSameContainer { [Export] @@ -547,7 +547,7 @@ public void LocalSharedNonLocalInSameContainer_ShouldSucceed() } } - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public class ScopeBridgingAdaptersConstructorInjection { [Export] @@ -636,7 +636,7 @@ public void ScopeBridgingAdapters_ShouldSucceed() } } - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public class ScopeBridgingAdaptersImportExportProperty { [Export] @@ -720,7 +720,7 @@ public void ScopeBridgingAdaptersImportExportProperty_ShouldSucceed() } } - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public class SelfExportFromExportFactory { [Export] diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ScopedCompositionServicetests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ScopedCompositionServicetests.cs index 7ed541c1f51f0..76d0efa06d755 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ScopedCompositionServicetests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ScopedCompositionServicetests.cs @@ -8,7 +8,7 @@ namespace System.ComponentModel.Composition { - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public class ScopedCompositionServiceTests { [Export] diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/AdaptingCollectionTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/AdaptingCollectionTests.cs index 3abd071c0f512..45b6472c91db9 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/AdaptingCollectionTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/AdaptingCollectionTests.cs @@ -155,7 +155,7 @@ public bool Remove(Lazy item) #endregion } - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public class AdaptingCollectionTests { public interface IContract { } diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/CatalogFilteringTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/CatalogFilteringTests.cs index 73d64ef5e4fd7..f981f0dc8a991 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/CatalogFilteringTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/CatalogFilteringTests.cs @@ -9,7 +9,7 @@ namespace System.ComponentModel.Composition { - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public class CatalogFilteringTests { [Fact] diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/CompositionContainerAttributedModelCycleTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/CompositionContainerAttributedModelCycleTests.cs index 30b812914348e..cee2038786458 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/CompositionContainerAttributedModelCycleTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/CompositionContainerAttributedModelCycleTests.cs @@ -30,7 +30,7 @@ public class CompositionContainerAttributedModelCycleTests // [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void APrerequisiteDependsOnBPrerequisite_ShouldThrowComposition() { AssertCycle(typeof(APrerequisiteDependsOnBPrerequisite), @@ -38,7 +38,7 @@ public void APrerequisiteDependsOnBPrerequisite_ShouldThrowComposition() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void APrerequisiteDependsOnBPost_ShouldThrowComposition() { AssertCycle(typeof(APrerequisiteDependsOnBPost), @@ -54,7 +54,7 @@ public void APrerequisiteDependsOnBNone_ShouldNotThrow() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void APostDependsOnBPrerequisite_ShouldThrowComposition() { AssertCycle(typeof(APostDependsOnBPrerequisite), diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/ConstructorInjectionTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/ConstructorInjectionTests.cs index 0d95a0854c113..877c50accbfbd 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/ConstructorInjectionTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/ConstructorInjectionTests.cs @@ -13,7 +13,7 @@ namespace Tests.Integration public class ConstructorInjectionTests { [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SimpleConstructorInjection() { var container = ContainerFactory.Create(); @@ -178,7 +178,7 @@ public InvalidImportManyCI( } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ImportMany_ConstructorParameter_OnNonAssiganbleType_ShouldThrowCompositionException() { var container = ContainerFactory.CreateWithAttributedCatalog(typeof(InvalidImportManyCI)); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DelayLoadingTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DelayLoadingTests.cs index cf92afe259e1e..57d9d24e1de63 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DelayLoadingTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DelayLoadingTests.cs @@ -14,7 +14,7 @@ namespace Tests.Integration { - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public class DelayLoadingTests { [Fact] diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DelegateCompositionTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DelegateCompositionTests.cs index a975c47243d96..54f76515302b2 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DelegateCompositionTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DelegateCompositionTests.cs @@ -175,7 +175,7 @@ public class ImportCustomExportedDelegates } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void CustomExportedDelegate_ShouldWork() { var container = ContainerFactory.CreateWithAttributedCatalog( diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DiscoveryTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DiscoveryTests.cs index da864d09ac47b..69230be2246ed 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DiscoveryTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/DiscoveryTests.cs @@ -72,7 +72,7 @@ public class DerivedBaseWithNonPublicImportAndExport : BaseWithNonPublicImportAn } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void Import_PrivateOnClass_ShouldSetImport() { var container = ContainerFactory.CreateWithAttributedCatalog(typeof(BaseWithNonPublicImportAndExport)); @@ -83,7 +83,7 @@ public void Import_PrivateOnClass_ShouldSetImport() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void Import_PrivateOnBase_ShouldSetImport() { var container = ContainerFactory.CreateWithAttributedCatalog(typeof(DerivedBaseWithNonPublicImportAndExport)); @@ -122,7 +122,7 @@ public class ClassWithInterfaceInheritedImport : InterfaceWithImport } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void Import_InheritImportFromInterface_ShouldExposeImport() { var container = ContainerFactory.CreateWithAttributedCatalog( @@ -171,7 +171,7 @@ public class DerivedWithOverrideExport : BaseWithVirtualExport } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void Export_BaseAndDerivedShouldAmountInTwoExports() { var container = ContainerFactory.CreateWithAttributedCatalog( @@ -307,7 +307,7 @@ public class Plugin1 : Plugin } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void Export_Plugin1() { var container = ContainerFactory.CreateWithAttributedCatalog( @@ -332,7 +332,7 @@ public override int Version } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void Export_Plugin2() { var container = ContainerFactory.CreateWithAttributedCatalog( @@ -360,7 +360,7 @@ public override int Version } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void Export_Plugin3() { var container = ContainerFactory.CreateWithAttributedCatalog( @@ -393,7 +393,7 @@ public override int Version } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void Export_Plugin4() { var container = ContainerFactory.CreateWithAttributedCatalog( @@ -414,7 +414,7 @@ public class MyPlugin : IPlugin } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void Export_MyPlugin() { var container = ContainerFactory.CreateWithAttributedCatalog( @@ -450,7 +450,7 @@ public class MyToolbarPlugin : IToolbarPlugin } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void TestInterfaces() { var container = ContainerFactory.CreateWithAttributedCatalog( @@ -509,7 +509,7 @@ public override int VirtualImport } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void Import_VirtualPropertyOverrideWithSameContract_ShouldSucceed() { var container = ContainerFactory.Create(); @@ -541,7 +541,7 @@ public override int VirtualImport } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void Import_VirtualPropertyOverrideWithDifferentContract_ShouldSucceed() { var container = ContainerFactory.Create(); @@ -669,7 +669,7 @@ public void Shutdown() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void DiscoverAddinsWithCombinedCustomExportAndMetadataAttribute() { var container = ContainerFactory.CreateWithAttributedCatalog(typeof(Addin1), typeof(Addin2), typeof(Addin3)); @@ -728,7 +728,7 @@ public int Property } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void Test_CustomInheritedExportAttribute_OnInterface() { var container = ContainerFactory.CreateWithAttributedCatalog(typeof(UsesCustomInheritedExportOnInterface)); @@ -751,7 +751,7 @@ public DerivedFromBaseWithCustomInheritedExport() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void Test_CustomInheritedExportAttribute_OnBaseClass() { var container = ContainerFactory.CreateWithAttributedCatalog(typeof(DerivedFromBaseWithCustomInheritedExport)); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/LifetimeTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/LifetimeTests.cs index 7b1360bf5fd81..87c4784eeac8d 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/LifetimeTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/LifetimeTests.cs @@ -55,7 +55,7 @@ public void Dispose() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void PartAddedViaAddExportedValue_ShouldNotBeDisposedWithContainer() { var container = new CompositionContainer(); @@ -69,7 +69,7 @@ public void PartAddedViaAddExportedValue_ShouldNotBeDisposedWithContainer() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void PartAddedTwice_AppearsTwice() { // You probably shouldn't be adding a part to the container twice, but it's not something we're going to check for and throw an exception on @@ -107,7 +107,7 @@ public void AnyPart_Simple_ShouldNotBeCollected() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void AnyPart_Disposable_ShouldNotBeCollected() { var catalog = new TypeCatalog(typeof(AnyPartDisposable)); @@ -122,7 +122,7 @@ public void AnyPart_Disposable_ShouldNotBeCollected() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void AnyPart_Disposable_ShouldBeDisposedWithContainer() { var catalog = new TypeCatalog(typeof(AnyPartDisposable)); @@ -138,7 +138,7 @@ public void AnyPart_Disposable_ShouldBeDisposedWithContainer() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void AnyPart_RecomposabeImport_ShouldNotBeCollected() { var catalog = new TypeCatalog(typeof(AnyPartRecomposable)); @@ -170,7 +170,7 @@ public void AnyPart_RecomposabeImport_ShouldNotBeCollected() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void AnyPart_DisposableRecomposabeImport_ShouldNotBeCollected() { var catalog = new TypeCatalog(typeof(AnyPartDisposableRecomposable)); @@ -265,7 +265,7 @@ public void SharedPart_Simple_ShouldNotBeCollected() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SharedPart_Disposable_ShouldNotBeCollected() { var catalog = new TypeCatalog(typeof(SharedPartDisposable)); @@ -282,7 +282,7 @@ public void SharedPart_Disposable_ShouldNotBeCollected() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SharedPart_Disposable_ShouldBeDisposedWithContainer() { var catalog = new TypeCatalog(typeof(SharedPartDisposable)); @@ -298,7 +298,7 @@ public void SharedPart_Disposable_ShouldBeDisposedWithContainer() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SharedPart_RecomposabeImport_ShouldNotBeCollected() { var catalog = new TypeCatalog(typeof(SharedPartRecomposable)); @@ -331,7 +331,7 @@ public void SharedPart_RecomposabeImport_ShouldNotBeCollected() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void SharedPart_DisposableRecomposabeImport_ShouldNotBeCollected() { var catalog = new TypeCatalog(typeof(SharedPartDisposableRecomposable)); @@ -424,7 +424,7 @@ public void Dispose() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void NonSharedPart_Disposable_ShouldNotBeCollected() { var catalog = new TypeCatalog(typeof(NonSharedPartDisposable)); @@ -441,7 +441,7 @@ public void NonSharedPart_Disposable_ShouldNotBeCollected() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void NonSharedPart_Disposable_ShouldBeDisposedWithContainer() { var catalog = new TypeCatalog(typeof(NonSharedPartDisposable)); @@ -457,7 +457,7 @@ public void NonSharedPart_Disposable_ShouldBeDisposedWithContainer() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void NonSharedPart_RecomposableImport_WithReference_ShouldNotBeCollected() { var catalog = new TypeCatalog(typeof(NonSharedPartRecomposable)); @@ -490,7 +490,7 @@ public void NonSharedPart_RecomposableImport_WithReference_ShouldNotBeCollected( } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void NonSharedPart_DisposableRecomposabeImport_NoReference_ShouldNotBeCollected() { var catalog = new TypeCatalog(typeof(NonSharedPartDisposableRecomposable)); @@ -545,7 +545,7 @@ public class NonSharedState } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void NonSharedPart_TwoRecomposablePartsSameExportedValue() { // This test is primarily used to ensure that we allow for multiple parts to be associated @@ -605,7 +605,7 @@ private static CompositionContainer GetContainer() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void GetReleaseExport_SharedRoot_ShouldNotDisposeChain() { var container = GetContainer(); @@ -620,7 +620,7 @@ public void GetReleaseExport_SharedRoot_ShouldNotDisposeChain() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void AddRemovePart_SharedRoot_ShouldNotDisposeChain() { var container = GetContainer(); @@ -640,7 +640,7 @@ public void AddRemovePart_SharedRoot_ShouldNotDisposeChain() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ContainerDispose_SharedRoot_ShouldDisposeChain() { var container = GetContainer(); @@ -655,7 +655,7 @@ public void ContainerDispose_SharedRoot_ShouldDisposeChain() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void GetReleaseExport_NonSharedRoot_ShouldDisposeChain() { var container = GetContainer(); @@ -686,7 +686,7 @@ public void GetReleaseExport_NonSharedRoot_ShouldDisposeChain() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void GetReleaseExport_NonSharedRoot_ShouldDisposeChain_WithMetadata() { var container = GetContainer(); @@ -717,7 +717,7 @@ public void GetReleaseExport_NonSharedRoot_ShouldDisposeChain_WithMetadata() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ReleaseExports_ShouldDispose_NonSharedParts() { var container = GetContainer(); @@ -738,7 +738,7 @@ public void ReleaseExports_ShouldDispose_NonSharedParts() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void AddRemovePart_NonSharedRoot_ShouldDisposeChain() { var container = GetContainer(); @@ -758,7 +758,7 @@ public void AddRemovePart_NonSharedRoot_ShouldDisposeChain() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ContainerDispose_NonSharedRoot_ShouldNotDisposeChain() { var container = GetContainer(); @@ -773,7 +773,7 @@ public void ContainerDispose_NonSharedRoot_ShouldNotDisposeChain() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void GetReleaseExport_NonSharedPart_ShouldNotRecomposeAfterRelease() { var catalog = new TypeCatalog(typeof(NonSharedPartRecomposable)); @@ -801,7 +801,7 @@ public void GetReleaseExport_NonSharedPart_ShouldNotRecomposeAfterRelease() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void GetExportManualDisposeThenRecompose_NonSharedDisposableRecomposablePart_ShouldThrowComposition() { var catalog = new TypeCatalog(typeof(NonSharedPartDisposableRecomposable)); @@ -842,7 +842,7 @@ public class MyImporter } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void RecomposeCausesOldImportedValuesToBeDisposed() { var cat = new AggregateCatalog(); @@ -885,7 +885,7 @@ private static CompositionContainer CreateParentChildContainerWithNonSharedImpor } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ChildContainerGetReleaseExport_NonSharedRoot_ShouldDisposeChain() { var child = CreateParentChildContainerWithNonSharedImporter(); @@ -900,7 +900,7 @@ public void ChildContainerGetReleaseExport_NonSharedRoot_ShouldDisposeChain() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ChildContainerAddRemovePart_NonSharedRoot_ShouldDisposeChain() { var child = CreateParentChildContainerWithNonSharedImporter(); @@ -920,7 +920,7 @@ public void ChildContainerAddRemovePart_NonSharedRoot_ShouldDisposeChain() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ChildContainerAddRemovePart_NonSharedRoot_ShouldNotDisposeChain() { var child = CreateParentChildContainerWithNonSharedImporter(); @@ -1291,7 +1291,7 @@ public void GetReleaseExport_NonSharedPart_ShouldCollectWholeObjectChain() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public void ReleaseExports_ShouldWorkWithExportCollection() { var container = GetContainer(); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/RecompositionTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/RecompositionTests.cs index 5734ba8a5589e..7455e6af70bd9 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/RecompositionTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/RecompositionTests.cs @@ -11,7 +11,7 @@ namespace Tests.Integration { - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public class RecompositionTests { public class Class_OptIn_AllowRecompositionImports diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/RejectionTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/RejectionTests.cs index b03583aa41292..76690fbb07770 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/RejectionTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/RejectionTests.cs @@ -12,7 +12,7 @@ namespace Tests.Integration { - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public class RejectionTests { public interface IExtension diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/RequiredCreationPolicyTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/RequiredCreationPolicyTests.cs index e1975483cb016..82801b0855efa 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/Integration/RequiredCreationPolicyTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/Integration/RequiredCreationPolicyTests.cs @@ -12,7 +12,7 @@ namespace Tests.Integration { - [ActiveIssue("https://github.com/mono/mono/issues/16417", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)] public class RequiredCreationPolicyTests { // Matrix that details which policy to use for a given part to satisfy a given import. diff --git a/src/libraries/System.Data.Common/tests/System/Data/Common/DbConnectionTests.cs b/src/libraries/System.Data.Common/tests/System/Data/Common/DbConnectionTests.cs index d28316a8b41a5..c6d0ae306751e 100644 --- a/src/libraries/System.Data.Common/tests/System/Data/Common/DbConnectionTests.cs +++ b/src/libraries/System.Data.Common/tests/System/Data/Common/DbConnectionTests.cs @@ -146,7 +146,7 @@ public void CanBeFinalized() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15180", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15180", TestRuntimes.Mono)] public void ProviderFactoryTest() { DbProviderFactoryConnection con = new DbProviderFactoryConnection(); diff --git a/src/libraries/System.Diagnostics.StackTrace/tests/StackFrameTests.cs b/src/libraries/System.Diagnostics.StackTrace/tests/StackFrameTests.cs index 03d6363ee292b..849b3bb5a9d81 100644 --- a/src/libraries/System.Diagnostics.StackTrace/tests/StackFrameTests.cs +++ b/src/libraries/System.Diagnostics.StackTrace/tests/StackFrameTests.cs @@ -34,7 +34,7 @@ public void Ctor_FNeedFileInfo(bool fNeedFileInfo) } [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/15183", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15183", TestRuntimes.Mono)] [InlineData(StackFrame.OFFSET_UNKNOWN)] [InlineData(0)] [InlineData(1)] @@ -45,7 +45,7 @@ public void Ctor_SkipFrames(int skipFrames) } [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/15187", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15187", TestRuntimes.Mono)] [InlineData(StackFrame.OFFSET_UNKNOWN, true)] [InlineData(0, true)] [InlineData(1, true)] @@ -93,7 +93,7 @@ public void Ctor_Filename_LineNumber(string fileName, int lineNumber) } [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/15184", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15184", TestRuntimes.Mono)] [InlineData(null, StackFrame.OFFSET_UNKNOWN, 0)] [InlineData("", 0, StackFrame.OFFSET_UNKNOWN)] [InlineData("FileName", 1, 2)] @@ -118,7 +118,7 @@ public static IEnumerable ToString_TestData() } [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/15186", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15186", TestRuntimes.Mono)] [MemberData(nameof(ToString_TestData))] public void ToString_Invoke_ReturnsExpected(StackFrame stackFrame, string expectedToString) { diff --git a/src/libraries/System.Diagnostics.StackTrace/tests/StackTraceTests.cs b/src/libraries/System.Diagnostics.StackTrace/tests/StackTraceTests.cs index 824241e4f929e..0915dd2537766 100644 --- a/src/libraries/System.Diagnostics.StackTrace/tests/StackTraceTests.cs +++ b/src/libraries/System.Diagnostics.StackTrace/tests/StackTraceTests.cs @@ -143,7 +143,7 @@ public void Ctor_EmptyException_FNeedFileInfo(bool fNeedFileInfo) } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/31796", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31796", TestRuntimes.Mono)] [InlineData(0)] [InlineData(1)] public void Ctor_Exception_SkipFrames(int skipFrames) @@ -182,7 +182,7 @@ public void Ctor_EmptyException_SkipFrames() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/31796", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31796", TestRuntimes.Mono)] [InlineData(0, true)] [InlineData(1, true)] [InlineData(0, false)] @@ -274,7 +274,7 @@ public void GetFrame_InvalidIndex_ReturnsNull() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/31797", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31797", TestRuntimes.Mono)] [MemberData(nameof(ToString_TestData))] public void ToString_Invoke_ReturnsExpected(StackTrace stackTrace, string expectedToString) { diff --git a/src/libraries/System.Drawing.Common/tests/Imaging/ImageAttributesTests.cs b/src/libraries/System.Drawing.Common/tests/Imaging/ImageAttributesTests.cs index aff8564c54bf3..940433cee61f4 100644 --- a/src/libraries/System.Drawing.Common/tests/Imaging/ImageAttributesTests.cs +++ b/src/libraries/System.Drawing.Common/tests/Imaging/ImageAttributesTests.cs @@ -282,7 +282,7 @@ public static IEnumerable ColorMatrixFlag_InvalidFlags_TestData() [ConditionalTheory(Helpers.IsDrawingSupported)] [MemberData(nameof(ColorAdjustType_InvalidTypes_TestData))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2337", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2337", TestRuntimes.Mono)] public void SetColorMatrix_InvalidFlags_ThrowsArgumentException(ColorMatrixFlag flag) { using (var imageAttr = new ImageAttributes()) diff --git a/src/libraries/System.Dynamic.Runtime/tests/Dynamic.OverloadResolution/Conformance.dynamic.overloadResolution.Methods.1class2methods.cs b/src/libraries/System.Dynamic.Runtime/tests/Dynamic.OverloadResolution/Conformance.dynamic.overloadResolution.Methods.1class2methods.cs index a6e0aa412bdfb..7c1ae18d39fe2 100644 --- a/src/libraries/System.Dynamic.Runtime/tests/Dynamic.OverloadResolution/Conformance.dynamic.overloadResolution.Methods.1class2methods.cs +++ b/src/libraries/System.Dynamic.Runtime/tests/Dynamic.OverloadResolution/Conformance.dynamic.overloadResolution.Methods.1class2methods.cs @@ -3995,7 +3995,7 @@ public void Method(int f, ref object x) public class Test { [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/14906", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14906", TestRuntimes.Mono)] public static void DynamicCSharpRunTest() { Assert.Equal(0, MainMethod(null)); diff --git a/src/libraries/System.Linq.Expressions/tests/Array/ArrayAccessTests.cs b/src/libraries/System.Linq.Expressions/tests/Array/ArrayAccessTests.cs index 5344890329672..9ddda2d799d9d 100644 --- a/src/libraries/System.Linq.Expressions/tests/Array/ArrayAccessTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/Array/ArrayAccessTests.cs @@ -13,7 +13,7 @@ public static class ArrayAccessTests public static IEnumerable Ranks() => Enumerable.Range(1, 5).Select(i => new object[] {i}); [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNonZeroLowerBoundArraySupported))] - [ActiveIssue("https://github.com/mono/mono/issues/14920", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14920", TestRuntimes.Mono)] [ClassData(typeof(CompilationTypes))] public static void ArrayAccess_MultiDimensionalOf1(bool useInterpreter) { @@ -32,7 +32,7 @@ public static void ArrayAccess_MultiDimensionalOf1(bool useInterpreter) } [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNonZeroLowerBoundArraySupported))] - [ActiveIssue("https://github.com/mono/mono/issues/14920", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14920", TestRuntimes.Mono)] [ClassData(typeof(CompilationTypes))] public static void ArrayIndex_MultiDimensionalOf1(bool useInterpreter) { @@ -80,7 +80,7 @@ public static void UnreadableIndex() } [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNonZeroLowerBoundArraySupported))] - [ActiveIssue("https://github.com/mono/mono/issues/14921", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14921", TestRuntimes.Mono)] [ClassData(typeof(CompilationTypes))] public static void NonZeroBasedOneDimensionalArrayAccess(bool useInterpreter) { diff --git a/src/libraries/System.Linq.Expressions/tests/Array/ArrayIndexTests.cs b/src/libraries/System.Linq.Expressions/tests/Array/ArrayIndexTests.cs index c7796a8c8fae2..1b2145ed26e0d 100644 --- a/src/libraries/System.Linq.Expressions/tests/Array/ArrayIndexTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/Array/ArrayIndexTests.cs @@ -2771,7 +2771,7 @@ public static void UnreadableIndex() } [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNonZeroLowerBoundArraySupported))] - [ActiveIssue("https://github.com/mono/mono/issues/14930", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14930", TestRuntimes.Mono)] [ClassData(typeof(CompilationTypes))] public static void NonZeroBasedOneDimensionalArrayIndex(bool useInterpreter) { @@ -2793,7 +2793,7 @@ public static void NonZeroBasedOneDimensionalArrayIndex(bool useInterpreter) } [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNonZeroLowerBoundArraySupported))] - [ActiveIssue("https://github.com/mono/mono/issues/14930", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14930", TestRuntimes.Mono)] [ClassData(typeof(CompilationTypes))] public static void NonZeroBasedOneDimensionalArrayIndexMethod(bool useInterpreter) { diff --git a/src/libraries/System.Linq.Expressions/tests/Array/NewArrayBoundsTests.cs b/src/libraries/System.Linq.Expressions/tests/Array/NewArrayBoundsTests.cs index 722b271b8bc07..bfb2db1f2f5da 100644 --- a/src/libraries/System.Linq.Expressions/tests/Array/NewArrayBoundsTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/Array/NewArrayBoundsTests.cs @@ -131,7 +131,7 @@ public static IEnumerable TestData() } [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/14912", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14912", TestRuntimes.Mono)] [PerCompilationType(nameof(TestData))] public static void NewArrayBounds(Type arrayType, object size, Type sizeType, object defaultValue, bool useInterpreter) { @@ -288,7 +288,7 @@ public static void UpdateNullThrows() } [Theory, ClassData(typeof(CompilationTypes))] - [ActiveIssue("https://github.com/mono/mono/issues/14933", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14933", TestRuntimes.Mono)] public static void SingleNegativeBoundErrorMessage(bool useInterpreter) { string localizedMessage = null; @@ -309,7 +309,7 @@ public static void SingleNegativeBoundErrorMessage(bool useInterpreter) } [Theory, ClassData(typeof(CompilationTypes))] - [ActiveIssue("https://github.com/mono/mono/issues/14934", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14934", TestRuntimes.Mono)] public static void MultipleNegativeBoundErrorMessage(bool useInterpreter) { string localizedMessage = null; diff --git a/src/libraries/System.Linq.Expressions/tests/BinaryOperators/Coalesce/BinaryCoalesceTests.cs b/src/libraries/System.Linq.Expressions/tests/BinaryOperators/Coalesce/BinaryCoalesceTests.cs index b81e616ae794c..98ec223eefef4 100644 --- a/src/libraries/System.Linq.Expressions/tests/BinaryOperators/Coalesce/BinaryCoalesceTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/BinaryOperators/Coalesce/BinaryCoalesceTests.cs @@ -497,7 +497,7 @@ public static void CoalesceReferenceToValueType(bool useInterpreter) #if FEATURE_COMPILE [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/14919", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14919", TestRuntimes.Mono)] public static void VerifyIL_NullableIntCoalesceToNullableInt() { ParameterExpression x = Expression.Parameter(typeof(int?)); diff --git a/src/libraries/System.Linq.Expressions/tests/Block/BlockTests.cs b/src/libraries/System.Linq.Expressions/tests/Block/BlockTests.cs index 09f2db3e72b00..07fb497d31ad7 100644 --- a/src/libraries/System.Linq.Expressions/tests/Block/BlockTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/Block/BlockTests.cs @@ -227,7 +227,7 @@ public static void ToStringTest() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/14919", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14919", TestRuntimes.Mono)] public static void InsignificantBlock() { Expression nop = Expression.Lambda( diff --git a/src/libraries/System.Linq.Expressions/tests/CompilerTests.cs b/src/libraries/System.Linq.Expressions/tests/CompilerTests.cs index 0838b4ca3c3e8..4069ca6a99d53 100644 --- a/src/libraries/System.Linq.Expressions/tests/CompilerTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/CompilerTests.cs @@ -167,7 +167,7 @@ public static void VariableBinder_CatchBlock_Filter2() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/14919", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14919", TestRuntimes.Mono)] public static void VerifyIL_Simple() { Expression> f = () => Math.Abs(42); @@ -184,7 +184,7 @@ .maxstack 1 } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/14919", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14919", TestRuntimes.Mono)] public static void VerifyIL_Exceptions() { ParameterExpression x = Expression.Parameter(typeof(int), "x"); @@ -245,7 +245,7 @@ [0] int32 } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/14919", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14919", TestRuntimes.Mono)] public static void VerifyIL_Closure1() { Expression>> f = () => () => 42; @@ -280,7 +280,7 @@ .maxstack 1 } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/14919", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14919", TestRuntimes.Mono)] public static void VerifyIL_Closure2() { Expression>> f = x => () => x; @@ -338,7 +338,7 @@ [0] object[] } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/14919", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14919", TestRuntimes.Mono)] public static void VerifyIL_Closure3() { // Using an unchecked addition to ensure that an add instruction is emitted (and not add.ovf) diff --git a/src/libraries/System.Linq.Expressions/tests/ExceptionHandling/ExceptionHandlingExpressions.cs b/src/libraries/System.Linq.Expressions/tests/ExceptionHandling/ExceptionHandlingExpressions.cs index 2dc3260786342..b9b5103047f20 100644 --- a/src/libraries/System.Linq.Expressions/tests/ExceptionHandling/ExceptionHandlingExpressions.cs +++ b/src/libraries/System.Linq.Expressions/tests/ExceptionHandling/ExceptionHandlingExpressions.cs @@ -224,7 +224,7 @@ public void ThrownNonExceptionPassesThroughNonMatchingHandlers(bool useInterpret } [Theory, ClassData(typeof(CompilationTypes))] - [ActiveIssue("https://github.com/mono/mono/issues/14925", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14925", TestRuntimes.Mono)] public void ExpressionsUnwrapeExternallyThrownRuntimeWrappedException(bool useInterpreter) { ParameterExpression exRWE = Expression.Variable(typeof(RuntimeWrappedException)); @@ -932,7 +932,7 @@ public void FilterBeforeInnerFault(bool useInterpreter) } [Theory, ClassData(typeof(CompilationTypes))] - [ActiveIssue("https://github.com/mono/mono/issues/14924", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14924", TestRuntimes.Mono)] public void ExceptionThrownInFilter(bool useInterpreter) { // An exception in a filter should be eaten and the filter fail. diff --git a/src/libraries/System.Linq.Expressions/tests/Goto/Return.cs b/src/libraries/System.Linq.Expressions/tests/Goto/Return.cs index 026b5a1b63976..e2cae0fc0addc 100644 --- a/src/libraries/System.Linq.Expressions/tests/Goto/Return.cs +++ b/src/libraries/System.Linq.Expressions/tests/Goto/Return.cs @@ -296,7 +296,7 @@ public static void DoNothing() } [Theory, ClassData(typeof(CompilationTypes))] - [ActiveIssue("https://github.com/mono/mono/issues/14919", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14919", TestRuntimes.Mono)] public void TailCallThenReturn(bool useInterpreter) { LabelTarget target = Expression.Label(); diff --git a/src/libraries/System.Linq.Expressions/tests/IndexExpression/IndexExpressionTests.cs b/src/libraries/System.Linq.Expressions/tests/IndexExpression/IndexExpressionTests.cs index c9de9c0fd6e27..23c6c7aa9b2a1 100644 --- a/src/libraries/System.Linq.Expressions/tests/IndexExpression/IndexExpressionTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/IndexExpression/IndexExpressionTests.cs @@ -100,7 +100,7 @@ private static TypeBuilder GetTestTypeBuilder() => .DefineType("TestType"); [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/14920", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14920", TestRuntimes.Mono)] public void NoAccessorIndexedProperty() { TypeBuilder typeBuild = GetTestTypeBuilder(); @@ -175,7 +175,7 @@ public void VoidIndexedProperty() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/14927", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14927", TestRuntimes.Mono)] public void IndexedPropertyGetReturnsWrongType() { TypeBuilder typeBuild = GetTestTypeBuilder(); @@ -328,7 +328,7 @@ public void IndexedPropertyGetterInstanceSetterStatic() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/14927", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14927", TestRuntimes.Mono)] public void IndexedPropertySetterValueTypeNotMatchPropertyType() { TypeBuilder typeBuild = GetTestTypeBuilder(); diff --git a/src/libraries/System.Linq.Expressions/tests/Lambda/LambdaTests.cs b/src/libraries/System.Linq.Expressions/tests/Lambda/LambdaTests.cs index 71c52fbeaecad..745a9e5e72231 100644 --- a/src/libraries/System.Linq.Expressions/tests/Lambda/LambdaTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/Lambda/LambdaTests.cs @@ -12,7 +12,7 @@ namespace System.Linq.Expressions.Tests { [TestCaseOrderer("System.Linq.Expressions.Tests.TestOrderer", "System.Linq.Expressions.Tests")] - [ActiveIssue("https://github.com/mono/mono/issues/14919", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14919", TestRuntimes.Mono)] public class LambdaTests { private delegate int IcosanaryInt32Func( diff --git a/src/libraries/System.Linq.Expressions/tests/Member/MemberAccessTests.cs b/src/libraries/System.Linq.Expressions/tests/Member/MemberAccessTests.cs index bd34b75a52901..19ceee9baa82b 100644 --- a/src/libraries/System.Linq.Expressions/tests/Member/MemberAccessTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/Member/MemberAccessTests.cs @@ -554,7 +554,7 @@ public static void MakeMemberAccess_MemberNotFieldOrProperty_ThrowsArgumentExcep #if FEATURE_COMPILE [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/14920", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14920", TestRuntimes.Mono)] public static void Property_NoGetOrSetAccessors_ThrowsArgumentException() { AssemblyBuilder assembly = AssemblyBuilder.DefineDynamicAssembly(new AssemblyName("Name"), AssemblyBuilderAccess.RunAndCollect); diff --git a/src/libraries/System.Linq.Expressions/tests/MemberInit/BindTests.cs b/src/libraries/System.Linq.Expressions/tests/MemberInit/BindTests.cs index 6101d240061ac..1e505ff9186ca 100644 --- a/src/libraries/System.Linq.Expressions/tests/MemberInit/BindTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/MemberInit/BindTests.cs @@ -162,7 +162,7 @@ public void MemberAssignmentFromMethodInfo(bool useInterpreter) } [Theory, ClassData(typeof(CompilationTypes))] - [ActiveIssue("https://github.com/mono/mono/issues/14918", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14918", TestRuntimes.Mono)] public void ConstantField(bool useInterpreter) { MemberInfo member = typeof(PropertyAndFields).GetMember(nameof(PropertyAndFields.ConstantString))[0]; diff --git a/src/libraries/System.Linq.Expressions/tests/StackSpillerTests.cs b/src/libraries/System.Linq.Expressions/tests/StackSpillerTests.cs index df9c1b9eaa597..bb988b3a0b49c 100644 --- a/src/libraries/System.Linq.Expressions/tests/StackSpillerTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/StackSpillerTests.cs @@ -9,7 +9,7 @@ namespace System.Linq.Expressions.Tests { - [ActiveIssue("https://github.com/mono/mono/issues/14919", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14919", TestRuntimes.Mono)] public static class StackSpillerTests { [Fact] diff --git a/src/libraries/System.Linq.Expressions/tests/Unary/UnaryArithmeticNegateCheckedNullableTests.cs b/src/libraries/System.Linq.Expressions/tests/Unary/UnaryArithmeticNegateCheckedNullableTests.cs index 3ee6cb38054ad..004d3b30e40d1 100644 --- a/src/libraries/System.Linq.Expressions/tests/Unary/UnaryArithmeticNegateCheckedNullableTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/Unary/UnaryArithmeticNegateCheckedNullableTests.cs @@ -204,7 +204,7 @@ private static void VerifyArithmeticNegateCheckedNullableShort(short? value, boo #if FEATURE_COMPILE [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/14919", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14919", TestRuntimes.Mono)] public static void VerifyIL_NullableShortNegateChecked() { ParameterExpression param = Expression.Parameter(typeof(short?)); diff --git a/src/libraries/System.Linq.Expressions/tests/Unary/UnaryArithmeticNegateCheckedTests.cs b/src/libraries/System.Linq.Expressions/tests/Unary/UnaryArithmeticNegateCheckedTests.cs index d2aa6b68a1fae..8a4ca5d12218d 100644 --- a/src/libraries/System.Linq.Expressions/tests/Unary/UnaryArithmeticNegateCheckedTests.cs +++ b/src/libraries/System.Linq.Expressions/tests/Unary/UnaryArithmeticNegateCheckedTests.cs @@ -211,7 +211,7 @@ private static void VerifyArithmeticNegateCheckedShort(short value, bool useInte #if FEATURE_COMPILE [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/14919", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14919", TestRuntimes.Mono)] public static void VerifyIL_ShortNegateChecked() { ParameterExpression param = Expression.Parameter(typeof(short)); diff --git a/src/libraries/System.Linq.Parallel/tests/PlinqModesTests.cs b/src/libraries/System.Linq.Parallel/tests/PlinqModesTests.cs index 565cd172697da..0bd5fd5db57d0 100644 --- a/src/libraries/System.Linq.Parallel/tests/PlinqModesTests.cs +++ b/src/libraries/System.Linq.Parallel/tests/PlinqModesTests.cs @@ -159,7 +159,7 @@ public static void WithExecutionMode_ArgumentException(Labeled(() => new ArrayBufferWriter(0)); diff --git a/src/libraries/System.Memory/tests/Span/Reflection.cs b/src/libraries/System.Memory/tests/Span/Reflection.cs index 4dbae22ba1473..9066c692a6554 100644 --- a/src/libraries/System.Memory/tests/Span/Reflection.cs +++ b/src/libraries/System.Memory/tests/Span/Reflection.cs @@ -66,7 +66,7 @@ public static void MemoryMarshal_GenericStaticReturningSpan() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/14993", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14993", TestRuntimes.Mono)] public static void Span_Constructor() { Type type = typeof(Span); @@ -103,7 +103,7 @@ public static void Span_StaticOperator() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/14998", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14998", TestRuntimes.Mono)] public static void Span_InstanceMethod() { Type type = typeof(Span); @@ -113,7 +113,7 @@ public static void Span_InstanceMethod() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/14993", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14993", TestRuntimes.Mono)] public static void ReadOnlySpan_Constructor() { Type type = typeof(ReadOnlySpan); @@ -150,7 +150,7 @@ public static void ReadOnlySpan_Operator() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/14998", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14998", TestRuntimes.Mono)] public static void ReadOnlySpan_InstanceMethod() { Type type = typeof(ReadOnlySpan); @@ -160,7 +160,7 @@ public static void ReadOnlySpan_InstanceMethod() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/14998", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14998", TestRuntimes.Mono)] public static void Memory_PropertyReturningSpan() { Type type = typeof(Memory); @@ -170,7 +170,7 @@ public static void Memory_PropertyReturningSpan() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/14962", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/14962", TestRuntimes.Mono)] public static void ReadOnlyMemory_PropertyReturningReadOnlySpan() { Type type = typeof(ReadOnlyMemory); diff --git a/src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/PlatformHandlerTest.cs b/src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/PlatformHandlerTest.cs index a3dd06ced74da..a871abc502df4 100644 --- a/src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/PlatformHandlerTest.cs +++ b/src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/PlatformHandlerTest.cs @@ -10,7 +10,7 @@ namespace System.Net.Http.Functional.Tests { - [ActiveIssue("https://github.com/mono/mono/issues/15005", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15005", TestRuntimes.Mono)] public class PlatformHandler_HttpClientHandler : HttpClientHandlerTestBase { public PlatformHandler_HttpClientHandler(ITestOutputHelper output) : base(output) { } diff --git a/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs b/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs index a9a74b26a6162..d87f4e79e51d5 100644 --- a/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs +++ b/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs @@ -446,13 +446,13 @@ private void TestArrayIndexBasedConstructorLessElements() where T : struct #region Tests for constructors using unsupported types [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15190", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15190", TestRuntimes.Mono)] public void ConstructorWithUnsupportedTypes_Guid() => TestConstructorWithUnsupportedTypes(); [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15190", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15190", TestRuntimes.Mono)] public void ConstructorWithUnsupportedTypes_DateTime() => TestConstructorWithUnsupportedTypes(); [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15190", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15190", TestRuntimes.Mono)] public void ConstructorWithUnsupportedTypes_Char() => TestConstructorWithUnsupportedTypes(); private void TestConstructorWithUnsupportedTypes() where T : struct diff --git a/src/libraries/System.Private.Xml/tests/Xslt/XslTransformApi/CXslTransform.cs b/src/libraries/System.Private.Xml/tests/Xslt/XslTransformApi/CXslTransform.cs index 829e8d25b3b54..a1d0a67ba50a3 100644 --- a/src/libraries/System.Private.Xml/tests/Xslt/XslTransformApi/CXslTransform.cs +++ b/src/libraries/System.Private.Xml/tests/Xslt/XslTransformApi/CXslTransform.cs @@ -474,7 +474,7 @@ public void TC_Xslt_Document_Function_Use_XmlUrlResolver(InputType inputType, Re [InlineData(InputType.Navigator, ReaderType.XmlValidatingReader, TransformType.Stream, DocType.XPathDocument)] [InlineData(InputType.Navigator, ReaderType.XmlValidatingReader, TransformType.TextWriter, DocType.XPathDocument)] [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/15353", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15353", TestRuntimes.Mono)] public void TC_AbsolutePath_Transform(InputType inputType, ReaderType readerType, TransformType transformType, DocType docType) { TestUsingTemporaryCopyOfResolverDocument(() => @@ -2098,7 +2098,7 @@ public void TC_Xslt_Document_Function_Use_XmlUrlResolver(InputType inputType, Re [InlineData(InputType.Navigator, ReaderType.XmlValidatingReader, TransformType.Stream, DocType.XPathDocument)] [InlineData(InputType.Navigator, ReaderType.XmlValidatingReader, TransformType.TextWriter, DocType.XPathDocument)] [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/15353", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15353", TestRuntimes.Mono)] public void TC_AbsolutePath_Transform(InputType inputType, ReaderType readerType, TransformType transformType, DocType docType) { TestUsingTemporaryCopyOfResolverDocument(() => diff --git a/src/libraries/System.Reflection.Context/tests/CustomReflectionContextTests.cs b/src/libraries/System.Reflection.Context/tests/CustomReflectionContextTests.cs index 1ef7b92b4aa61..527fae22d1dc7 100644 --- a/src/libraries/System.Reflection.Context/tests/CustomReflectionContextTests.cs +++ b/src/libraries/System.Reflection.Context/tests/CustomReflectionContextTests.cs @@ -31,7 +31,7 @@ public void MapType_Null_Throws() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15191", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15191", TestRuntimes.Mono)] public void MapType_MemberAttributes_Success() { var customReflectionContext = new TestCustomReflectionContext(); @@ -46,7 +46,7 @@ public void MapType_MemberAttributes_Success() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15191", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15191", TestRuntimes.Mono)] public void MapType_ParameterAttributes_Success() { var customReflectionContext = new TestCustomReflectionContext(); @@ -64,7 +64,7 @@ public void MapType_ParameterAttributes_Success() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15191", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15191", TestRuntimes.Mono)] public void MapType_Interface_Throws() { var customReflectionContext = new TestCustomReflectionContext(); diff --git a/src/libraries/System.Reflection.Emit.ILGeneration/tests/CustomAttributeBuilderTests.cs b/src/libraries/System.Reflection.Emit.ILGeneration/tests/CustomAttributeBuilderTests.cs index cdd908505ceb9..fd7f153c1b2fa 100644 --- a/src/libraries/System.Reflection.Emit.ILGeneration/tests/CustomAttributeBuilderTests.cs +++ b/src/libraries/System.Reflection.Emit.ILGeneration/tests/CustomAttributeBuilderTests.cs @@ -256,7 +256,7 @@ private static void VerifyCustomAttributeBuilder(CustomAttributeBuilder builder, } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public static void Ctor_AllPrimitives() { ConstructorInfo con = typeof(Primitives).GetConstructors()[0]; @@ -452,7 +452,7 @@ public static IEnumerable Ctor_RefEmitParameters_TestData() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] [MemberData(nameof(Ctor_RefEmitParameters_TestData))] public static void Ctor_RefEmitParameters(ConstructorInfo con, object[] constructorArgs, PropertyInfo[] namedProperties, object[] propertyValues, @@ -468,7 +468,7 @@ public static void Ctor_RefEmitParameters(ConstructorInfo con, object[] construc } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] [InlineData(nameof(TestAttribute.ReadonlyField))] [InlineData(nameof(TestAttribute.StaticField))] [InlineData(nameof(TestAttribute.StaticReadonlyField))] @@ -502,7 +502,7 @@ public void NamedProperties_StaticProperty_Works() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] [InlineData(typeof(PrivateAttribute))] [InlineData(typeof(NotAnAttribute))] public static void ClassNotSupportedAsAttribute_DoesNotThrow_DoesNotSet(Type type) @@ -548,7 +548,7 @@ public static void PrivateConstructor_ThrowsArgumentException() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] [InlineData(CallingConventions.Any)] [InlineData(CallingConventions.VarArgs)] public static void ConstructorHasNonStandardCallingConvention_ThrowsArgumentException(CallingConventions callingConvention) @@ -650,7 +650,7 @@ public static IEnumerable InvalidAttributeTypes_TestData() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "Coreclr fixed an issue where IntPtr/UIntPtr in constructorParameters causes a corrupt created binary.")] [MemberData(nameof(IntPtrAttributeTypes_TestData))] public void ConstructorParametersContainsIntPtrOrUIntPtrArgument_ThrowsArgumentException(Type type, object value) @@ -659,7 +659,7 @@ public void ConstructorParametersContainsIntPtrOrUIntPtrArgument_ThrowsArgumentE } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] [MemberData(nameof(InvalidAttributeTypes_TestData))] public void ConstructorParametersNotSupportedInAttributes_ThrowsArgumentException(Type type, object value) { @@ -674,7 +674,7 @@ public void ConstructorParametersNotSupportedInAttributes_ThrowsArgumentExceptio } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "Used to throw a NullReferenceException, see https://github.com/dotnet/corefx/issues/11702.")] public void NullValueForPrimitiveTypeInConstructorArgs_ThrowsArgumentNullException() { @@ -694,7 +694,7 @@ public static IEnumerable NotSupportedPrimitives_TestData() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "Coreclr fixed an issue where IntPtr/UIntPtr in constructorArgs causes a corrupt created binary.")] [MemberData(nameof(NotSupportedPrimitives_TestData))] public static void NotSupportedPrimitiveInConstructorArgs_ThrowsArgumentException(object value) @@ -709,7 +709,7 @@ public static void NotSupportedPrimitiveInConstructorArgs_ThrowsArgumentExceptio } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public static void DynamicTypeInConstructorArgs_ThrowsFileNotFoundExceptionOnCreation() { AssemblyBuilder assembly = Helpers.DynamicAssembly(); @@ -756,7 +756,7 @@ public static IEnumerable FieldDoesntBelongToConstructorDeclaringType_ } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] [MemberData(nameof(FieldDoesntBelongToConstructorDeclaringType_TestData))] public void NamedFields_FieldDoesntBelongToConstructorDeclaringType_ThrowsArgumentException(ConstructorInfo con, FieldInfo field) { @@ -767,7 +767,7 @@ public void NamedFields_FieldDoesntBelongToConstructorDeclaringType_ThrowsArgume } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public void NamedFields_ContainsConstField_ThrowsArgumentException() { ConstructorInfo con = typeof(TestAttribute).GetConstructor(new Type[0]); @@ -793,7 +793,7 @@ public static void NullFieldValues_ThrowsArgumentNullException() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public static void NullObjectInNamedFields_ThrowsArgumentNullException() { ConstructorInfo con = typeof(TestAttribute).GetConstructor(new Type[0]); @@ -804,7 +804,7 @@ public static void NullObjectInNamedFields_ThrowsArgumentNullException() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public static void NullObjectInFieldValues_ThrowsArgumentNullException() { ConstructorInfo con = typeof(TestAttribute).GetConstructor(new Type[0]); @@ -816,7 +816,7 @@ public static void NullObjectInFieldValues_ThrowsArgumentNullException() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] [MemberData(nameof(NotSupportedObject_Others_TestData))] public static void NotSupportedObjectInFieldValues_ThrowsArgumentException(object value) { @@ -829,7 +829,7 @@ public static void NotSupportedObjectInFieldValues_ThrowsArgumentException(objec } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public static void ZeroCountMultidimensionalArrayInFieldValues_ChangesToZeroCountJaggedArray() { ConstructorInfo con = typeof(TestAttribute).GetConstructor(new Type[0]); @@ -847,7 +847,7 @@ public static void ZeroCountMultidimensionalArrayInFieldValues_ChangesToZeroCoun } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] [MemberData(nameof(NotSupportedPrimitives_TestData))] [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "Coreclr fixed an issue where IntPtr/UIntPtr in fieldValues causes a corrupt created binary.")] public static void NotSupportedPrimitiveInFieldValues_ThrowsArgumentException(object value) @@ -864,7 +864,7 @@ public static void NotSupportedPrimitiveInFieldValues_ThrowsArgumentException(ob } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public static void DynamicTypeInPropertyValues_ThrowsFileNotFoundExceptionOnCreation() { AssemblyBuilder assembly = Helpers.DynamicAssembly(); @@ -912,7 +912,7 @@ public static void NullPropertyValues_ThrowsArgumentNullException() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public static void NullObjectInNamedProperties_ThrowsArgumentNullException() { ConstructorInfo con = typeof(TestAttribute).GetConstructor(new Type[0]); @@ -923,7 +923,7 @@ public static void NullObjectInNamedProperties_ThrowsArgumentNullException() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public static void IndexerInNamedProperties_ThrowsCustomAttributeFormatExceptionOnCreation() { ConstructorInfo con = typeof(IndexerAttribute).GetConstructor(new Type[0]); @@ -963,7 +963,7 @@ public static IEnumerable PropertyDoesntBelongToConstructorDeclaringTy } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] [MemberData(nameof(PropertyDoesntBelongToConstructorDeclaringType_TestData))] public void NamedProperties_PropertyDoesntBelongToConstructorDeclaringType_ThrowsArgumentException(ConstructorInfo con, PropertyInfo property) { @@ -974,7 +974,7 @@ public void NamedProperties_PropertyDoesntBelongToConstructorDeclaringType_Throw } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public static void NullObjectInPropertyValues_ThrowsArgumentNullException() { ConstructorInfo con = typeof(TestAttribute).GetConstructor(new Type[0]); @@ -986,7 +986,7 @@ public static void NullObjectInPropertyValues_ThrowsArgumentNullException() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] [MemberData(nameof(NotSupportedObject_Others_TestData))] public static void NotSupportedObjectInPropertyValues_ThrowsArgumentException(object value) { @@ -999,7 +999,7 @@ public static void NotSupportedObjectInPropertyValues_ThrowsArgumentException(ob } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public static void ZeroCountMultidimensionalArrayInPropertyValues_ChangesToZeroCountJaggedArray() { ConstructorInfo con = typeof(TestAttribute).GetConstructor(new Type[0]); @@ -1017,7 +1017,7 @@ public static void ZeroCountMultidimensionalArrayInPropertyValues_ChangesToZeroC } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] [MemberData(nameof(NotSupportedPrimitives_TestData))] [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "Coreclr fixed an issue where IntPtr/UIntPtr in propertValues causes a corrupt created binary.")] public static void NotSupportedPrimitiveInPropertyValues_ThrowsArgumentException(object value) @@ -1031,7 +1031,7 @@ public static void NotSupportedPrimitiveInPropertyValues_ThrowsArgumentException } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public static void DynamicTypeInFieldValues_ThrowsFileNotFoundExceptionOnCreation() { AssemblyBuilder assembly = Helpers.DynamicAssembly(); diff --git a/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/DeclareLocalTests.cs b/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/DeclareLocalTests.cs index 0b94ebc4f5789..2e75d30112f6d 100644 --- a/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/DeclareLocalTests.cs +++ b/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/DeclareLocalTests.cs @@ -95,7 +95,7 @@ public void DeclareLocal_NullLocalType_ThrowsArgumentNullException() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public void DeclareLocal_TypeCreated_ThrowsInvalidOperationException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.NotPublic); @@ -108,7 +108,7 @@ public void DeclareLocal_TypeCreated_ThrowsInvalidOperationException() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public void DeclareLocal_GlobalFunctionsCreated_ThrowsInvalidOperationException() { ModuleBuilder module = Helpers.DynamicModule(); diff --git a/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit2Tests.cs b/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit2Tests.cs index df94573ce5889..9023dfc7411e0 100644 --- a/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit2Tests.cs +++ b/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit2Tests.cs @@ -147,7 +147,7 @@ public void Emit_OpCodes_LocalBuilder_NullLocal_ThrowsArgumentNullException() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public void Emit_OpCodes_LocalBuilder_LocalFromDifferentMethod_ThrowsArgumentException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.NotPublic); @@ -160,7 +160,7 @@ public void Emit_OpCodes_LocalBuilder_LocalFromDifferentMethod_ThrowsArgumentExc } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public void Emit_OpCodes_LocalBuilder_TooManyLocals_ThrowsInvalidOperationException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.NotPublic); diff --git a/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit3Tests.cs b/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit3Tests.cs index bb908ddb04793..5ebcd29654a3e 100644 --- a/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit3Tests.cs +++ b/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit3Tests.cs @@ -223,7 +223,7 @@ public void Emit_OpCodes_LocalBuilder_NullLocal_ThrowsArgumentNullException() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public void Emit_OpCodes_LocalBuilder_LocalFromDifferentMethod_ThrowsArgumentException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.NotPublic); diff --git a/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit4Tests.cs b/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit4Tests.cs index f3606b81676c1..79551e3533084 100644 --- a/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit4Tests.cs +++ b/src/libraries/System.Reflection.Emit.ILGeneration/tests/ILGenerator/Emit4Tests.cs @@ -74,7 +74,7 @@ public void TestDynamicMethodEmitCalliBlittable() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public void TestEmitCalliNonBlittable() { string input = "Test string!", result = "!gnirts tseT"; diff --git a/src/libraries/System.Reflection.Emit.ILGeneration/tests/ParameterBuilder/SetCustomAttributeTests.cs b/src/libraries/System.Reflection.Emit.ILGeneration/tests/ParameterBuilder/SetCustomAttributeTests.cs index 6208e01a81e09..0a7bf9927607f 100644 --- a/src/libraries/System.Reflection.Emit.ILGeneration/tests/ParameterBuilder/SetCustomAttributeTests.cs +++ b/src/libraries/System.Reflection.Emit.ILGeneration/tests/ParameterBuilder/SetCustomAttributeTests.cs @@ -59,7 +59,7 @@ public void SetCustomAttribute_ConstructorInfo_ByteArray() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public void SetCustomAttribute_NullArgument_ThrowsArgumentNullException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.NotPublic); diff --git a/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperAddArgument.cs b/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperAddArgument.cs index 6bb7369c88902..57f7008405983 100644 --- a/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperAddArgument.cs +++ b/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperAddArgument.cs @@ -19,7 +19,7 @@ public void AddArgument_Type() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] [InlineData(true, 3)] [InlineData(false, 2)] public void AddArgument_Type_Bool(bool pinned, int expectedLength) @@ -32,7 +32,7 @@ public void AddArgument_Type_Bool(bool pinned, int expectedLength) } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] [InlineData(null, null, 2)] [InlineData(new Type[] { typeof(int) }, null, 4)] [InlineData(null, new Type[] { typeof(Type) }, 4)] @@ -47,7 +47,7 @@ public void AddArgument_Type_TypeArray_TypeArray(Type[] requiredCustomModifiers, } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public void AddArgument_NullType_ThrowsArgumentNullException() { ModuleBuilder module = Helpers.DynamicModule(); @@ -59,7 +59,7 @@ public void AddArgument_NullType_ThrowsArgumentNullException() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public void AddArgument_SignatureFinished_ThrowsArgumentException() { ModuleBuilder module = Helpers.DynamicModule(); @@ -71,7 +71,7 @@ public void AddArgument_SignatureFinished_ThrowsArgumentException() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public void AddArgument_DifferentCountsForCustomModifiers_ThrowsArgumentException() { ModuleBuilder module = Helpers.DynamicModule(); diff --git a/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperAddArguments.cs b/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperAddArguments.cs index 6f97c120f724e..dc816fc0daaff 100644 --- a/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperAddArguments.cs +++ b/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperAddArguments.cs @@ -18,7 +18,7 @@ public static IEnumerable AddArguments_TestData() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] [MemberData(nameof(AddArguments_TestData))] public void AddArguments(Type[][] requiredCustomModifiers, Type[][] optionalCustomModifiers, int expectedLength) { @@ -39,7 +39,7 @@ public void AddArguments_NullObjectInTypeArguments_ThrowsArgumentNullException() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public void AddArguments_SignatureFinished_ThrowsArgumentException() { ModuleBuilder module = Helpers.DynamicModule(); @@ -50,7 +50,7 @@ public void AddArguments_SignatureFinished_ThrowsArgumentException() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public void AddArgument_NullObjectInRequiredCustomModifiers_ThrowsArgumentNullException() { ModuleBuilder module = Helpers.DynamicModule(); @@ -60,7 +60,7 @@ public void AddArgument_NullObjectInRequiredCustomModifiers_ThrowsArgumentNullEx } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public void AddArgument_DifferentCountsForCustomModifiers_ThrowsArgumentException() { ModuleBuilder module = Helpers.DynamicModule(); @@ -74,7 +74,7 @@ public void AddArgument_DifferentCountsForCustomModifiers_ThrowsArgumentExceptio } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public void AddArgument_NullObjectInOptionalCustomModifiers_ThrowsArgumentNullException() { ModuleBuilder module = Helpers.DynamicModule(); diff --git a/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperGetMethodSigHelper.cs b/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperGetMethodSigHelper.cs index d1daaf1ba3d4e..1fe7f0ec7273b 100644 --- a/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperGetMethodSigHelper.cs +++ b/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperGetMethodSigHelper.cs @@ -9,7 +9,7 @@ namespace System.Reflection.Emit.Tests public class SignatureHelperGetMethodSigHelper { [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] [InlineData(CallingConventions.Any, typeof(int))] [InlineData(CallingConventions.ExplicitThis, typeof(string))] [InlineData(CallingConventions.HasThis, typeof(string))] @@ -22,7 +22,7 @@ public void GetMethodSigHelper_CallingConventions_Type_Length_ReturnsThree(Calli } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] [InlineData(CallingConventions.Any, typeof(int))] [InlineData(CallingConventions.ExplicitThis, typeof(string))] [InlineData(CallingConventions.HasThis, typeof(string))] @@ -39,7 +39,7 @@ public void GetMethodSigHelper_Module_CallingConventions_Type_Length_ReturnsThre } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public void GetMethodSigHelper_Module_Type_TypeArray() { ModuleBuilder module = Helpers.DynamicModule(); @@ -51,7 +51,7 @@ public void GetMethodSigHelper_Module_Type_TypeArray() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public void GetMethodSigHelper_Module_Type_TypeArray_NullObjectInParameterType_ThrowsArgumentNullException() { ModuleBuilder module = Helpers.DynamicModule(); diff --git a/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperGetPropertySigHelper.cs b/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperGetPropertySigHelper.cs index 6e4f3ce77ddaf..557c5007e8a82 100644 --- a/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperGetPropertySigHelper.cs +++ b/src/libraries/System.Reflection.Emit.ILGeneration/tests/SignatureHelper/SignatureHelperGetPropertySigHelper.cs @@ -10,7 +10,7 @@ namespace System.Reflection.Emit.Tests public class SignatureHelperGetPropertySigHelper { [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] [InlineData(typeof(string), new Type[] { typeof(Delegate), typeof(int) }, 6)] [InlineData(typeof(Type), new Type[] { typeof(char), typeof(object) }, 6)] public void GetPropertySigHelper_Module_Type_TypeArray(Type returnType, Type[] parameterTypes, int expectedLength) @@ -21,7 +21,7 @@ public void GetPropertySigHelper_Module_Type_TypeArray(Type returnType, Type[] p } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public void GetPropertySigHelper_Module_Type_TypeArray_NullModule_DoesNotThrow() { SignatureHelper helper = SignatureHelper.GetPropertySigHelper(null, typeof(string), new Type[] { typeof(string), typeof(int) }); @@ -29,7 +29,7 @@ public void GetPropertySigHelper_Module_Type_TypeArray_NullModule_DoesNotThrow() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public void GetPropertySigHelper_Module_Type_TypeArray_NullObjectInParameterTypes_ThrowsArgumentNullException() { ModuleBuilder module = Helpers.DynamicModule(); @@ -44,7 +44,7 @@ public static IEnumerable GetPropertySigHelper_TestData() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] [MemberData(nameof(GetPropertySigHelper_TestData))] public void GetProperySigHelper_Module_Type_TypeArray_TypeArray_TypeArrayArray_TypeArrayArray(Type[] types, int expectedLength) { @@ -56,7 +56,7 @@ public void GetProperySigHelper_Module_Type_TypeArray_TypeArray_TypeArrayArray_T } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public void GetPropertySigHelper_NullModule_ThrowsNullReferenceException() { Type[] types = new Type[] { typeof(short), typeof(bool) }; @@ -67,7 +67,7 @@ public void GetPropertySigHelper_NullModule_ThrowsNullReferenceException() [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2383", TestRuntimes.Mono)] public void GetPropertySigHelper_NullTypeInParameterTypes_ThrowsArgumentNullException() { Type[] types = new Type[] { typeof(short), null }; diff --git a/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicILInfoTests.cs b/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicILInfoTests.cs index 1c9c3af692bd8..079606261b88e 100644 --- a/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicILInfoTests.cs +++ b/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicILInfoTests.cs @@ -13,7 +13,7 @@ public class DynamicILInfoTests private static string HelloWorld() => "hello, world".ToUpper(); [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/31857", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31857", TestRuntimes.Mono)] public void GetTokenFor_String_Success() { DynamicMethod dynamicMethod = new DynamicMethod(nameof(HelloWorld), typeof(string), new Type[] { }, typeof(DynamicILInfoTests), false); @@ -44,7 +44,7 @@ private static long Fib(long value) } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/31857", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31857", TestRuntimes.Mono)] public void GetTokenFor_DynamicMethod_Success() { // Calling DynamicMethod recursively @@ -119,7 +119,7 @@ public override int GetHashCode() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/31857", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31857", TestRuntimes.Mono)] public void GetTokenFor_CtorMethodAndField_Success() { DynamicMethod dynamicMethod = new DynamicMethod(nameof(Mock), typeof(Person), new Type[] { }, typeof(DynamicILInfoTests), false); @@ -187,7 +187,7 @@ private static int SumInteger() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15321", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15321", TestRuntimes.Mono)] public void GetTokenFor_IntGenerics_Success() { DynamicMethod dynamicMethod = new DynamicMethod(nameof(SumInteger), typeof(int), new Type[] { }, typeof(DynamicILInfoTests), false); @@ -251,7 +251,7 @@ private static string ContactString() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/31857", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31857", TestRuntimes.Mono)] public void GetTokenFor_StringGenerics_Success() { DynamicMethod dynamicMethod = new DynamicMethod(nameof(ContactString), typeof(string), Type.EmptyTypes, typeof(DynamicILInfoTests), false); @@ -347,7 +347,7 @@ private static int ExceptionTest() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/31857", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31857", TestRuntimes.Mono)] public void GetTokenFor_Exception_Success() { DynamicMethod dynamicMethod = new DynamicMethod(nameof(ExceptionTest), typeof(int), Type.EmptyTypes, typeof(DynamicILInfoTests), false); @@ -429,7 +429,7 @@ private static bool GenericMethod() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/31857", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31857", TestRuntimes.Mono)] public void Test_GenericMethod() { DynamicMethod dynamicMethod = new DynamicMethod(nameof(GenericMethod), typeof(bool), Type.EmptyTypes, typeof(DynamicILInfoTests), false); @@ -509,7 +509,7 @@ private static int TwoDimTest() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/31857", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31857", TestRuntimes.Mono)] public void Test_TwoDimTest() { // 2-D array (set/address/get) @@ -583,7 +583,7 @@ private static string CallGM() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/31857", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31857", TestRuntimes.Mono)] public void Test_CallGM() { // GenericMethod inside GenericType @@ -655,7 +655,7 @@ private static void PutInteger4(int value, int startPos, byte[] array) } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/31858", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31858", TestRuntimes.Mono)] [InlineData(true)] [InlineData(false)] public unsafe void SetX_NullInput_ThrowsArgumentNullException(bool skipVisibility) @@ -669,7 +669,7 @@ public unsafe void SetX_NullInput_ThrowsArgumentNullException(bool skipVisibilit } [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/15334", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15334", TestRuntimes.Mono)] [InlineData(true)] [InlineData(false)] public unsafe void SetX_NegativeInputSize_ThrowsArgumentOutOfRangeException(bool skipVisibility) diff --git a/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicMethodCtor.cs b/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicMethodCtor.cs index 5c5010aa4ffb0..8c99b0cacab1d 100644 --- a/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicMethodCtor.cs +++ b/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicMethodCtor.cs @@ -160,7 +160,7 @@ public void NullOwner_ThrowsArgumentNullException() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/31858", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31858", TestRuntimes.Mono)] [InlineData(typeof(int[]))] [InlineData(typeof(TestInterface))] [InlineData(typeof(GenericClass<>))] diff --git a/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicMethodGetILGenerator.cs b/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicMethodGetILGenerator.cs index 88d706d3b4e9f..35f67a45f1762 100644 --- a/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicMethodGetILGenerator.cs +++ b/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicMethodGetILGenerator.cs @@ -29,7 +29,7 @@ public void GetILGenerator_Int_Owner(bool skipVisibility) } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15321", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15321", TestRuntimes.Mono)] [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "The coreclr ignores the skipVisibility value of DynamicMethod.")] public void GetILGenerator_Int_Module_CoreclrIgnoresSkipVisibility() { @@ -74,7 +74,7 @@ public void GetILGenerator_Owner(bool skipVisibility) } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15321", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15321", TestRuntimes.Mono)] [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "The coreclr ignores the skipVisibility value of DynamicMethod.")] public void GetILGenerator_Module_CoreclrIgnoresSkipVisibility() { diff --git a/src/libraries/System.Reflection.Emit/tests/AssemblyBuilderTests.cs b/src/libraries/System.Reflection.Emit/tests/AssemblyBuilderTests.cs index 3edc022a63340..0d09c0d4955b0 100644 --- a/src/libraries/System.Reflection.Emit/tests/AssemblyBuilderTests.cs +++ b/src/libraries/System.Reflection.Emit/tests/AssemblyBuilderTests.cs @@ -37,7 +37,7 @@ public static IEnumerable DefineDynamicAssembly_TestData() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(DefineDynamicAssembly_TestData))] public void DefineDynamicAssembly_AssemblyName_AssemblyBuilderAccess(AssemblyName name, AssemblyBuilderAccess access) { @@ -58,7 +58,7 @@ public static IEnumerable DefineDynamicAssembly_CustomAttributes_TestD } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(DefineDynamicAssembly_CustomAttributes_TestData))] public void DefineDynamicAssembly_AssemblyName_AssemblyBuilderAccess_CustomAttributeBuilder(AssemblyName name, AssemblyBuilderAccess access, IEnumerable attributes) { @@ -115,7 +115,7 @@ public static IEnumerable DefineDynamicModule_TestData() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(DefineDynamicModule_TestData))] public void DefineDynamicModule(string name) { diff --git a/src/libraries/System.Reflection.Emit/tests/ConstructorBuilder/ConstructorBuilderToString.cs b/src/libraries/System.Reflection.Emit/tests/ConstructorBuilder/ConstructorBuilderToString.cs index 6fd344a334964..a00d42e12c25f 100644 --- a/src/libraries/System.Reflection.Emit/tests/ConstructorBuilder/ConstructorBuilderToString.cs +++ b/src/libraries/System.Reflection.Emit/tests/ConstructorBuilder/ConstructorBuilderToString.cs @@ -9,7 +9,7 @@ namespace System.Reflection.Emit.Tests public class ConstructorBuilderToString { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void ToString_NullRequiredOptionalCustomModifiers() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); @@ -20,7 +20,7 @@ public void ToString_NullRequiredOptionalCustomModifiers() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void ToString_NoRequiredOptionalCustomModifiers() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.Emit/tests/EnumBuilder/EnumBuilder.Methods.Tests.cs b/src/libraries/System.Reflection.Emit/tests/EnumBuilder/EnumBuilder.Methods.Tests.cs index 461a3ceaee06e..d02de105199fe 100644 --- a/src/libraries/System.Reflection.Emit/tests/EnumBuilder/EnumBuilder.Methods.Tests.cs +++ b/src/libraries/System.Reflection.Emit/tests/EnumBuilder/EnumBuilder.Methods.Tests.cs @@ -50,7 +50,7 @@ public static IEnumerable DefineLiteral_TestData() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(DefineLiteral_TestData))] public void DefineLiteral(Type underlyingType, object literalValue) { @@ -114,7 +114,7 @@ public static IEnumerable DefineLiteral_InvalidLiteralValue_ThrowsArgu } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(DefineLiteral_InvalidLiteralValue_ThrowsArgumentException_TestData))] public void DefineLiteral_InvalidLiteralValue_ThrowsArgumentException(Type underlyingType, object literalValue) { @@ -209,7 +209,7 @@ public void MakePointerType() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void SetCustomAttribute_ConstructorInfo_ByteArray() { EnumBuilder enumBuilder = Helpers.DynamicEnum(TypeAttributes.Public, typeof(int)); @@ -223,7 +223,7 @@ public void SetCustomAttribute_ConstructorInfo_ByteArray() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void SetCustomAttribute_CustomAttributeBuilder() { EnumBuilder enumBuilder = Helpers.DynamicEnum(TypeAttributes.Public, typeof(int)); diff --git a/src/libraries/System.Reflection.Emit/tests/EnumBuilder/EnumBuilder.Properties.Tests.cs b/src/libraries/System.Reflection.Emit/tests/EnumBuilder/EnumBuilder.Properties.Tests.cs index a3b3e35d60846..e13310eae5265 100644 --- a/src/libraries/System.Reflection.Emit/tests/EnumBuilder/EnumBuilder.Properties.Tests.cs +++ b/src/libraries/System.Reflection.Emit/tests/EnumBuilder/EnumBuilder.Properties.Tests.cs @@ -9,7 +9,7 @@ namespace System.Reflection.Emit.Tests public class EnumBuilderPropertyTests { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void Guid_TypeCreated() { EnumBuilder enumBuilder = Helpers.DynamicEnum(TypeAttributes.Public, typeof(int)); diff --git a/src/libraries/System.Reflection.Emit/tests/FieldBuilder/FieldBuilderSetConstant.cs b/src/libraries/System.Reflection.Emit/tests/FieldBuilder/FieldBuilderSetConstant.cs index 220eb255aca30..7d0bf768d0e56 100644 --- a/src/libraries/System.Reflection.Emit/tests/FieldBuilder/FieldBuilderSetConstant.cs +++ b/src/libraries/System.Reflection.Emit/tests/FieldBuilder/FieldBuilderSetConstant.cs @@ -258,7 +258,7 @@ public static IEnumerable SetConstant_Invalid_TestData() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(SetConstant_Invalid_TestData))] public void SetConstant_InvalidType_ThrowsArgumentException(FieldBuilder field, object defaultValue) { diff --git a/src/libraries/System.Reflection.Emit/tests/GenericTypeParameterBuilder/GenericTypeParameterBuilderSetInterfaceConstraints.cs b/src/libraries/System.Reflection.Emit/tests/GenericTypeParameterBuilder/GenericTypeParameterBuilderSetInterfaceConstraints.cs index d634a50348ec6..9cea7e3d0dd5f 100644 --- a/src/libraries/System.Reflection.Emit/tests/GenericTypeParameterBuilder/GenericTypeParameterBuilderSetInterfaceConstraints.cs +++ b/src/libraries/System.Reflection.Emit/tests/GenericTypeParameterBuilder/GenericTypeParameterBuilderSetInterfaceConstraints.cs @@ -9,7 +9,7 @@ namespace System.Reflection.Emit.Tests public class GenericTypeParameterBuilderSetInterfaceConstraints { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void SetInterfaceConstraints_OneCustomInterface() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); @@ -40,7 +40,7 @@ public void SetInterfaceConstraints_Null() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void SetInterfaceConstraints_MultipleCustomInterfaces() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderDefineGenericParameters.cs b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderDefineGenericParameters.cs index 2d6d8e68570c4..eda2bcaf3f025 100644 --- a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderDefineGenericParameters.cs +++ b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderDefineGenericParameters.cs @@ -55,7 +55,7 @@ public void DefineGenericParameter_MultipleParameters() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void DefineGenericParameters_SingleTypeParameter_SetImplementationFlagsCalled_ThrowsInvalidOperationException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.NotPublic); @@ -65,7 +65,7 @@ public void DefineGenericParameters_SingleTypeParameter_SetImplementationFlagsCa } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void DefineGenericParameters_TwoTypeParameters_SetImplementationFlagsCalled_ThrowsInvalidOperationException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.NotPublic); @@ -77,7 +77,7 @@ public void DefineGenericParameters_TwoTypeParameters_SetImplementationFlagsCall } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void DefineGenericParameters_SingleTypeParameter_AlreadyDefined_ThrowsInvalidOperationException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.NotPublic); @@ -88,7 +88,7 @@ public void DefineGenericParameters_SingleTypeParameter_AlreadyDefined_ThrowsInv } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void DefineGenericParameters_TwoTypeParameters_AlreadyDefined_ThrowsInvalidOperationException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.NotPublic); diff --git a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderEquals.cs b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderEquals.cs index 198d1df5e90ec..2429eb650ecb4 100644 --- a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderEquals.cs +++ b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderEquals.cs @@ -72,7 +72,7 @@ public static IEnumerable Equals_TestData() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(Equals_TestData))] public void Equals(MethodBuilder builder, object obj, bool expected) { diff --git a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderGetGenericArguments.cs b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderGetGenericArguments.cs index 884d7dc794c94..17b9297d3408d 100644 --- a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderGetGenericArguments.cs +++ b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderGetGenericArguments.cs @@ -10,7 +10,7 @@ namespace System.Reflection.Emit.Tests public class MethodBuilderGetGenericArguments { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void GetGenericArguments_NonGenericMethod_ReturnsEmptyArray() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Abstract); diff --git a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderGetILGenerator.cs b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderGetILGenerator.cs index 1988ff20a3e87..7e226a4a1557c 100644 --- a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderGetILGenerator.cs +++ b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderGetILGenerator.cs @@ -27,7 +27,7 @@ public void GetILGenerator_Int(int size) } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [InlineData(TypeAttributes.Public, MethodAttributes.Public | MethodAttributes.PinvokeImpl)] [InlineData(TypeAttributes.Abstract, MethodAttributes.PinvokeImpl)] [InlineData(TypeAttributes.Abstract, MethodAttributes.Abstract | MethodAttributes.PinvokeImpl)] diff --git a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderMakeGenericMethod.cs b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderMakeGenericMethod.cs index 27191950c56aa..5843f091b1cce 100644 --- a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderMakeGenericMethod.cs +++ b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderMakeGenericMethod.cs @@ -32,7 +32,7 @@ public void MakeGenericMethod(string[] names, Type[] typeArguments, Type returnT } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void TestNotThrowsExceptionOnNull() { Type returnType = typeof(void); @@ -46,7 +46,7 @@ public void TestNotThrowsExceptionOnNull() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void TestNotThrowsExceptionOnEmptyArray1() { Type returnType = typeof(void); @@ -61,7 +61,7 @@ public void TestNotThrowsExceptionOnEmptyArray1() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void TestNotThrowsExceptionOnEmptyArray2() { Type returnType = typeof(void); diff --git a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderReturnParameter.cs b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderReturnParameter.cs index 106328c8e0f22..a1c640106f1f6 100644 --- a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderReturnParameter.cs +++ b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderReturnParameter.cs @@ -48,7 +48,7 @@ public void ReturnParameter_TypeNotCreated_ThrowsInvalidOperationException() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void ReturnParameter_NoBody_ThrowsInvalidOperationException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Abstract); diff --git a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetParameters.cs b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetParameters.cs index 56dafcc54d08c..6438c39630714 100644 --- a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetParameters.cs +++ b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetParameters.cs @@ -18,7 +18,7 @@ public static IEnumerable SetParameters_TestData() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(SetParameters_TestData))] public void SetParameters(Type[] parameterTypes, string[] typeParamNames) { @@ -102,7 +102,7 @@ public void SetParameters_NoParameterTypes() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void SetParameters_NullParameter_ThrowsArgumentNullException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Abstract); diff --git a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetReturnType.cs b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetReturnType.cs index 95aa4e2b70155..3258f93fcfd51 100644 --- a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetReturnType.cs +++ b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetReturnType.cs @@ -133,7 +133,7 @@ public void SetReturnType_TypeCreated_Works() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void SetReturnType_NullReturnType_ReturnsVoid() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Abstract); diff --git a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetSignature.cs b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetSignature.cs index 310c9a46dd00c..deec0e814e277 100644 --- a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetSignature.cs +++ b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderSetSignature.cs @@ -192,7 +192,7 @@ public void SetSignature_NonGenericMethod() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void SetSignature_AllParametersNull() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Abstract); @@ -203,7 +203,7 @@ public void SetSignature_AllParametersNull() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void SetSignature_NullReturnType_CustomModifiersSetToWrongTypes() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Abstract); diff --git a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderToString.cs b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderToString.cs index 8b6ed2da178fe..ae97821a67db6 100644 --- a/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderToString.cs +++ b/src/libraries/System.Reflection.Emit/tests/MethodBuilder/MethodBuilderToString.cs @@ -9,7 +9,7 @@ namespace System.Reflection.Emit.Tests public class MethodBuilderToString { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void ToString_AllFieldsSet() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Abstract); @@ -26,7 +26,7 @@ public void ToString_AllFieldsSet() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void ToString_NameAndAttributeSet() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Abstract); @@ -36,7 +36,7 @@ public void ToString_NameAndAttributeSet() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void ToString_NameAttributeAndSignatureSetSet() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Abstract); @@ -47,7 +47,7 @@ public void ToString_NameAttributeAndSignatureSetSet() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void ToString_NonGenericMethod() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); @@ -63,7 +63,7 @@ public void ToString_NonGenericMethod() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void ToString_GenericMethod() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderDefineEnum.cs b/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderDefineEnum.cs index 4609ee9184884..920dc871b5867 100644 --- a/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderDefineEnum.cs +++ b/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderDefineEnum.cs @@ -30,7 +30,7 @@ public static IEnumerable DefineEnum_TestData() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(DefineEnum_TestData))] public void DefineEnum(string name, TypeAttributes visibility, Type underlyingType) { @@ -78,7 +78,7 @@ public void DefineEnum(string name, TypeAttributes visibility, Type underlyingTy } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void DefineEnum_DynamicUnderlyingType_Works() { ModuleBuilder module = Helpers.DynamicModule(); @@ -161,7 +161,7 @@ public void DefineEnum_VoidUnderlyingType_ThrowsArgumentException() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void DefineEnum_ByRefUnderlyingType_ThrowsCOMExceptionOnCreation() { ModuleBuilder module = Helpers.DynamicModule(); diff --git a/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderDefineType.cs b/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderDefineType.cs index cbcd89e583e4d..fe52f133e5b5c 100644 --- a/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderDefineType.cs +++ b/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderDefineType.cs @@ -33,7 +33,7 @@ public static IEnumerable TestData() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(TestData))] public void DefineType(string name, TypeAttributes attributes, Type parent, PackingSize packingSize, int typesize, Type[] implementedInterfaces) { diff --git a/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderGetArrayMethod.cs b/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderGetArrayMethod.cs index 33c55fa2230f5..4e7f8e5799cf6 100644 --- a/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderGetArrayMethod.cs +++ b/src/libraries/System.Reflection.Emit/tests/ModuleBuilder/ModuleBuilderGetArrayMethod.cs @@ -25,7 +25,7 @@ public static IEnumerable CallingConventions_TestData() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(CallingConventions_TestData))] public void GetArrayMethod_ValidArrayValues_VoidReturnType(CallingConventions callingConvention) { @@ -34,7 +34,7 @@ public void GetArrayMethod_ValidArrayValues_VoidReturnType(CallingConventions ca } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(CallingConventions_TestData))] public void GetArrayMethod_ValidArrayValues_ValueReturnType(CallingConventions callingConvention) { @@ -43,7 +43,7 @@ public void GetArrayMethod_ValidArrayValues_ValueReturnType(CallingConventions c } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(CallingConventions_TestData))] public void GetArrayMethod_ValidArrayValues_ReferenceReturnType(CallingConventions callingConvention) { @@ -52,7 +52,7 @@ public void GetArrayMethod_ValidArrayValues_ReferenceReturnType(CallingConventio } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(CallingConventions_TestData))] public void GetArrayMethod_ValidArrayValues_ValueParameterType(CallingConventions callingConvention) { @@ -63,7 +63,7 @@ public void GetArrayMethod_ValidArrayValues_ValueParameterType(CallingConvention } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(CallingConventions_TestData))] public void GetArrayMethod_ValidArrayValues_ReferenceParameterType(CallingConventions callingConvention) { @@ -74,7 +74,7 @@ public void GetArrayMethod_ValidArrayValues_ReferenceParameterType(CallingConven } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(CallingConventions_TestData))] public void GetArrayMethod_JaggedArray(CallingConventions callingConvention) { @@ -85,7 +85,7 @@ public void GetArrayMethod_JaggedArray(CallingConventions callingConvention) } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(CallingConventions_TestData))] public void GetArrayMethod_MultiDimensionalArray(CallingConventions callingConvention) { @@ -96,7 +96,7 @@ public void GetArrayMethod_MultiDimensionalArray(CallingConventions callingConve } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(CallingConventions_TestData))] public void GetArrayMethod_NullParameters(CallingConventions callingConvention) { @@ -105,7 +105,7 @@ public void GetArrayMethod_NullParameters(CallingConventions callingConvention) } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [InlineData(typeof(ModuleBuilderGetArrayMethod))] [InlineData(typeof(int))] [InlineData(typeof(Array))] @@ -117,7 +117,7 @@ public void GetArrayMethod_ArrayClassNotArray_ThrowsArgumentException(Type array } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void GetArrayMethod_InvalidArgument_ThrowsArgumentException() { ModuleBuilder module = Helpers.DynamicModule(); diff --git a/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderAddOtherMethod.cs b/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderAddOtherMethod.cs index 144bac8775a65..dc3b4cdecfba8 100644 --- a/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderAddOtherMethod.cs +++ b/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderAddOtherMethod.cs @@ -9,7 +9,7 @@ namespace System.Reflection.Emit.Tests public class PropertyBuilderTest2 { [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [InlineData(MethodAttributes.Public, CallingConventions.HasThis, BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance)] [InlineData(MethodAttributes.Private, CallingConventions.HasThis, BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance)] [InlineData(MethodAttributes.Public | MethodAttributes.Static, CallingConventions.Any, BindingFlags.Public | BindingFlags.Static | BindingFlags.NonPublic | BindingFlags.Instance)] diff --git a/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetConstant.cs b/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetConstant.cs index f95f33057ad17..7df6848dc130e 100644 --- a/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetConstant.cs +++ b/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetConstant.cs @@ -42,7 +42,7 @@ public static IEnumerable SetConstant_TestData() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(SetConstant_TestData))] public void SetConstant(Type returnType, object defaultValue) { @@ -84,7 +84,7 @@ public void SetConstant_TypeAlreadyCreated_ThrowsInvalidOperationException() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void SetConstant_TypeNotConstant_ThrowsArgumentException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Class | TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetCustomAttribute.cs b/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetCustomAttribute.cs index 86622e69fd540..6a3aea0752425 100644 --- a/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetCustomAttribute.cs +++ b/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetCustomAttribute.cs @@ -53,7 +53,7 @@ public void SetCustomAttribute_CustomAttributeBuilder_NullBuilder_ThrowsArgument } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void SetCustomAttribute_CustomAttributeBuilder_TypeNotCreated_ThrowsInvalidOperationException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Class | TypeAttributes.Public); @@ -117,7 +117,7 @@ public void SetCustomAttribute_ConstructorInfo_ByteArray_NullConstructorInfo_Thr [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void SetCustomAttribute_ConstructorInfo_ByteArray_TypeAlreadyCreated_ThrowsInvalidOperationException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Class | TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetSetMethod.cs b/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetSetMethod.cs index 8c50bce0e1e14..35b792f2fb10e 100644 --- a/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetSetMethod.cs +++ b/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetSetMethod.cs @@ -35,7 +35,7 @@ public void SetSetMethod_NullMethodBuilder_ThrowsArgumentNullException() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void TestThrowsExceptionForCreateTypeCalled() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Class | TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetValue.cs b/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetValue.cs index 2db407e2f61d9..a1cb5738ef4b9 100644 --- a/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetValue.cs +++ b/src/libraries/System.Reflection.Emit/tests/PropertyBuilder/PropertyBuilderSetValue.cs @@ -9,7 +9,7 @@ namespace System.Reflection.Emit.Tests public class PropertyBuilderTest16 { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void SetValue_ThrowsNotSupportedException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Class | TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderAddInterfaceImplementaion.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderAddInterfaceImplementaion.cs index e755d8f705baa..6c1ca4d3fac1b 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderAddInterfaceImplementaion.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderAddInterfaceImplementaion.cs @@ -93,7 +93,7 @@ public static IEnumerable NonInterfaceTypes_TestData() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(NonInterfaceTypes_TestData))] public void AddInterfaceImplementation_TypeNotInterface_ThrowsTypeLoadExceptionOnCreation(Type interfaceType) { @@ -115,7 +115,7 @@ public void AddInterfaceImplementation_OpenGenericType_ThrowsBadImageFormatExcep } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void AddInterfaceImplementation_TypeDoesntImplementInterface_ThrowsTypeLoadExceptionOnCreation() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderAssemblyQualifiedName.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderAssemblyQualifiedName.cs index e16521cba5711..6d6f22c12278f 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderAssemblyQualifiedName.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderAssemblyQualifiedName.cs @@ -9,7 +9,7 @@ namespace System.Reflection.Emit.Tests public class TypeBuilderAssemblyQualifiedName { [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [InlineData("TypeName", "ad df df")] [InlineData("TypeName", "assemblyname")] [InlineData("type name ", "assembly name ")] diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderCreateType.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderCreateType.cs index a4ff0ab56b041..c07fe8f86a523 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderCreateType.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderCreateType.cs @@ -31,7 +31,7 @@ public void CreateType(TypeAttributes attributes) } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [InlineData(TypeAttributes.ClassSemanticsMask)] [InlineData(TypeAttributes.HasSecurity)] [InlineData(TypeAttributes.LayoutMask)] diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderCreateTypeInfo.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderCreateTypeInfo.cs index bbba624f24665..d114ef86d88fa 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderCreateTypeInfo.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderCreateTypeInfo.cs @@ -51,7 +51,7 @@ public void CreateType_GenericType() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [InlineData(TypeAttributes.ClassSemanticsMask, typeof(InvalidOperationException))] [InlineData(TypeAttributes.HasSecurity, typeof(ArgumentException))] [InlineData(TypeAttributes.LayoutMask, typeof(ArgumentException))] diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineConstructor.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineConstructor.cs index c5dbda45d8ae9..7de9d167ecb11 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineConstructor.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineConstructor.cs @@ -35,7 +35,7 @@ public static IEnumerable TestData() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(TestData))] public void DefineConstructor(MethodAttributes attributes, Type[] parameterTypes, CallingConventions callingConvention) { @@ -65,7 +65,7 @@ public void DefineConstructor(MethodAttributes attributes, Type[] parameterTypes } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(TestData))] public void DefineConstructor_NullRequiredAndOptionalCustomModifiers(MethodAttributes attributes, Type[] parameterTypes, CallingConventions callingConvention) { diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineDefaultConstructor.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineDefaultConstructor.cs index 4616c0b940d2b..bb4258c0fcb47 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineDefaultConstructor.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineDefaultConstructor.cs @@ -10,7 +10,7 @@ namespace System.Reflection.Emit.Tests public class TypeBuilderDefineDefaultConstructor { [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [InlineData(MethodAttributes.Public)] [InlineData(MethodAttributes.Static)] [InlineData(MethodAttributes.Family)] diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineEvent.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineEvent.cs index fbdf79b530758..39d44aa9da75e 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineEvent.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineEvent.cs @@ -27,7 +27,7 @@ public static IEnumerable TestData() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(TestData))] public void DefineEvent(string name, EventAttributes attributes, Type eventType, string expectedName, EventAttributes expectedAttributes) { diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineField.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineField.cs index f6ee4550f421e..3a36298510ca2 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineField.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineField.cs @@ -33,7 +33,7 @@ public static IEnumerable TestData() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(TestData))] public void DefineField(string name, Type fieldType, FieldAttributes attributes, FieldAttributes expectedAttributes) { @@ -113,7 +113,7 @@ public void DefineField_ByRefFieldType_ThrowsCOMExceptionOnCreation() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [InlineData((FieldAttributes)(-1), (FieldAttributes)(-38145))] [InlineData(FieldAttributes.FieldAccessMask, FieldAttributes.FieldAccessMask)] [InlineData((FieldAttributes)int.MaxValue, (FieldAttributes)2147445503)] @@ -127,7 +127,7 @@ public void DefineField_InvalidFieldAttributes_ThrowsTypeLoadExceptionOnCreation } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void DefineField_DynamicFieldTypeNotCreated_ThrowsTypeLoadException() { ModuleBuilder module = Helpers.DynamicModule(); diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineGenericParameters.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineGenericParameters.cs index 616075349ca8c..40e1efc2f8b86 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineGenericParameters.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineGenericParameters.cs @@ -73,7 +73,7 @@ public void DefineGenericParameters_NullName_ThrowsArgumentNullException() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void DefineGenericParameters_AlreadyDefinedGenericParameters_ThrowsInvalidOperationException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineMethod.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineMethod.cs index 5cf5f5d2fc9fa..f7fe0c1d4510f 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineMethod.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineMethod.cs @@ -63,7 +63,7 @@ public static IEnumerable TestData() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(TestData))] public void DefineMethod(string name, MethodAttributes attributes, CallingConventions callingConvention, Type returnType, Type[] parameterTypes) { diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineMethodOverride.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineMethodOverride.cs index ab100b4d76d36..fa33096e3636d 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineMethodOverride.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineMethodOverride.cs @@ -168,7 +168,7 @@ public void DefineMethodOverride_MethodNotVirtual_ThrowsTypeLoadExceptionOnCreat } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void DefineMethodOverride_NothingToOverride_ThrowsTypeLoadExceptionOnCreation() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); @@ -181,7 +181,7 @@ public void DefineMethodOverride_NothingToOverride_ThrowsTypeLoadExceptionOnCrea } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [InlineData(typeof(GenericInterface<>), nameof(GenericInterface.Method))] [InlineData(typeof(DefineMethodOverrideInterface), nameof(DefineMethodOverrideInterface.M))] public void DefineMethodOverride_ClassDoesNotImplementOrInheritMethod_ThrowsTypeLoadExceptionOnCreation(Type methodType, string methodName) @@ -198,7 +198,7 @@ public void DefineMethodOverride_ClassDoesNotImplementOrInheritMethod_ThrowsType } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void DefineMethodOverride_BodyAndDeclarationTheSame_ThrowsTypeLoadExceptionOnCreation() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); @@ -213,7 +213,7 @@ public void DefineMethodOverride_BodyAndDeclarationTheSame_ThrowsTypeLoadExcepti } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void DefineMethodOverride_CalledTwiceWithDifferentBodies_ThrowsTypeLoadExceptionOnCreation() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); @@ -236,7 +236,7 @@ public void DefineMethodOverride_CalledTwiceWithDifferentBodies_ThrowsTypeLoadEx } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [InlineData(typeof(int), new Type[0])] [InlineData(typeof(int), new Type[] { typeof(int), typeof(int) })] [InlineData(typeof(int), new Type[] { typeof(string), typeof(string) })] diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineNestedType.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineNestedType.cs index 234bb96286063..f17f3a7c022f1 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineNestedType.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineNestedType.cs @@ -55,7 +55,7 @@ public static IEnumerable TestData() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(TestData))] public void DefineNestedType(string name, TypeAttributes attributes, Type parent, PackingSize packingSize, int typesize, Type[] implementedInterfaces) { @@ -145,7 +145,7 @@ public void DefineNestedType_EmptyName_ThrowsArgumentException(string fullname) } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void DefineNestedType_LongName_ThrowsArgumentException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.NotPublic); @@ -153,7 +153,7 @@ public void DefineNestedType_LongName_ThrowsArgumentException() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [InlineData(TypeAttributes.Public, "attr")] [InlineData(TypeAttributes.NotPublic, "attr")] [InlineData(TypeAttributes.Interface, "attr")] @@ -169,7 +169,7 @@ public void DefineNestedType_InvalidAttributes_ThrowsArgumentException(TypeAttri } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void DefineNestedType_InvalidParent_ThrowsArgumentException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); @@ -230,7 +230,7 @@ public static IEnumerable InvalidInterfaceType_TestData() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(InvalidInterfaceType_TestData))] public void DefineNestedType_InvalidInterfaceType_ThrowsTypeLoadExceptionOnCreation(Type interfaceType) { diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineProperty.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineProperty.cs index 350030c798479..3be18d379154a 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineProperty.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineProperty.cs @@ -30,7 +30,7 @@ public static IEnumerable TestData() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] [MemberData(nameof(TestData))] public void DefineProperty(string name, PropertyAttributes attributes, Type returnType, Type[] parameterTypes, string expectedName, PropertyAttributes expectedPropertyAttributes) { @@ -138,7 +138,7 @@ public void DefineProperty_TypeCreated_ThrowsInvalidOperationException() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void DefineProperty_OpenGenericReturnType_ThrowsBadImageFormatExceptionGettingCreatedPropertyType() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); @@ -150,7 +150,7 @@ public void DefineProperty_OpenGenericReturnType_ThrowsBadImageFormatExceptionGe } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void DefineProperty_NullParameterType_ThrowsArgumentNullException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); @@ -158,7 +158,7 @@ public void DefineProperty_NullParameterType_ThrowsArgumentNullException() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void DefineProperty_OpenGenericParameterType_ThrowsBadImageFormatExceptionGettingCreatedPropertyType() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); @@ -170,7 +170,7 @@ public void DefineProperty_OpenGenericParameterType_ThrowsBadImageFormatExceptio } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void DefineProperty_DynamicPropertyTypeNotCreated_ThrowsTypeLoadException() { ModuleBuilder module = Helpers.DynamicModule(); @@ -187,7 +187,7 @@ public void DefineProperty_DynamicPropertyTypeNotCreated_ThrowsTypeLoadException } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void DefineProperty_DynamicParameterTypeNotCreated_ThrowsTypeLoadException() { ModuleBuilder module = Helpers.DynamicModule(); @@ -204,7 +204,7 @@ public void DefineProperty_DynamicParameterTypeNotCreated_ThrowsTypeLoadExceptio } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void DefineProperty_CalledMultipleTimes_Works() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Class | TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineTypeInitializer.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineTypeInitializer.cs index d720151e0d856..37e3b4f53a65e 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineTypeInitializer.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineTypeInitializer.cs @@ -9,7 +9,7 @@ namespace System.Reflection.Emit.Tests public class MethodBuilderDefineTypeInitializer { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void DefineTypeInitializer() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGUID.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGUID.cs index 0579c5b5760a8..0215401abac11 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGUID.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGUID.cs @@ -9,7 +9,7 @@ namespace System.Reflection.Emit.Tests public class TypeBuilderGUID { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void Guid_TypeCreated_NotEmpty() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.NotPublic); diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGetConstructor.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGetConstructor.cs index 2086341cd697e..e9ac5aaa2c476 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGetConstructor.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGetConstructor.cs @@ -33,14 +33,14 @@ public void GetConstructor() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void GetConstructor_TypeNotTypeBuilder_ThrowsArgumentException() { AssertExtensions.Throws(null, () => TypeBuilder.GetConstructor(typeof(int), typeof(int).GetConstructor(new Type[0]))); } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void GetConstructor_DeclaringTypeOfConstructorNotGenericTypeDefinitionOfType_ThrowsArgumentException() { ModuleBuilder module = Helpers.DynamicModule(); @@ -59,7 +59,7 @@ public void GetConstructor_DeclaringTypeOfConstructorNotGenericTypeDefinitionOfT } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void GetConstructor_TypeNotGeneric_ThrowsArgumentException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Class | TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGetField.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGetField.cs index 61369c6749d2b..f3edbe46fbfa7 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGetField.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGetField.cs @@ -33,14 +33,14 @@ public void GetField() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void GetField_TypeNotTypeBuilder_ThrowsArgumentException() { AssertExtensions.Throws(null, () => TypeBuilder.GetField(typeof(int), typeof(int).GetField("MaxValue"))); } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void GetField_DeclaringTypeOfFieldNotGenericTypeDefinitionOfType_ThrowsArgumentException() { ModuleBuilder module = Helpers.DynamicModule(); @@ -58,7 +58,7 @@ public void GetField_DeclaringTypeOfFieldNotGenericTypeDefinitionOfType_ThrowsAr } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void GetField_TypeNotGeneric_ThrowsArgumentException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Class | TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGetMethod.cs b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGetMethod.cs index 02ce79aad0b8c..9ab5a1587db67 100644 --- a/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGetMethod.cs +++ b/src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderGetMethod.cs @@ -42,14 +42,14 @@ public void GetMethod_ConstructedTypeMethod() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void GetMethod_TypeNotTypeBuilder_ThrowsArgumentException() { AssertExtensions.Throws(null, () => TypeBuilder.GetMethod(typeof(int), typeof(int).GetMethod("Parse", new Type[] { typeof(string) }))); } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void GetMethod_MethodDefinitionNotInTypeGenericDefinition_ThrowsArgumentException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Class | TypeAttributes.Public); @@ -65,7 +65,7 @@ public void GetMethod_MethodDefinitionNotInTypeGenericDefinition_ThrowsArgumentE } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void GetMethod_MethodNotGenericTypeDefinition_ThrowsArgumentException() { ModuleBuilder module = Helpers.DynamicModule(); @@ -88,7 +88,7 @@ public void GetMethod_MethodNotGenericTypeDefinition_ThrowsArgumentException() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2389", TestRuntimes.Mono)] public void GetMethod_TypeIsNotGeneric_ThrowsArgumentException() { TypeBuilder type = Helpers.DynamicType(TypeAttributes.Class | TypeAttributes.Public); diff --git a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/CustomAttributes/DllImportTests.cs b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/CustomAttributes/DllImportTests.cs index 8d13e17532c11..3bbd0f63d02ec 100644 --- a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/CustomAttributes/DllImportTests.cs +++ b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/CustomAttributes/DllImportTests.cs @@ -14,7 +14,7 @@ namespace System.Reflection.Tests { public static partial class CustomAttributeTests { - [ActiveIssue("https://github.com/mono/mono/issues/15340", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15340", TestRuntimes.Mono)] [Fact] public static void TestDllImportPseudoCustomAttribute() { @@ -48,7 +48,7 @@ private static void AssertEqual(DllImportAttribute d1, DllImportAttribute d2) } [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/15340", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15340", TestRuntimes.Mono)] [MemberData(nameof(MarshalAsTheoryData))] public static void TestMarshalAsPseudoCustomAttribute(string fieldName, MarshalAsAttribute expected) { diff --git a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Parameter/ParameterTests.cs b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Parameter/ParameterTests.cs index 88920d44a563e..69a517e21d8c9 100644 --- a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Parameter/ParameterTests.cs +++ b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Parameter/ParameterTests.cs @@ -68,7 +68,7 @@ public static void TestRawDefaultValue6() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15340", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15340", TestRuntimes.Mono)] public static void TestPseudoCustomAttributes() { MethodInfo m = typeof(ParametersWithPseudoCustomtAttributes).Project().GetTypeInfo().GetDeclaredMethod("Foo"); diff --git a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeInvariants.cs b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeInvariants.cs index 315b3e19c7c94..dd31553b10da1 100644 --- a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeInvariants.cs +++ b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeInvariants.cs @@ -14,7 +14,7 @@ namespace System.Reflection.Tests public static class TypeInvariants { [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15344", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15344", TestRuntimes.Mono)] public static void TestInvariantCode() { // These run some *runtime*-implemented Type objects through our invariant battery. diff --git a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeTests.cs b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeTests.cs index 3a5fbdc07cbf9..b9c63217c9de1 100644 --- a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeTests.cs +++ b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeTests.cs @@ -481,7 +481,7 @@ public static void TestComImportPseudoCustomAttribute() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15340", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15340", TestRuntimes.Mono)] public static void TestExplicitOffsetPseudoCustomAttribute() { Type t = typeof(ExplicitFieldOffsets).Project(); diff --git a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/TypeInfoFromProjectN/TypeInfo_ImplementedInterfacesTests.cs b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/TypeInfoFromProjectN/TypeInfo_ImplementedInterfacesTests.cs index 4c3820e769d01..0cff334e27a4f 100644 --- a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/TypeInfoFromProjectN/TypeInfo_ImplementedInterfacesTests.cs +++ b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/TypeInfoFromProjectN/TypeInfo_ImplementedInterfacesTests.cs @@ -32,7 +32,7 @@ public static void TestInterFaces3() // Verify implemented interfaces [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/18294", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/18294", TestRuntimes.Mono)] public static void TestInterFaces4() { VerifyInterfaces(typeof(D1).Project(), new Type[] { typeof(ImI1).Project(), typeof(I0).Project(), typeof(I21).Project() }); @@ -40,7 +40,7 @@ public static void TestInterFaces4() // Verify implemented interfaces [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/18294", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/18294", TestRuntimes.Mono)] public static void TestInterFaces5() { VerifyInterfaces(typeof(D2<>).Project(), new Type[] { typeof(ImI1).Project(), typeof(I0).Project(), typeof(I21).Project() }); @@ -48,7 +48,7 @@ public static void TestInterFaces5() // Verify implemented interfaces [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/18294", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/18294", TestRuntimes.Mono)] public static void TestInterFaces6() { VerifyInterfaces(typeof(D2).Project(), new Type[] { typeof(ImI1).Project(), typeof(I0).Project(), typeof(I21).Project() }); diff --git a/src/libraries/System.Reflection.TypeExtensions/tests/ConstructorInfo/ConstructorInfoInvokeArrayTests.cs b/src/libraries/System.Reflection.TypeExtensions/tests/ConstructorInfo/ConstructorInfoInvokeArrayTests.cs index f66066e4ecaa8..024e912a41dcd 100644 --- a/src/libraries/System.Reflection.TypeExtensions/tests/ConstructorInfo/ConstructorInfoInvokeArrayTests.cs +++ b/src/libraries/System.Reflection.TypeExtensions/tests/ConstructorInfo/ConstructorInfoInvokeArrayTests.cs @@ -33,7 +33,7 @@ public void Invoke_SZArrayConstructor() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15316", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15316", TestRuntimes.Mono)] public void Invoke_1DArrayConstructor() { Type type = Type.GetType("System.Char[*]"); @@ -221,7 +221,7 @@ public void Invoke_2DArrayConstructor() } } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15318", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15318", TestRuntimes.Mono)] public void Invoke_LargeDimensionalArrayConstructor() { Type type = Type.GetType("System.Type[,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,]"); diff --git a/src/libraries/System.Reflection.TypeExtensions/tests/ConstructorInfo/ConstructorInfoTests.cs b/src/libraries/System.Reflection.TypeExtensions/tests/ConstructorInfo/ConstructorInfoTests.cs index 82eb23ef8ce23..37a6962b1d56c 100644 --- a/src/libraries/System.Reflection.TypeExtensions/tests/ConstructorInfo/ConstructorInfoTests.cs +++ b/src/libraries/System.Reflection.TypeExtensions/tests/ConstructorInfo/ConstructorInfoTests.cs @@ -64,7 +64,7 @@ public static IEnumerable Invoke_Invalid_TestData() } [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/15317", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15317", TestRuntimes.Mono)] [MemberData(nameof(Invoke_Invalid_TestData))] public void Invoke_Invalid(Type constructorParent, Type[] constructorTypeParameters, object[] parameters, Type exceptionType) { diff --git a/src/libraries/System.Reflection.TypeExtensions/tests/MetadataTokenTests.cs b/src/libraries/System.Reflection.TypeExtensions/tests/MetadataTokenTests.cs index f293eb5784bf0..12c7fbf904889 100644 --- a/src/libraries/System.Reflection.TypeExtensions/tests/MetadataTokenTests.cs +++ b/src/libraries/System.Reflection.TypeExtensions/tests/MetadataTokenTests.cs @@ -37,7 +37,7 @@ public event EventHandler Event { add { } remove { } } new object[] { typeof(Test<>).GetGenericArguments()[0].GetTypeInfo(), 0x2A } }; - [ActiveIssue("https://github.com/mono/mono/issues/15194", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15194", TestRuntimes.Mono)] [ConditionalTheory(nameof(GetMetadataTokenSupported))] [MemberData(nameof(MembersWithExpectedTableIndex))] public void SuccessImpliesNonNilWithCorrectTable(MemberInfo member, int expectedTableIndex) diff --git a/src/libraries/System.Reflection.TypeExtensions/tests/PropertyInfoTests.cs b/src/libraries/System.Reflection.TypeExtensions/tests/PropertyInfoTests.cs index d3dc30d66dca8..22af271aeb215 100644 --- a/src/libraries/System.Reflection.TypeExtensions/tests/PropertyInfoTests.cs +++ b/src/libraries/System.Reflection.TypeExtensions/tests/PropertyInfoTests.cs @@ -33,7 +33,7 @@ public void SetValue_CantWrite_ThrowsArgumentException() } [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/15319", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15319", TestRuntimes.Mono)] [InlineData(typeof(PI_BaseClass), nameof(PI_BaseClass.PublicGetPublicSetProperty), true, false, true, false)] [InlineData(typeof(PI_BaseClass), nameof(PI_BaseClass.PublicGetProperty1), true, false, false, false)] [InlineData(typeof(PI_BaseClass), nameof(PI_BaseClass.PublicSetProperty), false, false, true, false)] diff --git a/src/libraries/System.Reflection.TypeExtensions/tests/TypeTests.cs b/src/libraries/System.Reflection.TypeExtensions/tests/TypeTests.cs index bd0bd7b3668d8..246b5bf6c9656 100644 --- a/src/libraries/System.Reflection.TypeExtensions/tests/TypeTests.cs +++ b/src/libraries/System.Reflection.TypeExtensions/tests/TypeTests.cs @@ -329,7 +329,7 @@ public static IEnumerable GetMethods_TestData() } [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/15320", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15320", TestRuntimes.Mono)] [MemberData(nameof(GetMethods_TestData))] public void GetMethods(Type type, BindingFlags bindingAttributes, string[] expectedNames) { diff --git a/src/libraries/System.Reflection/tests/AssemblyTests.cs b/src/libraries/System.Reflection/tests/AssemblyTests.cs index 4b072cc84ed2e..bf54c57924410 100644 --- a/src/libraries/System.Reflection/tests/AssemblyTests.cs +++ b/src/libraries/System.Reflection/tests/AssemblyTests.cs @@ -319,7 +319,7 @@ public void LoadFile_NullPath_ThrowsArgumentNullException() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/31650", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31650", TestRuntimes.Mono)] public void LoadFile_NoSuchPath_ThrowsFileNotFoundException() { string rootedPath = Path.GetFullPath(Guid.NewGuid().ToString("N")); @@ -348,7 +348,7 @@ public void LoadFile_ValidPEBadIL_ThrowsBadImageFormatExceptionWithPath() } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/31649", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31649", TestRuntimes.Mono)] [InlineData(0)] [InlineData(5)] [InlineData(50)] diff --git a/src/libraries/System.Reflection/tests/ConstructorInfoTests.cs b/src/libraries/System.Reflection/tests/ConstructorInfoTests.cs index 407bc54f5eb5e..0907bfaff1885 100644 --- a/src/libraries/System.Reflection/tests/ConstructorInfoTests.cs +++ b/src/libraries/System.Reflection/tests/ConstructorInfoTests.cs @@ -70,7 +70,7 @@ public void Invoke_StaticConstructor_NullObject_NullParameters() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15024", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15024", TestRuntimes.Mono)] public void Invoke_StaticConstructor_ThrowsMemberAccessException() { ConstructorInfo[] constructors = GetConstructors(typeof(ClassWithStaticConstructor)); @@ -157,7 +157,7 @@ public void Invoke_ExistingInstance() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15026", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15026", TestRuntimes.Mono)] public void Invoke_AbstractClass_ThrowsMemberAccessException() { ConstructorInfo[] constructors = GetConstructors(typeof(ConstructorInfoAbstractBase)); diff --git a/src/libraries/System.Reflection/tests/CoreCLR/AssemblyTests.cs b/src/libraries/System.Reflection/tests/CoreCLR/AssemblyTests.cs index 9f3e75a185dc5..0c4a1174891ce 100644 --- a/src/libraries/System.Reflection/tests/CoreCLR/AssemblyTests.cs +++ b/src/libraries/System.Reflection/tests/CoreCLR/AssemblyTests.cs @@ -24,7 +24,7 @@ public void CurrentLocation_HasLocaton() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/22110", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/22110", TestRuntimes.Mono)] public void LoadFromStream_Location_IsEmpty() { Assembly assembly = new TestStreamLoadContext().LoadFromAssemblyName(new AssemblyName("TinyAssembly")); diff --git a/src/libraries/System.Reflection/tests/MemberInfoTests.cs b/src/libraries/System.Reflection/tests/MemberInfoTests.cs index 4d2da9126ee6b..bf9485853a402 100644 --- a/src/libraries/System.Reflection/tests/MemberInfoTests.cs +++ b/src/libraries/System.Reflection/tests/MemberInfoTests.cs @@ -341,7 +341,7 @@ public static void HasSameMetadataDefinitionAs_NamedAndGenericTypes() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15069", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15069", TestRuntimes.Mono)] public static void HasSameMetadataDefinitionAs_GenericTypeParameters() { Type theT = typeof(GenericTestClass<>).GetTypeInfo().GenericTypeParameters[0]; @@ -463,7 +463,7 @@ private static IEnumerable NegativeTypeDataRaw } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/31648", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31648", TestRuntimes.Mono)] public static void HasSameMetadataDefinitionAs__CornerCase_HasElementTypes() { // HasSameMetadataDefinitionAs on an array/byref/pointer type is uninteresting (they'll never be an actual member of a type) diff --git a/src/libraries/System.Reflection/tests/MethodInfoTests.cs b/src/libraries/System.Reflection/tests/MethodInfoTests.cs index fe6aaafd23ee6..7dfde375b9f08 100644 --- a/src/libraries/System.Reflection/tests/MethodInfoTests.cs +++ b/src/libraries/System.Reflection/tests/MethodInfoTests.cs @@ -328,7 +328,7 @@ public void Invoke_ParameterSpecification_ArrayOfMissing() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15025", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15025", TestRuntimes.Mono)] public static void Invoke_OptionalParameterUnassingableFromMissing_WithMissingValue_ThrowsArgumentException() { AssertExtensions.Throws(null, () => GetMethod(typeof(MethodInfoDefaultParameters), "OptionalStringParameter").Invoke(new MethodInfoDefaultParameters(), new object[] { Type.Missing })); diff --git a/src/libraries/System.Reflection/tests/ParameterInfoTests.cs b/src/libraries/System.Reflection/tests/ParameterInfoTests.cs index 3c9a84216be7f..441e93ddc9d7b 100644 --- a/src/libraries/System.Reflection/tests/ParameterInfoTests.cs +++ b/src/libraries/System.Reflection/tests/ParameterInfoTests.cs @@ -109,7 +109,7 @@ public void RawDefaultValue_Enum() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15037", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15037", TestRuntimes.Mono)] public void RawDefaultValueFromAttribute() { ParameterInfo p = GetParameterInfo(typeof(ParameterInfoMetadata), "Foo2", 0); diff --git a/src/libraries/System.Reflection/tests/PropertyInfoTests.cs b/src/libraries/System.Reflection/tests/PropertyInfoTests.cs index 2f5544b4efd30..e6c18222ec115 100644 --- a/src/libraries/System.Reflection/tests/PropertyInfoTests.cs +++ b/src/libraries/System.Reflection/tests/PropertyInfoTests.cs @@ -82,7 +82,7 @@ public static IEnumerable GetValue_Invalid_TestData() } [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/15027", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15027", TestRuntimes.Mono)] [MemberData(nameof(GetValue_Invalid_TestData))] public void GetValue_Invalid(Type type, string name, object obj, object[] index, Type exceptionType) { diff --git a/src/libraries/System.Reflection/tests/TypeInfoTests.cs b/src/libraries/System.Reflection/tests/TypeInfoTests.cs index 3e85282c1323d..9d6d9fdbb8890 100644 --- a/src/libraries/System.Reflection/tests/TypeInfoTests.cs +++ b/src/libraries/System.Reflection/tests/TypeInfoTests.cs @@ -471,7 +471,7 @@ public static void IsEnumDefined(object value, bool expected) } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15028", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15028", TestRuntimes.Mono)] public void IsEnumDefined_Invalid() { AssertExtensions.Throws("", () => typeof(NonGenericClassWithNoInterfaces).GetTypeInfo().IsEnumDefined(10)); @@ -710,7 +710,7 @@ public void GetConstructor(Type[] types, int? expected) } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15029", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15029", TestRuntimes.Mono)] public static void FindMembers() { MemberInfo[] members = typeof(MembersClass).GetTypeInfo().FindMembers(MemberTypes.All, BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance, (MemberInfo memberInfo, object c) => true, "notused"); @@ -794,7 +794,7 @@ public void GetProperty() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15029", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15029", TestRuntimes.Mono)] public void GetMethod() { MethodInfo[] methods = typeof(MembersClass).GetTypeInfo().GetMethods(); @@ -813,7 +813,7 @@ public void GetMethod_Invalid() } [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/15029", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15029", TestRuntimes.Mono)] [InlineData(BindingFlags.Default, 9)] [InlineData(BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance, 16)] public void GetMethods(BindingFlags bindingAttributes, int length) @@ -880,7 +880,7 @@ public void GetMember(string name, BindingFlags bindingAttributes, int length) } [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/15029", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15029", TestRuntimes.Mono)] [InlineData(BindingFlags.Default, 15)] [InlineData(BindingFlags.NonPublic | BindingFlags.Instance, 13)] [InlineData(BindingFlags.Public | BindingFlags.Instance, 15)] diff --git a/src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs b/src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs index 44e2ae70b16f5..f7e2bb1cc1a00 100644 --- a/src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs +++ b/src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs @@ -167,7 +167,7 @@ public void FirstChanceException_Add_Remove() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16246", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16246", TestRuntimes.Mono)] public void FirstChanceException_Called() { RemoteExecutor.Invoke(() => { @@ -607,7 +607,7 @@ public void AssemblyResolve_RequestingAssembly() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16246", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16246", TestRuntimes.Mono)] public void AssemblyResolve_IsNotCalledForCoreLibResources() { RemoteExecutor.Invoke(() => @@ -670,7 +670,7 @@ public void TypeResolve() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16246", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16246", TestRuntimes.Mono)] public void ResourceResolve() { RemoteExecutor.Invoke(() => { @@ -910,7 +910,7 @@ public static IEnumerable TestingCreateInstanceObjectHandleFullSignatu } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/16246", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16246", TestRuntimes.Mono)] public void AssemblyResolve_FirstChanceException() { RemoteExecutor.Invoke(() => { diff --git a/src/libraries/System.Runtime.Extensions/tests/System/Environment.StackTrace.cs b/src/libraries/System.Runtime.Extensions/tests/System/Environment.StackTrace.cs index 85d63c32b879f..15f2b5b3ef1d8 100644 --- a/src/libraries/System.Runtime.Extensions/tests/System/Environment.StackTrace.cs +++ b/src/libraries/System.Runtime.Extensions/tests/System/Environment.StackTrace.cs @@ -16,7 +16,7 @@ public class EnvironmentStackTrace static string s_stackTrace; [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15315", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15315", TestRuntimes.Mono)] public void StackTraceTest() { //arrange diff --git a/src/libraries/System.Runtime.Extensions/tests/System/Runtime/ProfileOptimization.cs b/src/libraries/System.Runtime.Extensions/tests/System/Runtime/ProfileOptimization.cs index 9c39e28e2e0bd..eccec2be5a56f 100644 --- a/src/libraries/System.Runtime.Extensions/tests/System/Runtime/ProfileOptimization.cs +++ b/src/libraries/System.Runtime.Extensions/tests/System/Runtime/ProfileOptimization.cs @@ -12,7 +12,7 @@ namespace System.Runtime.Tests public class ProfileOptimizationTest : FileCleanupTestBase { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/31853", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31853", TestRuntimes.Mono)] public void ProfileOptimization_CheckFileExists() { string profileFile = GetTestFileName(); diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/DestroyStructureTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/DestroyStructureTests.cs index 7d301f1bf8dc5..c0e26a720ad59 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/DestroyStructureTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/DestroyStructureTests.cs @@ -92,7 +92,7 @@ public static IEnumerable DestroyStructure_InvalidType_TestData() } [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/15087", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15087", TestRuntimes.Mono)] [MemberData(nameof(DestroyStructure_InvalidType_TestData))] public void DestroyStructure_NonRuntimeType_ThrowsArgumentException(Type invalidType) { diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionForHRTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionForHRTests.cs index 19bc64f11ce30..985cc09f7905c 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionForHRTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetExceptionForHRTests.cs @@ -10,7 +10,7 @@ namespace System.Runtime.InteropServices.Tests public class GetExceptionForHRTests { [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/15093", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15093", TestRuntimes.Mono)] [InlineData(unchecked((int)0x80020006))] [InlineData(unchecked((int)0x80020101))] public void GetExceptionForHR_NoErrorInfo_ReturnsValidException(int errorCode) @@ -36,7 +36,7 @@ public static IEnumerable GetExceptionForHR_ErrorInfo_TestData() } [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/15093", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15093", TestRuntimes.Mono)] [MemberData(nameof(GetExceptionForHR_ErrorInfo_TestData))] public void GetExceptionForHR_ErrorInfo_ReturnsValidException(int errorCode, IntPtr errorInfo) { diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetFunctionPointerForDelegateTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetFunctionPointerForDelegateTests.cs index cecc0b0bb31c1..a1657dffbdce1 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetFunctionPointerForDelegateTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/GetFunctionPointerForDelegateTests.cs @@ -81,7 +81,7 @@ public void GetFunctionPointerForDelegate_ObjectNotDelegate_ThrowsInvalidCastExc } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15097", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15097", TestRuntimes.Mono)] public void GetFunctionPointer_GenericDelegate_ThrowsArgumentException() { MethodInfo targetMethod = typeof(GetFunctionPointerForDelegateTests).GetMethod(nameof(Method), BindingFlags.NonPublic | BindingFlags.Static); diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/OffsetOfTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/OffsetOfTests.cs index 9c35df5c56735..fff0898567261 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/OffsetOfTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/OffsetOfTests.cs @@ -209,7 +209,7 @@ public static IEnumerable OffsetOf_NotMarshallable_TestData() } [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/15087", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15087", TestRuntimes.Mono)] [MemberData(nameof(OffsetOf_NotMarshallable_TestData))] public void OffsetOf_NotMarshallable_ThrowsArgumentException(Type t, string fieldName) { diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/PtrToStructureTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/PtrToStructureTests.cs index e9e0339bcd7ba..6ab62723f6253 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/PtrToStructureTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/PtrToStructureTests.cs @@ -126,7 +126,7 @@ public void PtrToStructure_ZeroPointerWithType_ReturnsNull() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15101", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15101", TestRuntimes.Mono)] public void PtrToStructure_ZeroPointer_ThrowsArgumentNullException() { AssertExtensions.Throws("ptr", () => Marshal.PtrToStructure(IntPtr.Zero, (object)new SomeTestStruct())); diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/SizeOfTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/SizeOfTests.cs index 7a09a43a155a2..a45708b61e4eb 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/SizeOfTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/SizeOfTests.cs @@ -82,7 +82,7 @@ public static IEnumerable SizeOf_InvalidType_TestData() } [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/15087", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15087", TestRuntimes.Mono)] [MemberData(nameof(SizeOf_InvalidType_TestData))] public void SizeOf_InvalidType_ThrowsArgumentException(Type type, string paramName) { diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/StructureToPtrTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/StructureToPtrTests.cs index b13bdfec58249..c79d8087ecb77 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/StructureToPtrTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/StructureToPtrTests.cs @@ -11,7 +11,7 @@ namespace System.Runtime.InteropServices.Tests public class StructureToPtrTests { [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15102", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15102", TestRuntimes.Mono)] public void StructureToPtr_ByValBoolArray_Success() { var structure1 = new StructWithBoolArray() @@ -91,7 +91,7 @@ public void StructureToPtr_OverflowByValArrayInStruct_Success() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15103", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15103", TestRuntimes.Mono)] public void StructureToPtr_ByValDateArray_Success() { var structure = new StructWithDateArray() @@ -167,7 +167,7 @@ public void StructureToPtr_AutoLayout_ThrowsArgumentException() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15104", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15104", TestRuntimes.Mono)] public void StructureToPtr_InvalidLengthByValArrayInStruct_ThrowsArgumentException() { var structure = new StructWithByValArray diff --git a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ThrowExceptionForHRTests.cs b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ThrowExceptionForHRTests.cs index 28382d07020f3..deaacd98dc7cc 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ThrowExceptionForHRTests.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ThrowExceptionForHRTests.cs @@ -11,7 +11,7 @@ namespace System.Runtime.InteropServices.Tests public class ThrowExceptionForHRTests { [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/15093", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15093", TestRuntimes.Mono)] [InlineData(unchecked((int)0x80020006))] [InlineData(unchecked((int)0x80020101))] public void ThrowExceptionForHR_NoErrorInfo_ReturnsValidException(int errorCode) @@ -55,7 +55,7 @@ public static IEnumerable ThrowExceptionForHR_ErrorInfo_TestData() } [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/15093", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15093", TestRuntimes.Mono)] [MemberData(nameof(ThrowExceptionForHR_ErrorInfo_TestData))] public void ThrowExceptionForHR_ErrorInfo_ReturnsValidException(int errorCode, IntPtr errorInfo) { diff --git a/src/libraries/System.Runtime.Loader/tests/RefEmitLoadContext/RefEmitLoadContextTest.cs b/src/libraries/System.Runtime.Loader/tests/RefEmitLoadContext/RefEmitLoadContextTest.cs index e26f9f754b608..bba0ca7f2661e 100644 --- a/src/libraries/System.Runtime.Loader/tests/RefEmitLoadContext/RefEmitLoadContextTest.cs +++ b/src/libraries/System.Runtime.Loader/tests/RefEmitLoadContext/RefEmitLoadContextTest.cs @@ -69,7 +69,7 @@ private static void DeleteDirectory() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/31804", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31804", TestRuntimes.Mono)] public static void LoadRefEmitAssembly() { Init(); diff --git a/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs b/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs index 0e57249769e5c..e93f4eac15ed2 100644 --- a/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs +++ b/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs @@ -62,7 +62,7 @@ public void ValidateBasicObjectsRoundtrip(object obj, FormatterAssemblyStyle ass [Theory] [SkipOnCoreClr("Takes too long on Checked", RuntimeConfiguration.Checked)] - [ActiveIssue("https://github.com/mono/mono/issues/15115", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15115", TestRuntimes.Mono)] [MemberData(nameof(SerializableObjects_MemberData))] public void ValidateAgainstBlobs(object obj, TypeSerializableValue[] blobs) => ValidateAndRoundtrip(obj, blobs, false); diff --git a/src/libraries/System.Runtime.Serialization.Formatters/tests/FormatterServicesTests.cs b/src/libraries/System.Runtime.Serialization.Formatters/tests/FormatterServicesTests.cs index 13d51bbd96223..5501b23aec15e 100644 --- a/src/libraries/System.Runtime.Serialization.Formatters/tests/FormatterServicesTests.cs +++ b/src/libraries/System.Runtime.Serialization.Formatters/tests/FormatterServicesTests.cs @@ -55,7 +55,7 @@ public static IEnumerable GetUninitializedObject_NotSupportedType_Test } [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/15113", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15113", TestRuntimes.Mono)] [MemberData(nameof(GetUninitializedObject_NotSupportedType_TestData))] public void GetUninitializedObject_NotSupportedType_ThrowsArgumentException(Type type) { @@ -85,7 +85,7 @@ public static IEnumerable GetUninitializedObject_OpenGenericClass_Test } [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/15111", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15111", TestRuntimes.Mono)] [MemberData(nameof(GetUninitializedObject_OpenGenericClass_TestData))] public void GetUninitializedObject_OpenGenericClass_ThrowsMemberAccessException(Type type) { @@ -237,7 +237,7 @@ private class ObjectWithStaticField } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15114", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15114", TestRuntimes.Mono)] public void GetUninitializedObject_StaticConstructorThrows_ThrowsTypeInitializationException() { TypeInitializationException ex = Assert.Throws(() => FormatterServices.GetUninitializedObject(typeof(StaticConstructorThrows))); diff --git a/src/libraries/System.Runtime.Serialization.Formatters/tests/SerializationGuardTests.cs b/src/libraries/System.Runtime.Serialization.Formatters/tests/SerializationGuardTests.cs index 8e3f96f9a37b0..d29b1b9600b02 100644 --- a/src/libraries/System.Runtime.Serialization.Formatters/tests/SerializationGuardTests.cs +++ b/src/libraries/System.Runtime.Serialization.Formatters/tests/SerializationGuardTests.cs @@ -34,7 +34,7 @@ public static void BlockFileWrites() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15112", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15112", TestRuntimes.Mono)] public static void BlockReflectionDodging() { // Ensure that the deserialization tracker cannot be called by reflection. diff --git a/src/libraries/System.Runtime/tests/System/DelegateTests.cs b/src/libraries/System.Runtime/tests/System/DelegateTests.cs index 392097df6ecd0..9d3f635bee23d 100644 --- a/src/libraries/System.Runtime/tests/System/DelegateTests.cs +++ b/src/libraries/System.Runtime/tests/System/DelegateTests.cs @@ -383,7 +383,7 @@ public static void DynamicInvoke_OptionalParameter_WithExplicitValue() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15148", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15148", TestRuntimes.Mono)] public static void DynamicInvoke_OptionalParameter_WithMissingValue() { Assert.Equal( @@ -392,7 +392,7 @@ public static void DynamicInvoke_OptionalParameter_WithMissingValue() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15148", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15148", TestRuntimes.Mono)] public static void DynamicInvoke_OptionalParameterUnassingableFromMissing_WithMissingValue() { AssertExtensions.Throws(null, () => (new OptionalStringParameter(StringMethod)).DynamicInvoke(new object[] { Type.Missing })); @@ -407,7 +407,7 @@ public static void DynamicInvoke_ParameterSpecification_ArrayOfStrings() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15148", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15148", TestRuntimes.Mono)] public static void DynamicInvoke_ParameterSpecification_ArrayOfMissing() { Assert.Same( diff --git a/src/libraries/System.Runtime/tests/System/ExceptionTests.cs b/src/libraries/System.Runtime/tests/System/ExceptionTests.cs index aa92c0f804e8d..6d663486205a3 100644 --- a/src/libraries/System.Runtime/tests/System/ExceptionTests.cs +++ b/src/libraries/System.Runtime/tests/System/ExceptionTests.cs @@ -81,7 +81,7 @@ public static void Exception_TargetSite_Jit() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15140", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15140", TestRuntimes.Mono)] public static void ThrowStatementDoesNotResetExceptionStackLineSameMethod() { (string, string, int) rethrownExceptionStackFrame = (null, null, 0); @@ -111,7 +111,7 @@ private static (string, string, int) ThrowAndRethrowSameMethod(out (string, stri [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotArm64Process))] // [ActiveIssue(https://github.com/dotnet/runtime/issues/1871)] can't use ActiveIssue for archs - [ActiveIssue("https://github.com/mono/mono/issues/15141", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15141", TestRuntimes.Mono)] public static void ThrowStatementDoesNotResetExceptionStackLineOtherMethod() { (string, string, int) rethrownExceptionStackFrame = (null, null, 0); diff --git a/src/libraries/System.Runtime/tests/System/ExitCodeTests.Unix.cs b/src/libraries/System.Runtime/tests/System/ExitCodeTests.Unix.cs index 2e82dee2a1fed..b86cf0a018b69 100644 --- a/src/libraries/System.Runtime/tests/System/ExitCodeTests.Unix.cs +++ b/src/libraries/System.Runtime/tests/System/ExitCodeTests.Unix.cs @@ -17,7 +17,7 @@ public class ExitCodeTests private static extern int kill(int pid, int sig); [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/31656", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31656", TestRuntimes.Mono)] [InlineData(null)] [InlineData(0)] [InlineData(42)] diff --git a/src/libraries/System.Runtime/tests/System/GCTests.cs b/src/libraries/System.Runtime/tests/System/GCTests.cs index 7aef31969f247..568e2aec9ad50 100644 --- a/src/libraries/System.Runtime/tests/System/GCTests.cs +++ b/src/libraries/System.Runtime/tests/System/GCTests.cs @@ -399,7 +399,7 @@ public static void LargeObjectHeapCompactionModeRoundTrips(GCLargeObjectHeapComp } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/31657", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31657", TestRuntimes.Mono)] [InlineData(GCLatencyMode.Batch)] [InlineData(GCLatencyMode.Interactive)] public static void LatencyRoundtrips(GCLatencyMode value) @@ -782,7 +782,7 @@ public static void GetAllocatedBytesForCurrentThread(int size) } [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotArmProcess))] // [ActiveIssue("https://github.com/dotnet/corefx/issues/37378")] - [ActiveIssue("https://github.com/mono/mono/issues/15236", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15236", TestRuntimes.Mono)] public static void GetGCMemoryInfo() { RemoteExecutor.Invoke(() => diff --git a/src/libraries/System.Runtime/tests/System/Reflection/IsCollectibleTests.cs b/src/libraries/System.Runtime/tests/System/Reflection/IsCollectibleTests.cs index 07272982f54c6..c808e075b820a 100644 --- a/src/libraries/System.Runtime/tests/System/Reflection/IsCollectibleTests.cs +++ b/src/libraries/System.Runtime/tests/System/Reflection/IsCollectibleTests.cs @@ -18,7 +18,7 @@ public TestAssemblyLoadContext() : base(true) {} protected override Assembly Load(AssemblyName assemblyName) => null; } - [ActiveIssue("https://github.com/mono/mono/issues/15142", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15142", TestRuntimes.Mono)] public class IsCollectibleTests { public static string asmNameString = "TestCollectibleAssembly"; diff --git a/src/libraries/System.Runtime/tests/System/Reflection/PointerTests.cs b/src/libraries/System.Runtime/tests/System/Reflection/PointerTests.cs index 0703140060cf7..cd80bbaeabf69 100644 --- a/src/libraries/System.Runtime/tests/System/Reflection/PointerTests.cs +++ b/src/libraries/System.Runtime/tests/System/Reflection/PointerTests.cs @@ -171,7 +171,7 @@ public void PointerPropertySetValue_InvalidType(int value) } [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/15152", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15152", TestRuntimes.Mono)] [MemberData(nameof(Pointers))] public void PointerPropertyGetValue(int value) { diff --git a/src/libraries/System.Runtime/tests/System/Type/TypePropertyTests.cs b/src/libraries/System.Runtime/tests/System/Type/TypePropertyTests.cs index 61c170d870a80..fc683bd54718e 100644 --- a/src/libraries/System.Runtime/tests/System/Type/TypePropertyTests.cs +++ b/src/libraries/System.Runtime/tests/System/Type/TypePropertyTests.cs @@ -531,7 +531,7 @@ public class EnumTypeTests : ClassTypeTestBase public override Type BaseType => typeof(ValueType); } - [ActiveIssue("https://github.com/dotnet/runtime/issues/31713", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/31713", TestRuntimes.Mono)] public class VoidTests : StructTypeTestBase { public override Type CreateType() => typeof(void); diff --git a/src/libraries/System.Security.Cryptography.Encoding/tests/Oid.cs b/src/libraries/System.Security.Cryptography.Encoding/tests/Oid.cs index e22dc3aa26b35..6e6b04f6549df 100644 --- a/src/libraries/System.Security.Cryptography.Encoding/tests/Oid.cs +++ b/src/libraries/System.Security.Cryptography.Encoding/tests/Oid.cs @@ -23,7 +23,7 @@ public static void EmptyOid() } [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/16686", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16686", TestRuntimes.Mono)] [MemberData(nameof(ValidOidFriendlyNamePairs))] public static void LookupOidByValue_Ctor(string oidValue, string friendlyName) { @@ -34,7 +34,7 @@ public static void LookupOidByValue_Ctor(string oidValue, string friendlyName) } [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/16686", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16686", TestRuntimes.Mono)] [MemberData(nameof(ValidOidFriendlyNamePairs))] public static void LookupOidByFriendlyName_Ctor(string oidValue, string friendlyName) { @@ -70,7 +70,7 @@ public static void Oid_StringString_BothNull() } [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/16686", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16686", TestRuntimes.Mono)] [MemberData(nameof(ValidOidFriendlyNamePairs))] public static void Oid_StringString_NullFriendlyName(string oidValue, string expectedFriendlyName) { @@ -226,7 +226,7 @@ public static void LookupOidByFriendlyName_Method_EncryptionAlgorithm(string oid } [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/16686", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/16686", TestRuntimes.Mono)] [MemberData(nameof(ValidOidFriendlyNamePairs))] public static void LookupOidByFriendlyName_Method_InverseCase(string oidValue, string friendlyName) { diff --git a/src/libraries/System.Threading.Overlapped/tests/OverlappedTests.cs b/src/libraries/System.Threading.Overlapped/tests/OverlappedTests.cs index 23d61895ea813..ee50f7e5ad9de 100644 --- a/src/libraries/System.Threading.Overlapped/tests/OverlappedTests.cs +++ b/src/libraries/System.Threading.Overlapped/tests/OverlappedTests.cs @@ -62,7 +62,7 @@ public static void PropertyTest2() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15311", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15311", TestRuntimes.Mono)] public static void PropertyTest3() { IAsyncResult asyncResult = new Task(() => Console.WriteLine("this is a dummy task")); diff --git a/src/libraries/System.Threading.Overlapped/tests/ThreadPoolBoundHandle_PreAllocatedOverlappedTests.cs b/src/libraries/System.Threading.Overlapped/tests/ThreadPoolBoundHandle_PreAllocatedOverlappedTests.cs index 9ed9422b72c97..06166c3e8bf9f 100644 --- a/src/libraries/System.Threading.Overlapped/tests/ThreadPoolBoundHandle_PreAllocatedOverlappedTests.cs +++ b/src/libraries/System.Threading.Overlapped/tests/ThreadPoolBoundHandle_PreAllocatedOverlappedTests.cs @@ -10,7 +10,7 @@ public partial class ThreadPoolBoundHandleTests { [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15313", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15313", TestRuntimes.Mono)] public unsafe void PreAllocatedOverlapped_NullAsCallback_ThrowsArgumentNullException() { AssertExtensions.Throws("callback", () => @@ -42,7 +42,7 @@ public unsafe void PreAllocatedOverlapped_EmptyArrayAsPinData_DoesNotThrow() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15313", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15313", TestRuntimes.Mono)] public unsafe void PreAllocatedOverlapped_NonBlittableTypeAsPinData_Throws() { AssertExtensions.Throws(null, () => new PreAllocatedOverlapped((_, __, ___) => { }, new object(), new NonBlittableType() { s = "foo" })); @@ -70,7 +70,7 @@ public unsafe void PreAllocatedOverlapped_ObjectArrayAsPinData_DoesNotThrow() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15313", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15313", TestRuntimes.Mono)] public unsafe void PreAllocatedOverlapped_ObjectArrayWithNonBlittableTypeAsPinData_Throws() { object[] array = new object[] diff --git a/src/libraries/System.Threading.Tasks/tests/Task/TaskContinueWithTests.cs b/src/libraries/System.Threading.Tasks/tests/Task/TaskContinueWithTests.cs index 9e31b295c8237..376da9688b73c 100644 --- a/src/libraries/System.Threading.Tasks/tests/Task/TaskContinueWithTests.cs +++ b/src/libraries/System.Threading.Tasks/tests/Task/TaskContinueWithTests.cs @@ -1212,7 +1212,7 @@ public static void RunLazyCancellationTests_Negative() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/2084", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/2084", TestRuntimes.Mono)] public static void LongContinuationChain_ContinueWith_DoesNotStackOverflow() { const int DiveDepth = 12_000; diff --git a/src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs b/src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs index 1e01611abda0d..ddde9187ba3a5 100644 --- a/src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs +++ b/src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs @@ -89,7 +89,7 @@ public static void GetAvailableThreadsTest() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15164", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15164", TestRuntimes.Mono)] public static void SetMinMaxThreadsTest() { @@ -151,7 +151,7 @@ public static void SetMinMaxThreadsTest() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/32020", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/32020", TestRuntimes.Mono)] public static void SetMinMaxThreadsTest_ChangedInDotNetCore() { int minw, minc, maxw, maxc; diff --git a/src/libraries/System.Threading/tests/MutexTests.cs b/src/libraries/System.Threading/tests/MutexTests.cs index 3149426d4f53c..6b5132b0bd34b 100644 --- a/src/libraries/System.Threading/tests/MutexTests.cs +++ b/src/libraries/System.Threading/tests/MutexTests.cs @@ -38,7 +38,7 @@ public void Ctor_ConstructWaitRelease() } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15159", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15159", TestRuntimes.Mono)] [PlatformSpecific(TestPlatforms.AnyUnix)] public void Ctor_InvalidNames_Unix() { @@ -123,7 +123,7 @@ public void OpenExisting(string name) } [Fact] - [ActiveIssue("https://github.com/mono/mono/issues/15158", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15158", TestRuntimes.Mono)] public void OpenExisting_InvalidNames() { AssertExtensions.Throws("name", () => Mutex.OpenExisting(null)); diff --git a/src/libraries/System.Threading/tests/SemaphoreTests.cs b/src/libraries/System.Threading/tests/SemaphoreTests.cs index 5591fb542da67..f8af0363b3dfe 100644 --- a/src/libraries/System.Threading/tests/SemaphoreTests.cs +++ b/src/libraries/System.Threading/tests/SemaphoreTests.cs @@ -39,7 +39,7 @@ public void Ctor_ValidName_Windows(string name) } [PlatformSpecific(TestPlatforms.AnyUnix)] // named semaphores aren't supported on Unix - [ActiveIssue("https://github.com/mono/mono/issues/15161", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15161", TestRuntimes.Mono)] [Fact] public void Ctor_NamesArentSupported_Unix() { @@ -190,7 +190,7 @@ public void NamedProducerConsumer() } [PlatformSpecific(TestPlatforms.AnyUnix)] // named semaphores aren't supported on Unix - [ActiveIssue("https://github.com/mono/mono/issues/15160", TargetFrameworkMonikers.Mono)] + [ActiveIssue("https://github.com/mono/mono/issues/15160", TestRuntimes.Mono)] [Fact] public void OpenExisting_NotSupported_Unix() { From 001dbeb67c635df8277ff5ce1e2db39912eb8c05 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Fri, 14 Feb 2020 10:53:40 +0300 Subject: [PATCH 80/96] Remove redundant space --- .../System.Threading.ThreadPool/tests/ThreadPoolTests.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs b/src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs index ddde9187ba3a5..a72fe059893d0 100644 --- a/src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs +++ b/src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs @@ -90,7 +90,6 @@ public static void GetAvailableThreadsTest() [Fact] [ActiveIssue("https://github.com/mono/mono/issues/15164", TestRuntimes.Mono)] - public static void SetMinMaxThreadsTest() { int minw, minc, maxw, maxc; From 6a5a07ac65f40fb0c3c2e3ad471aedbba2d81e5e Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Fri, 14 Feb 2020 10:54:10 +0300 Subject: [PATCH 81/96] Remove all -notrait category --- src/mono/netcore/CoreFX.issues.rsp | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 1ce1857b6d271..b6cdedeffeedf 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -1,10 +1,3 @@ --notrait category=OuterLoop --notrait category=RequiresElevation --notrait category=nonnetcoreapptests --notrait category=nonmonotests --notrait category=failing --notrait category=IgnoreForCI - #################################################################### ## System.Runtime.Loader.Tests #################################################################### From b7aa5d307112baf413f95fee97fed01eea94dac0 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Fri, 14 Feb 2020 17:48:27 +0300 Subject: [PATCH 82/96] Add an active issue to System.ComponentModel.Composition.MetadataAttributeTests.StronglyTypedStructureTest --- .../ComponentModel/Composition/ExportableAttributeTests.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportableAttributeTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportableAttributeTests.cs index f057a66876d25..a8040bcbe7026 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportableAttributeTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ExportableAttributeTests.cs @@ -37,6 +37,7 @@ public void UntypedStructureTest() // Silverlight doesn't support strongly typed metadata [Fact] [Trait("Type", "Integration")] + [ActiveIssue("https://github.com/dotnet/runtime/issues/32295", TestRuntimes.Mono)] public void StronglyTypedStructureTest() { var container = ContainerFactory.Create(); From 3b743749adac7c6447ddbf70ab6438d7ade9a054 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Fri, 14 Feb 2020 22:13:58 +0300 Subject: [PATCH 83/96] Add an active issue to System.ComponentModel.Composition.CompositionContainerTests.GetExportOfTTMetadataView1_TypeAsMetadataViewTypeArgument_IsUsedAsMetadataConstraint --- .../ComponentModel/Composition/CompositionContainerTests.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerTests.cs index 81459728af7cb..fdd2e6729e606 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerTests.cs @@ -1630,6 +1630,7 @@ public void GetExportedValuesOfT2_AskingForContractWithExportInBothParentAndChil } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/32295", TestRuntimes.Mono)] public void GetExportOfTTMetadataView1_TypeAsMetadataViewTypeArgument_IsUsedAsMetadataConstraint() { var metadata = new Dictionary(); From 5514c90d04ef689c5d4cfe88617f2aacfa361fc6 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Sat, 15 Feb 2020 22:54:13 +0300 Subject: [PATCH 84/96] Disable the whole System.ComponentModel.Composition.Tests namespace --- .../tests/AssemblyInfo.cs | 7 +++++++ .../tests/System.ComponentModel.Composition.Tests.csproj | 1 + 2 files changed, 8 insertions(+) create mode 100644 src/libraries/System.ComponentModel.Composition/tests/AssemblyInfo.cs diff --git a/src/libraries/System.ComponentModel.Composition/tests/AssemblyInfo.cs b/src/libraries/System.ComponentModel.Composition/tests/AssemblyInfo.cs new file mode 100644 index 0000000000000..68af85566d692 --- /dev/null +++ b/src/libraries/System.ComponentModel.Composition/tests/AssemblyInfo.cs @@ -0,0 +1,7 @@ +// Licensed to the .NET Foundation under one or more agreements. +// The .NET Foundation licenses this file to you under the MIT license. +// See the LICENSE file in the project root for more information. + +using Xunit; + +[assembly: SkipOnMono("Flaky tests: https://github.com/mono/mono/issues/16417")] diff --git a/src/libraries/System.ComponentModel.Composition/tests/System.ComponentModel.Composition.Tests.csproj b/src/libraries/System.ComponentModel.Composition/tests/System.ComponentModel.Composition.Tests.csproj index 2c47c61615e32..7dac12f1e21a6 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System.ComponentModel.Composition.Tests.csproj +++ b/src/libraries/System.ComponentModel.Composition/tests/System.ComponentModel.Composition.Tests.csproj @@ -16,6 +16,7 @@ Common\System\IO\TempFile.cs + From 05fe86d8f0e2b566cbaa2399ec906e2f8626a6d2 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 17 Feb 2020 11:58:11 +0300 Subject: [PATCH 85/96] Move some System.Runtime.Loader.Tests, which rely on collectible AssemblyLoadContext, out of rsp file --- .../tests/AssemblyLoadContextTest.cs | 1 + .../tests/CollectibleAssemblyLoadContextTest.cs | 11 +++++++++++ .../tests/ContextualReflection.cs | 1 + src/mono/netcore/CoreFX.issues.rsp | 9 --------- 4 files changed, 13 insertions(+), 9 deletions(-) diff --git a/src/libraries/System.Runtime.Loader/tests/AssemblyLoadContextTest.cs b/src/libraries/System.Runtime.Loader/tests/AssemblyLoadContextTest.cs index 11626ff39d9aa..e4d042c43277e 100644 --- a/src/libraries/System.Runtime.Loader/tests/AssemblyLoadContextTest.cs +++ b/src/libraries/System.Runtime.Loader/tests/AssemblyLoadContextTest.cs @@ -184,6 +184,7 @@ public static void PublicConstructor_Default() } [Theory] + [ActiveIssue("https://github.com/mono/mono/issues/15142", TestRuntimes.Mono)] [InlineData("AssemblyLoadContextCollectible", true)] [InlineData("AssemblyLoadContextNonCollectible", false)] public static void PublicConstructor_Theory(string name, bool isCollectible) diff --git a/src/libraries/System.Runtime.Loader/tests/CollectibleAssemblyLoadContextTest.cs b/src/libraries/System.Runtime.Loader/tests/CollectibleAssemblyLoadContextTest.cs index 16b0c64f184b9..5c71c3804173c 100644 --- a/src/libraries/System.Runtime.Loader/tests/CollectibleAssemblyLoadContextTest.cs +++ b/src/libraries/System.Runtime.Loader/tests/CollectibleAssemblyLoadContextTest.cs @@ -29,6 +29,7 @@ static void CreateAndLoadContext(CollectibleChecker checker) } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15142", TestRuntimes.Mono)] public static void Unload_CollectibleWithNoAssemblyLoaded() { // Use a collectible ALC + Unload @@ -40,6 +41,7 @@ public static void Unload_CollectibleWithNoAssemblyLoaded() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15142", TestRuntimes.Mono)] public static void Finalizer_CollectibleWithNoAssemblyLoaded() { // Use a collectible ALC, let the finalizer call Unload @@ -109,6 +111,7 @@ class CollectibleWithOneAssemblyLoadedTest : TestBase } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15142", TestRuntimes.Mono)] public static void Unload_CollectibleWithOneAssemblyLoaded() { // Use a collectible ALC + Load an assembly by path + Unload @@ -135,6 +138,7 @@ public void Execute() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15142", TestRuntimes.Mono)] public static void Unload_CollectibleWithOneAssemblyLoadedWithStatic() { // Use a collectible ALC + Load an assembly by path + New Instance + Static reference + Unload @@ -166,6 +170,7 @@ public void CheckInstanceUnloaded() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15142", TestRuntimes.Mono)] public static void Unload_CollectibleWithOneAssemblyLoadedWithWeakReferenceToType() { // Use a collectible ALC + Load an assembly by path + WeakReference on the Type + Unload @@ -199,6 +204,7 @@ public void CheckInstanceUnloaded() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15142", TestRuntimes.Mono)] public static void Unload_CollectibleWithOneAssemblyLoadedWithWeakReferenceToInstance() { // Use a collectible ALC + Load an assembly by path + WeakReference on an instance of a Type + Unload @@ -250,6 +256,7 @@ public void CheckTypeUnloaded() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15142", TestRuntimes.Mono)] public static void Unload_CollectibleWithOneAssemblyLoadedWithStrongReferenceToType() { // Use a collectible ALC + Load an assembly by path + Strong reference on the Type + Unload @@ -310,6 +317,7 @@ public void CheckInstanceUnloaded() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15142", TestRuntimes.Mono)] public static void Unload_CollectibleWithOneAssemblyLoadedWithStrongReferenceToInstance() { // Use a collectible ALC + Load an assembly by path + Strong reference on an instance of a Type + Unload @@ -343,6 +351,7 @@ public void Execute() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15142", TestRuntimes.Mono)] public static void Unload_CollectibleWithTwoAssemblies() { // Use a collectible ALC + Load two assemblies (path + stream) + Unload @@ -403,6 +412,7 @@ public void CheckContextUnloaded2() } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15142", TestRuntimes.Mono)] public static void Unload_TwoCollectibleWithOneAssemblyAndOneInstanceReferencingAnother() { // We create 2 collectible ALC, load one assembly in each, create one instance in each, reference one instance from ALC1 to ALC2 @@ -429,6 +439,7 @@ public static void Unload_TwoCollectibleWithOneAssemblyAndOneInstanceReferencing } [Fact] + [ActiveIssue("https://github.com/mono/mono/issues/15142", TestRuntimes.Mono)] public static void Unsupported_FixedAddressValueType() { var asmName = new AssemblyName(TestAssemblyNotSupported); diff --git a/src/libraries/System.Runtime.Loader/tests/ContextualReflection.cs b/src/libraries/System.Runtime.Loader/tests/ContextualReflection.cs index 160df3d762c1e..8f7f1fd03e5c2 100644 --- a/src/libraries/System.Runtime.Loader/tests/ContextualReflection.cs +++ b/src/libraries/System.Runtime.Loader/tests/ContextualReflection.cs @@ -144,6 +144,7 @@ public void FixtureSetupAssertions() } } + [ActiveIssue("https://github.com/mono/mono/issues/15142", TestRuntimes.Mono)] public class ContextualReflectionTest : IClassFixture { IContextualReflectionTestFixture _fixture; diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index b6cdedeffeedf..073e410f395ac 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -2,15 +2,6 @@ ## System.Runtime.Loader.Tests #################################################################### -# NOTE: Not run (relies on collectible ALCs) --nomethod System.Runtime.Loader.Tests.ContextualReflectionTest.* - -# relies on collectible AssemblyLoadContext --nomethod System.Runtime.Loader.Tests.AssemblyLoadContextTest.Unload_* --nomethod System.Runtime.Loader.Tests.AssemblyLoadContextTest.Finalizer_CollectibleWithNoAssemblyLoaded --nomethod System.Runtime.Loader.Tests.AssemblyLoadContextTest.PublicConstructor_Theory --nomethod System.Runtime.Loader.Tests.AssemblyLoadContextTest.Unsupported_FixedAddressValueType - # relies on specific exception message -nomethod System.Runtime.Loader.Tests.AssemblyLoadContextTest.LoadFromAssemblyPath_PartiallyQualifiedPath_ThrowsArgumentException -nomethod System.Runtime.Loader.Tests.AssemblyLoadContextTest.LoadFromNativeImagePath_PartiallyQualifiedPath_ThrowsArgumentException From 07afeb21d7255feec1de382d7e543145d3baeaeb Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 17 Feb 2020 12:11:45 +0300 Subject: [PATCH 86/96] Remove three System.Runtime.Loader.Tests.AssemblyLoadContextTest tests with no local failures from rsp file --- src/mono/netcore/CoreFX.issues.rsp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 073e410f395ac..026be365340fb 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -2,11 +2,6 @@ ## System.Runtime.Loader.Tests #################################################################### -# relies on specific exception message --nomethod System.Runtime.Loader.Tests.AssemblyLoadContextTest.LoadFromAssemblyPath_PartiallyQualifiedPath_ThrowsArgumentException --nomethod System.Runtime.Loader.Tests.AssemblyLoadContextTest.LoadFromNativeImagePath_PartiallyQualifiedPath_ThrowsArgumentException --nomethod System.Runtime.Loader.Tests.AssemblyLoadContextTest.LoadFromNativeImagePath_PartiallyQualifiedPath_ThrowsArgumentException2 - # fails -nomethod System.Runtime.Loader.Tests.DefaultLoadContextTests.LoadNonExistentInDefaultContext -nomethod System.Runtime.Loader.Tests.AssemblyLoadContextTest.GetLoadContextTest_ValidUserAssembly From 6a0d1049efc4c8f2b1aa20cfba81e101ca602422 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 17 Feb 2020 12:40:47 +0300 Subject: [PATCH 87/96] Remove System.Runtime.Loader.Tests.DefaultLoadContextTests.LoadNonExistentInDefaultContext and System.Runtime.Loader.Tests.DefaultLoadContextTests.LoadInDefaultContext from rsp file because the related issues should be addressed --- src/mono/netcore/CoreFX.issues.rsp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 026be365340fb..5c394eea09ddc 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -3,9 +3,7 @@ #################################################################### # fails --nomethod System.Runtime.Loader.Tests.DefaultLoadContextTests.LoadNonExistentInDefaultContext -nomethod System.Runtime.Loader.Tests.AssemblyLoadContextTest.GetLoadContextTest_ValidUserAssembly --nomethod System.Runtime.Loader.Tests.DefaultLoadContextTests.LoadInDefaultContext -nomethod System.Runtime.Loader.Tests.AssemblyLoadContextTest.LoadFromAssemblyName_AssemblyNotFound -nomethod System.Runtime.Loader.Tests.AssemblyLoadContextTest.LoadAssemblyByPath_ValidUserAssembly -nomethod System.Runtime.Loader.Tests.AssemblyLoadContextTest.LoadAssemblyByStream_ValidUserAssembly From 3ce15ea10461cc63cff7f25f2e0a95ab628f21fb Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 17 Feb 2020 15:25:52 +0300 Subject: [PATCH 88/96] Add an active issue to System.Runtime.Loader.Tests.DefaultLoadContextTests.LoadNonExistentInDefaultContext and System.Runtime.Loader.Tests.DefaultLoadContextTests.LoadInDefaultContext because they fail on CI --- .../tests/DefaultContext/DefaultLoadContextTest.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libraries/System.Runtime.Loader/tests/DefaultContext/DefaultLoadContextTest.cs b/src/libraries/System.Runtime.Loader/tests/DefaultContext/DefaultLoadContextTest.cs index 2c0f997dc70f4..32c1c1524993c 100644 --- a/src/libraries/System.Runtime.Loader/tests/DefaultContext/DefaultLoadContextTest.cs +++ b/src/libraries/System.Runtime.Loader/tests/DefaultContext/DefaultLoadContextTest.cs @@ -84,6 +84,7 @@ private Assembly ResolveNullAssembly(AssemblyLoadContext sender, AssemblyName as } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/32433", TestRuntimes.Mono)] public void LoadInDefaultContext() { // This will attempt to load an assembly, by path, in the Default Load context via the Resolving event @@ -176,6 +177,7 @@ public void LoadInDefaultContext() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/32432", TestRuntimes.Mono)] public static void LoadNonExistentInDefaultContext() { // Now, try to load an assembly that does not exist From 7779a6bd0973f4f142f4b516e51f3bc642693abe Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 17 Feb 2020 16:21:07 +0300 Subject: [PATCH 89/96] Move several System.Runtime.Loader.Tests.AssemblyLoadContextTest with an active issues out of rsp file --- .../tests/AssemblyLoadContextTest.cs | 5 +++++ src/mono/netcore/CoreFX.issues.rsp | 11 ----------- 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/src/libraries/System.Runtime.Loader/tests/AssemblyLoadContextTest.cs b/src/libraries/System.Runtime.Loader/tests/AssemblyLoadContextTest.cs index e4d042c43277e..3cbede68a688d 100644 --- a/src/libraries/System.Runtime.Loader/tests/AssemblyLoadContextTest.cs +++ b/src/libraries/System.Runtime.Loader/tests/AssemblyLoadContextTest.cs @@ -70,6 +70,7 @@ public static void LoadFromNativeImagePath_PartiallyQualifiedPath_ThrowsArgument } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/32436", TestRuntimes.Mono)] public static void LoadAssemblyByPath_ValidUserAssembly() { var asmName = new AssemblyName(TestAssembly); @@ -83,6 +84,7 @@ public static void LoadAssemblyByPath_ValidUserAssembly() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/32437", TestRuntimes.Mono)] public static void LoadAssemblyByStream_ValidUserAssembly() { var asmName = new AssemblyName(TestAssembly); @@ -96,6 +98,7 @@ public static void LoadAssemblyByStream_ValidUserAssembly() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/32435", TestRuntimes.Mono)] public static void LoadFromAssemblyName_AssemblyNotFound() { var asmName = new AssemblyName("Non.Existing.Assembly.dll"); @@ -106,6 +109,7 @@ public static void LoadFromAssemblyName_AssemblyNotFound() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/32439", TestRuntimes.Mono)] public static void LoadFromAssemblyName_ValidTrustedPlatformAssembly() { var asmName = typeof(ISet<>).Assembly.GetName(); @@ -122,6 +126,7 @@ public static void LoadFromAssemblyName_ValidTrustedPlatformAssembly() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/32434", TestRuntimes.Mono)] public static void GetLoadContextTest_ValidUserAssembly() { var asmName = new AssemblyName(TestAssembly); diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 5c394eea09ddc..c7e678f1c972c 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -1,14 +1,3 @@ -#################################################################### -## System.Runtime.Loader.Tests -#################################################################### - -# fails --nomethod System.Runtime.Loader.Tests.AssemblyLoadContextTest.GetLoadContextTest_ValidUserAssembly --nomethod System.Runtime.Loader.Tests.AssemblyLoadContextTest.LoadFromAssemblyName_AssemblyNotFound --nomethod System.Runtime.Loader.Tests.AssemblyLoadContextTest.LoadAssemblyByPath_ValidUserAssembly --nomethod System.Runtime.Loader.Tests.AssemblyLoadContextTest.LoadAssemblyByStream_ValidUserAssembly --nomethod System.Runtime.Loader.Tests.AssemblyLoadContextTest.LoadFromAssemblyName_ValidTrustedPlatformAssembly - #################################################################### ## System.Utf8String.Experimental.Tests #################################################################### From 315a4c83b648bc955ca5a3e8167ac3b6467f28cc Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 18 Feb 2020 09:08:55 +0300 Subject: [PATCH 90/96] Remove System.Utf8String.Experimental.Tests from rsp file to verify how they behave on CI --- src/mono/netcore/CoreFX.issues.rsp | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index c7e678f1c972c..72a06c4182258 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -1,17 +1,3 @@ -#################################################################### -## System.Utf8String.Experimental.Tests -#################################################################### - -# Experimental feature -# Will be removed and we can skip for now. --nomethod System.Tests.MemoryTests.* --nomethod System.Tests.Utf8StringTests.* --nomethod System.Text.Tests.Utf8SpanTests.* --nomethod System.Tests.Utf8ExtensionsTests.* --nomethod System.Tests.Char8Tests.* --nomethod System.Tests.ReflectionTests.* --nomethod System.Net.Http.Tests.Utf8StringContentTests.* - #################################################################### ## System.Text.RegularExpressions.Tests #################################################################### From 16a55ef07e7440992c21fe5fe011b4d40865060d Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 18 Feb 2020 11:20:36 +0300 Subject: [PATCH 91/96] Clean up rsp file to check all remaining failures --- src/mono/netcore/CoreFX.issues.rsp | 63 ------------------------------ 1 file changed, 63 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp index 72a06c4182258..e69de29bb2d1d 100644 --- a/src/mono/netcore/CoreFX.issues.rsp +++ b/src/mono/netcore/CoreFX.issues.rsp @@ -1,63 +0,0 @@ -#################################################################### -## System.Text.RegularExpressions.Tests -#################################################################### - -# hits OOM --nomethod System.Text.RegularExpressions.Tests.RegexMatchTests.Match_Timeout_Loop_Throws - -#################################################################### -## System.ComponentModel.Composition.Registration.Tests -#################################################################### - -# System.ComponentModel.Composition.Registration APIs are not supported on this platform. --nomethod System.ComponentModel.Composition.Registration.Tests.RegistrationBuilderTests.* --nomethod System.ComponentModel.Composition.Registration.Tests.PartBuilderUnitTests.* --nomethod System.ComponentModel.Composition.Registration.Tests.PartBuilderOfTInheritanceTests.* --nomethod System.ComponentModel.Composition.Registration.Tests.ExportBuilderUnitTests.* --nomethod System.ComponentModel.Composition.Registration.Tests.RegistrationBuilderAttributedOverrideUnitTests.* --nomethod System.ComponentModel.Composition.Registration.Tests.PartBuilderOfTTests.* --nomethod System.ComponentModel.Composition.Registration.Tests.PartBuilderTests.* --nomethod System.ComponentModel.Composition.Registration.Tests.ExportBuilderTests.* --nomethod System.ComponentModel.Composition.Registration.Tests.ImportBuilderTests.* --nomethod System.ComponentModel.Composition.Registration.Tests.RegistrationBuilderUnitTests.* --nomethod System.ComponentModel.Composition.Registration.Tests.RegistrationBuilderExportFuncUnitTests.* --nomethod System.ComponentModel.Composition.Registration.Tests.PartBuilderInterfaceTests.* --nomethod System.ComponentModel.Composition.Registration.Tests.ExportInterfacesContractExclusionTests.* - -#################################################################### -## System.Security.Cryptography.X509Certificates.Tests -#################################################################### - -# Passes local, but leaving here because it may be flaky --nomethod System.Security.Cryptography.X509Certificates.Tests.DynamicChainTests.TestInvalidAia - -# disabled in CoreCLR too --noclass System.Security.Cryptography.X509Certificates.Tests.X509Certificate2UITests - --nomethod System.IO.Tests.File_Move_Tests.File_Move_From_Unwatched_To_Watched - -# unxpected non-breaking space in strings (char(160) - char(32)) --nomethod DataContractJsonSerializerTests.DCJS_VerifyDateTimeForDateTimeFormat --nomethod DataContractJsonSerializerTests.DCJS_VerifyDateTimeForFormatStringDCJsonSerSettings - -# GetCustomAttribute should ignore NullableContextAttribute? --nomethod System.Reflection.Tests.GetCustomAttributes_MemberInfo.GetCustomAttributeAll --nomethod System.Tests.AttributeGetCustomAttributes.MultipleAttributesTest - -# Unexpected IntPtr.Zero from Interop.Mmap --nomethod System.IO.MemoryMappedFiles.Tests.MemoryMappedViewAccessorTests.ValidAccessLevelCombinations --nomethod System.IO.MemoryMappedFiles.Tests.MemoryMappedViewStreamTests.ValidAccessLevelCombinations - -# requires precise gc (to be ignored in dotnet/corefx, e.g. https://github.com/dotnet/corefx/pull/39176) --nomethod System.IO.Tests.FileStream_Dispose.Dispose_CallsVirtualDispose_TrueArg --nomethod System.Net.Sockets.Tests.DisposedSocket.NonDisposedSocket_SafeHandlesCollected --nomethod System.Diagnostics.TraceSourceTests.SwitchClassTests.PruneTest - -# Flaky test (FileSystemWatcher) --nomethod System.IO.Tests.Directory_NotifyFilter_Tests.FileSystemWatcher_Directory_NotifyFilter_LastWriteTime - -#################################################################### -## System.Security.Cryptography.Encoding.Tests -#################################################################### - --nomethod System.Tests.StringComparerTests.CreateCultureOptions_InvalidArguments_Throws From 4e28d118fae4701f40203a1900bdf94aa2c29f0b Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 18 Feb 2020 13:07:28 +0300 Subject: [PATCH 92/96] Skip the entire System.ComponentModel.Composition.Registration.Tests namespace on Mono --- .../tests/AssemblyInfo.cs | 7 +++++++ ...em.ComponentModel.Composition.Registration.Tests.csproj | 1 + 2 files changed, 8 insertions(+) create mode 100644 src/libraries/System.ComponentModel.Composition.Registration/tests/AssemblyInfo.cs diff --git a/src/libraries/System.ComponentModel.Composition.Registration/tests/AssemblyInfo.cs b/src/libraries/System.ComponentModel.Composition.Registration/tests/AssemblyInfo.cs new file mode 100644 index 0000000000000..5dc2e1c959dfc --- /dev/null +++ b/src/libraries/System.ComponentModel.Composition.Registration/tests/AssemblyInfo.cs @@ -0,0 +1,7 @@ +// Licensed to the .NET Foundation under one or more agreements. +// The .NET Foundation licenses this file to you under the MIT license. +// See the LICENSE file in the project root for more information. + +using Xunit; + +[assembly: SkipOnMono("System.ComponentModel.Composition.Registration APIs are not supported on this platform")] \ No newline at end of file diff --git a/src/libraries/System.ComponentModel.Composition.Registration/tests/System.ComponentModel.Composition.Registration.Tests.csproj b/src/libraries/System.ComponentModel.Composition.Registration/tests/System.ComponentModel.Composition.Registration.Tests.csproj index 8c0707afe31bb..d7711c3f4dcde 100644 --- a/src/libraries/System.ComponentModel.Composition.Registration/tests/System.ComponentModel.Composition.Registration.Tests.csproj +++ b/src/libraries/System.ComponentModel.Composition.Registration/tests/System.ComponentModel.Composition.Registration.Tests.csproj @@ -3,6 +3,7 @@ $(NetCoreAppCurrent) + From 0d3f16310a94393a407b5163c88a143819fff84c Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 18 Feb 2020 17:28:21 +0300 Subject: [PATCH 93/96] Disable a set of classes in System.Utf8String.Experimental.Tests workspace. --- .../System.Utf8String.Experimental/tests/System/Char8Tests.cs | 1 + .../System.Utf8String.Experimental/tests/System/MemoryTests.cs | 1 + .../tests/System/Net/Http/Utf8StringContentTests.cs | 1 + .../tests/System/ReflectionTests.cs | 1 + .../tests/System/Utf8ExtensionsTests.cs | 1 + .../System.Utf8String.Experimental/tests/System/Utf8SpanTests.cs | 1 + .../tests/System/Utf8StringTests.cs | 1 + 7 files changed, 7 insertions(+) diff --git a/src/libraries/System.Utf8String.Experimental/tests/System/Char8Tests.cs b/src/libraries/System.Utf8String.Experimental/tests/System/Char8Tests.cs index 87da26b8e81fa..84acb981e21a2 100644 --- a/src/libraries/System.Utf8String.Experimental/tests/System/Char8Tests.cs +++ b/src/libraries/System.Utf8String.Experimental/tests/System/Char8Tests.cs @@ -7,6 +7,7 @@ namespace System.Tests { + [SkipOnMono("The features from System.Utf8String.Experimental namespace are experimental.")] public unsafe partial class Char8Tests { [Theory] diff --git a/src/libraries/System.Utf8String.Experimental/tests/System/MemoryTests.cs b/src/libraries/System.Utf8String.Experimental/tests/System/MemoryTests.cs index 34c2ca98f5358..8e7086a66f1b1 100644 --- a/src/libraries/System.Utf8String.Experimental/tests/System/MemoryTests.cs +++ b/src/libraries/System.Utf8String.Experimental/tests/System/MemoryTests.cs @@ -11,6 +11,7 @@ namespace System.Tests { + [SkipOnMono("The features from System.Utf8String.Experimental namespace are experimental.")] public partial class MemoryTests { [Fact] diff --git a/src/libraries/System.Utf8String.Experimental/tests/System/Net/Http/Utf8StringContentTests.cs b/src/libraries/System.Utf8String.Experimental/tests/System/Net/Http/Utf8StringContentTests.cs index 87c31c6dce394..0173b9bafc45e 100644 --- a/src/libraries/System.Utf8String.Experimental/tests/System/Net/Http/Utf8StringContentTests.cs +++ b/src/libraries/System.Utf8String.Experimental/tests/System/Net/Http/Utf8StringContentTests.cs @@ -11,6 +11,7 @@ namespace System.Net.Http.Tests { + [SkipOnMono("The features from System.Utf8String.Experimental namespace are experimental.")] public partial class Utf8StringContentTests { [Fact] diff --git a/src/libraries/System.Utf8String.Experimental/tests/System/ReflectionTests.cs b/src/libraries/System.Utf8String.Experimental/tests/System/ReflectionTests.cs index 4cbd4cf192d26..e45e8ddca07cc 100644 --- a/src/libraries/System.Utf8String.Experimental/tests/System/ReflectionTests.cs +++ b/src/libraries/System.Utf8String.Experimental/tests/System/ReflectionTests.cs @@ -9,6 +9,7 @@ namespace System.Tests { + [SkipOnMono("The features from System.Utf8String.Experimental namespace are experimental.")] public partial class ReflectionTests { [Fact] diff --git a/src/libraries/System.Utf8String.Experimental/tests/System/Utf8ExtensionsTests.cs b/src/libraries/System.Utf8String.Experimental/tests/System/Utf8ExtensionsTests.cs index 13d5f4c091b99..5b15679b006be 100644 --- a/src/libraries/System.Utf8String.Experimental/tests/System/Utf8ExtensionsTests.cs +++ b/src/libraries/System.Utf8String.Experimental/tests/System/Utf8ExtensionsTests.cs @@ -11,6 +11,7 @@ namespace System.Tests { + [SkipOnMono("The features from System.Utf8String.Experimental namespace are experimental.")] public partial class Utf8ExtensionsTests { [Fact] diff --git a/src/libraries/System.Utf8String.Experimental/tests/System/Utf8SpanTests.cs b/src/libraries/System.Utf8String.Experimental/tests/System/Utf8SpanTests.cs index 91d19de6dfe4d..93148cb652951 100644 --- a/src/libraries/System.Utf8String.Experimental/tests/System/Utf8SpanTests.cs +++ b/src/libraries/System.Utf8String.Experimental/tests/System/Utf8SpanTests.cs @@ -16,6 +16,7 @@ namespace System.Text.Tests { + [SkipOnMono("The features from System.Utf8String.Experimental namespace are experimental.")] public unsafe partial class Utf8SpanTests { [Fact] diff --git a/src/libraries/System.Utf8String.Experimental/tests/System/Utf8StringTests.cs b/src/libraries/System.Utf8String.Experimental/tests/System/Utf8StringTests.cs index 17da58ac16c13..12b8ad587d488 100644 --- a/src/libraries/System.Utf8String.Experimental/tests/System/Utf8StringTests.cs +++ b/src/libraries/System.Utf8String.Experimental/tests/System/Utf8StringTests.cs @@ -10,6 +10,7 @@ namespace System.Tests { + [SkipOnMono("The features from System.Utf8String.Experimental namespace are experimental.")] public unsafe partial class Utf8StringTests { [Fact] From 5172b49f4c4ced84f388ad2181a85c83dbca9386 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 18 Feb 2020 17:30:53 +0300 Subject: [PATCH 94/96] Add stubs for Utf8String and Utf8Span.cs classes to fix the test build on Mono --- .../System.Private.CoreLib.csproj | 2 + .../src/System/Text/Utf8Span.cs | 118 ++++++++++++++++++ .../src/System/Utf8String.cs | 112 +++++++++++++++++ 3 files changed, 232 insertions(+) create mode 100644 src/mono/netcore/System.Private.CoreLib/src/System/Text/Utf8Span.cs create mode 100644 src/mono/netcore/System.Private.CoreLib/src/System/Utf8String.cs diff --git a/src/mono/netcore/System.Private.CoreLib/System.Private.CoreLib.csproj b/src/mono/netcore/System.Private.CoreLib/System.Private.CoreLib.csproj index 0f0cca1431b49..3dc4c5875aa67 100644 --- a/src/mono/netcore/System.Private.CoreLib/System.Private.CoreLib.csproj +++ b/src/mono/netcore/System.Private.CoreLib/System.Private.CoreLib.csproj @@ -176,6 +176,7 @@ + @@ -252,6 +253,7 @@ + diff --git a/src/mono/netcore/System.Private.CoreLib/src/System/Text/Utf8Span.cs b/src/mono/netcore/System.Private.CoreLib/src/System/Text/Utf8Span.cs new file mode 100644 index 0000000000000..28b8e297e7422 --- /dev/null +++ b/src/mono/netcore/System.Private.CoreLib/src/System/Text/Utf8Span.cs @@ -0,0 +1,118 @@ +// Licensed to the .NET Foundation under one or more agreements. +// The .NET Foundation licenses this file to you under the MIT license. +// See the LICENSE file in the project root for more information. + +using System.Buffers; +using System.ComponentModel; +using System.Diagnostics; +using System.Runtime.CompilerServices; +using System.Runtime.InteropServices; +using System.Text.Unicode; +using Internal.Runtime.CompilerServices; + +#pragma warning disable 0809 //warning CS0809: Obsolete member 'Utf8Span.Equals(object)' overrides non-obsolete member 'object.Equals(object)' + +#pragma warning disable SA1121 // explicitly using type aliases instead of built-in types +#if TARGET_64BIT +using nint = System.Int64; +using nuint = System.UInt64; +#else +using nint = System.Int32; +using nuint = System.UInt32; +#endif + +namespace System.Text +{ + [StructLayout(LayoutKind.Auto)] + public readonly ref partial struct Utf8Span + { + [MethodImpl(MethodImplOptions.AggressiveInlining)] + public Utf8Span(Utf8String? value) + { + throw new PlatformNotSupportedException(); + } + + public ReadOnlySpan Bytes { get; } + + public static Utf8Span Empty => default; + + public bool IsEmpty => throw new PlatformNotSupportedException(); + + public int Length => throw new PlatformNotSupportedException(); + + public Utf8Span this[Range range] + { + get + { + throw new PlatformNotSupportedException(); + } + } + + public bool IsEmptyOrWhiteSpace() => throw new PlatformNotSupportedException(); + + [Obsolete("Equals(object) on Utf8Span will always throw an exception. Use Equals(Utf8Span) or operator == instead.")] + [EditorBrowsable(EditorBrowsableState.Never)] + public override bool Equals(object? obj) + { + throw new NotSupportedException(SR.Utf8Span_CannotCallEqualsObject); + } + + public bool Equals(Utf8Span other) => throw new PlatformNotSupportedException(); + + public bool Equals(Utf8Span other, StringComparison comparison) => throw new PlatformNotSupportedException(); + + public static bool Equals(Utf8Span left, Utf8Span right) => throw new PlatformNotSupportedException(); + + public static bool Equals(Utf8Span left, Utf8Span right, StringComparison comparison) + { + throw new PlatformNotSupportedException(); + } + + public override int GetHashCode() + { + throw new PlatformNotSupportedException(); + } + + public int GetHashCode(StringComparison comparison) + { + throw new PlatformNotSupportedException(); + } + + public bool IsAscii() + { + throw new PlatformNotSupportedException(); + } + + public bool IsNormalized(NormalizationForm normalizationForm = NormalizationForm.FormC) + { + throw new PlatformNotSupportedException(); + } + + [EditorBrowsable(EditorBrowsableState.Never)] + public ref readonly byte GetPinnableReference() + { + throw new PlatformNotSupportedException(); + } + + public override string ToString() + { + throw new PlatformNotSupportedException(); + } + + internal unsafe string ToStringNoReplacement() + { + throw new PlatformNotSupportedException(); + } + + public Utf8String ToUtf8String() + { + throw new PlatformNotSupportedException(); + } + + [MethodImpl(MethodImplOptions.AggressiveInlining)] + public static Utf8Span UnsafeCreateWithoutValidation(ReadOnlySpan buffer) + { + throw new PlatformNotSupportedException(); + } + } +} diff --git a/src/mono/netcore/System.Private.CoreLib/src/System/Utf8String.cs b/src/mono/netcore/System.Private.CoreLib/src/System/Utf8String.cs new file mode 100644 index 0000000000000..ebb787a56e749 --- /dev/null +++ b/src/mono/netcore/System.Private.CoreLib/src/System/Utf8String.cs @@ -0,0 +1,112 @@ +// Licensed to the .NET Foundation under one or more agreements. +// The .NET Foundation licenses this file to you under the MIT license. +// See the LICENSE file in the project root for more information. + +using System.Buffers; +using System.ComponentModel; +using System.Diagnostics; +using System.Diagnostics.CodeAnalysis; +using System.Runtime.CompilerServices; +using System.Text; +using System.Text.Unicode; +using Internal.Runtime.CompilerServices; + +#pragma warning disable SA1121 // explicitly using type aliases instead of built-in types +#if TARGET_64BIT +using nint = System.Int64; +using nuint = System.UInt64; +#else +using nint = System.Int32; +using nuint = System.UInt32; +#endif + +namespace System +{ + /// + /// Represents an immutable string of UTF-8 code units. + /// + public sealed partial class Utf8String : IComparable, IEquatable + { + public static readonly Utf8String Empty; + public static bool operator ==(Utf8String? left, Utf8String? right) => throw new PlatformNotSupportedException(); + public static bool operator !=(Utf8String? left, Utf8String? right) => throw new PlatformNotSupportedException(); + public static implicit operator Utf8Span(Utf8String? value) => throw new PlatformNotSupportedException(); + + public int Length => throw new PlatformNotSupportedException(); + public Utf8String this[Range range] + { + [MethodImpl(MethodImplOptions.AggressiveInlining)] + get + { + throw new PlatformNotSupportedException(); + } + } + + public int CompareTo(Utf8String? other) + { + throw new PlatformNotSupportedException(); + } + + public int CompareTo(Utf8String? other, StringComparison comparison) + { + throw new PlatformNotSupportedException(); + } + + public override bool Equals(object? obj) + { + throw new PlatformNotSupportedException(); + } + + public bool Equals(Utf8String? value) + { + throw new PlatformNotSupportedException(); + } + + public bool Equals(Utf8String? value, StringComparison comparison) => throw new PlatformNotSupportedException(); + + public static bool Equals(Utf8String? left, Utf8String? right) + { + throw new PlatformNotSupportedException(); + } + + public static bool Equals(Utf8String? a, Utf8String? b, StringComparison comparison) + { + throw new PlatformNotSupportedException(); + } + + public override int GetHashCode() + { + throw new PlatformNotSupportedException(); + } + + public int GetHashCode(StringComparison comparison) + { + throw new PlatformNotSupportedException(); + } + + [EditorBrowsable(EditorBrowsableState.Never)] // for compiler use only + public ref readonly byte GetPinnableReference() => throw new PlatformNotSupportedException(); + + public bool IsAscii() + { + throw new PlatformNotSupportedException(); + } + + public static bool IsNullOrEmpty([NotNullWhen(false)] Utf8String? value) + { + throw new PlatformNotSupportedException(); + } + + public static bool IsNullOrWhiteSpace([NotNullWhen(false)] Utf8String? value) + { + throw new PlatformNotSupportedException(); + } + + public byte[] ToByteArray() => throw new PlatformNotSupportedException(); + + public override string ToString() + { + throw new PlatformNotSupportedException(); + } + } +} From 7d0bbc6e2da5ff132e2017175d62ec12c165474a Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 18 Feb 2020 17:43:23 +0300 Subject: [PATCH 95/96] Remove nint/nunit aliases unused in PNSE version of Utf8Span --- .../System.Private.CoreLib/src/System/Text/Utf8Span.cs | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/mono/netcore/System.Private.CoreLib/src/System/Text/Utf8Span.cs b/src/mono/netcore/System.Private.CoreLib/src/System/Text/Utf8Span.cs index 28b8e297e7422..f3b37c2e952d1 100644 --- a/src/mono/netcore/System.Private.CoreLib/src/System/Text/Utf8Span.cs +++ b/src/mono/netcore/System.Private.CoreLib/src/System/Text/Utf8Span.cs @@ -12,15 +12,6 @@ #pragma warning disable 0809 //warning CS0809: Obsolete member 'Utf8Span.Equals(object)' overrides non-obsolete member 'object.Equals(object)' -#pragma warning disable SA1121 // explicitly using type aliases instead of built-in types -#if TARGET_64BIT -using nint = System.Int64; -using nuint = System.UInt64; -#else -using nint = System.Int32; -using nuint = System.UInt32; -#endif - namespace System.Text { [StructLayout(LayoutKind.Auto)] From 19a5e0452719a2294c7dc6001a34b483a538978e Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 18 Feb 2020 18:10:28 +0300 Subject: [PATCH 96/96] Remove CoreFX.issues.rsp file because it has been cleaned up --- eng/testing/tests.targets | 1 - src/mono/netcore/CoreFX.issues.rsp | 0 2 files changed, 1 deletion(-) delete mode 100644 src/mono/netcore/CoreFX.issues.rsp diff --git a/eng/testing/tests.targets b/eng/testing/tests.targets index 8a660f917e28c..b6a119c599fc0 100644 --- a/eng/testing/tests.targets +++ b/eng/testing/tests.targets @@ -80,7 +80,6 @@ <_rspFile Include="$(TestRspFile)" Condition="'$(TestRspFile)' != ''" /> - <_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues.rsp" /> <_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_mac.rsp" Condition="'$(TargetOS)' == 'OSX'" /> <_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_linux.rsp" Condition="'$(TargetOS)' == 'Linux'" /> <_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_windows.rsp" Condition="'$(TargetOS)' == 'Windows_NT'" /> diff --git a/src/mono/netcore/CoreFX.issues.rsp b/src/mono/netcore/CoreFX.issues.rsp deleted file mode 100644 index e69de29bb2d1d..0000000000000