-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown: unused definitions found #38549
Comments
@xtqqczze do you want to offer a PR? I thought I got the markdown clean, but maybe it's regressed or you have a different linter. |
@danmosemsft I used remark-lint-no-unused-definitions. Does the repo currently run any linters on CI? |
Not for markdown. But we could, if it was easy and reliable (and flagged impactful issues eg broken links) |
@danmosemsft I have two PRs to resolve these linter warnings:
|
@danmosemsft super-linter looks like it has a lot of dependencies, we could just use an action based on markdownlint-cli (this is what super-linter does). |
@xtqqczze as mentioned above, to add a linter it would at a minimum have to be totally reliable, and it would have to flag issues we care about (some markdown lint issues are things like inconsistent indent of headings which make no visual difference). If you think we should consider markdownlint-cli perhaps you could open a new issue to discuss. |
We would first need to replace invalid inline HTML like |
The text was updated successfully, but these errors were encountered: