Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code extension tool check should be === not >= #2398

Closed
brettfo opened this issue Oct 28, 2022 · 2 comments · Fixed by #2644
Closed

VS Code extension tool check should be === not >= #2398

brettfo opened this issue Oct 28, 2022 · 2 comments · Fixed by #2644

Comments

@brettfo
Copy link
Member

brettfo commented Oct 28, 2022

When the extension is installing the backing tool, the comparison should be === not >=; i.e., ensure exact version match.

@AbhitejJohn
Copy link
Contributor

@brettfo : What is the impact of this? Would this only affect customers installing a private vsix in certain niche scenarios?

@brettfo
Copy link
Member Author

brettfo commented Jan 5, 2023

That's what initially led to the discovery of this, but it's also an issue if somebody rolls back their extension to a previous version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants