Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASP.NET Core Extensions and Generic host removed /7 #33235

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

Rick-Anderson
Copy link
Contributor

@Rick-Anderson Rick-Anderson commented Aug 2, 2024

@Rick-Anderson
Copy link
Contributor Author

Rick-Anderson commented Aug 2, 2024

@mkArtakMSFT please assign a reviewer.
@BrennanConroy can you recommend a reviewer?

@Rick-Anderson Rick-Anderson changed the title Update for minimal host ASP.NET Core Extensions and Generic host removed Aug 13, 2024
@Rick-Anderson Rick-Anderson changed the title ASP.NET Core Extensions and Generic host removed ASP.NET Core Extensions and Generic host removed /7 Sep 3, 2024
Copy link
Member

@mkArtakMSFT mkArtakMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The WebApplicationBuilder change looks good. I'm not certain about the second second paragraph of the change - whether we should actually remove the extensions note or not.

@halter73 should it be removed or should it stay as is?

Copy link
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second paragraph doesn't make much sense in the "Install the preview site extension" section.

At some point, we should probably mention the "ASP.NET Core Logging Integration" site extension which is the actual thing installed by VS that "enables additional functionality for ASP.NET Core on Azure App Services, such as enabling Azure logging", but what's currently there looks wrong. And since VS adds this automatically, documentation suggesting adding it manually should probably be in the "Publish with the CLI" section rather than the overview.

And this doesn't make sense in the context of manually installing a preview "ASP.NET Core {Version} Runtime" site extension which doesn't add additional functionality at all. It's necessary when deploying non-self-contained builds relying on preview runtimes with or without VS. Otherwise, you'll get a "HTTP Error 500.31 - ANCM Failed to Find Native Dependencies"

@Rick-Anderson Rick-Anderson merged commit d77c5a3 into main Sep 19, 2024
3 checks passed
@Rick-Anderson Rick-Anderson deleted the Rick-Anderson-patch-7 branch September 19, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update Azure do for minimal host: When an app uses the Generic Host,
3 participants