Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No support for clojure ratio type #28

Closed
pangloss opened this issue Dec 22, 2020 · 3 comments
Closed

No support for clojure ratio type #28

pangloss opened this issue Dec 22, 2020 · 3 comments

Comments

@pangloss
Copy link

Instead of showing a ratio like 1/3 it just shows #ratio[2]
@djblue
Copy link
Owner

djblue commented Dec 22, 2020

Hi @pangloss, thanks for reporting the issue. This should be a pretty easy fix, just need to account for this type of tagged value here and implement a ratio renderer. Do you have any interest in submitting a PR?

@pangloss
Copy link
Author

Hi, sorry I'm busy with a couple of other projects so don't think I'll have time to do the PR. Was just trying out the project, and it looks very nice and useful.

By the way I took a quick look at the code you linked and was surprised you didn't use a multimethod for that part since it seems like a good way to make the system more user-extensible. Anyway, thanks for putting together a useful tool!

@djblue
Copy link
Owner

djblue commented Dec 24, 2020

No worries, 0b44c76 should fix it.

@djblue djblue closed this as completed Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pangloss @djblue