Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options for specifying port and host of launched UI #19

Merged
merged 5 commits into from
Oct 26, 2020
Merged

Add options for specifying port and host of launched UI #19

merged 5 commits into from
Oct 26, 2020

Conversation

justone
Copy link
Contributor

@justone justone commented Oct 19, 2020

No description provided.

@justone
Copy link
Contributor Author

justone commented Oct 19, 2020

I was able to test both the JVM and Node runners. A couple of questions remain:

  1. I don't think anything has to be done for the "web" launcher, is that correct?
  2. Since the web server is only started once, the port option is essentially ignored for subsequent open calls. This could be a point of confusion. Should the code could print a warning that calling close and then open again is necessary to change the port?

@djblue
Copy link
Owner

djblue commented Oct 19, 2020

@justone You are correct, the "web" launcher doesn't need a port option. For 2, I'm not sure what we should do here 🤔

@djblue djblue merged commit 67060fd into djblue:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justone @djblue