Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should it work on windows? #12

Closed
MrGung opened this issue Aug 30, 2020 · 8 comments
Closed

Should it work on windows? #12

MrGung opened this issue Aug 30, 2020 · 8 comments

Comments

@MrGung
Copy link

MrGung commented Aug 30, 2020

I am using Windows 10, starting portal in the REPL with

clojure -Sdeps '{:deps {djblue/portal {:mvn/version """"""0.4.0""""""}}}'

I then follow the example from the webpage:

Clojure 1.10.1
user=> (require '[portal.api :as p])
nil
user=> (p/open)
nil
user=> (p/tap)
nil
user=> (tap> :hello)

A browser-tab is opened (on p/open) but nothing is ever displayed. The window stays blank...

@djblue
Copy link
Owner

djblue commented Aug 30, 2020

It should. Can you try version 0.3.1 and see if that works?

@MrGung
Copy link
Author

MrGung commented Aug 31, 2020

It works fine with 0.3.1!

@djblue
Copy link
Owner

djblue commented Aug 31, 2020

I had to add a custom http server to support babashka. I only tested it on osx and linux. Guess it doesn't work on windows.

What browser does it open in? Also, can you get any information about network activity in the browser debug tools?

@djblue
Copy link
Owner

djblue commented Sep 1, 2020

Should be fixed by e13a9d9 and released in 0.4.1.

@MrGung
Copy link
Author

MrGung commented Sep 1, 2020

It opens in my default browser, which is Opera. I also copied the URL to Chrome. Same result: the only network-traffic is a GET for the favicon (which results in a 404).

@djblue
Copy link
Owner

djblue commented Sep 1, 2020

Does 0.4.1 work for you?

@MrGung
Copy link
Author

MrGung commented Sep 1, 2020

It does. Thanks!

@djblue
Copy link
Owner

djblue commented Sep 1, 2020

Sweet, thanks for the bug report!

@djblue djblue closed this as completed Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants