docs: Enhance /rest README #7757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
almeidx
reviewed
Apr 7, 2022
Co-authored-by: Almeida <almeidx@pm.me>
DTrombett
reviewed
Apr 7, 2022
|
Isn't it better to use CommonJS? |
|
No, it's not. We simply support CommonJS because it's legacy, and both CJS and ESM can load it, while only ESM can (conveniently) load ESM. ESM is superior in many ways, and personally, if you can use it, you should use it. |
|
If this is going with ESM syntax why not make use of top-level await |
SpaceEEC
approved these changes
Apr 9, 2022
FnrDev
reviewed
Apr 10, 2022
kyranet
approved these changes
Apr 10, 2022
vladfrangu
approved these changes
Apr 11, 2022
iCrawl
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Enhances rest's README akin to the other packages. As a note, the main documentation has been linked instead of stable as it is not yet released.
Status and versioning classification: