fix(build): update to support strictBuiltinIteratorReturn #10394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
I've filed this as a Draft PR in the event there are any other changes to microsoft/TypeScript#58243 that must be addressed. Once that PR has merged, I will mark this PR as "Ready for review". |
|
Duplicate of #10260. I don't mind which is kept. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10394 +/- ##
=======================================
Coverage 50.91% 50.91%
=======================================
Files 228 228
Lines 20750 20750
Branches 1258 1258
=======================================
Hits 10565 10565
Misses 10141 10141
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rbuckton
requested review from
ckohen,
vladfrangu,
iCrawl,
kyranet,
didinele,
Jiralite and
suneettipirneni
ckohen
approved these changes
Jul 19, 2024
Renegade334
suggested changes
Jul 19, 2024
almeidx
approved these changes
Jul 21, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
didinele
approved these changes
Jul 28, 2024
vladfrangu
approved these changes
Jul 28, 2024
kyranet
approved these changes
Jul 28, 2024
suneettipirneni
approved these changes
Jul 28, 2024
SpaceEEC
approved these changes
Aug 19, 2024
Co-authored-by: René <9092381+Renegade334@users.noreply.github.com>
nyapat
pushed a commit
to nyapat/discord.js
that referenced
this pull request
Sep 9, 2024
…10394) * fix(build): update to support strictBuiltinIteratorReturn * types: assert Value to be identical to InitialValue Co-authored-by: René <9092381+Renegade334@users.noreply.github.com> --------- Co-authored-by: ckohen <chaikohen@gmail.com> Co-authored-by: René <9092381+Renegade334@users.noreply.github.com> Co-authored-by: Almeida <github@almeidx.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This updates the build to be forwards compatible with microsoft/TypeScript#58243, which uses a stricter return type for built-in iterators under the new
strictBuiltinIteratorReturnoption, which is enabled by default when building withstrict.Status and versioning classification: