Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(WebSocketShard): explicit time out network error handling #10375

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

didinele
Copy link
Member

@didinele didinele commented Jul 2, 2024

This makes it so we try reconnecting for this error code.

@didinele didinele requested a review from a team as a code owner July 2, 2024 19:26
Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jul 2, 2024 7:29pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jul 2, 2024 7:29pm

@Jiralite Jiralite added this to the ws 2.0.0 milestone Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.37%. Comparing base (ab8bf0f) to head (1b827a0).

Files Patch % Lines
packages/ws/src/ws/WebSocketShard.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10375   +/-   ##
=======================================
  Coverage   50.37%   50.37%           
=======================================
  Files         228      228           
  Lines       20641    20644    +3     
  Branches     1240     1240           
=======================================
+ Hits        10397    10400    +3     
  Misses      10199    10199           
  Partials       45       45           
Flag Coverage Δ
ws 51.99% <80.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit 093ac92 into main Jul 2, 2024
27 checks passed
@kodiakhq kodiakhq bot deleted the feat/handle-etimedout branch July 2, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants