Fix backbone version #9151
Merged
Fix backbone version #9151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gross, ok thanks for that. i had figured all those minor changes would just be bug fixes |
|
Yeah I would have assumed that too :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @nickpell
There was a bug in cloudcare. A bisect revealed that it was introduced here: 45c8bcf. It looks like the bower conf changed from version
0.9.1to~0.9.1(meaning the latest version in the0.9range, which for the backbone package resolves to0.9.10). However, it looks like backbone doesn't use semantic versioning, so there were breaking changes introduced between0.9.1and0.9.10@benrudolph, I noticed that you switched all our packages to use version ranges with
~. I think we should revert all of those unless we confirm that the packages conform to semantic versioning. Any objection?