From 9bb1299fd6a3c621e7f9b673abf5de98fdc7e12a Mon Sep 17 00:00:00 2001 From: Jacob Heun Date: Mon, 21 May 2018 22:41:21 +0200 Subject: [PATCH 1/2] update travis build versions --- .travis.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.travis.yml b/.travis.yml index bb9ece3..110081d 100644 --- a/.travis.yml +++ b/.travis.yml @@ -3,6 +3,11 @@ language: node_js node_js: - 6 - 8 + - 10 + +os: + - linux + - windows # Make sure we have new NPM. before_install: From 4347c3c5c83eb2eafbe3ba3374bf705ffd793ece Mon Sep 17 00:00:00 2001 From: Jacob Heun Date: Mon, 21 May 2018 23:06:04 +0200 Subject: [PATCH 2/2] make callbacks explicit --- src/portable.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/portable.js b/src/portable.js index a3bdec6..7f68544 100644 --- a/src/portable.js +++ b/src/portable.js @@ -20,7 +20,7 @@ module.exports = function lockPortable (name, callback) { } cb() }), - (cb) => fs.open(name, 'w+', cb), + (cb) => fs.open(name, 'w+', (err, fd) => cb(err, fd)), (fd, cb) => { fs.write(fd, JSON.stringify({ ownerPID: process.pid @@ -54,7 +54,9 @@ function processLockfile (name, callback) { case STATUS.LOCKED: return callback(new Error(`file ${name} already locked`)) case STATUS.STALE: - return fs.unlink(name, callback) + return fs.unlink(name, (err) => { + callback(err) + }) case STATUS.INVALID: return callback(new Error(`can't lock file ${name}: has invalid content`)) default: