Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Request Implementation #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kabudu
Copy link

@kabudu kabudu commented Nov 1, 2018

@pedanticantic
Copy link

Hi there, thank you for the pull request.

I'm so sorry it's taken so long to respond.

I think you're changes are basically okay - changing the syntax of the array initialisation is fine. However, I think there needs to be a little bit of documentation. Specifically:

It's not clear whether the request uses a datacash reference or a merchant reference, or if either will work. It sends "$this->getTransactionReference()" in the request, but it's not clear which of those references can be used. Could you add a comment before that line just to explain what values are accepted?

Could you document the new request in the "Basic Usage" section of the README.md file?

@pedanticantic
Copy link

pedanticantic commented Sep 17, 2019

I've just checked what "getTransactionReference()" returns, and it's the datacash_reference.

Therefore, could you document in the request class and in the README.md that it only passes the datacash_reference? Thanks!

Once you've done that, we'll merge it in and create a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants