Make changes to the PlaySound action #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add documentation and examples. - Implement the action for other platforms using PyAudio. - Make the action play sound synchronously instead because it avoids having to handle file queues and errors from other threads.
drmfinlay
added
Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation and examples.
Re: Missing documentation #77.
Implement the action for other platforms using PyAudio.
I've tested that the action works perfectly on Windows, Mac OS and Linux-based systems.
pyaudiois effectively a soft-dependency on platforms other than Windows.PlaySoundwill raise an error when executed ifpyaudioisn't installed.Make the action play sound synchronously instead because it avoids having to handle file queues and errors from other threads.
Although this PR removes the last internal use of
dragonfly/os_dependent_mock.py, I'm leaving it in because Caster's tests make use of the file'sMockActionclass.