From cbcc800a6bfc95293600015796302eef804874f4 Mon Sep 17 00:00:00 2001 From: Quynh Nguyen <43350163+qn895@users.noreply.github.com> Date: Sun, 2 May 2021 21:34:43 -0500 Subject: [PATCH] [ML] Remove versioning check for Analytics list row expansion content functional tests (#98828) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> --- .../data_frame_analytics/classification_creation.ts | 8 -------- .../outlier_detection_creation.ts | 8 -------- .../ml/data_frame_analytics/regression_creation.ts | 8 -------- .../services/ml/data_frame_analytics_table.ts | 11 ++++------- 4 files changed, 4 insertions(+), 31 deletions(-) diff --git a/x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation.ts b/x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation.ts index e09e147c28f47a..1c1c5d956aae88 100644 --- a/x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation.ts +++ b/x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation.ts @@ -85,14 +85,6 @@ export default function ({ getService }: FtrProviderContext) { }, { section: 'progress', expectedEntries: { Phase: '8/8' } }, ], - jobStats: [ - { - section: 'stats', - expectedEntries: { - version: '8.0.0', - }, - }, - ], } as AnalyticsTableRowDetails, }, }, diff --git a/x-pack/test/functional/apps/ml/data_frame_analytics/outlier_detection_creation.ts b/x-pack/test/functional/apps/ml/data_frame_analytics/outlier_detection_creation.ts index 332819f8a5f7b4..62c506e06d7e6f 100644 --- a/x-pack/test/functional/apps/ml/data_frame_analytics/outlier_detection_creation.ts +++ b/x-pack/test/functional/apps/ml/data_frame_analytics/outlier_detection_creation.ts @@ -100,14 +100,6 @@ export default function ({ getService }: FtrProviderContext) { }, { section: 'progress', expectedEntries: { Phase: '4/4' } }, ], - jobStats: [ - { - section: 'stats', - expectedEntries: { - version: '8.0.0', - }, - }, - ], } as AnalyticsTableRowDetails, }, }, diff --git a/x-pack/test/functional/apps/ml/data_frame_analytics/regression_creation.ts b/x-pack/test/functional/apps/ml/data_frame_analytics/regression_creation.ts index b3603988e5b8fc..692de607c7d368 100644 --- a/x-pack/test/functional/apps/ml/data_frame_analytics/regression_creation.ts +++ b/x-pack/test/functional/apps/ml/data_frame_analytics/regression_creation.ts @@ -78,14 +78,6 @@ export default function ({ getService }: FtrProviderContext) { }, { section: 'progress', expectedEntries: { Phase: '8/8' } }, ], - jobStats: [ - { - section: 'stats', - expectedEntries: { - version: '8.0.0', - }, - }, - ], } as AnalyticsTableRowDetails, }, }, diff --git a/x-pack/test/functional/services/ml/data_frame_analytics_table.ts b/x-pack/test/functional/services/ml/data_frame_analytics_table.ts index b499ce31ea2dac..0ffb274d28b509 100644 --- a/x-pack/test/functional/services/ml/data_frame_analytics_table.ts +++ b/x-pack/test/functional/services/ml/data_frame_analytics_table.ts @@ -16,7 +16,7 @@ export interface ExpectedSectionTable { expectedEntries: ExpectedSectionTableEntries; } -export type AnalyticsTableRowDetails = Record<'jobDetails' | 'jobStats', ExpectedSectionTable[]>; +export type AnalyticsTableRowDetails = Record<'jobDetails', ExpectedSectionTable[]>; export function MachineLearningDataFrameAnalyticsTableProvider({ getService }: FtrProviderContext) { const find = getService('find'); const retry = getService('retry'); @@ -395,14 +395,11 @@ export function MachineLearningDataFrameAnalyticsTableProvider({ getService }: F } } - public async assertJobStatsTabContent(jobId: string, sections: ExpectedSectionTable[]) { + public async assertJobStatsTabContent(jobId: string) { const tabSubject = 'job-stats'; await this.ensureDetailsTabOpen(jobId, tabSubject); await this.assertDetailsSectionExists(jobId, 'stats'); - - for (const { section, expectedEntries } of sections) { - await this.assertRowDetailsSectionContent(jobId, section, expectedEntries); - } + await this.assertDetailsSectionExists(jobId, 'analysisStats'); } public async assertJsonTabContent(jobId: string) { @@ -431,7 +428,7 @@ export function MachineLearningDataFrameAnalyticsTableProvider({ getService }: F 'job-messages', ]); await this.assertJobDetailsTabContent(jobId, expectedRowDetails.jobDetails); - await this.assertJobStatsTabContent(jobId, expectedRowDetails.jobStats); + await this.assertJobStatsTabContent(jobId); await this.assertJsonTabContent(jobId); await this.assertJobMessagesTabContent(jobId); });