Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve assertions #37

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Improve assertions #37

merged 1 commit into from
Dec 22, 2020

Conversation

peter279k
Copy link
Contributor

Changed log

  • Using the assertFalse to assert expected is false.
  • Using the assertNull to assert expected is null.

@peter279k
Copy link
Contributor Author

It seems that the static analysis has been the issue about No error to ignore is reported on line 256. on Data.php because it doesn't report the // @phpstan-ignore-next-line issue.

I think it should be removed and it should another PR.

colinodell
colinodell approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@colinodell colinodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. I'll submit a separate PR to remove the PHPStan comment now that it properly detects the behavior of that code.

@simensen simensen merged commit 40e95db into dflydev:main Dec 22, 2020
@peter279k peter279k deleted the test_enhancement branch December 24, 2020 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinodell colinodell colinodell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peter279k @colinodell @simensen