From 00a25d30b5f1eeeb1893272a569aa5f004fdcb40 Mon Sep 17 00:00:00 2001 From: prakhar katiyar Date: Mon, 12 Aug 2024 13:54:04 +0530 Subject: [PATCH] default PipelineType given --- pkg/pipeline/BuildPipelineConfigService.go | 10 ++++++++++ pkg/pipeline/bean/CiPipeline/CiBuildConfig.go | 3 +++ 2 files changed, 13 insertions(+) diff --git a/pkg/pipeline/BuildPipelineConfigService.go b/pkg/pipeline/BuildPipelineConfigService.go index dd4e570d53c..225fb5f3152 100644 --- a/pkg/pipeline/BuildPipelineConfigService.go +++ b/pkg/pipeline/BuildPipelineConfigService.go @@ -285,6 +285,16 @@ func (impl *CiPipelineConfigServiceImpl) patchCiPipelineUpdateSource(baseCiConfi impl.logger.Errorw("error in fetching pipeline", "id", modifiedCiPipeline.Id, "err", err) return nil, err } + // updating PipelineType from db if not present in request + if modifiedCiPipeline.PipelineType == "" { + if CiPipeline.PipelineType(pipeline.PipelineType) != "" { + modifiedCiPipeline.PipelineType = CiPipeline.PipelineType(pipeline.PipelineType) + } else { + // updating default pipelineType if not present in request + modifiedCiPipeline.PipelineType = CiPipeline.DefaultPipelineType + + } + } if !modifiedCiPipeline.PipelineType.IsValidPipelineType() { impl.logger.Debugw(" Invalid PipelineType", "PipelineType", modifiedCiPipeline.PipelineType) errorMessage := fmt.Sprintf(CiPipeline.PIPELINE_TYPE_IS_NOT_VALID, modifiedCiPipeline.Name) diff --git a/pkg/pipeline/bean/CiPipeline/CiBuildConfig.go b/pkg/pipeline/bean/CiPipeline/CiBuildConfig.go index 44498619686..ef24b43410f 100644 --- a/pkg/pipeline/bean/CiPipeline/CiBuildConfig.go +++ b/pkg/pipeline/bean/CiPipeline/CiBuildConfig.go @@ -32,6 +32,9 @@ const PIPELINE_TYPE_IS_NOT_VALID = "PipelineType is not valid for pipeline %s" type PipelineType string +// default PipelineType +const DefaultPipelineType = CI_BUILD + const ( CI_BUILD PipelineType = "CI_BUILD" LINKED PipelineType = "LINKED"