Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new charts having functionality of pod-affinity and pod-antiaffinity in deployment, rollout and sts charts. #5379

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jatin2604
Copy link

Description

This PR introduces the ability to apply Pod Affinity and Anti-Affinity rules to our Kubernetes deployments, enhancing the scheduling flexibility and resilience of our applications. The changes include:

Features

Pod Affinity and Anti-Affinity Functionality:

Added support for both Pod Affinity and Anti-Affinity in the deployment rollout and StatefulSet (STS) Helm charts.
Users can now define affinity rules based on multiple key values, providing more granular control over pod placement.

Helm Chart Modifications:

Updated the deployment rollout and StatefulSet Helm charts to include configurations for pod affinity and anti-affinity.
Ensured backward compatibility so that existing deployments without affinity configurations remain unaffected.
Values.yaml Changes:

Introduced new fields in values.yaml to allow users to specify affinity and anti-affinity rules.
Documented examples in values.yaml to guide users on how to leverage these new features effectively.

Spec:
  Affinity:
    NodeAffinity:
      Key: null
      Values: ["instancegroup1" ]
    PodAffinity:
      Key: null
      Values: [ "my-app" ]
    PodAntiAffinity:
      Key: null
      Values: [ "my-app" ]

Benefits:

Improved Scheduling:

Allows for more flexible and efficient pod scheduling, improving resource utilization and application performance.

Enhanced Resilience:

Ensures better fault tolerance by enabling rules that spread pods across different nodes or zones.

Greater Control:

Provides users with the ability to define complex affinity and anti-affinity rules, tailoring pod placement to specific needs and requirements.

Testing and Validation:

Thoroughly tested the new functionality with various configurations to ensure stability and correctness.
Validated that the changes do not impact existing deployments without affinity rules.

Please review the changes and provide feedback. Thank you!

Copy link

gitguardian bot commented Jun 27, 2024

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9257608 Triggered Base64 AWS keys 18bfd81 scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/test-values.json View secret
2763127 Triggered Generic High Entropy Secret 18bfd81 scripts/devtron-reference-helm-charts/reference-chart_4-19-0/secrets-test-values.yaml View secret
2763127 Triggered Generic High Entropy Secret 18bfd81 scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/secrets-test-values.yaml View secret
2763127 Triggered Generic High Entropy Secret 18bfd81 scripts/devtron-reference-helm-charts/statefulset-chart_5-2-0/secrets-test-values.yaml View secret
141558 Triggered Generic High Entropy Secret 18bfd81 scripts/devtron-reference-helm-charts/statefulset-chart_5-2-0/env-values.yaml View secret
141558 Triggered Generic High Entropy Secret 18bfd81 scripts/devtron-reference-helm-charts/reference-chart_4-19-0/env-values.yaml View secret
141558 Triggered Generic High Entropy Secret 18bfd81 scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/env-values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant