From 212f4d1282af3e3b3c13cf866c8a88a6f3064cc2 Mon Sep 17 00:00:00 2001 From: Steven Lambert Date: Mon, 18 Nov 2019 08:52:50 -0700 Subject: [PATCH] fix(is-icon-ligature): ignore whitespace characters --- lib/commons/text/is-icon-ligature.js | 2 +- test/commons/text/is-icon-ligature.js | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/commons/text/is-icon-ligature.js b/lib/commons/text/is-icon-ligature.js index 00564561d9..ceae98fbef 100644 --- a/lib/commons/text/is-icon-ligature.js +++ b/lib/commons/text/is-icon-ligature.js @@ -72,7 +72,7 @@ text.isIconLigature = function( * │ │█│█│█│█│█│█│█│█│█│█│█│█│█│ │ * └─┴─┴─┴─┴─┴─┴─┴─┴─┴─┴─┴─┴─┴─┴─┘ */ - const nodeValue = textVNode.actualNode.nodeValue; + const nodeValue = textVNode.actualNode.nodeValue.trim(); // text with unicode or non-bmp letters cannot be ligature icons if ( diff --git a/test/commons/text/is-icon-ligature.js b/test/commons/text/is-icon-ligature.js index 4b5e755a93..e34f18c162 100644 --- a/test/commons/text/is-icon-ligature.js +++ b/test/commons/text/is-icon-ligature.js @@ -121,6 +121,13 @@ describe('text.isIconLigature', function() { } ); + (fontApiSupport ? it : it.skip)('should trim the string', function() { + var target = queryFixture( + '
fflu shot
' + ); + assert.isFalse(isIconLigature(target.children[0])); + }); + (fontApiSupport ? it : it.skip)( 'should return true for a font that has no character data', function() {