Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Paket for dotnet project #2190

Open
vbshift opened this issue Feb 12, 2019 · 21 comments
Open

Support Paket for dotnet project #2190

vbshift opened this issue Feb 12, 2019 · 21 comments
Labels
core 🍏 Relates to the dependabot-core library itself Keep Exempt this from being marked by stalebot service 💁 Relates to Dependabot features GitHub provides T: feature-request Requests for new features T: new-ecosystem Requests for new ecosystems/languages

Comments

@vbshift
Copy link

vbshift commented Feb 12, 2019

Do you plan to support Paket for dotnet project ?

Thank

@greysteil
Copy link
Contributor

Yes! It's not on our immediate roadmap, but we definitely want to add support in future. I'm going to keep this open so others can watch it for updates, and add their voice to adding support.

@haf
Copy link

haf commented May 27, 2019

Since paket is a more mature way of handling dependencies for .net projects, having dependabot read paket.lock from the root would be really great!

@infin8x infin8x transferred this issue from dependabot/feedback Jun 29, 2020
@infin8x infin8x added T: feature-request Requests for new features T: new-ecosystem Requests for new ecosystems/languages and removed T: feature-request Requests for new features labels Jul 2, 2020
@tforkmann
Copy link

Any news on that?

@jurre
Copy link
Member

jurre commented Dec 22, 2020

We've paused accepting new ecosystems into dependabot-core for now, we've described some of our reasoning here: https://github.com/dependabot/dependabot-core/blob/main/CONTRIBUTING.md#contributing-new-ecosystems. So this is not something that will land in the near future unfortunately.

@cdrnet
Copy link

cdrnet commented Dec 31, 2020

Paket is not really a separate ecosystem, it's really NuGet and NuGet packages - it's just a different client and different files that need to be updated. Thanks to the explicit solution level lock files, the implementation could even be simpler for Paket than with raw nuget, for both monitoring and pull requests.

@CumpsD
Copy link

CumpsD commented May 4, 2021

Sad to see only half of an ecosystem is supported. This is not about adding a new one, but making the .NET one more mature.

@da9l
Copy link

da9l commented Aug 3, 2021

@infin8x @jurre I think most of the F# and paket using participants in this discussion would argue that this ticket is incorrectly tagged. Since paket is part of the .net ecosystem this is not a feature request nor a new-ecosystem request. It should really be a bugreport or improvement on the .net ecosystem support in dependabot since it is lacking support for half of the tooling for .net dependency management (paket).

This is in line with the reasoning you are linking to above:

"we want to focus more of our resources on merging improvements to the ecosystems we already support."

Dependabot is already supporting .net and this is an improvement to the .net ecosystem support that will be in line with:

"We aim to provide the best user experience possible for each of these..."

@tknightnd
Copy link

Incorporating Paket into dependency checking would be a fantastic step forward in supporting the .Net ecosystem, and I must agree with @da9l that this is not a request for new ecosystem support, but rather a step towards completion.

Paket is perfectly usable with C# project types: it is not exclusively for F# projects at all. Even nuget.org supports Paket, before Cake. I suspect it's not seeing wider use because its documentation has F# all over it.

Please reconsider, and if you need help I'm sure there's a small army willing and able.

@alexeyshockov
Copy link

Very sad to see that Paket is still no supported, and there are no even plans to support that.

.NET Core (*.csproj) dependency management is complicated, broken in some places and is not fully supported by Dependabot anyway, so Paket would make a lot of sense, since it's simpler and work like NPM, Composer for PHP and other tools, so definitely easier to support.

And it's definitely not a new ecosystem!

@jurre jurre added T: feature-request Requests for new features core 🍏 Relates to the dependabot-core library itself service 💁 Relates to Dependabot features GitHub provides labels Nov 26, 2021
@kncesarini
Copy link

Here's one more vote for this. Crucial for MANY dotnet projects.

@jeffdoolittle
Copy link

Same here. Paket solves a lot of issues with dependency management and we need dependabot support for it asap.

@tforkmann
Copy link

Same!

@ImaginaryDevelopment
Copy link

Closing #1738 potentially removed the direct link from the issue to #1944 which I would think lowers the chance someone picks up that PR and pulls it over the finish line. So if anyone is looking for a PR to assist with on this issue, that may be it.

@exvuma
Copy link

exvuma commented Jan 9, 2022

Hi folks, I recently joined the Dependabot team as a product manager 👋🏻. Just wanted to let you know though we don't have a hard timeline for adding support for Paket right now, we are listening! We're actively working on easing the general path to adding ecosystem support, and I'm hopeful we can loop back soon with the next steps and timelines.

@ImaginaryDevelopment
Copy link

We're holding off the possibility of rolling our own automated scanner for our repos. Almost 2 months later, any progress update for us? @exvuma

@jeffdoolittle
Copy link

Hi @exvuma - any updates on this for us?

@BlythMeister
Copy link

Still no updates?

The dependabot alerts for .net and npm via GitHub has been so useful, it's a shame that half our repos do not alert as they use paket.

@dependabot dependabot deleted a comment from stale bot Aug 23, 2022
@dependabot dependabot deleted a comment from haf Aug 23, 2022
@64J0
Copy link

64J0 commented Jan 11, 2024

Still waiting for paket to be supported 🚀

@voronoipotato
Copy link

Agreed, it would be helpful!

@jonjanego jonjanego added the Keep Exempt this from being marked by stalebot label May 2, 2024
@bremerg-accuity
Copy link

@jonjanego - is there any news on adding support for Paket? We have a quite a few repos that use Paket and the lack of support in Dependabot is increasingly painful. Thanks!

@brettfo
Copy link
Contributor

brettfo commented Jul 15, 2024

@bremerg-accuity I'm the team that owns the NuGet updater.

The short version is that we don't currently have the bandwidth to enable and support the Paket updater and merging a "good enough" updater for paket could quickly fall apart, and enabling a non-complete updater can feel worse than not having an updater at all. We're focusing our efforts on making the csproj/vbproj/fsproj scenarios as solid as we can. I'll leave this issue open, however, for future tracking.

Adding a new file type to the updater (paket.lock) isn't necessarily trivial, and while the code path would likely be something like this...

if file_exists('paket.lock')
  # go down the paket path
else
  # use regular dotnet/nuget updater
end

...there are numerous places that would need to happen and there are some complicated interplays between dependabot and an individual updater where the updater is asked what packages currently exist, what updates are possible, and actually performing the updates.

I used to work on the F# compiler and language services and have some familiarity with Paket and interestingly enough, I was recently dealing with an issue with Artifactory/JFrog NuGet feeds and found that Paket doesn't support those, but I left a comment detailing how I worked around it in this repo in the hopes that the Paket maintainers would be able to use my findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core 🍏 Relates to the dependabot-core library itself Keep Exempt this from being marked by stalebot service 💁 Relates to Dependabot features GitHub provides T: feature-request Requests for new features T: new-ecosystem Requests for new ecosystems/languages
Projects
None yet
Development

Successfully merging a pull request may close this issue.