Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raise_if_not_exists for properties not configurable on CreateBuilder #2564

Closed
vegarsti opened this issue Jun 3, 2024 · 0 comments · Fixed by #2565
Closed

raise_if_not_exists for properties not configurable on CreateBuilder #2564

vegarsti opened this issue Jun 3, 2024 · 0 comments · Fixed by #2565
Labels
bug Something isn't working

Comments

@vegarsti
Copy link
Contributor

vegarsti commented Jun 3, 2024 •
edited
Loading

The CreateBuilder calls apply_properties_to_protocol with raise_if_not_exists set to true.

delta-rs/crates/core/src/operations/create.rs

Line 282 in f2e30a0

true,

This was introduced fairly recently, in #2264.

Could we make raise_if_not_exists configurable on the builder? We are using the with_configuration to add some opaque configuration, using config keys that delta-rs doesn't know about, so we can't upgrade delta-rs.

(I'm pushing a PR for this now.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add raise_if_key_not_exists to CreateBuilder
1 participant
@vegarsti