From ce165707ffde36c670d17ae92da84ea72d536a8f Mon Sep 17 00:00:00 2001 From: "ankit.patil" Date: Wed, 18 Oct 2023 19:29:29 +0530 Subject: [PATCH] HUBS-2080 - changes to rename source_id to sourece_value as we support both id/name in input and persist the same source_value as user inout and keep the source_id as recieved from dct response --- docs/resources/appdata_dsource.md | 2 +- examples/dsource/main.tf | 4 ++-- internal/provider/resource_appdata_dsource.go | 8 ++++++-- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/docs/resources/appdata_dsource.md b/docs/resources/appdata_dsource.md index 34518a9..5beffe8 100644 --- a/docs/resources/appdata_dsource.md +++ b/docs/resources/appdata_dsource.md @@ -111,7 +111,7 @@ resource "delphix_appdata_dsource" "dsource_name" { ## Argument Reference -* `source_id` - (Required) Id of the source to link. +* `source_value` - (Required) Id or Name of the source to link. * `group_id` - (Required) Id of the dataset group where this dSource should belong to. diff --git a/examples/dsource/main.tf b/examples/dsource/main.tf index d22cc70..a3b81ee 100644 --- a/examples/dsource/main.tf +++ b/examples/dsource/main.tf @@ -19,7 +19,7 @@ provider "delphix" { # resource "delphix_appdata_dsource" "test_app_data_dsource" { -# source_id = "1-APPDATA_STAGED_SOURCE_CONFIG-6" +# source_name = "1-APPDATA_STAGED_SOURCE_CONFIG-6" # group_id = "1-GROUP-1" # log_sync_enabled = false # make_current_account_owner = true @@ -52,7 +52,7 @@ provider "delphix" { # } resource "delphix_appdata_dsource" "test_app_data_dsource_second" { - source_id = "1-APPDATA_STAGED_SOURCE_CONFIG-7" + source_name = "1-APPDATA_STAGED_SOURCE_CONFIG-7" group_id = "1-GROUP-1" log_sync_enabled = false make_current_account_owner = true diff --git a/internal/provider/resource_appdata_dsource.go b/internal/provider/resource_appdata_dsource.go index 5e0d8a5..77b9249 100644 --- a/internal/provider/resource_appdata_dsource.go +++ b/internal/provider/resource_appdata_dsource.go @@ -25,7 +25,7 @@ func resourceAppdataDsource() *schema.Resource { Type: schema.TypeString, Optional: true, }, - "source_id": { + "source_value": { Type: schema.TypeString, Required: true, }, @@ -250,6 +250,10 @@ func resourceAppdataDsource() *schema.Resource { Type: schema.TypeString, Computed: true, }, + "source_id": { + Type: schema.TypeString, + Computed: true, + }, "database_type": { Type: schema.TypeString, Computed: true, @@ -390,7 +394,7 @@ func resourceAppdataDsourceCreate(ctx context.Context, d *schema.ResourceData, m if v, has_v := d.GetOk("name"); has_v { appDataDSourceLinkSourceParameters.SetName(v.(string)) } - if v, has_v := d.GetOk("source_id"); has_v { + if v, has_v := d.GetOk("source_value"); has_v { appDataDSourceLinkSourceParameters.SetSourceId(v.(string)) } if v, has_v := d.GetOk("group_id"); has_v {