fix: Getting event logs on Aurora #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirceanis
requested changes
Jan 20, 2022
There was a problem hiding this comment.
Overall it looks good,
But since this is a workaround specific to Aurora,
I'd like us to add some tests to make sure that events are processed as expected when they overlap in the same block.
Example:
- adding 2 services in 2 consecutive blocks should result in only 2 services appearing in the DID doc (no duplication).
- adding and removing a service in the same block should result in no change to the doc (correct order, same block)
- adding and removing a service in 2 consecutive blocks should result in no change to the doc (correct order 2 blocks).
- removing a service and then adding it back in the next block should keep the service visible in the resolved doc (correct order 2 blocks, corner case).
uport-automation-bot
pushed a commit
that referenced
this pull request
Jan 20, 2022
## [5.0.4](5.0.3...5.0.4) (2022-01-20) ### Bug Fixes * broaden window for event logs processing (fix Aurora) ([#149](#149)) ([5ee6bed](5ee6bed))
|
🎉 This PR is included in version 5.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aurora (and maybe some other EVM chains) fail to return event logs if
fromBlockandtoBlockare the same. This PR fixes that by substracting1fromfromBlock