Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New task: datum hash -> datum table #80

Open
SebastienGllmt opened this issue May 26, 2022 · 5 comments
Open

New task: datum hash -> datum table #80

SebastienGllmt opened this issue May 26, 2022 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed task related to Carp tasks

Comments

@SebastienGllmt
Copy link
Contributor

Lots of people want an indexer capable of mapping datum hash to datum. We should be able to create a task for this and then expose it in the server/client after

@SebastienGllmt SebastienGllmt added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed task related to Carp tasks labels May 26, 2022
@MitchTurner
Copy link

Started doing some TDD for this and found that it's painful constructing some of the Pallas types (e.g. TransactionBody) the tasks depend on directly. It looks like the main branch of Pallas makes the fields of the structs pub (at least for TransactionBody) , so it should be easier to construct in the future. Otherwise I might need to decode from CBOR directly in the test helpers :(.

It would be nice if carp had its own domain types for all the primitives rather than depending directly on Pallas. It's always a big undertaking up front to do that, but it would help avoid problems like this.

@MitchTurner
Copy link

MitchTurner commented Jun 17, 2022

Yeah. pallas v0.11.0-alpha.1 has the needed changes. I would recommend waiting until carp/tasks is updated to that version before trying to write the tests for the datum task. It's a non-trivial amount of work to update.

@SebastienGllmt
Copy link
Contributor Author

SebastienGllmt commented Jun 17, 2022

Ideally we would deprecate all of Pallas. Unfortunately it will be very hard and time-consuming to do

@MitchTurner
Copy link

MitchTurner commented Jun 17, 2022

What do you mean by "deprecate"? Swap them out with locally owned domain types?

@SebastienGllmt
Copy link
Contributor Author

Swap it all out with CML once all the CML upgrades are in place. Cardano Multiplatform Lib still has some limitations which means we currently have to use both, but that's kind of awkward and not ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed task related to Carp tasks
Projects
None yet
Development

No branches or pull requests

2 participants