Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For csv format of unit testing, empty strings ("") and "null" both convert to SQL NULL #5476

Open
FishtownBuildBot opened this issue May 9, 2024 · 0 comments
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core improvement Use this when an area of the docs needs improvement as it's currently unclear size: medium This change will take up to a week to address

Comments

@FishtownBuildBot
Copy link

FishtownBuildBot commented May 9, 2024

PR that needs documentation

dbt-labs/dbt-core#9881

🌶️ Hot take, we might consider closing this issue as just a special case of #4867 (which we should resolve!).

Page requiring updates

Not sure the best page(s). Likely one or more of the following:

Part(s) of the page to update

The csv format now works exactly the same as dbt seeds (which are only defined using CSV), so maybe we don't actually need to make any changes as a result of this PR!

More detail

We'd just need to check if there's anywhere in our unit testing docs that we mention blank / empty string values ("").

Overall, we should really just implement #4867 and make sure it covers all of these cases:

  • null values in csv format for unit tests
  • null values in dict format for unit tests
  • null values in sql format for unit tests
  • null values in CSV seeds
  • empty string values in csv format for unit tests
  • empty string values in dict format for unit tests
  • empty string values in sql format for unit tests
  • empty string values in CSV seeds
@runleonarun runleonarun added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear dbt Core The changes proposed in this issue relate to dbt Core labels May 9, 2024
@dbeatty10 dbeatty10 changed the title Docs Changes Needed from dbt-core Issue #9881 For csv format of unit testing, empty strings ("") and "null" both convert to SQL NULL May 9, 2024
@dbeatty10 dbeatty10 changed the title For csv format of unit testing, empty strings ("") and "null" both convert to SQL NULL For csv format of unit testing, empty strings ("") and "null" both convert to SQL NULL May 9, 2024
@nataliefiann nataliefiann added the size: medium This change will take up to a week to address label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core improvement Use this when an area of the docs needs improvement as it's currently unclear size: medium This change will take up to a week to address
Projects
None yet
Development

No branches or pull requests

3 participants