Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/CD Improvements] Migrate to hatch and standardize workflows #1027

Open
17 tasks
mikealfare opened this issue Apr 28, 2024 · 0 comments
Open
17 tasks

[CI/CD Improvements] Migrate to hatch and standardize workflows #1027

mikealfare opened this issue Apr 28, 2024 · 0 comments

Comments

@mikealfare
Copy link
Contributor

mikealfare commented Apr 28, 2024

Short description

As a maintainer, I want to standardize and modernize development tooling, so that I can reduce maintenance issues and focus more on content than form.

Objectives

  • Standardize workflows across all adapters; use dbt-postgres as the pilot
  • Minimize dependencies between workflows
    • Move shared dependencies into actions
  • Reduce GHA footprint in dbt-spark
    • Move repo-agnostic actions into actions repo
    • Move adapter-agnostic actions into dbt-adapters repo
  • Ensure dispatch workflows are idempotent
  • Simplify interactions between trigger events and inputs
  • Migrate to hatch

Acceptance Criteria

Suggestions

  • Use dbt-postgres as a template
  • It's fine to copy paste; it's worth violating DRY for the sake of isolation in a migration of this size

Style standards:

  • Job ids, step ids, and variables are in kebab case
  • Job names, step names, and description fields follow dbt docs standards (capitalize first word only)
  • Extra descriptors should be avoided unless required for disambiguation, e.g.
    • version-number -> version
    • archive-name -> archive
  • Workflow files use a four space tab
  • Scripts (inline or separate files) use environment variables in env instead of inline substitution like ${{ inputs.value }}

Testing

  • New workflows are tested against their dev branch prior to merging

Security

This should not increase security risk, and potentially could reduce it. Any security risks should be addressed as part of dbt-labs/actions#173.

@mikealfare mikealfare changed the title [Feature] Refresh workflows for the pyproject.toml migration [Release Improvements] Refresh workflows for the pyproject.toml migration May 7, 2024
@mikealfare mikealfare changed the title [Release Improvements] Refresh workflows for the pyproject.toml migration [CI/CD Improvements] Migrate to hatch and standardize workflows Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant