Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to embedded-hal v1.0.0 (embedded-can) #6

Open
zpg6 opened this issue Jun 24, 2024 · 3 comments
Open

bump to embedded-hal v1.0.0 (embedded-can) #6

zpg6 opened this issue Jun 24, 2024 · 3 comments

Comments

@zpg6
Copy link

zpg6 commented Jun 24, 2024

embedded-hal has released v1.0.0 which splits the CAN stuff into its own crate embedded-can. Same traits looks like.

embedded-hal v0.27.0 Frame: https://docs.rs/embedded-hal/0.2.7/embedded_hal/can/trait.Frame.html
embedded-can Frame: https://docs.rs/embedded-can/latest/embedded_can/trait.Frame.html

Are you open to bumping this if it is indeed a clean swap? I'd happily contribute the change and test on my esp-rs setup w/ 2 MCP2515s.

@davidcole1340
Copy link
Owner

Would be greatly appreciated if you could test and PR!

One suggestion, I've seen other crates that have embedded-hal 0.x as an optional dependency. Maybe it's also worth doing that here?

@zpg6
Copy link
Author

zpg6 commented Jul 4, 2024

The embedded-can stuff is indeed clean swap, but the bump to embedded-hal v1.0.0 has some breaking changes to SPI traits.

embedded-hal migrating 0.2 to 1.0 docs:
https://github.com/rust-embedded/embedded-hal/blob/master/docs/migrating-from-0.2-to-1.0.md#can-traits

This is a bigger job and maybe a separate preliminary PR.

@snorkman88
Copy link

Hi there!
My Rust knowledge is quite limited but, whenever the changes are in place for embedded-hal 1.0.0 I am happy to test it against my STM32411 and open a PR with an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants