Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: reproduce #67 and #68 #69

Merged
merged 4 commits into from
Aug 16, 2022
Merged

test: reproduce #67 and #68 #69

merged 4 commits into from
Aug 16, 2022

Conversation

davidalpert
Copy link
Owner

No description provided.

@davidalpert davidalpert linked an issue Aug 16, 2022 that may be closed by this pull request
🐛 GetAllGlobal(git-mob.co-author): nonzero exit code: 1: (when soloing) #67
Closed
@davidalpert
fix: return the actual exit code from utils.SilentRun
ba37a40 
enables client code to make a decision based on the available exit code
@davidalpert
fix: expose better error detail from underlying git config calls
4f7cc0e 
for example, the current bug #67 and #68 now reads like this:

    reading co-authors: The section or key is invalid (ret = 1): nonzero exit code: 1: exit status 1

which points more directly to the problem.
@davidalpert davidalpert force-pushed the 67-getallglobalgit-mobco-author-nonzero-exit-code-1-when-soloing branch from dac5456 to 4f7cc0e Compare August 16, 2022 18:51
@davidalpert
fix: ignore missing config keys when getting the current mob
faa110e 
if we don't have the git-mob.co-author key then there is no mob

resolves #67 #68
@davidalpert davidalpert force-pushed the 67-getallglobalgit-mobco-author-nonzero-exit-code-1-when-soloing branch from 14c4f49 to faa110e Compare August 16, 2022 19:02
@davidalpert davidalpert merged commit 6c4b5f0 into main Aug 16, 2022
davidalpert added a commit that referenced this pull request Aug 22, 2022
@davidalpert
Merge pull request #69 from davidalpert/67-getallglobalgit-mobco-auth…
c7b8ae8 
…or-nonzero-exit-code-1-when-soloing

test: reproduce #67 and #68
@davidalpert davidalpert deleted the 67-getallglobalgit-mobco-author-nonzero-exit-code-1-when-soloing branch August 22, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 GetAllGlobal(git-mob.co-author): nonzero exit code: 1: (when soloing)
1 participant
@davidalpert