Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which element to identify its activation comes from to prevent input pasthrough #39

Closed
wongnam opened this issue May 13, 2019 · 11 comments

Comments

@wongnam
Copy link

wongnam commented May 13, 2019

I have just want to know which element to identify its activation comes from to prevent input pasthrough
eg: to prevent input passthrough if the trigger from input node, of course
it will send the command if the trigger is from Alexa.

image

for example:

  • in node-red-contrib-alexa-local i detect the topic is null or not to prevent input pass through.
    image

  • in node-red-contrib-homekit I detect the msg.hap.context is null or not to prevent input pass through.
    image

@wongnam wongnam changed the title Which element to identify its activation comes from to prevent pasthrough Which element to identify its activation comes from to prevent input pasthrough May 13, 2019
@dermm
Copy link

dermm commented May 21, 2019

Hi wongman!
I had semilar problems and decided me to break the passtrough. The Input on the Node is only serves updates the status in Alexa.
Her my fork https://github.com/dermm/node-red-contrib-amazon-echo
If you see the lines that have been changed, you could change it so that it is still passed through with an addition in the payload.

@Barabba11
Copy link

Barabba11 commented May 21, 2019

Hi dermm, thank you for the kind post and really welcome contribute!
Since the author here is not more present (we hope one day to see him back!) are you interested to keep developing his module?
Thank you

I created a list of desidered changes here, please have a look:
#17 (comment)

@wongnam
Copy link
Author

wongnam commented May 22, 2019

Hi wongman!
I had semilar problems and decided me to break the passtrough. The Input on the Node is only serves updates the status in Alexa.
Her my fork https://github.com/dermm/node-red-contrib-amazon-echo
If you see the lines that have been changed, you could change it so that it is still passed through with an addition in the payload.

Thanks @dermm Good news. Let me try it now.

@wongnam
Copy link
Author

wongnam commented May 30, 2019

@dermm how to install it(https://github.com/dermm/node-red-contrib-amazon-echo) on my Node-red?
I have just update by replace 2 files(Index.html and Index.js)
Please also PR to merge it into the original one. Thanks,

image

@wongnam
Copy link
Author

wongnam commented May 30, 2019

@dermm It worked very well, good job. Thanks.
@datech appreciate if you merge this function to your code to improve the using experience.

Thanks.

@jgaret
Copy link

jgaret commented Jun 4, 2019

Hello, how did you manage to modify the files ?
If I do so in my node module, when I restart node red it states that the amazon echo nodes are not recognized.
Is there a command to update something to make it work ?

@wongnam
Copy link
Author

wongnam commented Jun 4, 2019

Just replace 2 files then node-red-stop and node-red-start
image

@datech
Copy link
Owner

datech commented Sep 25, 2019

@wongnam, @dermm Can you confirm that #60 will resolve this?

@wongnam
Copy link
Author

wongnam commented Sep 26, 2019

@datech Hi, I am afraid that I cannot check this node right now. I no longer use this node because it won't handle all my devices if it has more than 20 units.
BTW, Thank for the node.

@Barabba11
Copy link

I guess it's a big of echo, maybe you created names of devices too similar each other. Try to give short unique name, remove.all devices from Amazon account, remove echo from Amazon account, reset echo to factory, add it again and rediscover devices

@datech
Copy link
Owner

datech commented Sep 26, 2019

@wongnam, thanks for the info, I will close the issue then.

BTW, I've just done a test with 70 devices which my Echo Dot 3 managed to discover.

@datech datech closed this as completed Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants