Skip to content
This repository has been archived by the owner on Jul 8, 2021. It is now read-only.

Meaning of these magic numbers? #66

Open
hackfisher opened this issue Sep 3, 2020 · 4 comments
Open

Meaning of these magic numbers? #66

hackfisher opened this issue Sep 3, 2020 · 4 comments
Assignees

Comments

@hackfisher
Copy link
Contributor

#63 (review)

@hackfisher
Copy link
Contributor Author

@clearloop
Copy link
Collaborator

Update: https://github.com/darwinia-network/dj/blob/master/src/api/darwinia.ts#L216

dj/src/api/darwinia.ts

Lines 202 to 216 in 74cfb7f

/**
* Approve block in relayer game
*
* @description
*
* ## permission
* + 7 for root
* + 5 for council
* + 4 for normal account
*
* @param {number} block - block number
* @param {number} perms - permission
* @returns {Promise<ExResult>} the result of `approveBlock` ex
*/
public async approveBlock(block: number, perms: number = 4): Promise<ExResult> {

@freehere107
Copy link

@clearloop Maybe use enum or const to replace code comment will be better

@clearloop
Copy link
Collaborator

@clearloop Maybe use enum or const to replace code comment will be better

Later after the bridger, it will be finished tonight.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants