From 224d19ec06f2eafe421b9f5b7b124c82d6ee92d4 Mon Sep 17 00:00:00 2001 From: pq Date: Mon, 10 Jun 2024 15:00:00 +0000 Subject: [PATCH] [wildcards] `avoid_unused_constructor_parameters` wildcard test Test to ensure that `avoid_unused_constructor_parameters` doesn't overreport in the presence of an unused wildcard param. (Note that underscores are ignored pre-wildcards too and this ensures that that behavior is preserved too.) Fixes: https://github.com/dart-lang/linter/issues/4995 Change-Id: I13ef73eb28cf2501ed292dd3c56c9933a8feefa9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370540 Commit-Queue: Brian Wilkerson Auto-Submit: Phil Quitslund Reviewed-by: Brian Wilkerson --- pkg/linter/test/rule_test_support.dart | 2 +- ...id_unused_constructor_parameters_test.dart | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/pkg/linter/test/rule_test_support.dart b/pkg/linter/test/rule_test_support.dart index 852bc364dd18..9f046896490c 100644 --- a/pkg/linter/test/rule_test_support.dart +++ b/pkg/linter/test/rule_test_support.dart @@ -177,7 +177,7 @@ class PubPackageResolutionTest extends _ContextResolutionTest { bool get dumpAstOnFailures => true; - List get experiments => ['macros']; + List get experiments => ['macros', 'wildcard-variables']; List get lintRules => _lintRules; diff --git a/pkg/linter/test/rules/avoid_unused_constructor_parameters_test.dart b/pkg/linter/test/rules/avoid_unused_constructor_parameters_test.dart index 1d9e3d05f143..30ca42327ac2 100644 --- a/pkg/linter/test/rules/avoid_unused_constructor_parameters_test.dart +++ b/pkg/linter/test/rules/avoid_unused_constructor_parameters_test.dart @@ -63,6 +63,25 @@ class A { class B extends A { B(super.a, super.b); } +'''); + } + + test_wildcardParam() async { + await assertNoDiagnostics(r''' +class C { + C(int _); +} +'''); + } + + test_wildcardParam_preWildcards() async { + await assertNoDiagnostics(r''' +// @dart = 3.4 +// (pre wildcard-variables) + +class C { + C(int _); +} '''); } }