From feead18552c89e6935008e91113b6b9148a93054 Mon Sep 17 00:00:00 2001 From: vinayada1 <28875764+vinayada1@users.noreply.github.com> Date: Fri, 29 Jan 2021 16:09:46 -0800 Subject: [PATCH 1/2] fixes for getting the samples to work --- .../DaprClient/InvokeServiceGrpcExample.cs | 18 +++++++++--------- src/Dapr.Client/DaprClientGrpc.cs | 1 + 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/samples/Client/DaprClient/InvokeServiceGrpcExample.cs b/samples/Client/DaprClient/InvokeServiceGrpcExample.cs index f43e96cc7..9e76b6647 100644 --- a/samples/Client/DaprClient/InvokeServiceGrpcExample.cs +++ b/samples/Client/DaprClient/InvokeServiceGrpcExample.cs @@ -20,21 +20,21 @@ public override async Task RunAsync(CancellationToken cancellationToken) { using var client = new DaprClientBuilder().Build(); - Console.WriteLine("Invoking grpc balance"); - var request = new GetAccountRequest() { Id = "17", }; - var account = await client.InvokeMethodGrpcAsync("grpcsample", "getaccount", request, cancellationToken); - Console.WriteLine($"Received grpc balance {account.Balance}"); - Console.WriteLine("Invoking grpc deposit"); - var data = new GrpcServiceSample.Generated.Transaction() { Id = "17", Amount = 99 }; - account = await client.InvokeMethodGrpcAsync("grpcsample", "deposit", data, cancellationToken); + var deposit = new GrpcServiceSample.Generated.Transaction() { Id = "17", Amount = 99 }; + var account = await client.InvokeMethodGrpcAsync("grpcsample", "deposit", deposit, cancellationToken); Console.WriteLine("Returned: id:{0} | Balance:{1}", account.Id, account.Balance); Console.WriteLine("Completed grpc deposit"); Console.WriteLine("Invoking grpc withdraw"); - var withdraw = new Transaction() { Id = "17", Amount = 10, }; - await client.InvokeMethodGrpcAsync("grpcsample", "withdraw", data, cancellationToken); + var withdraw = new GrpcServiceSample.Generated.Transaction() { Id = "17", Amount = 10, }; + await client.InvokeMethodGrpcAsync("grpcsample", "withdraw", withdraw, cancellationToken); Console.WriteLine("Completed grpc withdraw"); + + Console.WriteLine("Invoking grpc balance"); + var request = new GetAccountRequest() { Id = "17", }; + account = await client.InvokeMethodGrpcAsync("grpcsample", "getaccount", request, cancellationToken); + Console.WriteLine($"Received grpc balance {account.Balance}"); } } } diff --git a/src/Dapr.Client/DaprClientGrpc.cs b/src/Dapr.Client/DaprClientGrpc.cs index 1f8e63cc3..e10f4ac6b 100644 --- a/src/Dapr.Client/DaprClientGrpc.cs +++ b/src/Dapr.Client/DaprClientGrpc.cs @@ -129,6 +129,7 @@ private async Task MakePublishRequest( if (content != null) { envelope.Data = content; + envelope.DataContentType = "application/json"; } if (metadata != null) From 4d55e382bd7a7b6cf9e012820567a02b5addbc97 Mon Sep 17 00:00:00 2001 From: vinayada1 <28875764+vinayada1@users.noreply.github.com> Date: Fri, 29 Jan 2021 16:27:43 -0800 Subject: [PATCH 2/2] add ut --- test/Dapr.Client.Test/PublishEventApiTest.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/Dapr.Client.Test/PublishEventApiTest.cs b/test/Dapr.Client.Test/PublishEventApiTest.cs index 10b9f09b5..90f5b96ec 100644 --- a/test/Dapr.Client.Test/PublishEventApiTest.cs +++ b/test/Dapr.Client.Test/PublishEventApiTest.cs @@ -36,6 +36,7 @@ public async Task PublishEventAsync_CanPublishTopicWithData() var request = await GrpcUtils.GetRequestFromRequestMessageAsync(entry.Request); var jsonFromRequest = request.Data.ToStringUtf8(); + request.DataContentType.Should().Be("application/json"); request.PubsubName.Should().Be(TestPubsubName); request.Topic.Should().Be("test"); jsonFromRequest.Should().Be(JsonSerializer.Serialize(publishData, daprClient.JsonSerializerOptions)); @@ -63,6 +64,7 @@ public async Task PublishEventAsync_CanPublishTopicWithData_WithMetadata() var request = await GrpcUtils.GetRequestFromRequestMessageAsync(entry.Request); var jsonFromRequest = request.Data.ToStringUtf8(); + request.DataContentType.Should().Be("application/json"); request.PubsubName.Should().Be(TestPubsubName); request.Topic.Should().Be("test"); jsonFromRequest.Should().Be(JsonSerializer.Serialize(publishData, daprClient.JsonSerializerOptions));