From 92d9e6d9d847785a5ef230446385dc05f8db3e5e Mon Sep 17 00:00:00 2001
From: JasonJiazhiZhang <21229070+JasonJiazhiZhang@users.noreply.github.com>
Date: Thu, 15 Aug 2019 14:29:52 -0700
Subject: [PATCH] Fix vector env deletion (#185)

Explicitly call close for vector env to avoid issues with file writer prematurely close buffer when tensorboard enabled. See #184 for more info.
---
 habitat_baselines/rl/ppo/ppo_trainer.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/habitat_baselines/rl/ppo/ppo_trainer.py b/habitat_baselines/rl/ppo/ppo_trainer.py
index 5eba415e9e..0339626006 100644
--- a/habitat_baselines/rl/ppo/ppo_trainer.py
+++ b/habitat_baselines/rl/ppo/ppo_trainer.py
@@ -341,6 +341,8 @@ def train(self) -> None:
                     self.save_checkpoint(f"ckpt.{count_checkpoints}.pth")
                     count_checkpoints += 1
 
+            self.envs.close()
+
     def _eval_checkpoint(
         self,
         checkpoint_path: str,
@@ -554,3 +556,5 @@ def _eval_checkpoint(
             {"average success": episode_success_mean},
             checkpoint_index,
         )
+
+        self.envs.close()