From 15565cb952d3ccdd0520b2d58da8381ae804aec0 Mon Sep 17 00:00:00 2001 From: rhee-elten <102012753+rhee-elten@users.noreply.github.com> Date: Thu, 15 Sep 2022 16:01:06 +0900 Subject: [PATCH] FIX: Remove a possibly duplicated encodeURI() (Issue #4428) (#4947) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * FIX: Remove possibly duplicated encodeURI() to prevent double encode non-ascii path (Issue #4428 Cannot connect file share,cannot recognize non-ascii path) * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Boris Sekachev --- CHANGELOG.md | 3 ++- cvat-core/src/server-proxy.ts | 3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7268f099d2f..26cd1cdd784 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,7 +19,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - TDB ### Fixed -- TDB +- Removed a possibly duplicated encodeURI() calls in `server-proxy.ts` to prevent doubly encoding +non-ascii paths while adding files from "Connected file share" (issue #4428) ### Security - TDB diff --git a/cvat-core/src/server-proxy.ts b/cvat-core/src/server-proxy.ts index d4441c63a16..de7b3de43d3 100644 --- a/cvat-core/src/server-proxy.ts +++ b/cvat-core/src/server-proxy.ts @@ -243,13 +243,12 @@ class ServerProxy { async function share(directoryArg) { const { backendAPI } = config; - const directory = encodeURI(directoryArg); let response = null; try { response = await Axios.get(`${backendAPI}/server/share`, { proxy: config.proxy, - params: { directory }, + params: { directory: directoryArg }, }); } catch (errorData) { throw generateError(errorData);