Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modifier preferences support #230

Closed
pokey opened this issue Aug 14, 2021 · 4 comments · Fixed by #235
Closed

Add modifier preferences support #230

pokey opened this issue Aug 14, 2021 · 4 comments · Fixed by #235
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@pokey
Copy link
Member

pokey commented Aug 14, 2021

these preferences would be handled like insideOutsidePreferences

@pokey pokey added the enhancement New feature or request label Aug 14, 2021
@pokey pokey added this to the 1.0.0 milestone Aug 14, 2021
@AndreasArvidsson AndreasArvidsson self-assigned this Aug 15, 2021
@AndreasArvidsson
Copy link
Member

AndreasArvidsson commented Aug 16, 2021

Is this issue just about adding support for the preferences or actually implementing for the above named actions?

For support of selection preference is added in #235

@pokey
Copy link
Member Author

pokey commented Aug 16, 2021

If you have a PR that adds support, and uses it in at least one place, I'd rename this issue and file a new one to track using it in the other actions

@AndreasArvidsson
Copy link
Member

@pokey Yes the clean up pr have support for this
I'm a bit unsure how useful it will be though for drink or pour
post air void => pour token air
post air spam => pour arg air

I guess where its most useful is for functions. pour funk

@AndreasArvidsson AndreasArvidsson changed the title Add modifier preferences support and use to allow "clone", "pour" etc to operate on other scopes Add modifier preferences support Aug 17, 2021
@pokey
Copy link
Member Author

pokey commented Aug 17, 2021

I think "drink" is maybe a bit more useful than "pour". But mostly "pour" just comes along for the ride because it's just easier and more consistent to support it if we're already doing it for "drink" and "clone"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants