Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for number_small performance on old knausj version #1021

Closed
3 of 4 tasks
pokey opened this issue Oct 9, 2022 · 0 comments · Fixed by #1026
Closed
3 of 4 tasks

Workaround for number_small performance on old knausj version #1021

pokey opened this issue Oct 9, 2022 · 0 comments · Fixed by #1026
Labels
bug Something isn't working documentation Improvements or additions to documentation
Milestone

Comments

@pokey
Copy link
Member

pokey commented Oct 9, 2022

The problem

With the release of #987, the DFA performance for Cursorless+knausj went above 1s. We were able to dramatically improve performance by optimising the number_small capture in knausj in talonhub/community#993, but unfortunately it is going to be a bit painful for people to merge knausj, given several recent large changes (eg talonhub/community#947 and talonhub/community#897). In addition, people may not even know that a knausj merge is necessary; they'll just notice that Talon periodically stalls for a DFA recompile and not know why.

The solution

We propose to do the following:

  • Create our own number_small capture and use it instead of the knausj number_small when the Cursorless tag is active
  • Add a tag that allows users to switch to their own number_small capture, in case they have customised it, and only use our custom capture if this tag is disabled (which it will be by default)
  • Add a docs page about how to use a custom number_small, and mentioning DFA performance
  • Detect that users have a custom number_small capture, and pop up a link to docs page
@pokey pokey added bug Something isn't working documentation Improvements or additions to documentation labels Oct 9, 2022
@pokey pokey added this to the 0.27.0 milestone Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant