This repository has been archived by the owner on Nov 18, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 171
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
internal/core/adt: fix overzealous disambiguation
Equality is used to remove duplicate entries in a disjunction. However, it did not consider optional fields. This could lead to differing disjuncts being deleted. The approach we take is to check that any of the original StructLits with optional fields are associated with both Vertices. Note that it is somewhat okay for Equality to return false negatives, as the spec does not guarantee this. At some point we need to come up with something that is more consistent. This change leads to a reopening of Issue #353. Change-Id: I7288061c7d3a51f7a754618c990a14e0275244d0 Reviewed-on: https://cue-review.googlesource.com/c/cue/+/8203 Reviewed-by: CUE cueckoo <cueckoo@gmail.com> Reviewed-by: Paul Jolly <paul@myitcv.org.uk> Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
- Loading branch information
Showing
3 changed files
with
49 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters