internal/core: concreteness errors not reported when conflict errors are present in other values

[verdverm]

What version of CUE are you using (cue version)?

0.4.0

What did you do?

cue eval -c foo.cue
cue vet -c foo.cue

-- foo.cue --
s: "hello"
s: "world"      // conflicting values "hello" and "world"

A: foo: "bar"
a: A.goo        // undefined field

b: int          // incomplete field

m: [1,2]
v: m[2]         // index out of range

I expected all errors for fields which do not interact. Instead I saw a series of errors shown depending on what other errors were found prior.

• conflicting values
• index out of range
• incomplete value

What did you expect to see?

s: conflicting values "world" and "hello":
    ./errors.cue:1:4
    ./errors.cue:2:4
a: undefined field: goo:
    ./errors.cue:5:6
b: incomplete value int
    ./errors.cue:7:4
v: index out of range [2] with length 2:
    ./errors.cue:10:6

What did you see instead?

s: conflicting values "world" and "hello":
    ./errors.cue:1:4
    ./errors.cue:2:4

if s is not present

v: index out of range [2] with length 2:
    ./errors.cue:10:6

if both s and v are not present

b: incomplete value int         // missing line information here
a: undefined field: goo:
    ./errors.cue:5:6

Errors are not in the order they appear. Having them in the same order as they appear in the file would be nice. Probably a separate issue.

[myitcv]

Passing comment: we discussed the different types/categories of errors a good deal whilst considering #822.

[myitcv]

See also the discussion in #1998.

cc @edouard-lopez