From fa1f369cd616d9da12f110ee08f986b36e104730 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Sat, 18 Mar 2023 16:17:46 +0000 Subject: [PATCH] cmd/cue: remove `go install` long tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit These testscripts verify that the `go install` instructions in docs like the README work when using proxy.golang.org. They are quite expensive; even with a warm cache, they take multiple seconds to run, as they do network roundtrips and re-link binaries. That is why they have always been long tests. However, they aren't good tests to keep going forward. We want to start having CI always run all long tests, because otherwise it's far too easy to forget them while testing CLs. Moreover, we will start writing interactive guides in the form of testable scripts which would run these same `go install` commands, so those would already serve the purpose of verifying that installing CUE works in a fully end-to-end way. Signed-off-by: Daniel Martí Change-Id: I9b69ed7ce9295ed8a6738a88aa278b2136250ae6 Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/551228 Reviewed-by: Paul Jolly TryBot-Result: CUEcueckoo --- cmd/cue/cmd/testdata/script/install.txtar | 18 ------------------ .../testdata/script/install_contributing.txtar | 18 ------------------ 2 files changed, 36 deletions(-) delete mode 100644 cmd/cue/cmd/testdata/script/install.txtar delete mode 100644 cmd/cue/cmd/testdata/script/install_contributing.txtar diff --git a/cmd/cue/cmd/testdata/script/install.txtar b/cmd/cue/cmd/testdata/script/install.txtar deleted file mode 100644 index 63bc1902fb4..00000000000 --- a/cmd/cue/cmd/testdata/script/install.txtar +++ /dev/null @@ -1,18 +0,0 @@ -# Test that we can install CUE via the install method described in the project -# README, which requires Go 1.16 or later. -# -# Keep this test in sync with all places that describe install -# instructions. - -[!long] skip 'Install tests use the network and take some time' - -# For this test we want to use the real proxy -env GOPROXY=https://proxy.golang.org - -# Sanity check pre install -! exists $GOPATH/bin/cue - -# Install -go install cuelang.org/go/cmd/cue@latest -exec $GOPATH/bin/cue help -stdout 'cue evaluates CUE files' diff --git a/cmd/cue/cmd/testdata/script/install_contributing.txtar b/cmd/cue/cmd/testdata/script/install_contributing.txtar deleted file mode 100644 index 5782e171a9e..00000000000 --- a/cmd/cue/cmd/testdata/script/install_contributing.txtar +++ /dev/null @@ -1,18 +0,0 @@ -# Test that we can install tools required to contribute to the CUE -# project via the new Go 1.16 method -# -# Keep this test in sync with all places that describe install -# instructions for contributing - -[!long] skip 'Install tests use the network and take some time' - -# For this test we want to use the real proxy -env GOPROXY=https://proxy.golang.org - -# Sanity check pre install -! exists $GOPATH/bin/git-codereview - -# Install -go install golang.org/x/review/git-codereview@latest -exec $GOPATH/bin/git-codereview help -stdout 'Git-codereview is a git helper'