internal/ci: establish better defaults in base

This change should not result in any .github/workflows changes.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I1eea0f513ccd3f1d5a7c6d356b1ad76b66f3cc9d
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/551594
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Unity-Result: CUEcueckoo <cueckoo@cuelang.org>
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>

internal/ci/base/base.cue

@@ -31,32 +31,36 @@
 package base
 
 import (
-	"path"
 	"strings"
 )
 
 // Package parameters
-githubRepositoryURL:          string
-defaultBranch:                string
-testDefaultBranch:            "ci/test"
-botGitHubUser:                string
-botGitHubUserTokenSecretsKey: string
-protectedBranchPatterns: [...string]
-releaseTagPattern: string
+githubRepositoryPath:   *(URLPath & {#url: githubRepositoryURL, _}) | string
+githubRepositoryURL:    *("https://github.com/" + githubRepositoryPath) | string
+gerritHubHostname:      "review.gerrithub.io"
+gerritHubRepositoryURL: *("https://\(gerritHubHostname)/a/" + githubRepositoryPath) | string
+trybotRepositoryPath:   *(githubRepositoryPath + "-" + trybot.key) | string
+trybotRepositoryURL:    *("https://github.com/" + trybotRepositoryPath) | string
 
-linuxMachine:                       string
-gerritHubHostname:                  string
-gerritHubRepositoryURL:             string
-trybotRepositoryURL:                *(githubRepositoryURL + "-" + trybot.key) | string
+defaultBranch:           *"master" | string
+testDefaultBranch:       *"ci/test" | _
+protectedBranchPatterns: *[defaultBranch] | [...string]
+releaseTagPrefix:        *"v" | string
+releaseTagPattern:       *(releaseTagPrefix + "*") | string
+
+botGitHubUser:                      string
+botGitHubUserTokenSecretsKey:       *(strings.ToUpper(botGitHubUser) + "_GITHUB_PAT") | string
 botGitHubUserEmail:                 string
 botGerritHubUser:                   *botGitHubUser | string
-botGerritHubUserPasswordSecretsKey: string
+botGerritHubUserPasswordSecretsKey: *(strings.ToUpper(botGitHubUser) + "_GERRITHUB_PASSWORD") | string
 botGerritHubUserEmail:              *botGitHubUserEmail | string
 
-// Pending cuelang.org/issue/1433, hack around defaulting #gerritHubRepository
-// based on #repository
-let _#repositoryURLNoScheme = strings.Split(githubRepositoryURL, "//")[1]
-gerritHubRepository: *("https://\(gerritHubHostname)/a/" + path.Base(path.Dir(_#repositoryURLNoScheme)) + "/" + path.Base(_#repositoryURLNoScheme)) | _
+linuxMachine: string
+
+codeReview: #codeReview & {
+	github: githubRepositoryURL
+	gerrit: gerritHubRepositoryURL
+}
 
 // Define some shared keys and human-readable names.
 //