Skip to content

Commit

Permalink
Revert "internal/ci: move configuration from workflows.cue to core"
Browse files Browse the repository at this point in the history
This reverts commit 5a0922e.

Reason for revert: automated submit went wrong and submitted CLs out of
order breaking the submission of the chain.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: Ie38f36e846fdbf1e6fd3f1441b0865db8b7789ae
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/551622
Unity-Result: CUEcueckoo <cueckoo@cuelang.org>
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
  • Loading branch information
myitcv committed Mar 26, 2023
1 parent 38156f2 commit 26ff449
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 21 deletions.
18 changes: 5 additions & 13 deletions internal/ci/core/core.cue
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,10 @@ macosMachine: "macos-11"
windowsMachine: "windows-2022"

// Define core URLs that will be used in the codereview.cfg and GitHub workflows
githubRepositoryURL: "https://github.com/cue-lang/cue"
gerritHubHostname: "review.gerrithub.io"
gerritHubRepositoryURL: "https://\(gerritHubHostname)/a/cue-lang/cue"
githubRepositoryPath: "cue-lang/cue"
unityRepositoryURL: "https://github.com/cue-unity/unity"

botGitHubUser: "cueckoo"
botGitHubUserTokenSecretsKey: "CUECKOO_GITHUB_PAT"
botGitHubUserEmail: "cueckoo@gmail.com"
botGerritHubUser: botGitHubUser
botGerritHubUserPasswordSecretsKey: "CUECKOO_GERRITHUB_PASSWORD"
botGerritHubUserEmail: botGitHubUserEmail
githubRepositoryURL: "https://github.com/cue-lang/cue"
gerritRepositoryURL: "https://review.gerrithub.io/a/cue-lang/cue"
githubRepositoryPath: "cue-lang/cue"
unityRepositoryURL: "https://github.com/cue-unity/unity"

// Use the latest Go version for extra checks,
// such as running tests with the data race detector.
Expand Down Expand Up @@ -73,7 +65,7 @@ zeroReleaseTagPattern: "*" + zeroReleaseTagSuffix

codeReview: base.#codeReview & {
github: githubRepositoryURL
gerrit: gerritHubRepositoryURL
gerrit: gerritRepositoryURL
"cue-unity": unityRepositoryURL
}

Expand Down
16 changes: 8 additions & 8 deletions internal/ci/github/workflows.cue
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,12 @@ workflows: close({
_gerrithub: gerrithub & {
#repositoryURL: core.githubRepositoryURL
#trybotKey: _base.trybot.key
#botGitHubUser: core.botGitHubUser
#botGitHubUserTokenSecretsKey: core.botGitHubUserTokenSecretsKey
#botGitHubUserEmail: core.botGitHubUserEmail
#botGerritHubUser: core.botGitHubUser
#botGerritHubUserPasswordSecretsKey: core.botGerritHubUserPasswordSecretsKey
#botGerritHubUserEmail: core.botGitHubUserEmail
#botGitHubUser: "cueckoo"
#botGitHubUserTokenSecretsKey: "CUECKOO_GITHUB_PAT"
#botGitHubUserEmail: "cueckoo@gmail.com"
#botGerritHubUser: #botGitHubUser
#botGerritHubUserPasswordSecretsKey: "CUECKOO_GERRITHUB_PASSWORD"
#botGerritHubUserEmail: #botGitHubUserEmail
}

// _base is an instance of ./base, parameterised by the properties of this
Expand All @@ -74,8 +74,8 @@ _gerrithub: gerrithub & {
_base: base & {
#githubRepositoryURL: core.githubRepositoryURL
#defaultBranch: core.defaultBranch
#botGitHubUser: core.botGitHubUser
#botGitHubUserTokenSecretsKey: core.botGitHubUserTokenSecretsKey
#botGitHubUser: "cueckoo"
#botGitHubUserTokenSecretsKey: "CUECKOO_GITHUB_PAT"
#protectedBranchPatterns: core.protectedBranchPatterns
#releaseTagPattern: core.releaseTagPattern
}

0 comments on commit 26ff449

Please sign in to comment.