-
Notifications
You must be signed in to change notification settings - Fork 243
Upgrade to latest react-router (v4 beta) #356
Comments
Let's hope so! I've been delaying upgrading to RR4 anywhere as there's been so many changes. Yet to find a data loading technique that feels "right" with the new changes. |
I've been working around that bug all weekend. It's so frustrating that they moved the library into a subdirectory so you can't even target the branch to get the latest. |
@carsonperrotti sorry to hear. It does sound like it will land soon though. 🤞 |
I suppose to mitigate this error you should install earlier beta.
don't forget to execute |
@ctrlplusb I have updated my PR to solve this issue. |
@diondirza When I tested earlier versions, I thought the issue still existed in beta 4. Did you not find that to be the case? |
@carsonperrotti nope, I have used beta 4 before and error exist in beta 5. Since new react router using new |
@ctrlplusb @carsonperrotti looks like react-router already release beta-6, looks promising right now. I'm still reviewing though, hopefully won't find another bug in it. My PR also updated as well. |
I have this running on v13. Thank you so much @diondirza for your helpful PR! I will credit you with this. :) We just need to figure out how to return a 404 status code when no Route is matched. |
@ctrlplusb you are welcome, ah I missed that part I thought it wasn't necessary. Anyway I found how to solve that problem and I have send you a PR for it. |
Done! Thanks goes to @diondirza for completing this for us. 🙏 |
@ryanflorence "promises" us that the API in the beta can be considered stable.
SSR checksum is currently broken though. Awaiting remix-run/react-router#4484
The text was updated successfully, but these errors were encountered: