From b4d4a2a2371061aa2129d818fb82dc7a5c61def9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rn=20Friedrich=20Dreyer?= Date: Thu, 13 Jan 2022 11:40:06 +0000 Subject: [PATCH] ignore handled errors when creating spaces MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Jörn Friedrich Dreyer --- changelog/unreleased/ignore-known-erros.md | 5 +++++ .../grpc/services/storageprovider/storageprovider.go | 12 ++++++------ 2 files changed, 11 insertions(+), 6 deletions(-) create mode 100644 changelog/unreleased/ignore-known-erros.md diff --git a/changelog/unreleased/ignore-known-erros.md b/changelog/unreleased/ignore-known-erros.md new file mode 100644 index 0000000000..0d759f541d --- /dev/null +++ b/changelog/unreleased/ignore-known-erros.md @@ -0,0 +1,5 @@ +Enhancement: ignore handled errors when creating spaces + +The CreateStorageSpace no longer logs all error cases with error level logging + +https://github.com/cs3org/reva/pull/2439 \ No newline at end of file diff --git a/internal/grpc/services/storageprovider/storageprovider.go b/internal/grpc/services/storageprovider/storageprovider.go index ad7d5f1171..0de4b1b5ca 100644 --- a/internal/grpc/services/storageprovider/storageprovider.go +++ b/internal/grpc/services/storageprovider/storageprovider.go @@ -507,13 +507,13 @@ func (s *service) CreateStorageSpace(ctx context.Context, req *provider.CreateSt st = status.NewAlreadyExists(ctx, err, "already exists") default: st = status.NewInternal(ctx, "error listing spaces") + appctx.GetLogger(ctx). + Error(). + Err(err). + Interface("status", st). + Interface("request", req). + Msg("failed to create storage space") } - appctx.GetLogger(ctx). - Error(). - Err(err). - Interface("status", st). - Interface("request", req). - Msg("failed to create storage space") return &provider.CreateStorageSpaceResponse{ Status: st, }, nil