Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reva_version="(Unknown)" on latest revad builds #1406

Closed
SamuAlfageme opened this issue Jan 19, 2021 · 2 comments · Fixed by #1413
Closed

reva_version="(Unknown)" on latest revad builds #1406

SamuAlfageme opened this issue Jan 19, 2021 · 2 comments · Fixed by #1413
Labels
bug Something isn't working CI

Comments

@SamuAlfageme
Copy link
Contributor

For some reason, the git output that used to fill these variables:

reva/Makefile

Lines 5 to 8 in 4a9be34

GIT_COMMIT=`git rev-parse --short HEAD`
GIT_BRANCH=`git rev-parse --symbolic-full-name --abbrev-ref HEAD`
GIT_DIRTY=`git diff-index --quiet HEAD -- || echo "dirty-"`
VERSION=`git describe --always`

... is empty:

[salfagem@lxplus765 ~]$ kubectl exec -ti iop-gateway-6fbcd98bb-cgv5k -- /go/bin/revad -version
version= commit= go_version=go1.13.15 build_date=2021-01-15T14:10:42+0000

... which contrast with the version string returned by the reva client (generated on the daily release pipeline):

reva version
version=2021_01_15T150629_47119beffae215190124e98e063f1734b9e75938 commit=47119beffae215190124e98e063f1734b9e75938 go_version=go1.13.15 build_date=2021-01-15

This issue makes the reva_version exposed via revad_sys_info metric to be "(Unknown)"

# HELP revad_sys_info A metric with a constant '1' value labeled by various system information elements
# TYPE revad_sys_info gauge
revad_sys_info{reva_build_date="2021-01-15T14:10:42+0000",reva_version="(Unknown)"} 1
@SamuAlfageme SamuAlfageme added bug Something isn't working CI labels Jan 19, 2021
@SamuAlfageme
Copy link
Contributor Author

Therefore, some of these values are missing on the site information dashboard:

image

cc/ @Daniel-WWU-IT

@Daniel-WWU-IT
Copy link
Contributor

Nothing I can do about this. I use the information that is somehow built into Reva during CI, but if that is empty, I output this "(Unknown)" instead. I guess during all these recent changes to the CI, something must have broken...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants