Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): build-ci and test-ci-push badges #633

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

733amir
Copy link
Contributor

@733amir 733amir commented Sep 24, 2023

Fixes: #631

Description of the change:

  • Edited existing badge from ci.yml to build-ci.yml
  • Added another badge to test-ci-push.yml

Motivation for the change:

  • There was no ci.yml anymore.

How to manually test:

  • Open README.md and click on the badges.

@733amir 733amir changed the title fix build-ci badge; add a badge for test-ci-build fix: build-ci and test-ci-build badges Sep 24, 2023
@733amir 733amir changed the title fix: build-ci and test-ci-build badges fix: build-ci and test-ci-push badges Sep 24, 2023
@tthvo tthvo added the docs label Sep 24, 2023
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing @733amir! Just need to update the file extensions of the workflow files.

Can I also ask you to sign your commits? https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@733amir
Copy link
Contributor Author

733amir commented Sep 24, 2023

Can I also ask you to sign your commits? https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

I have signed my commit. GitHub didn't know about my public key which I added to my profile.

@tthvo
Copy link
Member

tthvo commented Sep 24, 2023

Sounds good! Thanks! Its verified now.

@andrewazores andrewazores changed the title fix: build-ci and test-ci-push badges docs(readme): build-ci and test-ci-push badges Sep 25, 2023
andrewazores and others added 2 commits September 25, 2023 10:32
Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Andrew Azores <me@andrewazor.es>
Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Andrew Azores <me@andrewazor.es>
@andrewazores andrewazores merged commit 7aac9e0 into cryostatio:main Sep 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Task] Update CI badge
3 participants