Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(scorecard): fix missing image tags #615

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Aug 28, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Related to #609

Description of the change:

  • Fixed missing scorecard image tags while pushing to ghcr.io.
  • Also, refactor image tag computing into a separate for the scorecard-test job. This eases future refactoring when we implements /build_test command here.
    • CI tag: ci-${COMMIT_SHA}
    • Pull Request Tag: pr-${PR _NUMBER}-${COMMIT_SHA}

Motivation for the change:

CI Fail: https://github.com/cryostatio/cryostat-operator/actions/runs/6004320255/job/16284655157

Signed-off-by: Thuan Vo <thvo@redhat.com>
@andrewazores andrewazores merged commit 3fe4b93 into cryostatio:main Aug 29, 2023
12 of 13 checks passed
@tthvo tthvo deleted the test-image-push branch August 29, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants