Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(multiarch): produce multiarch scorecard test image #605

Merged
merged 4 commits into from
Aug 16, 2023

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Aug 16, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #604

Here's an example run from my fork: https://github.com/andrewazores/cryostat-operator/actions/runs/5882380118/job/15952785662

scorecard-test push to ghcr.io is still failing because I haven't added a token to my fork's repo secrets, but it appears to have correctly built the multiarch manifest image first and then tried to push that before failing with 403 Unauthorized.

Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for taking care of this!

@andrewazores andrewazores merged commit 58d38b4 into cryostatio:main Aug 16, 2023
23 of 30 checks passed
@andrewazores andrewazores deleted the multiarch-scorecard branch August 16, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

[Task] Build multi-arch custom scorecard images
2 participants