-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datasource): migrate simple-json to infinity datasource, upgrade Angular panels #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
added
chore
Refactor, rename, cleanup, etc.
feat
New feature or request
labels
Jul 8, 2024
andrewazores
changed the title
feat(datasource): migrate from simple-json to infinity datasource"
feat(datasource): migrate from simple-json to infinity datasource
Jul 8, 2024
andrewazores
changed the title
feat(datasource): migrate from simple-json to infinity datasource
feat(datasource): migrate simple-json to infinity datasource, upgrade Angular panels
Jul 8, 2024
7 tasks
aali309
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25
Fixes #60
Current bugs:
1. The main dashboard panels are still placed into rows, but the rows are expanded by default and any chart that is in the viewport when the dashboard loads will try to render, triggering a datasource query, which can be expensive. Updating the dashboard JSON definition to collapse the rows leads to empty collapsed rows and visible panels rendered outside of the rows, but when this happens, expanding the empty row and collapsing it again causes it to "recapture" the chart panels and hide them.On load:
"Expand" Network row:
Collapse Network row:
The object allocation sub-dashboard's query for determining what classes have been allocated (setting theobjectClass
template variable) querys from the Unix epoch0
(ie 1970-01-01-00:00:00) until 1000 years later. The${__timeFrom:date}
and${__timeTo:date}
macros that work in other datasource queries do not seem to work in the template variable query - the macros both always get substituted with the Unix epoch0
, leading to a query with a range of 0 duration, and no samples, therefore an empty dashboard. The 1970-2970 range workaround works fine and will work for most of this millenium, and captures all of the allocated class names, so this is not actually causing any problem.To Test
./build.sh && podman image prune -f
cd cryostat ; ./smoketest.bash -Ot
and wait for it to come upcryostat3:9091
target and "View in Grafana" on one of the existing recordingsBefore:
After: