[1.23] Make storage unmount less strict #6518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/release-note-label-needed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
approved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-1.23 #6518 +/- ##
================================================
- Coverage 43.02% 42.99% -0.03%
================================================
Files 123 123
Lines 12396 12401 +5
================================================
- Hits 5333 5332 -1
- Misses 6556 6560 +4
- Partials 507 509 +2 |
saschagrunert
force-pushed
the
release-1.23-unmount-container-gone
branch
2 times, most recently
from
50f385b
to
bfd88c2
Compare
There are cases where the container storage unmount has been already (partially) done. This would cause `StopContainer()` in `server/container_stop.go:76` fail and therefore make containers get stuck in recreation, making their pods stuck in `NotReady`. We now double check the two c/stroage errors `ErrContainerUnknown` and `ErrLayerUnknown` Somehow related to: containers/podman#11207 (comment) Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
release-1.23-unmount-container-gone
branch
from
bfd88c2
to
260dfc0
Compare
saschagrunert
changed the title
|
@haircommander PTAL, 4.11 got verified. |
|
/test e2e-agnostic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
There are cases where the container storage unmount has been already (partially) done. This would cause
StopContainer()inserver/container_stop.go:76fail and therefore make containers get stuck in recreation, making their pods stuck inNotReady.We now double check the two c/storage errors
ErrContainerUnknownandErrLayerUnknownSomehow related to: containers/podman#11207 (comment)
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Cherry-pick of #6517
Issue: https://issues.redhat.com/browse/OCPBUGS-6585
Does this PR introduce a user-facing change?