Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coveralls keeps posting PR coverage reports instead of editing the current one #215

Closed
ITaluone opened this issue Jun 26, 2024 · 7 comments

Comments

@ITaluone
Copy link

See e.g. here: fluentassertions/fluentassertions#2676

See how many new coveralls coverage report comments has been posted. I also noticed that apparently after the second edit (meaning three comment versions) a new one is posted.

Is this a miss configuration?

@afinetooth
Copy link
Member

Hi @ITaluone. Thanks for reporting this.

It is a known issue that's in the backlog for our current sprint. We hope to resolve it this week.

In the meantime, apologies for the inconvenience. I'll update this issue when it's fixed.

@ITaluone
Copy link
Author

Thank you for your quick response.

Yeah, thanks

@afinetooth
Copy link
Member

@ITaluone and anyone else affected by this issue, I wanted to provide an update and ETA:

Update:
The new ETA for resolution of this issue is this coming Mon, Jul 8. We expect that to be the latest date when this issue will be resolved. We are working to resolve it sooner.

An explanation is included below if you're interested.

We apologize for the continued inconvenience and want to assure you we're doing what we can to resolve this issue as quickly as possible.

Details:
To resolve this issue, we need to change column types in several database tables to increase their storage capacity. This is in response to new pull request comment IDs coming to us from GitHub that exceed our previous storage capacity.

With a codebase that's been in production for over 13 years, many of our challenges are ones of scale. In this case, we attempted to make the column changes in several tables during a scheduled maintenance window this past weekend. However, with tens of millions of rows in each affected table, we were unable to execute the changes safely and completely in our planned 4-hr. window.

As a result, we've switched to a zero-downtime approach that we'll execute this week, but the approach still needs to be performed in several stages that we prefer to schedule during off-peak hours, each of which we expect to take 0.5-1 day.

Should we encounter any unexpected issues and foresee the need for it, we'll schedule another maintenance window for Sat night, this coming weekend; but for now, the effort has begun and all is well. Should that occur, you can follow the status here: https://status.coveralls.io/

@Kixunil
Copy link

Kixunil commented Jul 2, 2024

I think that hiding old report rather than editing would be also an acceptable solution. It does spam GH notifications but it looks better in the comment history since it goes after "user pushed x commits" message.

@afinetooth
Copy link
Member

afinetooth commented Jul 2, 2024

@Kixunil I will make that recommendation! It sounds like a good backup approach should this ever occur again:

  • Delete / replace old comment &&
  • Hide any previous comments by Coveralls found in the PR

Thank you.

@afinetooth
Copy link
Member

@ITaluone @Kixunil

This issue of receiving MULTIPLE PR COMMENTS from Coveralls should now be resolved.

Going forward, Coveralls should always update the last comment with its latest comment.

Please let me know if you experience multiple PR comments on any PRs that were created after Sun Jul 7 at ~7p PDT. PRs created before that time may have received more than one comment.

@tomasMizera
Copy link

Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants